From patchwork Fri Jul 28 17:10:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 13331535 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A92CC001E0 for ; Fri, 28 Jul 2023 09:10:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB26B6B007E; Fri, 28 Jul 2023 05:10:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CC63F8D0006; Fri, 28 Jul 2023 05:10:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B7788D0003; Fri, 28 Jul 2023 05:10:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 867606B007D for ; Fri, 28 Jul 2023 05:10:26 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4AEB4140F5B for ; Fri, 28 Jul 2023 09:10:26 +0000 (UTC) X-FDA: 81060449652.25.36BD80F Received: from dggsgout12.his.huawei.com (unknown [45.249.212.56]) by imf08.hostedemail.com (Postfix) with ESMTP id F267C160003 for ; Fri, 28 Jul 2023 09:10:23 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=none; spf=none (imf08.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.56) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690535424; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Mpjk2P6RiXjgICoXizaFLfK3UaZ6mz5AsfEmljnimno=; b=T1V/NV1uW6dh57FbD9OkWgklt78Mil/d38L4XqviTMU9qz/DkdlI3eZt5JPQT+OvgguO+F zeNjvNp77nQnQDTcK2OWZ10xhau1faVYjI2n1g+VE89AUnx44AILQW8ALMJ2teYvI5tbz6 TlwcI4FhJ77l2SZvUTxaiY09mq4LSsk= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=none; spf=none (imf08.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.56) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690535424; a=rsa-sha256; cv=none; b=0i0RBQXDIUHSkjyKt0jJnZ4JRz1Acu7GL4EAx+tXYdxpa8M+0yoG3mqhCjuGvDDkxp63Az TNFEdwB08lK5k4Y94Oxjien34xczAGF2xconyS8gDG6j1h9u+8As9TJSEW3GBi4Q0TInPp oCv627vT1TshNKUuDyOtaCwFlcn5yLE= Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4RC20P673Qz4f3nyg for ; Fri, 28 Jul 2023 17:10:13 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgA3n7L1hcNkCrD+Ow--.32454S4; Fri, 28 Jul 2023 17:10:16 +0800 (CST) From: Kemeng Shi To: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, willy@infradead.org, david@redhat.com Cc: shikemeng@huaweicloud.com Subject: [PATCH 2/8] mm/compaction: correct last_migrated_pfn update in compact_zone Date: Sat, 29 Jul 2023 01:10:31 +0800 Message-Id: <20230728171037.2219226-3-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230728171037.2219226-1-shikemeng@huaweicloud.com> References: <20230728171037.2219226-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: gCh0CgA3n7L1hcNkCrD+Ow--.32454S4 X-Coremail-Antispam: 1UD129KBjvJXoW7CFyfAw1fGrWDCFWrZry7Wrg_yoW8WryUp3 4rCwn7Kr4kWayUZFyYy34kZ3WYkwsxKF43ArZ8Jw18AFs5Ka4jk347KF1jvrWUXrnIy3sY vF4qga97AanrZa7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUBK14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2jI8I6cxK62vIxIIY0VWUZVW8XwA2048vs2IY02 0E87I2jVAFwI0_Jryl82xGYIkIc2x26xkF7I0E14v26r4j6ryUM28lY4IEw2IIxxk0rwA2 F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjx v20xvEc7CjxVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E 87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64 kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r106r15McIj6I8E87Iv67AKxVWUJVW8JwAm 72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYx C7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_ Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x 0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8 JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIx AIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7sR_veHUUUUUU= = X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: F267C160003 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: oob15jb88eyj915t3xudcfpkq4pi8xok X-HE-Tag: 1690535423-406609 X-HE-Meta: U2FsdGVkX19AR5H0lLoz0vvjaGAO9DHjb8dgSem5ekTiMmtQu7DGWUWde1AAYgbbMV7ZNMDjOUL+JUPeLqgwZeLFQnFPdG2eZ0EyvP0VkrNBJLsaAqJmaYxrGw7BsvlTSt/EHlkX/Hrry3jKJ7K0S1YbJ99Bv5aji6L40a8MxksOHPjSGWGlOSS5FX/kmncUCzcydXnIBbbmAu0WSntieUZJ6h9aYIvXrwX8G/GIOtbyOQznryAoHmlpZ1iv3Q1mTYw3nbWr+AhaPShiI8Zd9vZ2qfRMrwcUx6RWd6nRjyB2U8HeWAkalnyrxisAwFWaI6W7cFotyNKYHffjl19D0qf9NxnYUn0uFsGQeEitBuaMEWpHNd6uSdUyE7DgjJ5OlelwgOlVLYccuDEGLDUBJEt9ZrEA+jGH5sVJPKBjPv72yq01kwIvGevqt0W2k/ceoSDdJmNAv6GGuYB8QdH2LID4ZFXDGb13jGo6w+8pZOxOmcSVZALKSMCg8w1ub1PBW024KjQSoNwMMCj2y44Fiog82B4spLez0N8ue91J1LUHdr7djlGu+ckb0Pvc50M9vjd6G41ZtvZvyaGBCexcQY5wskKnw6SrGFL9blyyDsgTmiW3mxYlFAEXzwUD2zbtozKalq74NbNekVJenmrG9UaHfn0q6RDEWUC2q/uLyeq/sjv90KGz/iUD3+Dcz0YnBzZan8uRERcIawwEosPAQ4INkuU8tE2MMfqInqdlBxyTcOzTzGOtoqj93sVEzYCpa1+BO8g33+nHcS6oVfsU+yBlS/dXCJ3cXTJ3DzVhvITl4Tya+CE5NIia3BJVulKxuQDqJQAIZXvxZlDt/Gw67u5uafNwmggC3nt1Zqe7BXO7YRI27Lj+TZZsgsi+aIO7oOKr6kxHbArNRUaxjDkI8fubH/f+OnkePDHmgo8ghnJ8Ejt6t50wYhVQqYoycmGubGws1Jb9GwL56LI0cxP 1ZVFwdib uXiHolqAxL5Gvh3L7nRxcrJo3Z5HBvOzozmqB3RSk5D9nwbgnWNDAzyNL/S6a2tWtLThb+8+tUQCmnSNciW9OzB/Lj+ZblsgMKsuj/4JxN2zcjN37WP5OZ/eVr9c0GrvY0eYs0VwHTh+4NooWR0vhxCGHlFwaWo6iBKLkxtPaI9N1jhPKKz1WqPssqDxVR9RYtAvCoCYL1/8km5YydzhMrNzjSpiHCbABQbS4gX7rGE8N7EAEFLRMDlH5JEM5qxYvlPcCvqYUnBhO++GTcNa2urSMruGMHDxMAixE6QZy7ceKfIPJdvcDvvnO0SniDI2K5rIH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: We record start pfn of last isolated page block with last_migrated_pfn. And then: 1. We check if we mark the page block skip for exclusive access in isolate_migratepages_block by test if next migrate pfn is still in last isolated page block. If so, we will set finish_pageblock to do the rescan. 2. We check if a full cc->order block is scanned by test if last scan range passes the cc->order block boundary. If so, we flush the pages were freed. We treat cc->migrate_pfn before isolate_migratepages as the start pfn of last isolated page range. However, we always align migrate_pfn to page block or move to another page block in fast_find_migrateblock or in linearly scan forward in isolate_migratepages before do page isolation in isolate_migratepages_block. Update last_migrated_pfn with pageblock_start_pfn(cc->migrate_pfn - 1) after scan to correctly set start pfn of last isolated page range. Signed-off-by: Kemeng Shi --- mm/compaction.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/compaction.c b/mm/compaction.c index ce7841363b12..fb250c6b2b6e 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -2482,7 +2482,8 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) goto check_drain; case ISOLATE_SUCCESS: update_cached = false; - last_migrated_pfn = iteration_start_pfn; + last_migrated_pfn = max(cc->zone->zone_start_pfn, + pageblock_start_pfn(cc->migrate_pfn - 1)); } err = migrate_pages(&cc->migratepages, compaction_alloc,