From patchwork Fri Jul 28 17:10:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 13331536 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E411AC0015E for ; Fri, 28 Jul 2023 09:10:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 155438D0005; Fri, 28 Jul 2023 05:10:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1059B8D0003; Fri, 28 Jul 2023 05:10:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DAFC06B007D; Fri, 28 Jul 2023 05:10:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C17178D0005 for ; Fri, 28 Jul 2023 05:10:26 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7738F140F8A for ; Fri, 28 Jul 2023 09:10:26 +0000 (UTC) X-FDA: 81060449652.19.1730ABF Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by imf17.hostedemail.com (Postfix) with ESMTP id 26A854000B for ; Fri, 28 Jul 2023 09:10:23 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=none (imf17.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690535424; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IX2xAfEp8ZVgXbkaWKLtfcUpvHjyvM0q566WPMqN2WI=; b=HXVgZTNBusj7gr4hJEbtMo8MmRoBGO0mij3DXJxbg8FDaSKLHqOHTKwRikbhjel9fu0WnA F6Epmzjj1mRk4IYhXjazf7vZgfwVU/UeBRGMbM4gxmHPn7oa/smwKyVIHWvZm2ZmBn1C9V CabaNC+SNOQruBnT0NkRHpO+Z6qd09k= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=none (imf17.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690535424; a=rsa-sha256; cv=none; b=v+65cQcTOqMiJVMgbi4ZPKPlS29+fvE58sNe6aSQUJrT/PJov0JdubNG1uXrzx1/7oSqqD csZItWSpYiSWasItD2A0vHuXSQNV8p8LSwicdoqav+9k71Rrznm2+Nb11AbJ3DzmXW2NCx YJ4VDrh8jxbxdoAKwtjnzESSU4MA4lo= Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RC20T1C9vz4f3kk3 for ; Fri, 28 Jul 2023 17:10:17 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgA3n7L1hcNkCrD+Ow--.32454S7; Fri, 28 Jul 2023 17:10:17 +0800 (CST) From: Kemeng Shi To: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, willy@infradead.org, david@redhat.com Cc: shikemeng@huaweicloud.com Subject: [PATCH 5/8] mm/compaction: corret comment of cached migrate pfn update Date: Sat, 29 Jul 2023 01:10:34 +0800 Message-Id: <20230728171037.2219226-6-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230728171037.2219226-1-shikemeng@huaweicloud.com> References: <20230728171037.2219226-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: gCh0CgA3n7L1hcNkCrD+Ow--.32454S7 X-Coremail-Antispam: 1UD129KBjvdXoWruF1kGw4xtr1kGw4rtw18Zrb_yoWktFX_Xa 1xtrs0k390kFyvqanrAw4akr4UGFWDZF1DG3Wktr47CFyvy3WDZ3WDZr1fur90qa9rWr9x Gw1kuFyjkFyakjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbDkFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M28IrcIa0xkI8V A2jI8067AKxVWUAVCq3wA2048vs2IY020Ec7CjxVAFwI0_Xr0E3s1l8cAvFVAK0II2c7xJ M28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4x0Y4vE2I x0cI8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK 6I8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4 xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r106r15McIj6I8E87Iv67AKxVWUJVW8 JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20V AGYxC7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAF wI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc4 0Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1I6r4UMIIF0xvE2Ix0cI8IcVCY1x0267AK xVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr 1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7sRRkucDUU UUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 26A854000B X-Rspam-User: X-Stat-Signature: 4whkpot1bib38kaaokjpxgo66f6idjsn X-Rspamd-Server: rspam01 X-HE-Tag: 1690535423-292606 X-HE-Meta: U2FsdGVkX1+NtaoTPw7afW+Y1j3vwTsiEl8wASWeae4zSDLb3TK89p84s6Iv6Fii2wxbezZny+fpH95fYb8FsoYghsQMZoKyKJbXPVkQSWaOPbNnTd+VwNHJDMTrE+KqA4A2p4elo8ztjW9KTn3hUogxzoJ+sfsF8vxGKBSNor8AR/d+/Cn2ZrquGZ7p4UW3vqAbdz+llNoNR8nwd+Y962vkMgeEiFhGdtmu+D1So1JDW9p8xqavU4wadDMdBRTrRs40TSfGCa464VnLxJ59rJNRfUQNnHf4ZBXnlDu7OToERLIErV3AKMAaUT6RugDjpnhUK7Q1HFXmnr0N7fmuymOiPPC+JTtHZutmVNHHEZA78XYT9McnTItTT5OxIvCeTbs7JpGsRw0STDE/lBdtOTBlZSPLSpEpFlpXcfe+ebFjRZm55fVvBXE9x77ZpMcGuuNHbW0D+ftvQ6QY4OV81NTLD/uH1ymRMHZSLDYmcCk/TtJM/KMzhACyXnsLOhewBrdfDH0XnFq9ATnvwjGvs4O0GPiHexnhOUijKKWPGwmLXkk0Jc+tuB6rs1VPfoNHJEDaTJDqlw9xJCuu9vZyHuw8faSQb6fMiNCSwzafHRHBe11vAI+q590tWaDUmh23kEAhEB0kp8LiRPaYzXovuJyDghCiQSt5dxs7yJCYOzTQj4xXGCQCVJ6pPKGL0IdM1NpxCeXraM/JlCCvsF1frSJHlkeya74MHzMNEei8lUtwm13ZRvr3qc83pClR0MW1rdaA0jBNKN/q1bpaUxTis3eURYuG7kCh8S1yu6/By6YyjgZimkTfpCUhMVpDqqPXjFrjsGmIIEL6R/e8iD7mkszLGtUMUQGyKNzWZHlieZ5+MaG12hzwDE48gFX2c+bT0XTGHMvo7kLwrLuWy2wf9vAxlS3mnW7uKiiteQ+SqMwSbPQ5LD67GLotvM8xBbvLq9YNrbAXAAuMGPfLDYM ulNKoshJ K+4hh1TabIYoWUiZelokc0PDusdOxbi3RmHOxbZZpboEBQFVeCxJoTrz9qcttKDqBoChs2K/VficBFYMAUikTc1IwR4+QziQkAj/oO6iRzv92CPb36/b8tLmlRxrAUabPL9AaFX7yu4V414Jx6pkUHvFGtHtVsLDWdvOvWvAZTZhAKDyg9rTnWG++PLmOjn410kREr/4FqCIfwr9p3slF6NmeDg9b6lIprpIqFU/Qnp+miV2HoVa6N/23fKG6JvOEyxHd+JTvsJ93sqg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Commit e380bebe47715 ("mm, compaction: keep migration source private to a single compaction instance") moved update of async and sync compact_cached_migrate_pfn from update_pageblock_skip to update_cached_migrate but left the comment behind. Move the relevant comment to correct this. Signed-off-by: Kemeng Shi Reviewed-by: David Hildenbrand Reviewed-by: Baolin Wang --- mm/compaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/compaction.c b/mm/compaction.c index 09c36251c613..1eebb61a1f63 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -464,6 +464,7 @@ static void update_cached_migrate(struct compact_control *cc, unsigned long pfn) pfn = pageblock_end_pfn(pfn); + /* Update where async and sync compaction should restart */ if (pfn > zone->compact_cached_migrate_pfn[0]) zone->compact_cached_migrate_pfn[0] = pfn; if (cc->mode != MIGRATE_ASYNC && @@ -485,7 +486,6 @@ static void update_pageblock_skip(struct compact_control *cc, set_pageblock_skip(page); - /* Update where async and sync compaction should restart */ if (pfn < zone->compact_cached_free_pfn) zone->compact_cached_free_pfn = pfn; }