From patchwork Fri Jul 28 20:34:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13332649 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74E6DC001DE for ; Fri, 28 Jul 2023 20:34:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 734A78D0005; Fri, 28 Jul 2023 16:34:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E6036B0074; Fri, 28 Jul 2023 16:34:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3146B8D0005; Fri, 28 Jul 2023 16:34:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1FBBF6B0071 for ; Fri, 28 Jul 2023 16:34:53 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C59F91207C8 for ; Fri, 28 Jul 2023 20:34:52 +0000 (UTC) X-FDA: 81062174424.28.E419E1E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 1CF7940013 for ; Fri, 28 Jul 2023 20:34:50 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qEqsPnDT; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690576491; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zxVpN4g06DUCb7PKXyAD338noc2KODnd6S5Q4w7jTog=; b=a6IMXxdW1nMvdudkZwhJlOU2Im/Lc8vUzxQpdvQiAghTx8PyhhVDyG3bXJa134O3Kz74ID m60WJ224HXlw5a1u/QYG1gbhCNdKZLF0rZHH+bSqDsHGUBI/Y8ebMDW5aeh4I5FNTcjokH fEPKNfMpFCxu/S0Nv9ine5JETxNZg2E= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qEqsPnDT; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690576491; a=rsa-sha256; cv=none; b=6LR5aTGfxwJsNSTvZB7FPbNvxG3oP5aXyaEZaZ2UNSxC57JzFnIAcZBVxN7S9M/dUKfm+V uNgZEscQwkuH82Zh+YzOn/TsiQFtfLla+P1WzEttBP5fdsNotxbZXMOpDoT9rxTOeygGnC yNrce/mNkK+naK824aWe+hLrpv4C4Iw= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5DBC962206; Fri, 28 Jul 2023 20:34:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DF4BC433CA; Fri, 28 Jul 2023 20:34:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690576489; bh=JP7uB7/G+cUBWmCMFTcCRqLSa2LcbVSrJBh+8gJznBY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qEqsPnDTJzgFVqfu9V8EzsZlJlOVBtwCUd28gFsY/AzjTQsZhZQksDgaSHRkRvXm6 l3JmnJRVO+FpqhUHnEBOWdcaXQfMAG9/39tTQYzHzN1prb1O/bPdPv1kPt8Auwz/5D jjYGnpBfoMfmgM4oSg5UDHunwAmxiVSwcyEzQTP/oXG5pTb73/hEKtZ0XgBxx2q6s8 ZyGQTXlE3Ps1FA+5JnDoErKrZO8u8BKTzajZt0R1+WIrtbuOJHsuLZx/b3rVLGIgME FZMqUi57nVG89VRujJdxFHqvDZ1vymbdZLhk8ZLlSPzkG/ZxwgmTLxXbJBw5HTGc2e zSvAEuArFDBfA== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH 02/13] mm/damon/sysfs-schemes: support address range type DAMOS filter Date: Fri, 28 Jul 2023 20:34:33 +0000 Message-Id: <20230728203444.70703-3-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230728203444.70703-1-sj@kernel.org> References: <20230728203444.70703-1-sj@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Stat-Signature: rqzhkjb3dj3uokhfozffqsxjwn59x4zu X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1CF7940013 X-HE-Tag: 1690576490-197927 X-HE-Meta: U2FsdGVkX1/3JOMT570NiXPBjefYBMDfAF8dF7m/6F4+P7IZBHI36KOj+KMzHV3nUZFyLKQfAo0DjE+e5W+ewu6cAho3Qwa4UOvdIpeldXMpk4VV+jYS+GuAZVW2LsAFExhMD47AoNUubbgqnBqk0lrtvUE/rsNaa9p8epQUYbUUmy33J5bWi4SpPHFNrXTJubvvaZNgAkZq/Q17onhNL8XFn0lnq9Oou8ElpMFKnvSfj5KOpFTxVe1tBNAuo+cawRunJ64gnrjtnRCFlv44uT0dY4YRZZgH3B5s6EAHdqMqoDnqkkWp/cyuqvYIsfW8Bc8oE406J88c5UGYTp6UnM+42F5wFC1LL9pZtQ3pgnmQkyshQENh6jEmEdWQK9kwKp1UqVxvH6z+s3Vy/LvoCisu0Crj4PyDM+4dHlhoxwOIJP7FRrshDRd5P7+11M0ebUtDqdfLyVinZJKBWpReqQvLC5FvLJo0eqJq4RAi6popMkjjB/XVN5o9l/SkSoirT0227BKLjQa4v/dUpgtS9j8ME10/DU7VJ4eNStExg/uUHC5IRMnMB2/gbqmG03j3Dy+exCSn3Lq5sDGshod33l2mSy3aUyhl5laLMRT9dLQIdturFQekV8dphjpSJRgbI4CBdIWwuQpkfruF5wcaeBNVi297Y4Z+m4UHX6/Qf6me7IMsrSCIapusraDAN8DuJbwhvVXx0gxB835MjNKNicJ8h826f262EzzpDdKkG60DsH0FP7Gz75J1xSSVbTXM+EzeeLHBoU7mn1VyN/+two6YFzwb232HGQ7TDtooM3mKT84upX4wabT5yl40oLefDOMZnNlQNv3U3uHxcfRwjzcsjzFNYWE4tW/dxshKUGWDr+AAd1PduYuNCq7AJh3wR6nED9KIdVBfWt2jaPgTFLLbGneSQU8p+dPeHH4eUeD5quuP6T4n12kG88pt9uRi+ZNetXDN8Ka2U4Rn/C3 L4Y5PcdU aRV87TwvNrbk2GZGk/CrlOLcSpBMcJjEBtGAQNrFVi/vzSj/oMJT3e8JQWJXMFdTeQeqqHPf9GNi3WfrE6/vBQzdHacvnyeK6jBi8Wb+bMJHOVi1NO6ZjRiur7LSAGGamq2t/cm/0eEKwzAaQ9JyO99LnnuaYFDq/dKU2wUqYyB2KjucjrQo0ZC/VH7uTbZfO7/yAV8Wf9MNACem6hYzjf/XgeYr6w28VLkyPfhsJAwVpxojIJCwIlEp37066jNNRD6Zo9+8t1auygcE1uFTXZzEMmi9cNI5GDS+CHcf24gWrD0X3c2mbIRyQ3bo9/L8ph8cQA/BDwQ1Ucn4s8VqgOKm0cA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Extend DAMON sysfs interface to support address range based DAMOS filters, by adding a special keyword for the filter//type file, namely 'addr', and two files under filter// for specifying the start and the end addresses of the range, namely 'addr_start' and 'addr_end'. Signed-off-by: SeongJae Park --- mm/damon/sysfs-schemes.c | 56 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 56 insertions(+) diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c index 9a015079f3a4..03ddba3e216d 100644 --- a/mm/damon/sysfs-schemes.c +++ b/mm/damon/sysfs-schemes.c @@ -282,6 +282,7 @@ struct damon_sysfs_scheme_filter { enum damos_filter_type type; bool matching; char *memcg_path; + struct damon_addr_range addr_range; }; static struct damon_sysfs_scheme_filter *damon_sysfs_scheme_filter_alloc(void) @@ -293,6 +294,7 @@ static struct damon_sysfs_scheme_filter *damon_sysfs_scheme_filter_alloc(void) static const char * const damon_sysfs_scheme_filter_type_strs[] = { "anon", "memcg", + "addr", }; static ssize_t type_show(struct kobject *kobj, @@ -373,6 +375,44 @@ static ssize_t memcg_path_store(struct kobject *kobj, return count; } +static ssize_t addr_start_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) +{ + struct damon_sysfs_scheme_filter *filter = container_of(kobj, + struct damon_sysfs_scheme_filter, kobj); + + return sysfs_emit(buf, "%lu\n", filter->addr_range.start); +} + +static ssize_t addr_start_store(struct kobject *kobj, + struct kobj_attribute *attr, const char *buf, size_t count) +{ + struct damon_sysfs_scheme_filter *filter = container_of(kobj, + struct damon_sysfs_scheme_filter, kobj); + int err = kstrtoul(buf, 0, &filter->addr_range.start); + + return err ? err : count; +} + +static ssize_t addr_end_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) +{ + struct damon_sysfs_scheme_filter *filter = container_of(kobj, + struct damon_sysfs_scheme_filter, kobj); + + return sysfs_emit(buf, "%lu\n", filter->addr_range.end); +} + +static ssize_t addr_end_store(struct kobject *kobj, + struct kobj_attribute *attr, const char *buf, size_t count) +{ + struct damon_sysfs_scheme_filter *filter = container_of(kobj, + struct damon_sysfs_scheme_filter, kobj); + int err = kstrtoul(buf, 0, &filter->addr_range.end); + + return err ? err : count; +} + static void damon_sysfs_scheme_filter_release(struct kobject *kobj) { struct damon_sysfs_scheme_filter *filter = container_of(kobj, @@ -391,10 +431,18 @@ static struct kobj_attribute damon_sysfs_scheme_filter_matching_attr = static struct kobj_attribute damon_sysfs_scheme_filter_memcg_path_attr = __ATTR_RW_MODE(memcg_path, 0600); +static struct kobj_attribute damon_sysfs_scheme_filter_addr_start_attr = + __ATTR_RW_MODE(addr_start, 0600); + +static struct kobj_attribute damon_sysfs_scheme_filter_addr_end_attr = + __ATTR_RW_MODE(addr_end, 0600); + static struct attribute *damon_sysfs_scheme_filter_attrs[] = { &damon_sysfs_scheme_filter_type_attr.attr, &damon_sysfs_scheme_filter_matching_attr.attr, &damon_sysfs_scheme_filter_memcg_path_attr.attr, + &damon_sysfs_scheme_filter_addr_start_attr.attr, + &damon_sysfs_scheme_filter_addr_end_attr.attr, NULL, }; ATTRIBUTE_GROUPS(damon_sysfs_scheme_filter); @@ -1484,7 +1532,15 @@ static int damon_sysfs_set_scheme_filters(struct damos *scheme, damos_destroy_filter(filter); return err; } + } else if (filter->type == DAMOS_FILTER_TYPE_ADDR) { + if (sysfs_filter->addr_range.end < + sysfs_filter->addr_range.start) { + damos_destroy_filter(filter); + return -EINVAL; + } + filter->addr_range = sysfs_filter->addr_range; } + damos_add_filter(scheme, filter); } return 0;