From patchwork Mon Jul 31 13:43:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 13334739 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37D17C001DF for ; Mon, 31 Jul 2023 13:52:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C783C280051; Mon, 31 Jul 2023 09:52:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C2832280023; Mon, 31 Jul 2023 09:52:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF07F280051; Mon, 31 Jul 2023 09:52:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9EEF0280023 for ; Mon, 31 Jul 2023 09:52:38 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5A623120B92 for ; Mon, 31 Jul 2023 13:52:38 +0000 (UTC) X-FDA: 81072047196.30.B10532B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 8531F40011 for ; Mon, 31 Jul 2023 13:52:36 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="bmm91TA/"; spf=pass (imf01.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690811556; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DhriSxQor3DCGKL2zl7My1a/kfJpgsRjjKwA8agrULg=; b=KEUU3qkHkxuRS6iot7vR0Z7KLHGlzaE138zGOIXOp+8AC7V5ZfyQ44z4a24hQtLXF3cyIy sH1d/CL6A8faqmRUpGETpBqEMv4AHEHPkKL6kh0wkXWum+qiZFAFFs0oohzwjadDke3qnw 3dpEoCpR33o2TyruZAMatbzHyfJ9x/0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="bmm91TA/"; spf=pass (imf01.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690811556; a=rsa-sha256; cv=none; b=ZOyqrZITKSzd4R50IjbnzljSexY4qYvIiKwxtfX9CjVhHJyH9q8Y0zKB6FUeE7WlVsmpRR 7dx2WLIMiK12UJfiRMKdm2LsHnAXatrUPgKHlKqnF82AqHT/lpDDCc5zOvoOcZLq9t+XWc ViQhEa1o99HAoYv787X158QfdNP67og= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9FBCD6115B; Mon, 31 Jul 2023 13:52:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A00FC433C9; Mon, 31 Jul 2023 13:52:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690811555; bh=Qk1oAglcSxLTK1OL1yhAbWpcUwaL4dga6Y2wJZdhO9Q=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=bmm91TA/wsaZPU0/8wE66pnfaNWaSJdQZVbqyg3+SSOShzdh0ggMTWS1FEAC8/NxK olDE9hRIYeFcpsqtYbtxT9mAS1hff4uLcoSdxJtguNtWeqQs/V4wxTl570gn1ndoZd eFqbL2i9VUFa5Q7U+ZyKcfdkwFLF/DloaBbZ7+y+DOmQM1cxJzkNGFeo1nVstpdwzM afv2h8zB6/rbNODhkZAd/WU5Nf38ID2g6gff8Dk/bxjUXdKwpIqcLMOE5hNmSb2W98 QatGmPLu2OnW0BCOwH3hZbmmzSODz6YMFJCxHpY5zrzMUJt3DrfnFvdoYANLDanfsF /3ft2eN+AWRgg== From: Mark Brown Date: Mon, 31 Jul 2023 14:43:26 +0100 Subject: [PATCH v3 17/36] arm64/mm: Handle GCS data aborts MIME-Version: 1.0 Message-Id: <20230731-arm64-gcs-v3-17-cddf9f980d98@kernel.org> References: <20230731-arm64-gcs-v3-0-cddf9f980d98@kernel.org> In-Reply-To: <20230731-arm64-gcs-v3-0-cddf9f980d98@kernel.org> To: Catalin Marinas , Will Deacon , Jonathan Corbet , Andrew Morton , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Arnd Bergmann , Oleg Nesterov , Eric Biederman , Kees Cook , Shuah Khan , "Rick P. Edgecombe" , Deepak Gupta , Ard Biesheuvel , Szabolcs Nagy Cc: "H.J. Lu" , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Mark Brown X-Mailer: b4 0.13-dev-099c9 X-Developer-Signature: v=1; a=openpgp-sha256; l=5613; i=broonie@kernel.org; h=from:subject:message-id; bh=Qk1oAglcSxLTK1OL1yhAbWpcUwaL4dga6Y2wJZdhO9Q=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBkx7whzsGmRy/nIppQQzz6Nju8+l9OjAbrBNJUqFYd 152B5w+JATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZMe8IQAKCRAk1otyXVSH0F8nB/ 9BMXz+0V/6xYz4FAymiTLZwdJwh0jPkGzUNNQ45BqYlDb+x6M9e0xKuUa7+TytDqYicRBsPjo7Klds +Q8TfYSMGxTMvIRDH4iQMdnx4H+KQWvInDHoHh4Jb1lXG469AvJYqKX10Z7foIXDivnKVlhaoE4AXr VPTmdHvr7KQzC6NablbK0C1oy2iyVr36ptY/usiMPdpTv+3AyEuguLBNcpheQBotMdb5R3dHlIqwxO jn9rTcce0v/zhcIanMJv62RMbmz+8h5s97uXmiKyR8E7/LYsJeZ3dO+rl6omtuOk6F1V2bVG96+D31 NQNAplzBhb0gclp1zq2dRARGuU79VQ X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB X-Rspamd-Queue-Id: 8531F40011 X-Rspam-User: X-Stat-Signature: zfp9diqjtezad8qn7n9xtuj6bjnyz9nx X-Rspamd-Server: rspam01 X-HE-Tag: 1690811556-312766 X-HE-Meta: U2FsdGVkX1+cLnaJJ0+DBnJYuCDooz1OzG+AEglX5mtblB/aALu/NUWGoQYhy46yUaNreBczm7xUyHbrRIpO8Y8GDmx6iq/wuCwZEHcDXZx37Z0GAwt2gJmP3ywdt44r5ZmXBtMipdEJVD1jRsa/AsEhh1O9HUkwfxRSkKNoPCqZNGIOKxFpyX7iaDzqoK61YvXNMprg+r7WBqdhQdtBLeEp8jPLYQ5h+JesqbldMkEasMwDa9mccAAmgS2Z3HhatsyevsNuo2PVwnpoq+KiXqtL4Ql25jTho0GWWV9Q0wZWHEh23KKxBCr/2C9CHty3N8GscIJpKxkMbDO5g5HGkhVwi3RZ9G2oR+DR5A7Lfr8Se87+GczXZUpQezybyTv8NYQmTgGMGL4YeSLTDf1ZQxcoO6bL//ouR75k7bJ2ZWpA9VW1EeCNUcATo3X+HHZ//ixd/Gu5flfI+QCQHQeFhR7xrGeekzr60ZWDBU8Aa0nJotIUeNpJ71OC98zumTKyoEA5PEvvbueVDASOuD2xvBNQyL3TmMSdPYLSy1Ly5WEJWahjJaJkmvOhlUbsrHsHWnAWtNo2T5MAc6hEDVtsZrlIYS5fykO2BkkFKJ9IVPJt9jjCwpzHDKpvJlFuBvOrW7jD1Z4mSWVmJ7kzfgSICPRtqRFTm+dvusXw8IKlPGO35dgGLlGB5uMkymwsKU/6BzhXo3N6qoNwmLkPHgtr31kHlFusY0o+RdXOSyEqU+kmU0yQ25tvMn8ileEqkFLW0TWCZCvVk+7eX5nCJhlMp0Uef3CaYYJtHWUejjP4GrXYH1bgitQ+44/bCtum1Njqb6e/9uX2PhkIpkLlEhVE8KhygrjeAMyU4efA6i7ajGvbBqh69VEpqZjqBkyxmhMQajFzhvtIN5LaZeVW0yrd10J2jH5TN8H+5LVkYV6RCuPdkyVGdyphKdYrdEh1W6vdVN4tS+LKZxAT++e7DQG Qkd/oP0Z ouLUHh2iMHmgqa5h9ULpG7QzQ0fHbjtDgRY1e16PYFD2GQvU9LdKBbkrIEKtsffukDRt95Atf2LdPajmAJA1nTXYqKPnjhwIDNiXGPZ4SBn+RuGTjmBIijt0Gt0yQqxfRSqFtuxJLUz3iY0UhhnQ1BGNuSkCYKIH7jN9PBK3+Z1O2lKBbkODGdcNqjihtnoanXWDYeIHBUk30gqwcHkCPcvE6egfQch8hRdGd4HqKRQLsuWGO+hHKKKa8m7I/Hp69JwIH7M7LyHEu9qsYFfILo6/FsUyE/FT/U7jzT6mdSI8dINxLfmOFHAX6L30M+faU+r2k76fh7nGmFOaoVbbx8i+bT+3uCFbsfJnDlDxu9Qw7p06C1jdQT3ozcx0/rGFkm0DN+OxZAvzUCzfZqHqcnMdTvWsHZPTWbdkmy/YTUA44vUg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: All GCS operations at EL0 must happen on a page which is marked as having UnprivGCS access, including read operations. If a GCS operation attempts to access a page without this then it will generate a data abort with the GCS bit set in ESR_EL1.ISS2. EL0 may validly generate such faults, for example due to copy on write which will cause the GCS data to be stored in a read only page with no GCS permissions until the actual copy happens. Since UnprivGCS allows both reads and writes to the GCS (though only through GCS operations) we need to ensure that the memory management subsystem handles GCS accesses as writes at all times. Do this by adding FAULT_FLAG_WRITE to any GCS page faults, adding handling to ensure that invalid cases are identfied as such early so the memory management core does not think they will succeed. The core cannot distinguish between VMAs which are generally writeable and VMAs which are only writeable through GCS operations. EL1 may validly write to EL0 GCS for management purposes (eg, while initialising with cap tokens). We also report any GCS faults in VMAs not marked as part of a GCS as access violations, causing a fault to be delivered to userspace if it attempts to do GCS operations outside a GCS. Signed-off-by: Mark Brown --- arch/arm64/mm/fault.c | 78 +++++++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 70 insertions(+), 8 deletions(-) diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c index 3fe516b32577..ec392207a475 100644 --- a/arch/arm64/mm/fault.c +++ b/arch/arm64/mm/fault.c @@ -494,13 +494,30 @@ static void do_bad_area(unsigned long far, unsigned long esr, } } +/* + * Note: not valid for EL1 DC IVAC, but we never use that such that it + * should fault. EL0 cannot issue DC IVAC (undef). + */ +static bool is_write_abort(unsigned long esr) +{ + return (esr & ESR_ELx_WNR) && !(esr & ESR_ELx_CM); +} + +static bool is_gcs_fault(unsigned long esr) +{ + if (!esr_is_data_abort(esr)) + return false; + + return ESR_ELx_ISS2(esr) & ESR_ELx_GCS; +} + #define VM_FAULT_BADMAP ((__force vm_fault_t)0x010000) #define VM_FAULT_BADACCESS ((__force vm_fault_t)0x020000) static vm_fault_t __do_page_fault(struct mm_struct *mm, struct vm_area_struct *vma, unsigned long addr, unsigned int mm_flags, unsigned long vm_flags, - struct pt_regs *regs) + unsigned long esr, struct pt_regs *regs) { /* * Ok, we have a good vm_area for this memory access, so we can handle @@ -510,6 +527,26 @@ static vm_fault_t __do_page_fault(struct mm_struct *mm, */ if (!(vma->vm_flags & vm_flags)) return VM_FAULT_BADACCESS; + + if (vma->vm_flags & VM_SHADOW_STACK) { + /* + * Writes to a GCS must either be generated by a GCS + * operation or be from EL1. + */ + if (is_write_abort(esr) && + !(is_gcs_fault(esr) || is_el1_data_abort(esr))) + return VM_FAULT_BADACCESS; + } else { + /* + * GCS faults should never happen for pages that are + * not part of a GCS and the operation being attempted + * can never succeed. + */ + if (is_gcs_fault(esr)) + return VM_FAULT_BADACCESS; + } + + return handle_mm_fault(vma, addr, mm_flags, regs); } @@ -518,13 +555,18 @@ static bool is_el0_instruction_abort(unsigned long esr) return ESR_ELx_EC(esr) == ESR_ELx_EC_IABT_LOW; } -/* - * Note: not valid for EL1 DC IVAC, but we never use that such that it - * should fault. EL0 cannot issue DC IVAC (undef). - */ -static bool is_write_abort(unsigned long esr) +static bool is_invalid_el0_gcs_access(struct vm_area_struct *vma, u64 esr) { - return (esr & ESR_ELx_WNR) && !(esr & ESR_ELx_CM); + if (!system_supports_gcs()) + return false; + if (likely(!(vma->vm_flags & VM_SHADOW_STACK))) { + if (is_gcs_fault(esr)) + return true; + return false; + } + if (is_gcs_fault(esr)) + return false; + return is_write_abort(esr); } static int __kprobes do_page_fault(unsigned long far, unsigned long esr, @@ -573,6 +615,13 @@ static int __kprobes do_page_fault(unsigned long far, unsigned long esr, /* If EPAN is absent then exec implies read */ if (!cpus_have_const_cap(ARM64_HAS_EPAN)) vm_flags |= VM_EXEC; + /* + * Upgrade read faults to write faults, GCS reads must + * occur on a page marked as GCS so we need to trigger + * copy on write always. + */ + if (is_gcs_fault(esr)) + mm_flags |= FAULT_FLAG_WRITE; } if (is_ttbr0_addr(addr) && is_el1_permission_fault(addr, esr, regs)) { @@ -595,6 +644,19 @@ static int __kprobes do_page_fault(unsigned long far, unsigned long esr, if (!vma) goto lock_mmap; + /* + * We get legitimate write faults for GCS pages from GCS + * operations and from EL1 writes to EL0 pages but just plain + * EL0 writes are invalid. Specifically check for this since + * as a result of upgrading read faults to write faults for + * CoW the mm core isn't able to distinguish these invalid + * writes. + */ + if (is_invalid_el0_gcs_access(vma, esr)) { + vma_end_read(vma); + goto lock_mmap; + } + if (!(vma->vm_flags & vm_flags)) { vma_end_read(vma); goto lock_mmap; @@ -624,7 +686,7 @@ static int __kprobes do_page_fault(unsigned long far, unsigned long esr, goto done; } - fault = __do_page_fault(mm, vma, addr, mm_flags, vm_flags, regs); + fault = __do_page_fault(mm, vma, addr, mm_flags, vm_flags, esr, regs); /* Quick path to respond to signals */ if (fault_signal_pending(fault, regs)) {