From patchwork Tue Aug 1 12:48:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Hildenbrand X-Patchwork-Id: 13336681 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48FDBC001DF for ; Tue, 1 Aug 2023 12:49:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE8BD940017; Tue, 1 Aug 2023 08:49:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D9842940010; Tue, 1 Aug 2023 08:49:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C87EB940017; Tue, 1 Aug 2023 08:49:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B6F7D940010 for ; Tue, 1 Aug 2023 08:49:28 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9712CB17C9 for ; Tue, 1 Aug 2023 12:49:28 +0000 (UTC) X-FDA: 81075516816.29.EC031D2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id D5D9A20024 for ; Tue, 1 Aug 2023 12:49:26 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UK93yNpx; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690894166; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ETNtty+qD9MfEou6PkXGN63LTSt4s/cNeotNKd9s/vU=; b=dM+R26fUlz8xa8GG7adfPFyO/J023uMGS5cIT81fK8gvJSl4aJfiHlCVqPjOPYlAvQYhIJ NsQ7JRD9jHFP7w+H8UmnxPIiha5o+KVmIZct07WlCtF9/WVq3UJ3jfZ5domoFAgqfiEUU3 YHp0k8YTxN375Jp+5bqUs7T4x6UkW0E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690894166; a=rsa-sha256; cv=none; b=j+QDpNi0y3xS80C3/QSatRQ5X0Ji0EOIiUFKSMHdccqBvDF99YWMa4wVsWlqQXG2m8SHvr xEmEFKY2VKPHe9RcFUhJEec4zBm7vLjlueO5vc9kVdh19pepaM3Bb6oglr3MvRVk6sDLNG 49vroPXJ79jTWO9LDVEe/QwNZ83J300= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UK93yNpx; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690894166; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ETNtty+qD9MfEou6PkXGN63LTSt4s/cNeotNKd9s/vU=; b=UK93yNpxDbIxT3k7ddN7S7AnJ137QUogB4SeCupNzkElArGbQXVE9A/yC2087UkSt1RUIm vBvIb1bAhmD6KkYAxOe5F8dgBVH2JHHf4n+GDXEZ+2iTqfeZo0bA0ZzxSK2+tKTiNapuNN 3cLJxjTvV6GAomi9U+MOsyhMW9ziZHQ= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-613-KCGrX7soNoWrUz7xASwZ2A-1; Tue, 01 Aug 2023 08:49:20 -0400 X-MC-Unique: KCGrX7soNoWrUz7xASwZ2A-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0FC5529ABA07; Tue, 1 Aug 2023 12:49:20 +0000 (UTC) Received: from t14s.fritz.box (unknown [10.39.193.232]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0D58AC585A0; Tue, 1 Aug 2023 12:49:16 +0000 (UTC) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, David Hildenbrand , Andrew Morton , Linus Torvalds , liubo , Peter Xu , Matthew Wilcox , Hugh Dickins , Jason Gunthorpe , John Hubbard , Mel Gorman , Shuah Khan , Paolo Bonzini Subject: [PATCH v2 6/8] mm/huge_memory: remove stale NUMA hinting comment from follow_trans_huge_pmd() Date: Tue, 1 Aug 2023 14:48:42 +0200 Message-ID: <20230801124844.278698-7-david@redhat.com> In-Reply-To: <20230801124844.278698-1-david@redhat.com> References: <20230801124844.278698-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Rspamd-Queue-Id: D5D9A20024 X-Rspam-User: X-Stat-Signature: cggpoexwxn1mo656hqyzars6f4zn8uyj X-Rspamd-Server: rspam03 X-HE-Tag: 1690894166-598855 X-HE-Meta: U2FsdGVkX1+2XJWRd/8rXwi++Pk2pUm2HxkB2ni/NGsEJr739zhCZ910EPAPhPc4CZ7j6xNLH3IXre87DhkJpse07w1W1zoIR9YvYjsXwSgcrJebu28xd6GmEy0fV6Bn2Yf1Q+ZBKFtKEX38b2Ui3kQfP8z+kIHre7EvDfFcNSVba7QnNjPifubQBqLe5fITi1rBI1fG27MY6WMJypcZHZX8QXr98+2Qyrtq0oCHTd+I8bNLtmrA3UC3q24KNBoxwzs9H+3KaSBCWIpM5OcCLA0znoECGUOg1TyH/Y61ikwVbXjGAGpn3GqOMQXHiJ3qu9cvYqz9WvE69f822dSfMMojh3Sp+3HQPOIm+Dpb3pQlxwR5VIMZkDdVcd3IjkaW9iK2JzhFpqnuikIOkIfeglj9AKqxMPbqYp1otWvQ1YRJ7xGtEKhHZm98NaTK60Dy2Z+PX/Uov7aXazuoUSJlYnjzj+Jd51IrVAL9DFuuTQtSpbySBOnd/nFLPcVYlO2pq0cjSVRqjl8D6oFcs6y64XHP1Ph3NzoGM8flZRaU8tHLiP3zz6l6k50wLb2hEd6CTpw05Coz9ZP0R8y2oe73Gib3iBgpHUtuVdFwsLMr4pZ+wpP0EIDVW+Udke3tX6U+NsTq8BeSZtRG4q1D0ghphabPcAAvfQ22kXNXRssTRpcmDymeCerUJMFB6Mo/puebfI0ewaBFE0QfQBJF/LzAXJqHvW2nxtd+h2Tf35NbRkzrmfXz7QBIr1ZdN3zY88WRqdIt3G/U8WqQEJSrHn72eff176ULYfi50D5x5W95+0gGzx+R4MsfitauALf26r9Gz2AH8OuttrHT/9/NfWQtYmY62aotduJmK6re54KWsJaj/q+smrQvH5RYY88C4OR5s3Pilsq8Qt7L05nvS5DC4wm8K1rX2/wu4jhK+KU/qtxgsdben4jZ2DGIE3/Iuy7gBxH1giJMSsOtkCqh9h6 oFi3ig/T 8ZlucYc7pINXL5CIxzqRWjfAIMKl7ygWvqxzM3UOQ/4/QQrVimU9z9AWR/NfulMvU3FsNzJTsZ61ondzLBMasC9qW+Kbo5T65N5Kfu4emBvAJHfGL9vGMRZ/pvaxaJxKZOam0+unA9hTMdXc+48FuY5pwKc5p77hg7y9FksPLhSObxESEeO4hOU1vt3ELHZ7afZGU06eD1EO57WMlRT5zod2kgA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: That comment for pmd_protnone() was added in commit 2b4847e73004 ("mm: numa: serialise parallel get_user_page against THP migration"), which noted: THP does not unmap pages due to a lack of support for migration entries at a PMD level. This allows races with get_user_pages Nowadays, we do have PMD migration entries, so the comment no longer applies. Let's drop it. Signed-off-by: David Hildenbrand Acked-by: Mel Gorman --- mm/huge_memory.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 2cd3e5502180..0b709d2c46c6 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -1467,7 +1467,6 @@ struct page *follow_trans_huge_pmd(struct vm_area_struct *vma, if ((flags & FOLL_DUMP) && is_huge_zero_pmd(*pmd)) return ERR_PTR(-EFAULT); - /* Full NUMA hinting faults to serialise migration in fault paths */ if (pmd_protnone(*pmd) && !gup_can_follow_protnone(vma, flags)) return NULL;