From patchwork Wed Aug 2 09:37:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 13337510 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19257C001DF for ; Wed, 2 Aug 2023 01:37:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB716280111; Tue, 1 Aug 2023 21:37:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E8E9F280110; Tue, 1 Aug 2023 21:37:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A219D280111; Tue, 1 Aug 2023 21:37:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 793DA280112 for ; Tue, 1 Aug 2023 21:37:35 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4892A1C9C05 for ; Wed, 2 Aug 2023 01:37:35 +0000 (UTC) X-FDA: 81077452470.11.33AB418 Received: from dggsgout12.his.huawei.com (unknown [45.249.212.56]) by imf19.hostedemail.com (Postfix) with ESMTP id 7DD891A0016 for ; Wed, 2 Aug 2023 01:37:32 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; spf=none (imf19.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.56) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690940253; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bgf3L5+1beG8C64RCCnI2PAMOD4a+B0/f237uX2C7Xk=; b=WFA8vNiDl5KpGZbMI+SlZjwpkWdFljPskccdlM/FVnhlHIrCKKGGaOO/p2JPAooO7n3suM WYE066HFeQ4YL6VNGMrW7VdFxm8tCgaETzZPx+HZlql5MMnFF/UaCPArFt3vJ2Dzve++MM GOaH2PBfjSRhXhheXPn8SAL9o6JI8XA= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=none (imf19.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.56) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690940253; a=rsa-sha256; cv=none; b=18laJQ+Hu4kggNTbQzpp1EMNlG9KIpecLSBxhq4vvPW8Ybs9+tvqjTa4PsY6gYVShKLtAD 5DysBMFBcyDY59A5IUXo6V/unTsZclmuNx8s9uCfD9yNwrMzrcIEUNEOpEtHJfoG5PsiQl L9PBLhSMVbAFLjM415E339oB2lqwHCs= Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4RFvjd4Ftxz4f4K1T for ; Wed, 2 Aug 2023 09:37:25 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgAXzrFTs8lkvrtvPQ--.56352S7; Wed, 02 Aug 2023 09:37:28 +0800 (CST) From: Kemeng Shi To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, david@redhat.com Cc: shikemeng@huaweicloud.com Subject: [PATCH v2 5/8] mm/compaction: correct comment of cached migrate pfn update Date: Wed, 2 Aug 2023 17:37:38 +0800 Message-Id: <20230802093741.2333325-6-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230802093741.2333325-1-shikemeng@huaweicloud.com> References: <20230802093741.2333325-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: gCh0CgAXzrFTs8lkvrtvPQ--.56352S7 X-Coremail-Antispam: 1UD129KBjvJXoW7tr1Duw4UKF45WFWktFWDArb_yoW8Jw13pr 97Cw1jqw4vqa13Kas2yr1kZa18Jr4ftFy3trsrK348AF43K3ZrtF9rtFyUZFW5X3sIvrWa vF47KFW7ta1fZaUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUPF14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2jI8I6cxK62vIxIIY0VWUZVW8XwA2048vs2IY02 0E87I2jVAFwI0_JF0E3s1l82xGYIkIc2x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0 rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6x IIjxv20xvEc7CjxVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xv wVC2z280aVCY1x0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFc xC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_ Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2 IErcIFxwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E 14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIx kGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUCVW8JwCI42IY6xIIjxv20xvEc7CjxVAF wI0_Cr0_Gr1UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJV W8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjTRKfOw UUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 7DD891A0016 X-Rspam-User: X-Stat-Signature: qefwwxen68gt87g4jrsrtaydw5ac9tof X-Rspamd-Server: rspam01 X-HE-Tag: 1690940252-692797 X-HE-Meta: U2FsdGVkX1997ScQlMgvVuYZi7CvI2bOFgUPOlXSmtOzZEIRnbE3AJWHqTNyoL75N9glzITpi8WkLhHYDcH4Onv7mS8ljDolsjqTOqtIhVvDVuZDaX5UM1c6z0dGnU/wPIJ3+tJ1hPdG9es8TdS7azyBVjJtReGRVWOyGoGJ3Oj+M2zXy2v09Nkk9FX6z39v4DD7l47NduhTTR5S0VuuF5VHzsRCn8hMhx/BeYdTzaVrDBF4FEw8BwRfnlVmHdv0wQk60WJR0aWaOuEYzLT1dHNt26bmPR6sUnKYIh47fjGHk7xj0zKM995StxZ/F6o4R5/rocKaGI/l9cCAoYYqI9hdBUaWaAzf+wyASdWwy4IHG+Hl+vNI/ezBjgvwXAURc9+dhQKjXvaR4BSp5Q97pTleaXuzeYzGHtzipr0Wosh2S6DaKnCKWKpu9GrsHgd05pFssoCCvwt1f8hoL0WRRKHX4+Zmchvm9cuNUlAy0KZpBRbSiYQijZeOEYfiPk+VWlWuaO84uUig+6+o+6cmg8x0jIXZlEFSO7hv/N9h6ksLpuqjfeQ969pLBN3m6uYtij3C6aHvbEvW7e0gc4bG7ezNUqGl91mVv2HyR/W6lYniYPpr8mBX7lUr7ZsUHXhfrmoYfRNSVLt/W9Mj2ubogNiPQldBqaSYB19I0IygQ6F7V32J5QrP+P4pxzoparotPuBfoo7a+d2IYCW2/V3bG4XNvmM/26oLJww4Cm77amg87lFONZj11cVlzurmDh0FK8CivV9KJgnkUTYl0QpU1ZhLwuHntIhNh7mA3hjYoPRMGlGuE/xllGlJR3mJL1MbEbkCL1tBHcDcXRWiygiUDzT37S5w+FCVVl1aQZz5XsaTDUxRfGmeuxwBo9KzdGvLPsqrpSJ9dIi3JfQMXX460OzG95ZZEWDWArffT5Jw4xDE+Tl2ByOYyyzQ6A2+YOOY12JLpEqUddVkhYZOBkL 1LrbnZLv A+BN1yUoM3ZH8zxcMAmWBn0qPS2TRvBk5KXE0CL0HyFDp2Rc1gPlwMW0s62xK+txy0Bzdqy00OnVNBfVJdjBbC6S3cHBcnU2Xgt1B6GTWrTgEHMaaccOfjeEc4dMFVrkBmGJRruDpmXINwhCGGENJEA4UuRy7O2fVK4kz3sPe3N4CDPS+FUtuYvHQqwxkpZpPki0UF4r16PIIWfQAKO5Syc5yNY9SEk8HrC73oJNky4YewyPaKKMpMtprQbm/S2Ok5n7clwOuREi24aaHs0MJiN6dOC5mAXU2L92NwA1q+GfDUlSjyvULkLWLtg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Commit e380bebe47715 ("mm, compaction: keep migration source private to a single compaction instance") moved update of async and sync compact_cached_migrate_pfn from update_pageblock_skip to update_cached_migrate but left the comment behind. Move the relevant comment to correct this. Signed-off-by: Kemeng Shi Reviewed-by: David Hildenbrand Reviewed-by: Baolin Wang --- mm/compaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/compaction.c b/mm/compaction.c index 5c9dc4049e8e..7f01fbeb3084 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -469,6 +469,7 @@ static void update_cached_migrate(struct compact_control *cc, unsigned long pfn) pfn = pageblock_end_pfn(pfn); + /* Update where async and sync compaction should restart */ if (pfn > zone->compact_cached_migrate_pfn[0]) zone->compact_cached_migrate_pfn[0] = pfn; if (cc->mode != MIGRATE_ASYNC && @@ -490,7 +491,6 @@ static void update_pageblock_skip(struct compact_control *cc, set_pageblock_skip(page); - /* Update where async and sync compaction should restart */ if (pfn < zone->compact_cached_free_pfn) zone->compact_cached_free_pfn = pfn; }