From patchwork Mon Aug 7 19:38:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 13344813 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AA7DC04E69 for ; Mon, 7 Aug 2023 19:39:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5D956B007B; Mon, 7 Aug 2023 15:39:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE64B6B007D; Mon, 7 Aug 2023 15:39:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A13296B007E; Mon, 7 Aug 2023 15:39:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9164F6B007B for ; Mon, 7 Aug 2023 15:39:22 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5DB9DC05F5 for ; Mon, 7 Aug 2023 19:39:22 +0000 (UTC) X-FDA: 81098322564.24.0A52C4B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 8EE3F100007 for ; Mon, 7 Aug 2023 19:39:20 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=n+ZsTu28; spf=pass (imf05.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691437160; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MKgBp9oK9I/eGiA5ZFHpYsdGcuADtbCd2AXbZ6/hxtU=; b=5BKjTtqzRVAbdwn7JhwLFVa22bHjk5xnx2KLoAotS8sXApxNvRW8oBVqp+uP85GUjTRGrF HnvyCq378LrBggv55tAGwa1jVoR+NNAc+VVjtHfbQIgoPmkjDGxPIj6ImlL3jZJyjC7ooK Twp+whdwgTk6OkfLzP6FHbi/OMzMhAc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691437160; a=rsa-sha256; cv=none; b=FdEMkJ2qsPXLIE7A9jJw78awUabCI516eBL+pAkYC83L9ZUwQPnnaVlW+6p6kfzArsmSpu h384dZW8AhS3wITsdScCyKyj6G4c6+PmMBQp+NxEpG0LtGcDR4eQI2uuY6dwD+jYvq1u1n WMb7n+0FI1xtfofJzvKzhrZoKYNKaKE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=n+ZsTu28; spf=pass (imf05.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BC37D621D9; Mon, 7 Aug 2023 19:39:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7F53C0760F; Mon, 7 Aug 2023 19:39:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691437159; bh=w/lSN0ukwva6epMNoVXoGECLFjjw4G/9PpuKUglAlXI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=n+ZsTu28M3VdcwnYvSVxoPse+qwGyO+HkVh5pC077q8BEHXzpiyNNUgAHQPYiFJIS j6ZKghZfFnGATLTZj4oxP2NYEGEO7AiSUifGgRP68IlVHDXaWCgn54hYIL0JpmM0p+ CqLzra1OclcPSOt/Hnsh2xZ1sDfSGHbAsCwHm3aTfTxLNmvkLgEmlZKZJ5/0AUuD+R Eqm6CVVkz6y/GuBriAK4Wwi5djQ8NvbLaSPToikNPLCl3fBhu8w7JrnSDO0z49QTWe mdzgssplnSDCZhdVt8pPDznGidgkZHlZ4hD7/wgE/28c355BGbe+y20j1GWIEszM3w vHVLY1B9cMgXw== From: Jeff Layton Date: Mon, 07 Aug 2023 15:38:36 -0400 Subject: [PATCH v7 05/13] fat: make fat_update_time get its own timestamp MIME-Version: 1.0 Message-Id: <20230807-mgctime-v7-5-d1dec143a704@kernel.org> References: <20230807-mgctime-v7-0-d1dec143a704@kernel.org> In-Reply-To: <20230807-mgctime-v7-0-d1dec143a704@kernel.org> To: Alexander Viro , Christian Brauner , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , Amir Goldstein , "Darrick J. Wong" , Benjamin Coddington Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org, Jeff Layton X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1355; i=jlayton@kernel.org; h=from:subject:message-id; bh=w/lSN0ukwva6epMNoVXoGECLFjjw4G/9PpuKUglAlXI=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBk0Ug9pI0NrLPqkw/IVc72gm+1CKA4xq0qrZy8b uVUq7nnyrmJAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCZNFIPQAKCRAADmhBGVaC Fa9OEACCVBv40jfSNekICILFILSv3kfMvSgBhgjGx95YgjXppdwzEyLLlwpSVrSsRV+cftyGpIm fAE/yx7Tg45YQHPEAIjZsXv7bmnKzSjeE6SBYRlzajEuRP5jYccKnpHBkFgt3Bm6CzwTXKsc+wP P+Os6/rMfvLYhgIRrsw2TynaKTK+KCmkPhLl2MY80nE/IJJDuKyc12CA3WObaND9DMiDvrpFrVy +EpTXRHLFTVw9XhkfotB2MTddGG22XE2bX61v2EY7jVHsLfvCexOUHqHERkOMf7sNYTYBNGbQWj GDOTlMmoFkepJxCRNTmBrGPvaEWotzG/J/olLjLSwazaPHviKqV6+YswMlUDwNSkpe3Vj9wVLz4 2q00zgOWKIlzdWwn+HfMColQvMyebLbvGGAipQSNWb31zah3OmKeUULR8PVuszN88ZNHeezNxXA hvZpmJoX1eJLN7m8v8Ed43X/VhazgHgNvOCNu7abZkmYVfTwgI40o7Bd9RLXq+64YqOP+YK+z3Q Zq+YbwZYcxNUuUpn+Cgp7YHZUbEsahymP2YrmwqP4Xob7knCd5llIT+NhSveXB+ZQWC6fDyX7Ch VbhvDGsvPZ+SUd/2o3PDvfQrzxcr0zoGj7FQvhSljVPTCnHDYuqdBgwJjRAwav0+7Gr4YtL69lE MReVPilZbhz9ThA== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 X-Stat-Signature: woxrih6cud3quaportfs5xcmhwxcmrq8 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8EE3F100007 X-Rspam-User: X-HE-Tag: 1691437160-138933 X-HE-Meta: U2FsdGVkX18F0slfBPraP3H9hW0cELX02DABhbfP1OOF5a0qqWooB+5D1QHXPMcQaGaa+47OrtZ7GKFEtS093AOFF79+1/ZE5ABFqKdd1JCFRHOOi2zGqzFqwwabSsbO2EV5Xg4Cf7aioMjgE7+qkXt30bR1PiYMsF/GUN0MR5PUqxSI09vLoEC9RNw6c4NPMcrMnDausHd/CN3kNLKJYUb9GdKeE95GAKEMQAmrun7A/oecUaCQhVZvMqaMIqxfLqnMzHvDI/m1oxDS0W48niE94+b+mI+OvI0ZeYTpg3XbIoGQGrlOMD/lTi4clY43naeqoYy2kIAbAscwnMkHNlrf+9F/c/R2bFRdCf1d83IVucgMkY2DEXp7UzK0l5ztJ1wKvTng3Iar9q7Wym5AXjyMQtLhgFpIsiWFT2PyezKqeps+CbCq0KRe0YCBXcGEv9juBf1WK4vEzyYzmhRPfcH3IIUnG8XXZhsIoW+cckyegGZ2w/GYi8oPkhTLrPzb+YI0CZV0pitVGqS1CzobnFlRpCkYIx34AKZS41m+EvhcQLeCalAyP/+uGaXYRBNFRikjayqjP9ap4Ky0d9lBdCnCguwOfEvDkmCDyiWt6tP0eHFWupe7c/5DL+RXY16H6+xzEATABIBWW/MWepLnSw7xrqdjrQdWfoeTIptAune4QHweM3nF/orUE9+ZwM1CEUHn8PDASe8p9LaNVeHElA/pl599znXHEVorvd5YYiVG6VK/z3FRkHRvWHpdQrQUoKgENBb4N8466Ue1XUc1Ov/ebtf8WRcpYeTdDwiNl5lTTHAIoDgAi/HL/DLX89zWJu63blG6Hg5e2Y8EoD/8v+R0qFUFOnOAiL11YAH2LF5P4TG36k8a3TdMNhAdvyMVEfOCGLdkXarzw3Jp4nYYs+jkdHhyWTO1bW0pfyRwvNo6ks5dEE4aNzHFjBEGy7J7jVHydTAF9O4U3C9tC+u FIG1I5Nq zohQOL05zOjQhLvhb7/E2n+DKHb5AYdH5XHn60LX/USj8fSWVQGm27499XKpI4DjTaY4Z0UDCSBcaW+eA7FwaulBw4xw6WsV2p/jGel/9kH1DbIipUcCX4L3BQw6FPmeEVOO4oPy8AgL3QZmSez1y/j3kZBZl1GC6o64IcBHFo0Emp7tD8IfFLdUHlNlMCSgPryrP75ZgcX7xvLWtPi4RqZTEyYo7bDNCYq/KEv36NkqABq7FWV7iSxT3wQh80fRyHN0Sltclh9/tviZPEVm5QkD5BnIF0oAwwM98ndcIVtFBgIWBVk6AuZmBeXZcfRMgOyP7L0h6kUV58EDBpfMIUD42NWBARQOQBpuEghaXH53PzfXUigprVwfHF12jorl6ZgzvTqh66L9RWWo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: In later patches, we're going to drop the "now" parameter from the update_time operation. Fix fat_update_time to fetch its own timestamp. It turns out that this is easily done by just passing a NULL timestamp pointer to fat_update_time. Also, it may be that things have changed by the time we get to calling fat_update_time after checking inode_needs_update_time. Ensure that we attempt the i_version bump if any of the S_* flags besides S_ATIME are set. Signed-off-by: Jeff Layton Reviewed-by: Jan Kara --- fs/fat/misc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/fat/misc.c b/fs/fat/misc.c index 67006ea08db6..8cab87145d63 100644 --- a/fs/fat/misc.c +++ b/fs/fat/misc.c @@ -347,14 +347,14 @@ int fat_update_time(struct inode *inode, struct timespec64 *now, int flags) return 0; if (flags & (S_ATIME | S_CTIME | S_MTIME)) { - fat_truncate_time(inode, now, flags); + fat_truncate_time(inode, NULL, flags); if (inode->i_sb->s_flags & SB_LAZYTIME) dirty_flags |= I_DIRTY_TIME; else dirty_flags |= I_DIRTY_SYNC; } - if ((flags & S_VERSION) && inode_maybe_inc_iversion(inode, false)) + if ((flags & (S_VERSION|S_CTIME|S_MTIME)) && inode_maybe_inc_iversion(inode, false)) dirty_flags |= I_DIRTY_SYNC; __mark_inode_dirty(inode, dirty_flags);