From patchwork Mon Aug 7 11:09:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qi Zheng X-Patchwork-Id: 13343504 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AE3BC04FE2 for ; Mon, 7 Aug 2023 11:15:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBC0A6B0078; Mon, 7 Aug 2023 07:15:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C6C406B007B; Mon, 7 Aug 2023 07:15:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B357A8D0003; Mon, 7 Aug 2023 07:15:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A3F956B0078 for ; Mon, 7 Aug 2023 07:15:46 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 774F1B2054 for ; Mon, 7 Aug 2023 11:15:46 +0000 (UTC) X-FDA: 81097053492.12.F9AAC6B Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by imf12.hostedemail.com (Postfix) with ESMTP id 8430540022 for ; Mon, 7 Aug 2023 11:15:44 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=BoRgxmNU; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf12.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691406944; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qDCHIUUJzhdUAQEb2C7RW/Dwv8wB1L4nNlzD+13VK1U=; b=f9VTo8zlFG7VafYwfV2CTSRIUMiPeAu9IUPkyMzMkiejDcTK3vvscmxt4PKJueWj94tn5u NfGzw7EAVbzWScpGmwrkx0xReP9oXLv0GBW5r3YBf9y5D/ZdG8ADFxWoIHFp4NGR2T9e2e 8+AAyXz5ThS3dN2mh4TwE/YyMOKZVGU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=BoRgxmNU; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf12.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691406944; a=rsa-sha256; cv=none; b=AAfI31M5/XCniirgIPsu4Z/7xCLIJK9YF7ydqic/WHB8p45h/jzs8RoMruCO5ZV8+PL3mP og8xNgqOiy42/qAlkWyd+fb1bL/9YD461jpFXBnWO9OWCMW5RD//BGbBxbduws7nL+/G8D OfX3Lmb+INLBq8cO+T4+Gl/OmmSG09M= Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-268663fb09cso631559a91.0 for ; Mon, 07 Aug 2023 04:15:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406943; x=1692011743; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qDCHIUUJzhdUAQEb2C7RW/Dwv8wB1L4nNlzD+13VK1U=; b=BoRgxmNUDtxzbmTK8+NbyH+07KYCd+Dr+oKPPa6V2FtEa17D0GvDQxjGlpnMkhmfxh v95DV47NbKABEXmmquIWadBnc0OBxkEOLW5WkwOTzTf/BxgV/A3wBC3uAtz5110v+hzE Ab8A6lWD76Mq+5DiKmh8yjejLb6xJUC09A5jGZ8oJIUHv3JYqq06sjhL7prumjkiRo3O qB570Dus+/9+aUH0B/0q8kHN6EW2eaOwjl0xOlzT2kA7NW6hf0e/OVGGbp1TjXoLyoWq aNUKJyMjC1sbPHUX4hmJJ6cJvGihC8n4kqK2Irls4fBt7l8WiF7MHJ0n9oTLuTvoH1vN CZ3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406943; x=1692011743; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qDCHIUUJzhdUAQEb2C7RW/Dwv8wB1L4nNlzD+13VK1U=; b=GVua8gCPD67SSq+fE3UrQxeUm58uS1NoZ+yopY5j1Capduy/ZThAv4vHeiq/sEAFkd DNf7w3qC0f1RCjoM05QQQ36wbIbsPc+jC1dhJM08DACnAMQmBSOOGMKJz4B7ngy7GQuQ AtyCx5RWtXiAuIZSqLTVmW/Zlu3WxeLf5niLo+AvWioUjbDjduGArj3mdNgsgFSJsflI 51jWLxwdY4C8MQWqiSbXPGMnV2P9REWp3JgXPzSTEfm+5LCMoWH0U6AcQLWEHZg8G3cs IotLpNhO7FNkdmRw/G15SFYlkYfJpTs/dKMjdsJL6XzDE1rbYaixJfgKl6NsM9Lrt9gS 4BLA== X-Gm-Message-State: ABy/qLYrRtsKzV9WorZRsQegdTQE3pz9zyWmrm4AKcFsKt7KEbbZWVeD 4Lv1K+Lx6OrmcdKvZdTK1A+Tnw== X-Google-Smtp-Source: APBJJlEUCHWWWNXSTNLHQrmZRIrp+biqETFoyppqOsbwjUrAqcyZvOjgkWFuVkSEp/5UbdP5i9KhZA== X-Received: by 2002:a17:90a:6c97:b0:263:730b:f568 with SMTP id y23-20020a17090a6c9700b00263730bf568mr23067993pjj.3.1691406943426; Mon, 07 Aug 2023 04:15:43 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.15.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:15:43 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 27/48] dm zoned: dynamically allocate the dm-zoned-meta shrinker Date: Mon, 7 Aug 2023 19:09:15 +0800 Message-Id: <20230807110936.21819-28-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 X-Rspam-User: X-Stat-Signature: edt7jpamdsutg11irjafge9pxoeprjfx X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8430540022 X-HE-Tag: 1691406944-13202 X-HE-Meta: U2FsdGVkX1/nETUwoOjGp/8X+XkKqFGl1fxLzjsV0sI6NXRjTV7fN3BTujD42gWceI6+i6ii/ED0xbfCb5I1OAPSHnsQFfoWRZN6H74XSyvyVBciwIkIXZ7zxu+xujeQKQCABA42I150LG3zsOn9Fb7Ot/P9ucWpK+/3Z/VLGxkbzJmdWXSnh4PCy7f2afDDYHewkDKU9M7gGvr0TT9qHKckGTnlgbX4+e3YUSl+x3ZtkMdjVhekQ7Ge2TQCWoKo0kd75bgWlo9UjSOXLGzuoUfyxccNIPk8lXRuNCZlfE3fqfnZzC3SSTFbefIRJyvjy5bnaKDiJa9kAq1Q07Wk7lsWQqeyuvYRy1Qdpk/jtE+1Dcz/OtNvoQz6DETrUSSMdOqpLrOat85cgZkkMiNionBVMpmyR2Lhts1V+Zo3/83daU0exXTP8teCKFcn0MSgI2ZhbP0Al4LYxwjonMe+VyBuir2krAu6dgZfZRH6xLX2RJkX+E9P2n+GJODdNgrfO2qKJB8gaRbSudhnzUadB6X3gag6B4Gd2neQBZgxFS+1w1+LWPIPiNyuB3mkzU4PO72bzxt7uJ7kdlRMaHWm3nbzz8o18Z7Cohnzt/UB3dNa9utQJEgPIyICpaBJf+AjFiiUPXEvJg/iLQUHSgfpZC4CNqFDIJb4oofVHwrGVtsaUbl2pIe2YYVnNQh4EgfXABBpUIH+z+5YoBuI5c3V1Vkip+jO3uvsNJcl5Ubvf4ytSemWcPSPPT2kIELQuVVrpsnCEQLoKPGMV2v5gYIvpWHrihGEqDW/qxiR5wRMqV8Mniul+b2R4Op0FhI7GmgxxgPnDtaeD/4Wp3mxRnYsxmaegHdJ0gwJL1Dcv4c8MBjJRyf0Bowi6T4wMmc4jwaEqcJl/NwFnHvcVRLRm9iYXx6ZKcKMs+Rwf0BhH7Y+iS4J1FdChnL5f0Qeba9SA1KIKHa+DuLiXq0n7zkVjKx A14q67iz eYuyflcMuo/QsoS9eAY7xOfGU+Yfx8+Um9aXU/vHvZu3ns4t2hCGZvIoiuCp7pehF2E3l2vwHKnxo0yNUA2CkRQEWP0eRVQ/hyAZGw+6tDHF21KJ/9qojVSy3wKdIp0H/jZITuYs+2bbUy00xFoLhakbSyA88QnOKMYp0XIlJjh+s8AkQQUu0Lx1cyOkn3JqZcJrLZhf4IIfPI3r2CFknfzbKYGD1Qt3v8PgHH8dj34y52FwfZn2jOjOvmgXEtYzPOmwIgKMk8S3DIh7ft1HBVqVC/wsJV19+WMzvgW8Ie+QyJ11r1iooMhudrEQYnNOzN1eFDNRikRBnelKWDIAovtcbII+LbXpUB18+jiDL2KSPDig3SYFnSVeRRptXZ4rrM9EO0Y5yI0PbQP9UVTCLDJjLbRwkhx+ztcRq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: In preparation for implementing lockless slab shrink, use new APIs to dynamically allocate the dm-zoned-meta shrinker, so that it can be freed asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU read-side critical section when releasing the struct dmz_metadata. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- drivers/md/dm-zoned-metadata.c | 29 +++++++++++++++++------------ 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c index 9d3cca8e3dc9..bbb0e69a7908 100644 --- a/drivers/md/dm-zoned-metadata.c +++ b/drivers/md/dm-zoned-metadata.c @@ -187,7 +187,7 @@ struct dmz_metadata { struct rb_root mblk_rbtree; struct list_head mblk_lru_list; struct list_head mblk_dirty_list; - struct shrinker mblk_shrinker; + struct shrinker *mblk_shrinker; /* Zone allocation management */ struct mutex map_lock; @@ -615,7 +615,7 @@ static unsigned long dmz_shrink_mblock_cache(struct dmz_metadata *zmd, static unsigned long dmz_mblock_shrinker_count(struct shrinker *shrink, struct shrink_control *sc) { - struct dmz_metadata *zmd = container_of(shrink, struct dmz_metadata, mblk_shrinker); + struct dmz_metadata *zmd = shrink->private_data; return atomic_read(&zmd->nr_mblks); } @@ -626,7 +626,7 @@ static unsigned long dmz_mblock_shrinker_count(struct shrinker *shrink, static unsigned long dmz_mblock_shrinker_scan(struct shrinker *shrink, struct shrink_control *sc) { - struct dmz_metadata *zmd = container_of(shrink, struct dmz_metadata, mblk_shrinker); + struct dmz_metadata *zmd = shrink->private_data; unsigned long count; spin_lock(&zmd->mblk_lock); @@ -2936,19 +2936,24 @@ int dmz_ctr_metadata(struct dmz_dev *dev, int num_dev, */ zmd->min_nr_mblks = 2 + zmd->nr_map_blocks + zmd->zone_nr_bitmap_blocks * 16; zmd->max_nr_mblks = zmd->min_nr_mblks + 512; - zmd->mblk_shrinker.count_objects = dmz_mblock_shrinker_count; - zmd->mblk_shrinker.scan_objects = dmz_mblock_shrinker_scan; - zmd->mblk_shrinker.seeks = DEFAULT_SEEKS; /* Metadata cache shrinker */ - ret = register_shrinker(&zmd->mblk_shrinker, "dm-zoned-meta:(%u:%u)", - MAJOR(dev->bdev->bd_dev), - MINOR(dev->bdev->bd_dev)); - if (ret) { - dmz_zmd_err(zmd, "Register metadata cache shrinker failed"); + zmd->mblk_shrinker = shrinker_alloc(0, "dm-zoned-meta:(%u:%u)", + MAJOR(dev->bdev->bd_dev), + MINOR(dev->bdev->bd_dev)); + if (!zmd->mblk_shrinker) { + ret = -ENOMEM; + dmz_zmd_err(zmd, "Allocate metadata cache shrinker failed"); goto err; } + zmd->mblk_shrinker->count_objects = dmz_mblock_shrinker_count; + zmd->mblk_shrinker->scan_objects = dmz_mblock_shrinker_scan; + zmd->mblk_shrinker->seeks = DEFAULT_SEEKS; + zmd->mblk_shrinker->private_data = zmd; + + shrinker_register(zmd->mblk_shrinker); + dmz_zmd_info(zmd, "DM-Zoned metadata version %d", zmd->sb_version); for (i = 0; i < zmd->nr_devs; i++) dmz_print_dev(zmd, i); @@ -2995,7 +3000,7 @@ int dmz_ctr_metadata(struct dmz_dev *dev, int num_dev, */ void dmz_dtr_metadata(struct dmz_metadata *zmd) { - unregister_shrinker(&zmd->mblk_shrinker); + shrinker_free(zmd->mblk_shrinker); dmz_cleanup_metadata(zmd); kfree(zmd); }