From patchwork Thu Aug 10 07:47:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: xiaolei wang X-Patchwork-Id: 13348902 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F899C001DB for ; Thu, 10 Aug 2023 07:47:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 984196B0074; Thu, 10 Aug 2023 03:47:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 933536B0075; Thu, 10 Aug 2023 03:47:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 739258E0001; Thu, 10 Aug 2023 03:47:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 621896B0074 for ; Thu, 10 Aug 2023 03:47:36 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 339A4405E3 for ; Thu, 10 Aug 2023 07:47:36 +0000 (UTC) X-FDA: 81107415312.17.399A34F Received: from mx0b-0064b401.pphosted.com (mx0b-0064b401.pphosted.com [205.220.178.238]) by imf26.hostedemail.com (Postfix) with ESMTP id 252EA140007 for ; Thu, 10 Aug 2023 07:47:32 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=windriver.com header.s=PPS06212021 header.b="Hmtw/Eve"; dmarc=pass (policy=reject) header.from=windriver.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf26.hostedemail.com: domain of "prvs=7586362fe7=xiaolei.wang@windriver.com" designates 205.220.178.238 as permitted sender) smtp.mailfrom="prvs=7586362fe7=xiaolei.wang@windriver.com" ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691653653; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kO2unsl0pxbA2sfGTphXE1MHCO64iOliAz2mFZSmsc4=; b=2P0fxYHcGRqgv90I0iDwTxc8yt3H3XDditS8YlqiK12F+LuZ+CCo7IpAD9am1snl4Lz1bX 5B8xImv0CbUI0w+gEKLfe2rfQAty/B58CIVW+KC4z07G8Afn2xEa5J/TBvbMBV18MYSXov /UWb7QYCNBYZjFYQKnlOi9LXrpjYtGw= ARC-Authentication-Results: i=2; imf26.hostedemail.com; dkim=pass header.d=windriver.com header.s=PPS06212021 header.b="Hmtw/Eve"; dmarc=pass (policy=reject) header.from=windriver.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf26.hostedemail.com: domain of "prvs=7586362fe7=xiaolei.wang@windriver.com" designates 205.220.178.238 as permitted sender) smtp.mailfrom="prvs=7586362fe7=xiaolei.wang@windriver.com" ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1691653653; a=rsa-sha256; cv=pass; b=p7lyhC/XxgMbP1Bnfgm8UitrmjzgnEe4pfBRwpsbilGQQdN8FiD1gDATC4Ej3O+kj3Zn/r PwBHGHgNMoEmlTXNOOFPUILs22YN6jrpwmnAHrWfy/gqDUs/zCnbLpMgCzNJ7YvhicvF5S kzhibvC7mbvdUD1p1q64e98On30PGbc= Received: from pps.filterd (m0250812.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 37A702ox014269; Thu, 10 Aug 2023 07:47:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=from:to:cc:subject:date:message-id:in-reply-to:references :content-transfer-encoding:content-type:mime-version; s= PPS06212021; bh=kO2unsl0pxbA2sfGTphXE1MHCO64iOliAz2mFZSmsc4=; b= Hmtw/EveHgAe+5MVMEvsozQMtUwCvVt5bmqc80EZLkynw2GdilhjXFIQpbG/QFxj wY3MlMvHfX0UvsPZjBcAvtff8DtIyypB3daNzdHsnQVZo+NTyvdega/ueZD3eshX vejFrvoMbKEm3dL4k/f0bc7C/eKzU5LmF3R/a9xWppQbMBmCVuNusMMYL1LM+Q+q H7zMDWLuD5uGD1s0y/E7JzSGbbfg5HwCATuoalKoPLo9k3AjJzdj3ejkoFoJLywG cc5RgzrVzvqf8Ee81iwapSDll98u0SxwJlseHgUwERvMS1t35GJ1Y65KuuhVk2E8 pKK0oYL3PfkmUCxf5xS+Dg== Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2049.outbound.protection.outlook.com [104.47.73.49]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 3s9dd64msq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Aug 2023 07:47:27 +0000 (GMT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QszQvue1t7qm9J3IxwYscn1IY4OyTQ/8zyYqY6+CTiJj1Igf/3PHyEozJrnohNsG+flFUcuVfrxPBIeePQZSvBk4HzGKuvNgyiWZZ4VV46qZBc5CBRTd+/VvOR8gWZQ/39icTgGW+GrZeo6AVZqFjyhClTMPKQ/sDvazow8vCyTUcqJMt/Xbs3q4UC2yAFYZE+RH6l2DciJO9INLXAYS5YA3CSi2gpd5LQdWWncGSDl2oD+JiCKA6VpYxpTEvIAZd29YJ2uuSTHLiHy5dgMxxofNn/OFq1lSVTdFBHx5a1TrY2A3UcbwwZ1GxE4lsu0rbnVuvhpA76YY+bm4knbacg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kO2unsl0pxbA2sfGTphXE1MHCO64iOliAz2mFZSmsc4=; b=O/zeCeG64OMxsAdMOl5xgJRl7AD7f+9a9wypJpQNGeE0PHUcJS0/qpNNp4KGUdUBlsp8lSIGWytSPuwLsVYzQqsh5lFQPP8mus9VSrG18Px8OquaSmQTkCVZOBV9oCLHFjMlrIgUVclZiOerEpR7K733uQEfadW6Yg+YF3AK4Bkx3MKzkPz72O6kACBOZhZPdlMiLwYOhPyDoYYNX+OirOBij+LUSLWlTiaDvw9xACZn0RZjG1ieMD6BgB/nQZpJYi77ZBsBIj71QfrxpQJanRspBb+dg6mximan448h246Q02bqPNUuCM2NTWCgudoHPze8uqBPzGtCC3OHknDiYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from SJ0PR11MB5769.namprd11.prod.outlook.com (2603:10b6:a03:420::8) by PH7PR11MB7497.namprd11.prod.outlook.com (2603:10b6:510:270::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 07:47:26 +0000 Received: from SJ0PR11MB5769.namprd11.prod.outlook.com ([fe80::1b5d:f77d:a3c1:ce4c]) by SJ0PR11MB5769.namprd11.prod.outlook.com ([fe80::1b5d:f77d:a3c1:ce4c%4]) with mapi id 15.20.6652.026; Thu, 10 Aug 2023 07:47:26 +0000 From: Xiaolei Wang To: catalin.marinas@arm.com, akpm@linux-foundation.org, glider@google.com, andreyknvl@gmail.com, vbabka@suse.cz, zhaoyang.huang@unisoc.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] lib/stackdepot: Bail out in __stack_depot_save() if the stack_table is not allocated Date: Thu, 10 Aug 2023 15:47:03 +0800 Message-Id: <20230810074704.2042664-2-xiaolei.wang@windriver.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230810074704.2042664-1-xiaolei.wang@windriver.com> References: <20230810074704.2042664-1-xiaolei.wang@windriver.com> X-ClientProxiedBy: SI2PR02CA0006.apcprd02.prod.outlook.com (2603:1096:4:194::8) To SJ0PR11MB5769.namprd11.prod.outlook.com (2603:10b6:a03:420::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR11MB5769:EE_|PH7PR11MB7497:EE_ X-MS-Office365-Filtering-Correlation-Id: 204e435a-0cae-4280-0c50-08db997609fc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ocYoDtvZvI2IdH4t1oJTzKBxV+B3mJkzys/E62kbmA7O7w7SBc+IJmF6+PLGdPpi0fbFYErk/hQ7zs7ZgE+bfBL96Dd63EvN04jLn2uer+e/mMQjRShjuHKFU3vfUn1c7ZfIgMTQS5Q4r1AwaqM0j3AyQnPQGJVQwTTFYVn3dd5EeHs7cw0RaJBF3kDB2r5jfidynt3rbK2SE8tAOTnMJfXh1KDCMSkaOCEA6EJ74vx+iz4l+tSQ61AQRJmuq2BsKLgvyxSUP3jXOpm6kT17hixQZ2obBFebKpGx1l52PdvIYdk2l5JVNLzaeSWyK9CfDRicqB7RVShX/Lm6TbSrQPPJV7iJzcW3nSvr+/VgO5c6Izo9kq85wj8VCZ7sVJZB8u/R4wN+I7Ovejz847BGP1I6jrQn+zo8xfjn9xTzPBf89nN+Gqqb5FnersNHTuHLGUEjE/OXZ5jWuQTpQJ7ZMBaWck8StV8xQYxZEdNCg0srs0C94dR3z3cwQJE8V3juk6W80CyycBPGG+z4GQvXdmqSIvLL6m3vCk2aMNc0gMkxeObyy6OVMrkLHCuA6H8M/mzv4jqazET+XJvzidRWv7fTlsqM0CXj2rLKu/s8kCM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR11MB5769.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(376002)(366004)(396003)(39850400004)(186006)(1800799006)(451199021)(2616005)(316002)(86362001)(478600001)(6666004)(6506007)(26005)(1076003)(36756003)(5660300002)(8936002)(8676002)(44832011)(6486002)(41300700001)(6512007)(52116002)(4326008)(2906002)(38350700002)(38100700002)(83380400001)(66476007)(66556008)(66946007)(4744005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: iP3OaXL1JR7WFvIXLAnb1cnoK8BLABl86HmKV7icXHHPuSs7kvM/+oZPZchTEE3qAMJPPdJvmVnpghoxbLFqq/DjX3gh9jczg1plPamsnrclddcKsKWyyDPZKF1EcS9YJFwfNX3ymZwkB6Xsdpd0V/wzcLO2Cy6URXk/ZeGlTmD/zi73Mlsx8W4bUuV05yLi3VbNW6tC1phd8Cjoux6tDJkXumveez2wM3TB06B3sNpNiX8UVhOEfxlkFi7p6Oz5Y6fZ+cXEL1YaYGoWvPKHaHUKjxDUZbS3pFyV18Wnq0FvBTHo7bxrDD7AjqlWQo/mm9sPOBzTh8X2PjzpVAIBqpIxYEpoIjGfTighMmdmADK6W9XaWFSTw7xlzVhndb5rCV6qN4j4CqY8MzdcxjjFPBaqHF9lkplpZzt9V7Sw42+9vV1tA4yGHr+IcEmoR2ahupzb0UIPrEdoNsXXLGUxMjt9FYXdXiNFF8gT8T3PMO9/mxq9i85QGuEuHZbHDWcn5D1vJDgZxh3NvUaL3tSZtI2fmRKEMayIMnVIhzGyjRAkiW6SjpksBkpjkETceWJnjppxq1kWlP8sH0EWnNEpf8tgAemOQgsTtHszvRqtHFqVd83tIdDYQR/MReOPaTvi52szOP3DS8/H9cgmfk7MGoI8acHAY7daAN2xFS2fJeGpdwbcQHOa7weEYPADNMpb9nYU/TM6qpE0qr2OjYenBNlWHp6lytd+x8T0epTDl4j0zxLqia9KpqOx9WcC7tc8ZXIwIq9m1PaCUxdstlE49T2n7RaTW9qpt/FCq/RWkdI0kvIeVoznic5LI+StNARu8JXm9bhfrKbMUriP+KIAeu4dPIsPi6azu/nOsTxMEQqaEh/9JNyypKJjx0Mbec5Fggw1KLLTE8CVVWWKSY5BABNev6VWPSKkT/ljyoPeFkAISMnOvyEG6JMSLtwWmA3GydthaahX/omdpkpD7zbUEOcyBwmd+vKI/QjrWTO4sBekI98J4xaLx01R1h2eCwVRizPS6iGHDhCKS2nkmtp2z30uBHE1seEd2GvLdXDRLJfpJxkOuv2mU5DgLd9xNhqkaRp8AyZtYLXXJB5/Ad/LDBh7McZ0+Q5bcZC65zt4ruq2u/gVAupa+pEPIydTYcAMkfm1xR1fHiovQRbiIl45vkc2FtoyxwwEkQgAzvYX54EsZGQfnJcRbpo1pekPrhi/gGtr2Y7dqRZTxYwGAc87T+vTASzQhyTu5ESVO+s7t9csMGILsAVh+wtc0KE08PNM4afkFzOJ4g9BxS9Un0540kkGrFrN4AYzCFRuig/+gigh4CgLoJ63bvRRxBbKfp1KpFVEQZw352ADvgE0Y4q4jXiyXy14hXoTM6l+sNoVyYwTyCsxw9U0IvCk94yursQi9AkH9qTuu9ywLgzhs2Xxs4woiLnZqOd7YysYmxfi6jnbnf22EGHXY18BzujI1nmzb1K8nlkHRl3gMXi1kFB8r/5/ZztbH4KN6YehzLtJtZqe74RmOdkYtAV9gQ5fA8IYKkT/nKGCak5ZqyOhCRAAAxWtVDrEELN5zhPKmLhe+0Fzwod6zzDMX+zudpzFAmrCTX1+pycsbK+Kr0fSXeVqMg== X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 204e435a-0cae-4280-0c50-08db997609fc X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5769.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 07:47:25.9542 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CndRtmNA/YyU8Bcd65+FHXNLfmjaDsIwfNGEVoOcv7Hd4ANwPiCPhzpoP5yBz7At7xbbv//hG++hu0K4Pi9TJJX/3/nkgwh3brqHJ6GNonY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7497 X-Proofpoint-GUID: 24tkBtBO4qCJRhzpj64h80Heo7lmGNAY X-Proofpoint-ORIG-GUID: 24tkBtBO4qCJRhzpj64h80Heo7lmGNAY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-10_07,2023-08-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0 mlxlogscore=645 impostorscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 adultscore=0 clxscore=1015 bulkscore=0 malwarescore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2306200000 definitions=main-2308100065 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 252EA140007 X-Stat-Signature: upy5rpjc3chhy54od1uukahicr7ttdos X-Rspam-User: X-HE-Tag: 1691653652-386766 X-HE-Meta: U2FsdGVkX1+JAy9jT3tMg6cDNfxwSrdzDZ65viB5wJQHSu9WzKT3SK4T+7UDQGF21RcdGe7rmUMKJT1TO7u2mrCXwJz9uBqM4hqWQTpM+dBlwCskPYqXUZxeR/QWgNnocrV+1i4R0SMfUx3QI7W9tWjz6E8X28X4+FajaMR7n/ZAi5Sm8eoEj7bEQtFI+tKPJA3Ya6z5V5jYCGj9SXDx7I2eGvK+G+gbEDc6NWOd4JMtL4Fg0NpBRkT1v+/W7vc2SMTQTQPWkgleJU/rWyXum6EIcAoWIGnyZBndLbAprmPGzFUH0zBDv6kHqlA3WurZPjLcMjQT4XqpnB7OONlx1c3PLLpLpmjDxBHPQwKmZysi9oV6z4av0ZY2SlacCwJSdHkAkvoCX6NpUUmIsLBWoQSYulcPdp3UtoZQKE0jHyqk/pxcdg5DZV/dZ1Wb8GZSYsFDT7CI04W4KIAr5dmpXxnlMcioHs1S73wtgq55F0fGEXJG0EPpKWi7TQcNPqACBMnWzev+HnLN6itnTYYvUJxK/rEx+SnmOWxHCK8OlD+dyvilXtqM2VfEGuNTwSRuZWtaN0Kmmv9hxu+oo1Y63wnXv9PYX/eptGa4Dw4SwmFx1dxQLAC51UERRRv/s2gpsMVfrAN+qAcZmtfWKiDcRFS8p7OWKgYHhH2UKeCc/kxAPwAiGxeijIdGlQYFFd1AJoMfAzZ8v3t3sAL7JRpE59zbyL8rbmqtvHe3wHKOj1xfXlqgtuxGx7ZiZNc/PRiurCJN5g007A1iOEGJZkR+xGLDcbmi2aSR4IOHNBAjmf4Z/uzXVvQCZUv69H670NuC+IQzWaoAFIW+emiTQf4F/cZAIlEU7hlxWdWrU9BHWsrpOLTf8FyiQmyzoSuC3KL9y4aKXYR9B8dOFRqZG65dmmnv1nsUD+AW9mc9oX9DlRQCKr7K2q8AMsDkVwDYe9Qw3UtJiVr4zLg/ooyRNWf 9i6jolOU 81NXEhVxWmXCXfPBH01rApJKlmNruha+QwHsfF8RQbfkGaDzwZf9ynPMgxsTxHiE3oMXa6VduBDb2OpMLGxVhkfbYi9iJbLrdeueSc0tIHYEsu8AOl4a0nftkmr8XtKoJVgQmLFsVh87bsgKQgy7cb2hs4zyDg1wSej2sc0pJsVsgPVnuFDTpLPLonvQKoJLO0vI87PxGn8T5Ie+TqVwZYjyqCAB8UHhqBJUxRBNByGHzVSyuQSrXCIucmiAM2lS/KIAC6MxD+NBE7mPK46xyHQ09bvR+zE3zcHsXtpML9JDVuq7pZNEUR0py7ITgp4wwti+h6F681bzKCsM8+kpFL+MhK96ULRk0fpHHpsxIpWo5xb+S7UOqwUxBT50uSeEf6eDZ+jnldfMfnBl74asEWklXRuNowKLBak2fzQKj/LxIak++ck2KLMc+8p/1thoUwo49tBVb5e6D/enQ0ZVGf9A1SApptNjoXDpvj2vp/XTsvizztIMELYxgumbj5BW5EU2wznn0y7urdHRUgciDknH/pZKJqLy8HdalDbfNWA7rT0B/gahs0z7ARA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The __stack_depot_save() may be used by some subsystems even before the stack depot is initialized. So add a check of stack_table in __stack_depot_save() to make sure no oops in this case. Fixes: 56a61617dd22 ("mm: use stack_depot for recording kmemleak's backtrace") Signed-off-by: Xiaolei Wang --- lib/stackdepot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/stackdepot.c b/lib/stackdepot.c index 2f5aa851834e..a0651d013a0d 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -376,7 +376,7 @@ depot_stack_handle_t __stack_depot_save(unsigned long *entries, */ nr_entries = filter_irq_stacks(entries, nr_entries); - if (unlikely(nr_entries == 0) || stack_depot_disabled) + if (unlikely(nr_entries == 0) || stack_depot_disabled || unlikely(!stack_table)) goto fast_exit; hash = hash_stack(entries, nr_entries);