diff mbox series

[2/4] sched/fair: fix opencoded numa_nearest_node()

Message ID 20230810162442.9863-3-yury.norov@gmail.com (mailing list archive)
State New
Headers show
Series sched fixes | expand

Commit Message

Yury Norov Aug. 10, 2023, 4:24 p.m. UTC 
task_numa_placement() searches for a nearest node by calling
for_each_node_state(). Now that we have numa_nearest_node(), switch to
using it.

Signed-off-by: Yury Norov <yury.norov@gmail.com>
---
 kernel/sched/fair.c | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

Comments

Andy Shevchenko Aug. 11, 2023, 8:50 a.m. UTC | #1 
On Thu, Aug 10, 2023 at 09:24:40AM -0700, Yury Norov wrote:
> task_numa_placement() searches for a nearest node by calling
> for_each_node_state(). Now that we have numa_nearest_node(), switch to
> using it.

For better looking you may rewrap the above as

---8<---
task_numa_placement() searches for a nearest node by calling
for_each_node_state(). Now that we have numa_nearest_node(),
switch to using
---8<---
diff mbox series

Patch

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index b3e25be58e2b..e7b7cf87937b 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -2645,19 +2645,7 @@  static void task_numa_placement(struct task_struct *p)
 	}
 
 	/* Cannot migrate task to CPU-less node */
-	if (max_nid != NUMA_NO_NODE && !node_state(max_nid, N_CPU)) {
-		int near_nid = max_nid;
-		int distance, near_distance = INT_MAX;
-
-		for_each_node_state(nid, N_CPU) {
-			distance = node_distance(max_nid, nid);
-			if (distance < near_distance) {
-				near_nid = nid;
-				near_distance = distance;
-			}
-		}
-		max_nid = near_nid;
-	}
+	max_nid = numa_nearest_node(max_nid, N_CPU);
 
 	if (ng) {
 		numa_group_count_active_nodes(ng);