From patchwork Mon Aug 21 16:05:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andre Przywara X-Patchwork-Id: 13359608 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7F03EE49AB for ; Mon, 21 Aug 2023 16:05:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 335006B0078; Mon, 21 Aug 2023 12:05:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 296C68E0005; Mon, 21 Aug 2023 12:05:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C1088E0003; Mon, 21 Aug 2023 12:05:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E37E26B0078 for ; Mon, 21 Aug 2023 12:05:43 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 86077405FE for ; Mon, 21 Aug 2023 16:05:43 +0000 (UTC) X-FDA: 81148587366.16.C517B2F Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf28.hostedemail.com (Postfix) with ESMTP id 92CA1C0017 for ; Mon, 21 Aug 2023 16:05:41 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf28.hostedemail.com: domain of andre.przywara@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=andre.przywara@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692633941; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GQS+ilbOsXKNDGsp93OHzTjf+ZI+0FmYOoAUfFJ0BBw=; b=Ts2R7u038uhTdqjDDnYQhAntzxv/vctk/xcCj9OPj88haMEav6d52XjJ3uNI4LEFGkb2Rb KsZ12xkabtuvufxe7BkUFY/Phb5ckA7NIb0ni2gj/R9jEwho7Q02AEvBrQcQnqLpCblVso 6w8vIZzsS9NWLP0+G0ytDjyhCh+Jb/I= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf28.hostedemail.com: domain of andre.przywara@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=andre.przywara@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692633941; a=rsa-sha256; cv=none; b=kX2XZlsu1hcTOu7FqzlwKqv6G5xmrhCf97xYOy01WaXJJz2FL7NXmh/x2kVbMKY1Wefuz7 dYP0JgNGskQ5e4kRD2dJCfNlifTN5UZxyJ/CsyZLTVQPOzPybrENUrwQ2iNci3rzj6eT6k fNVIkF/QMLoUnna/N4BB23u7D6eLa/M= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7AC65143D; Mon, 21 Aug 2023 09:06:21 -0700 (PDT) Received: from donnerap.arm.com (donnerap.manchester.arm.com [10.32.100.58]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 95A373F64C; Mon, 21 Aug 2023 09:05:39 -0700 (PDT) From: Andre Przywara To: Shuah Khan , Nhat Pham , Johannes Weiner Cc: linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] selftests: cachestat: test for cachestat availability Date: Mon, 21 Aug 2023 17:05:33 +0100 Message-Id: <20230821160534.3414911-2-andre.przywara@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230821160534.3414911-1-andre.przywara@arm.com> References: <20230821160534.3414911-1-andre.przywara@arm.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 92CA1C0017 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: drf7xw6nty44nrwgs9nwwgzs66gmyt49 X-HE-Tag: 1692633941-893278 X-HE-Meta: U2FsdGVkX1/SnjMop84fMXI5/3L599w++dd2/bvcDTCVKciBZyQVxbShyt+sv0dU8C8Kc+4ZEmfoUQqUpamFin+KTxQrLZw8W7YcRLQ+LBgxH8kbV8AKe9jVRBhnoL5ieqoeUzJ4CRrOtEqeba83ktJcslBLaJJhK3Nsb8YYDfFby4qDYop2ecDfcIJeb2nblSrYHLtC1oISSxJnWozYPPMO+Go9Zqe/Y85u0P/d0rI1Z+PGBhbcQ75aDV6hcTVD0EIk449jZY8mH2UX6WW+iu9vXd4igRrMaEZ2g/j0NuOK3Rko+viI8N/2obMMenCuOj3RsmHIOqv0ny183IjQbBKM373Quer6PS+B6/fQzsE8ouLkbCF08MGX3xRvC2Em49neqsz4wU8ZKvTBRZUfz42UmNWPjaJ5OJ2lnbHmVGjuJhFDPhIgeGiySDjMbAF48+brTw8vONqq04vbQv31ZVa2TZHM8QGX2+FE9okvNR4QtNQlBQnHmDN5wYNvI0q9tKAzYfnRTWELm0UMH4n08mq4SNkjCaFUNDIUuRhIMJ7QDGhwWTSUihVeApHq0LFBLF8WVgbEEXAS0e226sl3lDywgdZGgJESO3Z+szXYtc8F+lnI90M2IWpXLQVfZEhNehqWdV7wHDPeC6FjT+13Y4tY3OMCGr0lBmY/83CFx0SXRKWukxwD4hN9fNWsvfKSfB00qjJ6ROm6y1etlya+tdDMcydwi8bA4xBkprq6+/qE8/c82Hp91wj7Bt3dHe17GeIepYDzKmb4WXhDRlmhIsfuBG6zrkzcRCrryUok0kvAfZYR8Ja8EzkvloZuxg+1SKHiW2nRIAxizIgO5VvMQksHI1Dk1uwt9ccfhTd2CZvHjtsojai3f3gdU9QluBSIeaaEYEXaskLxrdSUvHXbdGhfgHeFxr5kRJflQmIV4RFWLXwwENw5hLtDVbjI8bpcQ7OlBW68iWz6RnHB4Zf AW2xnKji bROGwBjL5dk+Ao9VsvU4WrU887j3b1alHSc3+p51DskAxv3ugjU0l2lyeKX5YbUXvZ6Euir2yGI+mTyVcQK/55JU/TNaRILmGMJLuLc5LKPxL8GTCAmi78X3s/9RI+jP9r6ktc1ZUBGI+yekItAeCg6HnRLv1l63q+56ZiYBprxE91vk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: As cachestat is a new syscall, it won't be available on older kernels, for instance those running on a development machine. At the moment the test reports all tests as "not ok" in this case. Test for the cachestat syscall availability first, before doing further tests, and bail out early with a TAP SKIP comment. This also uses the opportunity to add the proper TAP headers, and add one check for proper error handling (illegal file descriptor). Signed-off-by: Andre Przywara Acked-by: Nhat Pham --- .../selftests/cachestat/test_cachestat.c | 20 ++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/cachestat/test_cachestat.c b/tools/testing/selftests/cachestat/test_cachestat.c index a5a4ac8dcb76c..8f8f46c24846d 100644 --- a/tools/testing/selftests/cachestat/test_cachestat.c +++ b/tools/testing/selftests/cachestat/test_cachestat.c @@ -15,6 +15,8 @@ #include "../kselftest.h" +#define NR_TESTS 8 + static const char * const dev_files[] = { "/dev/zero", "/dev/null", "/dev/urandom", "/proc/version", "/proc" @@ -235,7 +237,23 @@ bool test_cachestat_shmem(void) int main(void) { - int ret = 0; + int ret; + + ksft_print_header(); + + ret = syscall(__NR_cachestat, -1, NULL, NULL, 0); + if (ret == -1 && errno == ENOSYS) + ksft_exit_skip("cachestat syscall not available\n"); + + ksft_set_plan(NR_TESTS); + + if (ret == -1 && errno == EBADF) { + ksft_test_result_pass("bad file descriptor recognized\n"); + ret = 0; + } else { + ksft_test_result_fail("bad file descriptor ignored\n"); + ret = 1; + } for (int i = 0; i < 5; i++) { const char *dev_filename = dev_files[i];