From patchwork Mon Aug 21 18:33:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Weiner X-Patchwork-Id: 13359739 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 221A7EE4996 for ; Mon, 21 Aug 2023 18:37:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 816FF900006; Mon, 21 Aug 2023 14:37:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 77691900005; Mon, 21 Aug 2023 14:37:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C82D900006; Mon, 21 Aug 2023 14:37:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 48F81900005 for ; Mon, 21 Aug 2023 14:37:49 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0EE591403DA for ; Mon, 21 Aug 2023 18:37:49 +0000 (UTC) X-FDA: 81148970658.13.531B153 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by imf11.hostedemail.com (Postfix) with ESMTP id 2B7AA40002 for ; Mon, 21 Aug 2023 18:37:46 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=zgi7MRwU; spf=pass (imf11.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.174 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692643067; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pMLPduHfWGGT6ewh4Swe7Rx903irp7oZR0cyociTE+I=; b=Kb9Xsc154e0t9B2tg1xvv24QRGN8K5i5bAqZhFkP1SLniAxjc2CkztyN/ZQgdkPEIg4UA9 Fv4eaIrWyY33EQIw5szEMrgA8vUA+w9A05ZNqbkXvkI8KtNE/bHa6JXH8apGymx/rJtXdV u9M7pRt6JD2ShG95V28FdsY57QYcT+w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692643067; a=rsa-sha256; cv=none; b=XAze68F6AyIdQ4hsSE96HBW2auL7G9+u+nnvwQjKYKr7Qij+w4OdwYeszjM0ep/YycxjYX EU6Cst0Yr8A/+8b4kVRJ42ik8wRER1XvUkzRr84KqLLbjEifARSMsO67CMG+1qV6PyDiON NSPgJM5oi3Uy9fvq+UW/QjrbR+p9jwE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=zgi7MRwU; spf=pass (imf11.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.174 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-76d9a79e2fdso161348685a.1 for ; Mon, 21 Aug 2023 11:37:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20221208.gappssmtp.com; s=20221208; t=1692643066; x=1693247866; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pMLPduHfWGGT6ewh4Swe7Rx903irp7oZR0cyociTE+I=; b=zgi7MRwUxuxU6l+6YWjAy02b4tuqcRki3BC55feePlInbqdpdKi7StCxg8XQ8rUlHV qmL0t/87Bm5h3OxPZpMbVir3PnUDYIcuJ4FTPTwg2FPhSmFY8fKiY88CHgVjPTbYLZIG 2DoN2pg+fmyDdEaeyvxyZ3ave1nYE95eRU9EGOtwqubG3M0SowaS80jCKCoaP+xr8d/F u/BS/51tAH69n0fVHUIkW3sy1+PKVJM5fl3G4a4v1K5sZmTdaxUBjIqf1pDgxrGW407t enI3crDHWIDAWXZiLOIWDD7vKqkHVmkYAgjZ7o57kJL6DPyevUUImgJQN1FC2BK0aIa7 0h+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692643066; x=1693247866; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pMLPduHfWGGT6ewh4Swe7Rx903irp7oZR0cyociTE+I=; b=jy8hUAiVQr5puUDAZJxEeyeTJoLus2S7nn0st27MSUOFycS46tJveW2bPhSB6ylKqY MewvPo41Q/uSlBKHReSE3GFLnfODU1Cqi/3VfwTTG5oYM5qzwH+c6ruWr62at0/XnPUk YYK7oWSqgqO+T0hnr+t1q/5PWEBmtktkV+/zDNqWmBVN4l+nEAeJAGRikgwbJv19t144 A8siIwlQUq1FaKCXN43OaAZEdru8oNCl8as7WxIfjddebtaaN0bfyLECbnmrmMHIySvy zhaqyHzYbtP7vCEfIXURCSIO0drHn9PqmKdp91Y3mgHaiQbgfoco+7RTzRhMMMGidFnm g5aQ== X-Gm-Message-State: AOJu0YxqVQSqMNYkA0+B3IqFhuBrDQd8/fyuKjMTuF9aTmShcGJyQIbn +DOfve9aRhvbFvQZUxLpIJVaBw== X-Google-Smtp-Source: AGHT+IEfqgsX5taJcI3/zF6FUgi9VLti8jni51wseVE9vjrqfDRao4TKvZ/QW/DivW2ebVFb/vqJVg== X-Received: by 2002:a05:620a:4550:b0:76c:af30:3281 with SMTP id u16-20020a05620a455000b0076caf303281mr10650217qkp.10.1692643066118; Mon, 21 Aug 2023 11:37:46 -0700 (PDT) Received: from localhost (2603-7000-0c01-2716-699c-6fe1-d2a8-6a30.res6.spectrum.com. [2603:7000:c01:2716:699c:6fe1:d2a8:6a30]) by smtp.gmail.com with ESMTPSA id w13-20020a05620a148d00b0076d25b11b62sm2388467qkj.38.2023.08.21.11.37.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Aug 2023 11:37:45 -0700 (PDT) From: Johannes Weiner To: Andrew Morton Cc: Vlastimil Babka , Mel Gorman , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/8] mm: page_alloc: fix highatomic landing on the wrong buddy list Date: Mon, 21 Aug 2023 14:33:35 -0400 Message-ID: <20230821183733.106619-4-hannes@cmpxchg.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230821183733.106619-1-hannes@cmpxchg.org> References: <20230821183733.106619-1-hannes@cmpxchg.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: 2B7AA40002 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: hgn76rupb6mwgfkps8nx97ybe5hnnefm X-HE-Tag: 1692643066-200581 X-HE-Meta: U2FsdGVkX194pgnyTtSMtX3qOcVvXiYa6CPg25WR8aKmzDphGodRf8SXj+/l9kGI6AroIkjst3cqLKkLzdv1Q59QMi4wXFnYiatKDrEzTXUV/0GSFfyuuqKSwMzCeKYQ9s4tX293YJvvM667yCXLddcIb6qBFHMezHEeEaamyNEEMyDYMsMznMpG8pnw57GXFBfVdpdzPZLgJwNujVHXF5hfnMtWt/LiyrLo2584jzu4yRzpEvI+5Uw+5lPOdRanHH1UXBgfBTAiemQFb2VFqFIg3vaPMy6OVtZ8r38mGnzsiv81iseZLbJJ/oleAfM2QHVBO9TFHfjgDCu99I93YlagleOhnFUKctk4GJmkUqyCokj5rSLS+x/MZZewCVccKHfPAUIkUdd4UjzIp+oUBfoVis6U+1gjhxlX3RmjYHS/Eg87nT9N6DHJsQWjZSeM/LlICaMSeY8igQ3hz8A1DgBAnBksXY4QJit4b1JKB+VWCOnkTym5fdB3cLlvieImuZY/MC7ioFoG9SvGBDrxFwGBJlV2NuWG4XzeNHOn+WCLYkNrmyJ5spPo/nXzPhv//gcd4tT3eS5kyXUJYzb9eS6Sm4znauAi8GnlydNrrWuxjtoOViKV9XJSLIGoDa5AD4oYnQOzsr2+g9gLqVYxndkk997wE6g7OZ6P/zhKI8j4U+lBIJ4nDZVNXq65RklM0XZgjzdLpt10FxfJu8Jz14SWaUrRfjD4y1D794w/HlJHd4nfNmG1GSCxWtN+QdK5tKM79DQ26g5ZlPzsNR43z0lmOvf1tq12ZeNZBWQNtbAdLVVlpsutdTkpAD41rd1Ye+hc4dEGOgnjdhCjXQIfMq1yO+LIQmNUb63mPXr6RnPTYk172Jju/QbNyzyB+LNvQq1ki56OR7ExgDgeyYZj1d+4lDi81R0vGKl4DV0bQ9dq5WUnY4BO4xCJtaugIFBJhU7bOQcbpUrsP3uDiSB mhrhncbh S5lPZpK7w4wi9XG2rHddCEhnLJMT8BGCOpyYzl2TqqRrYnGU38XOZYSEq2dEVxXBabT7k5TIPmyinwfsM9QNtfx2rhALlazyd44zF422Z7i5iBDXCI0kL8KSsWFCkhbCzTl+gzeUmZpVbMSj9gAm8XmEnQRgWOYAlkN6ik1X64hgP36/w2KXu4zZrLumLinn857O0Dd6GVtWNQ/XQyzLF7mK3v2BGFK7TzGGvjT2nD3R6+qp/g4gcKmU0559uoIkKH3zrko14p531Qqg2SP2NokvJxw80pVcNxWWdaT4R+JNgWM3XuyjGr5TL2kzDk1DaSllUNx96dBdJqapwy7GJnRFWA+KmOWTgwNfjkKAjYDPYA8N4ehKiVlxsAc7ZizfGnMUf+dgHCDhHHBQXcAd73YYPaKGsfQHu5cV60Hi+zKafQRxmMfD3n1d1vNMTjDaQp8Kw2qMbzLLwQCwczW2dMWO2A/nCVQFqJyrJUmGDMZkTR9A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The following triggers from a custom debug check: [ 89.401754] page type is 3, passed migratetype is 1 (nr=8) [ 89.407930] WARNING: CPU: 2 PID: 75 at mm/page_alloc.c:706 __free_one_page+0x5ea/0x6b0 [ 89.415847] Modules linked in: [ 89.418902] CPU: 2 PID: 75 Comm: kswapd0 Not tainted 6.5.0-rc1-00013-g42be896e9f77-dirty #233 [ 89.427415] Hardware name: Micro-Star International Co., Ltd. MS-7B98/Z390-A PRO (MS-7B98), BIOS 1.80 12/25/2019 [ 89.437572] RIP: 0010:__free_one_page+0x5ea/0x6b0 [ 89.442271] Code: [ 89.461003] RSP: 0000:ffffc900001acea8 EFLAGS: 00010092 [ 89.466221] RAX: 0000000000000036 RBX: 0000000000000003 RCX: 0000000000000000 [ 89.473349] RDX: 0000000000000106 RSI: 0000000000000027 RDI: 00000000ffffffff [ 89.480478] RBP: ffffffff82ca4780 R08: 0000000000000001 R09: 0000000000000000 [ 89.487601] R10: ffffffff8285d1e0 R11: ffffffff8285d1e0 R12: 0000000000000000 [ 89.494725] R13: 0000000000063448 R14: ffffea00018d1200 R15: 0000000000063401 [ 89.501853] FS: 0000000000000000(0000) GS:ffff88806e680000(0000) knlGS:0000000000000000 [ 89.509930] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 89.515671] CR2: 00007fc66488b006 CR3: 00000000190b5001 CR4: 00000000003706e0 [ 89.522798] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 89.529924] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 89.537048] Call Trace: [ 89.539498] [ 89.541517] ? __free_one_page+0x5ea/0x6b0 [ 89.545619] ? __warn+0x7d/0x130 [ 89.548852] ? __free_one_page+0x5ea/0x6b0 [ 89.552946] ? report_bug+0x18d/0x1c0 [ 89.556607] ? handle_bug+0x3a/0x70 [ 89.560097] ? exc_invalid_op+0x13/0x60 [ 89.563933] ? asm_exc_invalid_op+0x16/0x20 [ 89.568113] ? __free_one_page+0x5ea/0x6b0 [ 89.572210] ? __free_one_page+0x5ea/0x6b0 [ 89.576306] ? refill_obj_stock+0xf5/0x1c0 [ 89.580399] free_one_page.constprop.0+0x5c/0xe0 This is a HIGHATOMIC page being freed to the MOVABLE buddy list. Highatomic pages have their own buddy freelists, but not their own pcplist. free_one_page() adjusts the migratetype so they can hitchhike on the MOVABLE pcplist. However, when the pcp trylock then fails, they're fed directly to the buddy list - with the incorrect type. Use MIGRATE_MOVABLE only for the pcp, not for the buddy bypass. Signed-off-by: Johannes Weiner --- mm/page_alloc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 20973887999b..a5e36d186893 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -2403,7 +2403,7 @@ void free_unref_page(struct page *page, unsigned int order) struct per_cpu_pages *pcp; struct zone *zone; unsigned long pfn = page_to_pfn(page); - int migratetype; + int migratetype, pcpmigratetype; if (!free_pages_prepare(page, order, FPI_NONE)) return; @@ -2415,20 +2415,20 @@ void free_unref_page(struct page *page, unsigned int order) * areas back if necessary. Otherwise, we may have to free * excessively into the page allocator */ - migratetype = get_pfnblock_migratetype(page, pfn); + migratetype = pcpmigratetype = get_pfnblock_migratetype(page, pfn); if (unlikely(migratetype >= MIGRATE_PCPTYPES)) { if (unlikely(is_migrate_isolate(migratetype))) { free_one_page(page_zone(page), page, pfn, order, migratetype, FPI_NONE); return; } - migratetype = MIGRATE_MOVABLE; + pcpmigratetype = MIGRATE_MOVABLE; } zone = page_zone(page); pcp_trylock_prepare(UP_flags); pcp = pcp_spin_trylock(zone->per_cpu_pageset); if (pcp) { - free_unref_page_commit(zone, pcp, page, migratetype, order); + free_unref_page_commit(zone, pcp, page, pcpmigratetype, order); pcp_spin_unlock(pcp); } else { free_one_page(zone, page, pfn, order, migratetype, FPI_NONE);