From patchwork Wed Aug 23 13:13:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru Elisei X-Patchwork-Id: 13362290 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D2BBEE4993 for ; Wed, 23 Aug 2023 13:15:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B414490002E; Wed, 23 Aug 2023 09:15:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF13590002C; Wed, 23 Aug 2023 09:15:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91D1090002E; Wed, 23 Aug 2023 09:15:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8348890002C for ; Wed, 23 Aug 2023 09:15:26 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6453016010B for ; Wed, 23 Aug 2023 13:15:26 +0000 (UTC) X-FDA: 81155415852.19.F1D77CD Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf10.hostedemail.com (Postfix) with ESMTP id BDE9BC0010 for ; Wed, 23 Aug 2023 13:15:24 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692796524; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mQXtYP7R5BBbKPu5paKceFa7P/n6vcGbguF9R7S7xqM=; b=PQqtGkN3AVjeLPT3nR991artA/4dPu6swRa1bRP68fnnBOWeQLGoSfFs1JJZic5gy5nc9t rAAL4z6Rg9wjApCLKN0yEpmDJGCw9EGDpdOoxxwiqgt5hYTnuBJhaYZhUheiRvmA5m3x+y NuciRIf44n1zJjHfztT0wXeZ9yFptRk= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692796524; a=rsa-sha256; cv=none; b=neL7O2PQpNvSdKMqi8c/PLOBVL3gpDaqyzpE7IkcqpVVr3cw+TbA4oJ7ps3d/RY20va65K d1wImHe0bSs0hTjErKVIhDLRKo9GKdFpgwwDTLzumDtpREov/wgE78IzyQjPLENL/EXVXC Hg8H043I12QcFg/OmIJp5GqFTIrxxnQ= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 91C481650; Wed, 23 Aug 2023 06:16:04 -0700 (PDT) Received: from e121798.cable.virginm.net (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4AFC03F740; Wed, 23 Aug 2023 06:15:18 -0700 (PDT) From: Alexandru Elisei To: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com Cc: pcc@google.com, steven.price@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH RFC 12/37] mm: gup: Don't allow longterm pinning of MIGRATE_METADATA pages Date: Wed, 23 Aug 2023 14:13:25 +0100 Message-Id: <20230823131350.114942-13-alexandru.elisei@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230823131350.114942-1-alexandru.elisei@arm.com> References: <20230823131350.114942-1-alexandru.elisei@arm.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: BDE9BC0010 X-Rspam-User: X-Stat-Signature: ma3fp66wfw8f8ozdnocsgpwmr3ydhn43 X-Rspamd-Server: rspam01 X-HE-Tag: 1692796524-870582 X-HE-Meta: U2FsdGVkX19/7KJNLRFj33c8iN3k4w/uMMJsIma9aaGuKXOlV+2MhFkqkpfBdoNPehGUwrBpuFhZE597+cKbjAsJNmcQ3ciTO4gPzSUBQnIYf33IG/OuvScS2FtahiMWYpqRHmnR7m51xKtU6GDJXBLzfadop7hZ0aaakbcs5KhSRjYxRBXm7g61fmjjgBuEEpFBmzDwWjdZ81DY7BXkXdziTWParrJrIIZMXGtwCfArursgE043EChlGv10V0W3w4P0Xq5nkBlEDEOtgeTrcvtsf3Zd5gUM00y/0EZwxXPM73j4tT46OwLDKMms0YAqxoy8OgrvkD+3ab5Y31OVeZO3m/CPqNBSIYwaElp12dqZxTZTqeilZoFgv2/f+JYhzDvYLRwOzyUuBq8RJUcTjdFwk2quPYTdXSMAoHacTNoBfz0wA4pVC0A8bG9P6XdMmSR4AalkCUA5qLpwbaE6SN05ncl/wW/FroGHbzU/H+1vssSKZ+a/qI+dsUtYcwoRUosLcU8AWdLwHCxVOUNMrrx2JwRKZeZWAEnm/IitFvmOo7tm/AsjNBgvn8u2DSp6V/Y09MHb3js9mV1Ov0pOzsIJj2chFE8/myIoewRPAVuOnYRI6WmRlCTmpR6Bdnk3pCCJpCgtQIoRMM0hTMHZx4Si3+FSn4Ik8SgfEcINGtORY5CrSkxBw6PGEhPjViYjWCyLIywxUllZkQJptKx73KvPiUccja2m46OXMYbI1UUMBaowa7B1gFdgncymVKbsLu5k46ar7rL6ULVqcqK9gmtaps5guIwUDYKyPeKh8X6Ge3bdzmcy9w8xmiqAZ0XzTqeQq8OPDenEe/fxu3o2VLArpCV9Udarwn5k6GJkLE3sesns2ObnOrOTuZdEiyB0rFVJ8J8JsgAFhD0t61MyaZvcTsHDbXvJOSfMfM/asIzPYLwNnJQg3d9yT6R+KQ/GRmdeKWDPRcX2oHljX0N g7HjfR25 LNfO905LbydX77RPPdSnMRkj5pOd5w3zizLrJHzULOofITwqZqt0T2SFC/hztlkpfpVcrbdHOh/B1ud2EXcwdk7LgGaFrN4lWq9uY+5BHiym7yHxGhnEtNsF01tquqyjyrX/RuaJ37ZtmKOA58wihhxCCt4TdVY5ipluE+FjEh28Q+zK09Yi/hzBX28tXKH3QSaGxdVfLqiopnWg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Treat MIGRATE_METADATA pages just like movable or CMA pages and don't allow them to be pinned longterm. No special handling needed for migrate_longterm_unpinnable_pages() because the gfp mask for allocating the destination pages is GFP_USER. GFP_USER doesn't include __GFP_MOVABLE, which makes it impossible to accidently allocate metadata pages for migrating the pinned pages. Signed-off-by: Alexandru Elisei --- include/linux/mm.h | 10 +++++++--- mm/Kconfig | 2 ++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 2dd73e4f3d8e..ce87d55ecf87 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -1925,16 +1925,20 @@ static inline bool is_zero_folio(const struct folio *folio) return is_zero_page(&folio->page); } -/* MIGRATE_CMA and ZONE_MOVABLE do not allow pin folios */ +/* MIGRATE_CMA, MIGRATE_METADATA and ZONE_MOVABLE do not allow pin folios */ #ifdef CONFIG_MIGRATION static inline bool folio_is_longterm_pinnable(struct folio *folio) { -#ifdef CONFIG_CMA +#if defined(CONFIG_CMA) || defined(CONFIG_MEMORY_METADATA) int mt = folio_migratetype(folio); - if (mt == MIGRATE_CMA || mt == MIGRATE_ISOLATE) + if (mt == MIGRATE_ISOLATE) + return false; + + if (is_migrate_cma(mt) || is_migrate_metadata(mt)) return false; #endif + /* The zero page can be "pinned" but gets special handling. */ if (is_zero_folio(folio)) return true; diff --git a/mm/Kconfig b/mm/Kconfig index 838193522e20..847e1669dba0 100644 --- a/mm/Kconfig +++ b/mm/Kconfig @@ -1238,6 +1238,8 @@ config LOCK_MM_AND_FIND_VMA config MEMORY_METADATA bool + select MEMORY_ISOLATION + select MIGRATION source "mm/damon/Kconfig"