From patchwork Wed Aug 23 13:13:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru Elisei X-Patchwork-Id: 13362383 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E9DFEE49A0 for ; Wed, 23 Aug 2023 13:17:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B41D5280072; Wed, 23 Aug 2023 09:17:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF22228005D; Wed, 23 Aug 2023 09:17:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9935D280072; Wed, 23 Aug 2023 09:17:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8A2A528005D for ; Wed, 23 Aug 2023 09:17:52 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5E619B1071 for ; Wed, 23 Aug 2023 13:17:52 +0000 (UTC) X-FDA: 81155421984.21.1314E79 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf06.hostedemail.com (Postfix) with ESMTP id 93E0B18002D for ; Wed, 23 Aug 2023 13:17:50 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692796670; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uWgWK0tZ+ZryHuzLyftTn9MC7JOaN9vOC7vkU1Btibg=; b=B4FtOSVPXZbBBsgOf/m/e6aT18M5OVnJeEpHYE7uMjibhBdecWZRq0RJ/CAJDIZpkKuWkp eLCDdzVUHMs0HWmj3b4vWJya8ec7iJAm9vmX+sTrgBMRdDj24fu8wnsnszSLaMHrx/2KwH 2fDTupMxsYgvOFS2wHDSZejBdlXH/Ls= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692796670; a=rsa-sha256; cv=none; b=SOQEPd0RI7t3Biuw1QsCH2hoPGzXzhBDRdckjWckhBuwvhdmPVQUj3VgzKhDQ+Gle9c36p g6Lhm3/FjT0XlyUFkWNYXvOKJNUmbe27Ve9VoUvT2nU2VkmnsYxvjeobGYUVlYwSSiky/v 0GfCubYLfjJBxYp97t7ILfHJ+1y5DTs= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6AF6E16F8; Wed, 23 Aug 2023 06:18:30 -0700 (PDT) Received: from e121798.cable.virginm.net (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2CE8A3F740; Wed, 23 Aug 2023 06:17:44 -0700 (PDT) From: Alexandru Elisei To: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com Cc: pcc@google.com, steven.price@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH RFC 34/37] arm64: mte: Handle fatal signal in reserve_metadata_storage() Date: Wed, 23 Aug 2023 14:13:47 +0100 Message-Id: <20230823131350.114942-35-alexandru.elisei@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230823131350.114942-1-alexandru.elisei@arm.com> References: <20230823131350.114942-1-alexandru.elisei@arm.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 93E0B18002D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: tops98x7qtrmgpz59dgm318fi84naikx X-HE-Tag: 1692796670-530198 X-HE-Meta: U2FsdGVkX1+ZvYZdMmpQNw5iYl7NceaKHxhb4tZlaG6A6axxydiVYh0USZvIKqY+wlG7eBvCGeIRDF6DgikTsruimULQDa+NGEAezDQmuJl89f5TmMo8vQ6YphoCD6a0ewwpib5szw6Bh7JmUp7S15DVowHCVGRgclq0wVnh++EXQAhCZcBJ3+0FKShjKV5aFRRF5BW+k87rygWG/JRer3Otg7oHALHFA6+W0htWIjcfgJfcOgK+F/q0Gv6W93puC7/IR3mJ27QuIDy4/TrQ4IiQVPYWtvRk2Ytd09THcy9l+ZtfJTlASgtzu78JnH1B9m8NlMgipDP5+mi5cL+BCSLSi+MT0ZmQCk7R5+oyB3W5e/zt56/5AD2YyaoM6QD1ZXEAVkOR612pJdzn0mMnK29WKqKnv70mU5kuzB2exIiorBvCHOgFpve/nxNI3OsEdOTiZWjx5HVvgs3iyEB5dCZXrUg4nyu3q2Y7Bvr4HhrfJN7zwBWxwrvsuBkDlW1I0o5H08Y4iBZoPtFXngdWGGnaOV+fT75nFZ9bZ+qgao2FxCUEF08XGLzXycvCsXp/2pyq6lErmJmBfARVlST8jA9BkMiJhXYo5HaE4Mci6NfJu5j2c5MCAmdU0kwSnNiQ/3jPr0zNQ6ZPD9hSMu8pmQwEmtzR4v6UJAV7u0pk6shD7bzrNQXVALWPxrQsr67nU6rgeHMq7MvL4Mz8F4tmZNJCVFu9cMCPHSkgIb97V4MHADSr+bkoRydayr7BHnI651SFvkQDc3j9hzL1gWBcYBresFByFD8hpugTYbrBQ4XPthUEOCSx9qHn/F62KbK5r043cemhD7JaB5ep8UlynwXo149mjXB9o6RTfAOvkxvxhCRY++7lT31YOG6jQ/Q1tMl4Ziy/4I38aZ26lMLuupJxQjpPWg2Bh9yIIxcG37lQOFJOXzIIRTmaCtD1rnlZOBFZU4jrQDSsDQ690Sh 8f/fST48 kkddI8v1KMvZOmOwtbYnzVV28PkU1770nNFSKqWKM5mbc4LNHB7pixfUhuarbPwV5hopAqBN/PpLikiCVbRIATZVIKC5kzyevyuuJBD7IwRJgA3k2xDH9DfBWT7d6oMOXkXJ4PcvsMlAC9+awzO9K+zOSDjA610e7DDLzFLYpq00BCqxajrO//zza8ub/5gptp11wQIdVOPDjp9/5JhRiI9fKDLEd9IIndXcp5In2dzx1rcnAjZrtUW9BZw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: As long as a fatal signal is pending, alloc_contig_range() will fail with -EINTR. This makes it impossible for tag storage allocation to succeed, and the page allocator will print an OOM splat. The process is going to be killed, so return 0 (success) from reserve_metadata_storage() to allow the page allocator to make progress. set_pte_at() will map it with PAGE_METADATA_NONE and subsequent accesses from different threads will trap until the signal is delivered. Signed-off-by: Alexandru Elisei --- arch/arm64/kernel/mte_tag_storage.c | 17 +++++++++++++++++ arch/arm64/mm/fault.c | 23 +++++++++++++++++++++++ 2 files changed, 40 insertions(+) diff --git a/arch/arm64/kernel/mte_tag_storage.c b/arch/arm64/kernel/mte_tag_storage.c index ce378f45f866..1ccbcc144979 100644 --- a/arch/arm64/kernel/mte_tag_storage.c +++ b/arch/arm64/kernel/mte_tag_storage.c @@ -556,6 +556,23 @@ int reserve_metadata_storage(struct page *page, int order, gfp_t gfp) break; } + /* + * alloc_contig_range() returns -EINTR from + * __alloc_contig_migrate_range() if a fatal signal is pending. + * As long as the signal hasn't been handled, it is impossible + * to reserve tag storage for any page. Treat it as an error, + * but return 0 so the page allocator can make forward progress, + * instead of printing an OOM splat. + * + * The tagged page with missing tag storage will be mapped with + * PAGE_METADATA_NONE in set_pte_at(), and accesses until the + * signal is delivered will cause a fault. + */ + if (ret == -EINTR) { + ret = 0; + goto out_error; + } + if (ret) goto out_error; diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c index 7e2dcf5e3baf..64c5d77664c8 100644 --- a/arch/arm64/mm/fault.c +++ b/arch/arm64/mm/fault.c @@ -37,7 +37,9 @@ #include #include #include +#include #include +#include #include #include #include @@ -936,10 +938,31 @@ void do_debug_exception(unsigned long addr_if_watchpoint, unsigned long esr, } NOKPROBE_SYMBOL(do_debug_exception); +static void save_zero_page_tags(struct page *page) +{ + void *tags; + + clear_page(page_address(page)); + + tags = kmalloc(MTE_PAGE_TAG_STORAGE_SIZE, GFP_KERNEL | __GFP_ZERO); + if (WARN_ON(!tags)) + return; + + if (WARN_ON(mte_save_page_tags_by_pfn(page, tags))) + mte_free_tags_mem(tags); +} + void tag_clear_highpage(struct page *page) { /* Tag storage pages cannot be tagged. */ WARN_ON_ONCE(is_migrate_metadata_page(page)); + + if (metadata_storage_enabled() && + unlikely(!page_tag_storage_reserved(page))) { + save_zero_page_tags(page); + return; + } + /* Newly allocated page, shouldn't have been tagged yet */ WARN_ON_ONCE(!try_page_mte_tagging(page)); mte_zero_clear_page_tags(page_address(page));