Message ID | 20230823131350.114942-8-alexandru.elisei@arm.com (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 807EEEE49A0 for <linux-mm@archiver.kernel.org>; Wed, 23 Aug 2023 13:14:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A3E3900028; Wed, 23 Aug 2023 09:14:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 155178E0011; Wed, 23 Aug 2023 09:14:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01C31900028; Wed, 23 Aug 2023 09:14:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E77D58E0011 for <linux-mm@kvack.org>; Wed, 23 Aug 2023 09:14:55 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BD15A120118 for <linux-mm@kvack.org>; Wed, 23 Aug 2023 13:14:55 +0000 (UTC) X-FDA: 81155414550.08.1BF7EEF Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf25.hostedemail.com (Postfix) with ESMTP id 1A825A001F for <linux-mm@kvack.org>; Wed, 23 Aug 2023 13:14:53 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf25.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692796494; a=rsa-sha256; cv=none; b=uobyihivSOPoV4Q3zuc/b0C6LEHSSZFvwPd4VDvQG9JTz9TMcEBpoEI0rHk9ONQbcsYmtg D58RACisp1AHJoAXUqQSu8AHzILB2629vdvJKrWqh+cav+H8CGfuNXP2Dc7jYy+gVL7JLw Jc2p76aK/2g+HdKNooptVXvab9rJJZY= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf25.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692796494; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A51Ox/2QEasSjpYzQHkVp8hfIbl3ucpbfQjyxPrD1/A=; b=0FsTLFop7hCC4Sra3cDbNXKNctBsZuOr7L/UVewty4ziN2nBTDtKVD2XHHwazx8q8b1Xk0 GXXtX9sDhmapFrhT26tDg3ksJ6MvANiaHMf9VdOj5xrqY8dsiDe0s+HYE31K6Fs9+cvcFy 7qwZ6SrJMebklb+ySB5L6gh5UsurUJM= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B6AC91595; Wed, 23 Aug 2023 06:15:33 -0700 (PDT) Received: from e121798.cable.virginm.net (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 51AF33F740; Wed, 23 Aug 2023 06:14:47 -0700 (PDT) From: Alexandru Elisei <alexandru.elisei@arm.com> To: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com Cc: pcc@google.com, steven.price@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH RFC 07/37] mm: page_alloc: Bypass pcp when freeing MIGRATE_METADATA pages Date: Wed, 23 Aug 2023 14:13:20 +0100 Message-Id: <20230823131350.114942-8-alexandru.elisei@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230823131350.114942-1-alexandru.elisei@arm.com> References: <20230823131350.114942-1-alexandru.elisei@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 1A825A001F X-Stat-Signature: um7fmys5fda4wr5oxebu9y5gc3hm4k8j X-Rspam-User: X-HE-Tag: 1692796493-414253 X-HE-Meta: U2FsdGVkX1/pQjLd6HRwtqE2i9Wj9hShhuU1E6nBb5bhOS+NimfpaKZXnvRxBMRyX6aOyntcuDcLzJx/UW8+rIwxF5ciWSNDqxyfTCIteJ/J02dzcWHHUgCvjyZZdSd4o/1T1AYDQqAczIVwqn04bDiFaFDaI1YgIXcUnhk6iRRQlySbk4/GSshkFp/Wlws1QLY0xLkiNlGDylyjaRStMYJJZn3pfWe25qTKJDjrA4W0X4+Jt4gdGP3GUcwbzorNPfxaSWN/Qi5nl+eToKbcDweOadKheSLdVh1Iue/G4iuzaiytVoDQr2GE3s44RdN2sTpaNaBfT0vrYM9vk8TT7y//mpWPXwzuuD6T1ZYbC5sbUvtz7iflmVQti33+D3J0Ny0AWpbRTmztTse8pR6Nfplt0D+7zVXaA4+93riieRFtHSypH+lYpFMs/xmg2fsco/kVXoJEsSdaQvnXJ5WyFOPMP9HqJOBODglysvjN2KDgj+kWAB+vooOd4/15YDa56zh0MahwL4e20SABqzFw/xtBV27OQ7rCgisYfp1xhuj1fY7nO4csbtGFI512IZWWFEsQVsWj6URRzkV+0/qwJlnnD2xRem0nc/ggD3KOHavCDMhrhUw/pvZnRpkhRdNQwiGF1USI5A/ktZ5HLMLWZRyRjOAv76hNB7LFXWYySCeJi7AUYTq2M0jB4KizXQ9ZTIVeril1T8VVfVCTidhYEVseRUb6wCTJwV0C+Dh94ZhXZw1CT5owtjMzXzeyAykuX5U25wLEFvBx5jUVuJJwdBN/aKP+gkm+g6iF6bDnx/IHCxAhTvQzHtvcnLGzxD3mJSHpFAaPMvAoOk/5WdpB8rhbWO2ymQVuRDeKRu0baXADT8Wghtogtnm9nvKRnX7VijVzrLJL6Mq7E9pbe3rMP8T5nV0/MCUOU0i6WpLlxJEbYY1qcYzIPvh1xngPGVmi0xjdzr04AP3HiZG4tPp 9Q57tPzO i2t/EACZOQNuMJk5jAvbVwSowJX44N2BIlUp9+7Xq/yiUT45WJJCm11D1SVYLGmoOI/C8ll9V7HpSQoMDfxoRIMiE0UJVaTav4cPdRcXUAcRwOy4mj8wXNwYmckUPA4CDzkKVUU0n9XDNEuU5N8ra6jjIjuaKqYLRXR61/8lnBJRIBbUQvHzv946Z+QtlvaQcp7bW+RPvVR85/ds= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> |
Series |
[RFC,01/37] mm: page_alloc: Rename gfp_to_alloc_flags_cma -> gfp_to_alloc_flags_fast
|
expand
|
diff --git a/mm/page_alloc.c b/mm/page_alloc.c index a693e23c4733..bbb49b489230 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -2478,7 +2478,8 @@ void free_unref_page(struct page *page, unsigned int order) */ migratetype = get_pcppage_migratetype(page); if (unlikely(migratetype >= MIGRATE_PCPTYPES)) { - if (unlikely(is_migrate_isolate(migratetype))) { + if (unlikely(is_migrate_isolate(migratetype) || + is_migrate_metadata(migratetype))) { free_one_page(page_zone(page), page, pfn, order, migratetype, FPI_NONE); return; } @@ -2522,7 +2523,8 @@ void free_unref_page_list(struct list_head *list) * comment in free_unref_page. */ migratetype = get_pcppage_migratetype(page); - if (unlikely(is_migrate_isolate(migratetype))) { + if (unlikely(is_migrate_isolate(migratetype) || + is_migrate_metadata(migratetype))) { list_del(&page->lru); free_one_page(page_zone(page), page, pfn, 0, migratetype, FPI_NONE); continue;
When a metadata page is returned to the page allocator because all the associated pages with metadata were freed, the page will be returned to the pcp list, which makes it very likely that it will be used to satisfy an allocation request. This is not optimal, because metadata pages should be used as a last resort, to increase the chances they are not in use when they are needed, to avoid costly page migration. Bypass the pcp lists when freeing metadata pages. Note that metadata pages can still end up on the pcp lists when a list is refilled, but this should only happen when memory is running low, which is as intended Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com> --- mm/page_alloc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)