From patchwork Fri Aug 25 13:54:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hao Xu X-Patchwork-Id: 13365926 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15B06C71133 for ; Fri, 25 Aug 2023 14:04:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A8B012800D7; Fri, 25 Aug 2023 10:04:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A3B542800D0; Fri, 25 Aug 2023 10:04:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92ABD2800D7; Fri, 25 Aug 2023 10:04:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8399E2800D0 for ; Fri, 25 Aug 2023 10:04:12 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5AA061206BA for ; Fri, 25 Aug 2023 14:04:12 +0000 (UTC) X-FDA: 81162796344.27.4B5D737 Received: from out-245.mta1.migadu.com (out-245.mta1.migadu.com [95.215.58.245]) by imf23.hostedemail.com (Postfix) with ESMTP id 81725140032 for ; Fri, 25 Aug 2023 14:04:10 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=rqq9t63T; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf23.hostedemail.com: domain of hao.xu@linux.dev designates 95.215.58.245 as permitted sender) smtp.mailfrom=hao.xu@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692972250; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZAHRQkTlH3B9Ayy3ByDVW6IFO8x4JKviNIiMKvNnRxw=; b=4EVTJgrWtdD3Ezn6wpxDHhUcRh2a/0aDgKBUlJ8yfPXeWuclmEHLfzoF/sX5/GL4nGdxI4 55wSgZCQzOEoGXW8CfeKuMxMu4eQa1ONCUC4UI0CiWCxEnYpMX++ozKMHF3qqymrbc2//L t6RC1U5cPF3KrO3p5QgLwB/RBG2W6fE= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=rqq9t63T; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf23.hostedemail.com: domain of hao.xu@linux.dev designates 95.215.58.245 as permitted sender) smtp.mailfrom=hao.xu@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692972250; a=rsa-sha256; cv=none; b=STc6nl30EMX4fr7J6VdmkX6kCwavD0epICdzwp2RlMqvckVMWYBN6ppvVubNN0/tcdwRLk nsCEFnEIMQntSTgLSWhXf7RwooXcNOorcZkAdxBXG38SQq4bgK9zlCbUVg4SUf/hrJRKbG /4QmntL49jKhTlRwrz1Z2WTLDLJxoW4= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1692972248; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZAHRQkTlH3B9Ayy3ByDVW6IFO8x4JKviNIiMKvNnRxw=; b=rqq9t63T1b93nHdvHPb4iPnifbVgNhCPhaGA0/+lVUtdq72oLevGN3oePkSOWgj4tFeMJO 883BuPqR+igY5LuYYZDHjdap5mSmKgc54EL0giqHkQRTPmks0t1/1oKfHQU1t1pMyd2ThX 7baCMPgFPzeqpA42kG/A+w1RFMlPw/c= From: Hao Xu To: io-uring@vger.kernel.org, Jens Axboe Cc: Dominique Martinet , Pavel Begunkov , Christian Brauner , Alexander Viro , Stefan Roesch , Clay Harris , Dave Chinner , "Darrick J . Wong" , linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-cachefs@redhat.com, ecryptfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-unionfs@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, codalist@coda.cs.cmu.edu, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, linux-nilfs@vger.kernel.org, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, Wanpeng Li Subject: [PATCH 22/29] xfs: comment page allocation for nowait case in xfs_buf_find_insert() Date: Fri, 25 Aug 2023 21:54:24 +0800 Message-Id: <20230825135431.1317785-23-hao.xu@linux.dev> In-Reply-To: <20230825135431.1317785-1-hao.xu@linux.dev> References: <20230825135431.1317785-1-hao.xu@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 81725140032 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: xhx93isuusdtnuoiqmwu1z9pkxp85q5z X-HE-Tag: 1692972250-740529 X-HE-Meta: U2FsdGVkX19aix9Ko4hi2Ri28saZaDKJIdkxV+3F7EP8q9xpGIicAdv09K/rPuu7IDJc0RIGcj96JxCkmvjGr+G+KWIDvPenwhV7q2ygM1sJTMYjsxRHjMU/5yTUlzGggYJctD8f+18tglN2gnHLG+Of+eNhKDLKdtXXIWhEGhkLk/3yJdAcRLzWlohBWCT/gTzgOaxc4Cwf5kAXRu/0EfB0yUpn5NUFuC3NWv2Fr9JcJzVdLVim/X9iZEsj3TSBYcH7eQjoLVQK0U2CUt+vNXPa1gRUKnMyEc6/i05liwWcUxD/49OA+c9Rxudm0pzu7e/9l866CJJ6HhFL16bDnoagEWJOKxgaWMfysSZ7M4DixEjlywl1aKT0RV7Y2nzWiT+PFEGFJZOCbVSDz2qRelpHwMR/RllxzIT+q9wZvDfY2CQfecMJ02fWl3ywcPI1O/cddcW9y1BOhJWbm33HrxHoVfD10zDeJ+kMkOWCaOK531MQd92lXrLCEK7EnZi2T+YUlA8T9Dl3fJ575G4HVwNlWHMQBoJf2MU8LopDH9aenVcP2GIdhzMoDuydHFT6MiiI3e+QUWxiP1k2togRACZbvLgh0YBRKh4oTMD8JTW/nJt/J5K9dm9yMMcSAD33LQgGXJPjnEqyjsC3cJk54Nb5Mx1olP/hxkPCd/889xCtE3tEySk8xz6rfD0udflQUHeLMt4r2YVVuSowkhvkJqrNJO/v1gw3w33K1OvEStl7AoX+YWhN3cHfaKBVfQJNxC7NMX5WTfsrMGHNQ/hz2RK6Z/HTsDqmcbkD8vTqY+NiSm/9qojjBfXgsMrkeU2aDPFkgeGYUUzV5UPcIF09CQpFvXkCbjSQXj3FM7BF7pUiEGTxQs6nETnGsT8j3Lnyh0ZEQ3nnhZzrlBZbRR+jmcCmtX0YNBQ+CRB35mvzUd1OWAhfB3MiMc2XMJ0ffehutR8Zna+PnvAPR8P2+x7 1/naEQwF xR+QIWqnKJbjbNeZCpNPZn8gLIy1yb+afLVvllJgu1MQZvtZ1LWqxe7RnMztHGvTqJo9Boua5v1RSLguWI84+MV4ZH1cHEr4fO5UsuDXR90e1tr8iTjEQAfmAF9aIsBkUR72tN1NAnNalWebJ5wCxMt0z3FHYWleS/+tSXlfWmdJFGmnpDgBpB5u5E8K6HDnPj8yaUsniw/OqvZVOX8vVp7yfHyn9mHgRRO/4rK89Z1kgAgs3rFVynwQghQBXTk9vm07x X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Hao Xu Add comments for page allocation in nowait case in xfs_buf_find_insert() Signed-off-by: Hao Xu --- fs/xfs/xfs_buf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index eb3cd7702545..57bdc4c5dde1 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c @@ -633,6 +633,8 @@ xfs_buf_find_insert( * allocate the memory from the heap to minimise memory usage. If we * can't get heap memory for these small buffers, we fall back to using * the page allocator. + * xfs_buf_alloc_kmem may return -EAGAIN, let's not return it but turn + * to page allocator as well. */ if (BBTOB(new_bp->b_length) >= PAGE_SIZE || xfs_buf_alloc_kmem(new_bp, flags) < 0) {