From patchwork Fri Aug 25 13:54:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hao Xu X-Patchwork-Id: 13365928 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48E78C79F77 for ; Fri, 25 Aug 2023 14:05:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D71DC680003; Fri, 25 Aug 2023 10:05:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D2249680001; Fri, 25 Aug 2023 10:05:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BEA54680003; Fri, 25 Aug 2023 10:05:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AEE25680001 for ; Fri, 25 Aug 2023 10:05:11 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 878C91406AC for ; Fri, 25 Aug 2023 14:05:11 +0000 (UTC) X-FDA: 81162798822.13.BEF3E33 Received: from out-247.mta1.migadu.com (out-247.mta1.migadu.com [95.215.58.247]) by imf26.hostedemail.com (Postfix) with ESMTP id AFF30140019 for ; Fri, 25 Aug 2023 14:05:09 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=mPHInzP0; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf26.hostedemail.com: domain of hao.xu@linux.dev designates 95.215.58.247 as permitted sender) smtp.mailfrom=hao.xu@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692972309; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xYVJABOgP4/8L2CV4jLRK/KE5S9+YcPlTWp5R3EisXs=; b=G/50DzuZMGMkbQr6pvfleKKzKU45C8vYwC/feF2A5pcqYJ/YNj7wr2eW1zNAiOGexHa430 FkP8uxM7tanEy5E3yrhxRUHGAHxjmwqIg/QIJIQWzlc8JBYQyEORE3pbk0H6R+r+TOHJVk uRw8mDss9tF7bsXZg3Y4EjbSVFmuoeQ= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=mPHInzP0; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf26.hostedemail.com: domain of hao.xu@linux.dev designates 95.215.58.247 as permitted sender) smtp.mailfrom=hao.xu@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692972309; a=rsa-sha256; cv=none; b=s3/79yQxczjW+bMLDd/ZC03lDRMiMaNr5POEwi3GwjzYvlFczWvJ9b3ElFeVTUjMfMPD99 oIljKQ3WKHcWsoMxL/iQjrvDbEh9i/JCPPuuU4kUQERVy23co2kGq3seN69FQi9ULkkV5F mNSS5T+vhQOCbsJH+b/VTIePGIIlJ1Y= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1692972304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xYVJABOgP4/8L2CV4jLRK/KE5S9+YcPlTWp5R3EisXs=; b=mPHInzP0NdE0PARLrMiNVwBxHc2RcZZ9h1TcJI1UDo2PmUbrGHosmFv1DSPqUTrb8M6kqp 4M25de/KL1vHeKbgvgWIJvfxIGajB7oK9YCJR4tOksovz6wykfv/qKqEWZZksomlKe2dSa K35zik9gA6wCtduft3CmT9CQD0iaLDk= From: Hao Xu To: io-uring@vger.kernel.org, Jens Axboe Cc: Dominique Martinet , Pavel Begunkov , Christian Brauner , Alexander Viro , Stefan Roesch , Clay Harris , Dave Chinner , "Darrick J . Wong" , linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-cachefs@redhat.com, ecryptfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-unionfs@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, codalist@coda.cs.cmu.edu, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, linux-nilfs@vger.kernel.org, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, Wanpeng Li Subject: [PATCH 24/29] xfs: support nowait for xfs_buf_read_map() Date: Fri, 25 Aug 2023 21:54:26 +0800 Message-Id: <20230825135431.1317785-25-hao.xu@linux.dev> In-Reply-To: <20230825135431.1317785-1-hao.xu@linux.dev> References: <20230825135431.1317785-1-hao.xu@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: ftktk3y47fon11kzxnyi6wxdudyt6r56 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: AFF30140019 X-HE-Tag: 1692972309-151781 X-HE-Meta: U2FsdGVkX1/0QgtlAkr+AHYGkDfMZhl41YSfHWiAPwmdmJHe/0awG2gTx+bc8uZefqV6F6389BDuk8AMheRUCQ16Sq8fEsKR4KftUFZ7HrOJWZUQzCAq/NnnYoSKDTd7SfGzXLS6NR0rY0Y6PdAlshLcF4SdhPxSeRtn09SUmc+3eK4XmaiKI0gLOtx9CsT20C91BnhUJkcMtFKN5xuux16tAWBEJDxwl23r4EJhpLnmcDmUCE/1+UKrmGbpwvHfjEiXDNr5ABAM2/jWYIhwZslVG1YcUFMvkUOtBT/0L2E28CBpCmcFWYR45Drao9nMcsb2MJl0tdcCWDZaPXTsEP1f3+u366YOqpbOspQayXeBUMQbhd8q15m+ejiW242rRwZ8+inBEkePolgaRo6sEavhIZcGtB/EpVH7YmbDVwHBetnCG+vrqfknUVOe0fIZlZWbg9rjY59caMhnPm1G68ClymBeFBLehKvAN7lH9yYEG9TphoGdc9I+Y05IXhSvx0gxnYAH3X/Cp0sdiqhKWb+2me9FJSLUSWo6L4vWbVvQ1doAaSkR9a7t19VKswulQt9L9EA2u6rUD/ZlO1Q/0y1UG1qLJM6s6YAWSKhyo/uT831fG76iq73qATetWrg/sAuz79CJINebVsCiKRBj63Aag7KXwVo5stfAPwz7jeducmqqUXVLPjMkJ2l4hdrRUD85nW2WGzYLbY8f8T0t/VeDUY1LrwkTpvJRuKceOk/riQHa4cORJQkStqgqj5zoX2i8rBYc4/Rn8BXNdg3lD/hVsN6BCJA6A+QbaaAJi7Hm72HH6iAj0RmTLox3UpwBiu+Xe3Tti/6Bv3FaFQl2iHNgrTqGv5SCdRfdW74727DxVHfaKhBZWSMMsYyciNxLBYbpQHBRs50fTQDmrVCGKJr5Qeefg4OXV2ogDU+zv8Tdxi9pS2808kh0QcpHKwIdVLGIv8cqOX29i1Sfx7O yNOFdHAy jMXzlqDIUKBS8vdDAxyq/p2+JenrQeLhgj6Hqm+/HLYCjZlf9aOc2+UIeo++U7rl2dCP1v6vZX6UQZvFhQFEzbgydQG9ys+2ak4jk45wImWbXZzWpkmLOACZHkZlgXIkjgIFCrNrA237MLa9NAmi/JBZqdHd/IPTAJMRCgQCy1xzIAz47GXpeytJ80UVXC5g8oxVPkkKEnHfFYV4zO/rlMgA5Zzbg6vgcF41FrNzl79Wvt+oZ/qwG11YTZ6fTBjTJqCg5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Hao Xu This causes xfstests generic/232 hung in umount process, waiting for ail push, so I comment it for now, need some hints from xfs folks. Not a real patch. Signed-off-by: Hao Xu --- fs/xfs/xfs_buf.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index cdad80e1ae25..284962a9f31a 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c @@ -828,6 +828,13 @@ xfs_buf_read_map( trace_xfs_buf_read(bp, flags, _RET_IP_); if (!(bp->b_flags & XBF_DONE)) { +// /* +// * Let's bypass the _xfs_buf_read() for now +// */ +// if (flags & XBF_NOWAIT) { +// xfs_buf_relse(bp); +// return -EAGAIN; +// } /* Initiate the buffer read and wait. */ XFS_STATS_INC(target->bt_mount, xb_get_read); bp->b_ops = ops;