From patchwork Fri Aug 25 13:54:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hao Xu X-Patchwork-Id: 13365931 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F360C71133 for ; Fri, 25 Aug 2023 14:05:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EABAB680007; Fri, 25 Aug 2023 10:05:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E5B19680001; Fri, 25 Aug 2023 10:05:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CFDB1680007; Fri, 25 Aug 2023 10:05:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BE91F680001 for ; Fri, 25 Aug 2023 10:05:56 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 82E0E1206CF for ; Fri, 25 Aug 2023 14:05:56 +0000 (UTC) X-FDA: 81162800712.03.0553875 Received: from out-252.mta1.migadu.com (out-252.mta1.migadu.com [95.215.58.252]) by imf01.hostedemail.com (Postfix) with ESMTP id CD44B40029 for ; Fri, 25 Aug 2023 14:05:54 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=gfnw7iot; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf01.hostedemail.com: domain of hao.xu@linux.dev designates 95.215.58.252 as permitted sender) smtp.mailfrom=hao.xu@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692972355; a=rsa-sha256; cv=none; b=JvB3AyWKG937MEj8vPSUhcwM0FSNx2b0hjT42W2s5vrjlv2VrN+cb6WGyTXRawlYs1KjIe YSoH313QvGOQD8zxP/9z8h/EgpYiQu96bEt7b8xPO2JYifBHG9TKaoVbwgXOkrzYFbMrO1 YHKaimH8mvjC5cgHWfbar7Vi7uPjcCY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=gfnw7iot; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf01.hostedemail.com: domain of hao.xu@linux.dev designates 95.215.58.252 as permitted sender) smtp.mailfrom=hao.xu@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692972355; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4gmh1Yl1nIIBwKe+EGho8dT2/H6COtTrErlOIONZgFQ=; b=OhCpy+7G35mkdbBVioTA3mv2AzjroRvI8xOZ0OYfcr4t06Edev31Z8fRe5H2A+zNVuQ4qW 0EtKdRiwepW3wQNbBVN8Z5APpCbVmi3lCEZjMk7ljKaorYvkdyWixsACIhY8xd9CHm2Smc Ou+Rj82I/sGoGCaW/eHcihwf4JcVei0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1692972353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4gmh1Yl1nIIBwKe+EGho8dT2/H6COtTrErlOIONZgFQ=; b=gfnw7iot2v83zX2rBTLz1spXwFLJTgZUr3L11o+Xtkb6kMiY2V8isvCmRHCyeGMc3m+Cgc 4QGEiH3BvMZ39xF7zrn0F0ImfXnteloPQ0HANELCYOPXSgll6hNjSPIHSsKK/xLoS1sTMP 6uHJDx4f8EyPCrO0C+jtU3MY4km0+Ig= From: Hao Xu To: io-uring@vger.kernel.org, Jens Axboe Cc: Dominique Martinet , Pavel Begunkov , Christian Brauner , Alexander Viro , Stefan Roesch , Clay Harris , Dave Chinner , "Darrick J . Wong" , linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-cachefs@redhat.com, ecryptfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-unionfs@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, codalist@coda.cs.cmu.edu, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, linux-nilfs@vger.kernel.org, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, Wanpeng Li Subject: [PATCH 27/29] xfs: add a comment for xlog_kvmalloc() Date: Fri, 25 Aug 2023 21:54:29 +0800 Message-Id: <20230825135431.1317785-28-hao.xu@linux.dev> In-Reply-To: <20230825135431.1317785-1-hao.xu@linux.dev> References: <20230825135431.1317785-1-hao.xu@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: CD44B40029 X-Stat-Signature: w8gkqejr5si7awfqnc9g69scdmt7rq9n X-HE-Tag: 1692972354-682451 X-HE-Meta: U2FsdGVkX1+5V6jMKaYa4sJ7mrBc6emSb9QluTj+ckp9nhhSx/qPHysvw/LEol7uNd/MQb7KmWz2fwWMX1MkhrGNcVtRLhCDyI+0n8C4EwvsoloHPALFBakkKJP1aZ77zOBhqZ4UIFEih6NOIQmNJk1KyrdwRhMOpgpYJLcqU9jU5S9kBLJJtOAaDY28Xc0x6lDDxBm17mj2xujx+ajMBjNem8Glq+w9xOUbgoT0+tzXN1LZB8BohQcRdCe9rImiVP+pALNy+M90B72svsz9+gLNYZ0keJd8dPXBA71Wi1yHDNrKMlqQ9JjZsbTG8TyWu7SqO2oEmutQWtUdFI/wGvM1jO9/P4BAUjqHnLJ203S+hUY4faJxCWUfOhV7iCabd1gHf5VcYzpqIwZQz+uAMjsOl8EqslxYzT2oCWUn4w42kcRtl2sVja+F5t6w4HJrFKWZj3g/YbvY14LfliqrNyCf+utT5maWY3YULOryt5MCnniUfCZRYORDNq5WVJtFOD/eKMdw6AXOPeWGCQGb959IJlYd6MAGUg8SDBk0lFEZCWZebrBdttk6Cy9XjEbgvTadJcg0QMp1XJufg3g0Wos+jboB6kfIXRVGOMmpammqezm5prooMbI0+qj7IVJWYMLnmyl7FHsAriblyR7KCRIBIZJ8dzqNFdCB97KeJ+EoI67zb1ZqpCIOflXxj/CREMI77A3I0CX3PoJrM2ZEQ7EcN8NK+s6pN99ojK+zMsRqZvK01cQP8Z/1fWsjNA8zTPqWNjtOCFKKm+nQ7+FOth0DnLJdSLnUjj/SVnmeYJIEYwGqzSKOhFqLN30QcwS4M5wANZ6W917ZzCpPQPQiB73oAhzWIknEyOM/Zl0SPmicq0ey826/b+X9tfhnn9Wa3AFkE8z93gmZkKgrBsCm9+ujUxLDAzGCzZpZC8UnaPdAn/FK59Uk/5A3ZHssEVz+R2Oz5P+RXufa8d+R6G9 d2IxIgbq XkdcJpdeM+f086QiDK7cHAaISkuzMV4yCHWKKrLfEgkA9jcVWIayTbpZqwnKNOHSW4xhK5crtkBTK1Y/MEhjs9UvXuT11DW99r2xl3zypYTrRAOdkF7aVK5hvIPy/qdEfGBSIK120gVb5dbd+ngsqtowr1tXuePfo77ZlY9zNvls0LS9R640UhQ3Rgx+yyk4KpxyY5cFt3bB40iVQ6xD3Bs4Hu2AAx+U/rq6vrGVdzjK7C+lOy5qQVYrMbA7SoR1ZtzWG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Hao Xu vmalloc() always succeed in 64 bit system? Not a real patch. Signed-off-by: Hao Xu --- fs/xfs/xfs_log_cil.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/xfs/xfs_log_cil.c b/fs/xfs/xfs_log_cil.c index f17c1799b3c4..b31830ee36dd 100644 --- a/fs/xfs/xfs_log_cil.c +++ b/fs/xfs/xfs_log_cil.c @@ -335,6 +335,9 @@ xlog_cil_alloc_shadow_bufs( * storage. */ kmem_free(lip->li_lv_shadow); + /* + * May this be indefinite loop in nowait case? + */ lv = xlog_kvmalloc(buf_size); memset(lv, 0, xlog_cil_iovec_space(niovecs));