Message ID | 20230828225431.354d3d2d3b80ee5b88e65eb5@linux-foundation.org (mailing list archive) |
---|---|
State | New |
Headers | show |
Series | [GIT,PULL] non-MM updates for 6.6-rc1 | expand |
On Mon, 28 Aug 2023 at 22:54, Andrew Morton <akpm@linux-foundation.org> wrote: > > Linus, please pull mm.git's non-MM updates for this cycle. Hmm. For some non-obvious (to me) reason this triggers vmlinux.o: warning: objtool: ibt_selftest+0x18: sibling call from callable instruction with modified stack frame which didn't happen before, even though the pull doesn't actually change that file at all. I see that Josh has a patch to fix this by making it be real assembly code rather than a hacky inline asm in a C file, but it's a bit surprising, and I don't see why it's triggered now when it wasn't before. At a guess it's related to the Kconfig changes, but I have nothing to back that guess up with. Slightly annoying, but I guess I'll live with the warning for now. Linus
The pull request you sent on Mon, 28 Aug 2023 22:54:31 -0700:
> git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm tags/mm-nonmm-stable-2023-08-28-22-48
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/d68b4b6f307d155475cce541f2aee938032ed22e
Thank you!
On Tue, Aug 29, 2023 at 03:20:37PM -0700, Linus Torvalds wrote: > On Mon, 28 Aug 2023 at 22:54, Andrew Morton <akpm@linux-foundation.org> wrote: > > > > Linus, please pull mm.git's non-MM updates for this cycle. > > Hmm. For some non-obvious (to me) reason this triggers > > vmlinux.o: warning: objtool: ibt_selftest+0x18: sibling call from > callable instruction with modified stack frame > > which didn't happen before, even though the pull doesn't actually > change that file at all. > > I see that Josh has a patch to fix this by making it be real assembly > code rather than a hacky inline asm in a C file, but it's a bit > surprising, and I don't see why it's triggered now when it wasn't > before. > > At a guess it's related to the Kconfig changes, but I have nothing to > back that guess up with. > > Slightly annoying, but I guess I'll live with the warning for now. As far as I can tell this warning only shows up with the rare combination of CONFIG_X86_KERNEL_IBT and CONFIG_UNWINDER_FRAME_POINTER (the latter being pretty much deprecated at this point). Did you manage to enable frame pointers somehow? The fix (to rewrite the IBT selftest) was merged into tip/x86/shstk. Presumably it'll be in a pull request soon-ish.
On 8/30/2023 3:53 PM, Josh Poimboeuf wrote: > On Tue, Aug 29, 2023 at 03:20:37PM -0700, Linus Torvalds wrote: >> Hmm. For some non-obvious (to me) reason this triggers >> >> vmlinux.o: warning: objtool: ibt_selftest+0x18: sibling call from >> callable instruction with modified stack frame >> ... >> At a guess it's related to the Kconfig changes, but I have nothing to >> back that guess up with. >> >> Slightly annoying, but I guess I'll live with the warning for now. This may be due to commit 0d345996e4cb ("x86/kernel: increase kcov coverage under arch/x86/kernel folder") Sohil