From patchwork Tue Aug 29 08:11:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uladzislau Rezki X-Patchwork-Id: 13368666 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2DDCC83F14 for ; Tue, 29 Aug 2023 08:12:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0CC1C280040; Tue, 29 Aug 2023 04:11:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0551A280037; Tue, 29 Aug 2023 04:11:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1A23280040; Tue, 29 Aug 2023 04:11:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C8CF7280037 for ; Tue, 29 Aug 2023 04:11:54 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A0D838057C for ; Tue, 29 Aug 2023 08:11:54 +0000 (UTC) X-FDA: 81176423748.16.9855735 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf11.hostedemail.com (Postfix) with ESMTP id C030840007 for ; Tue, 29 Aug 2023 08:11:52 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=T6NvuHcl; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693296712; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WDP4tqNUhlNIFZZBcXRgHZdwRMYy1Esdu/NCW7wWlsU=; b=nJqIAG2SIyLoqijEsivrYDp1KkQKsUHwA+fncWGIC7kGujwHTDQK79zPpFq/DCv8L7J/XH lSK/wedu57ukbHEUnSwgN/fMFbZZw2lNCsSXrqWjqDdL5DCDnyBx3XDa2ccLAbamqEDMe7 jVvWWXtV11VlV6tPGftT3V36T9VUV7E= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=T6NvuHcl; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693296712; a=rsa-sha256; cv=none; b=EUcha8dY0ge1n7HSwfFMEbpHdEPLIHkfQd4bD6kWyZ84ZDhASE/aXmzp/zKPHfp4oGkzVu pdbQ8UW4RPgcqA0Wn2JoIBPi9bA6Ogzycta32O0wYFMNum22N1VK/pfqyMNeXAdDssM4nG WmVP80TAEyD34/lG+tnb/QKsbQVOVug= Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-50098cc8967so6466790e87.1 for ; Tue, 29 Aug 2023 01:11:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693296711; x=1693901511; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WDP4tqNUhlNIFZZBcXRgHZdwRMYy1Esdu/NCW7wWlsU=; b=T6NvuHclCxEppT8nFMh71q62sGE+tZlEA3hwVNUz/ZA8HpvLfE+jVsPEvlDkp2T6JA BvVtxAhcubFWHDu5ZanFy0HlsbfyU3/qbdz4bPI28m2qBXIlGa0rCttCqxWc/uXOIkl6 6UE+UaAshUPaG0V/dJkZFtmhVNTtGPOu4CJjaX56Km4/Cqox9EMJRpbuy2p45aKZ3PEV ZfkG9G9bTOinVcpj5NxphQLFLuXXYYF71Lw3fOpDNkJDEWv7QBySNmUcO8Z9PAuRFoM/ JueZT8bnCq4JbJcus2pTRqEENYrYmcJdD3FqrPZwA6rzNqirwxtGgAkf/SOxs02IMk+2 BN3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693296711; x=1693901511; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WDP4tqNUhlNIFZZBcXRgHZdwRMYy1Esdu/NCW7wWlsU=; b=MO1y8ICkI1ezF4+WLMFilckfZywrdzYHixIsc5UhEOELOLpBr+Eg9gk+ZqI7iNLX3J ymxibhj6PXiKwvNhjvL78IWau+Iy5wXo0SbyD2nItvlbHP6tFvMHGiib7dtfdkMPeKK+ mXms6PunSE4FXNFM5JKShE9HvqssEUHSaOkP7mpDBX7dZwUZH9LXVRL4EvKH8FlzlOX0 K4JRhzqcCJM9NQG4wZrgZ8vtmUf/YbZA5A1CAYgvxcsKxfPVMv6ZI/bn+gkgfWJGA2pR 7t3Pwl9Aebw9vVYXItDOLTBNoPe7QzaEHuhIRmtyZVuhh9B9F8ZgGuv5tg2PXmJvFHO6 IrUQ== X-Gm-Message-State: AOJu0Yx5KNnhmEGaASFNsQLMY99xlUGBzopzfEW2QzkcuVnTgtNuhObp 9Zxj9PTvQD277/qT75z10oJnqnhtdD6h6g== X-Google-Smtp-Source: AGHT+IHUJH0ptBLC+Y1DnxMxgzbKnbR/6Fjs1YJ0+fTGbIM1B2rz7XjXZu/5VMJRPZ0+lDrr4JRlNg== X-Received: by 2002:a19:ca12:0:b0:500:8fcd:c3b4 with SMTP id a18-20020a19ca12000000b005008fcdc3b4mr12372967lfg.69.1693296711166; Tue, 29 Aug 2023 01:11:51 -0700 (PDT) Received: from pc638.lan ([155.137.26.201]) by smtp.gmail.com with ESMTPSA id f25-20020a19ae19000000b004fbad341442sm1868026lfc.97.2023.08.29.01.11.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Aug 2023 01:11:50 -0700 (PDT) From: "Uladzislau Rezki (Sony)" To: linux-mm@kvack.org, Andrew Morton Cc: LKML , Baoquan He , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Uladzislau Rezki , Oleksiy Avramchenko Subject: [PATCH v2 9/9] mm: vmalloc: Set nr_nodes/node_size based on CPU-cores Date: Tue, 29 Aug 2023 10:11:42 +0200 Message-Id: <20230829081142.3619-10-urezki@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230829081142.3619-1-urezki@gmail.com> References: <20230829081142.3619-1-urezki@gmail.com> MIME-Version: 1.0 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C030840007 X-Stat-Signature: bfw1rtooxredkbuq1arrmmig5maauwoc X-Rspam-User: X-HE-Tag: 1693296712-734736 X-HE-Meta: U2FsdGVkX1+8tvTLpmFInRX5leQoRz0TcURty2Oj5moMAcDQHyOKOsg+8+Rq2PY6OReRb0KH0K1Su10PY8EFg5JIH3IZlHAYLdb/3NCiN4KFQo6Aw5U6WWgNZlC4/adqjhJBhYoQRv3hIRHZlnvbpVVvDVNTNJdBX3OZouN06bYFSh/LPap70e/nQWss0INt+vqXOi/6KyRtjm/S67NuLO2s/jIgCB1smJgh7yBsltp8po96Vt8I7DYbVFHanSAfFAHZzSIX7zWcArnyyTcp8f4xs0z+4ziBpSmApX8cWbBK2IRv1rVop3HLEJKjgndYYeX+fu/tGkz0BSZyvHH5+5bpe18IzDKyfeJQGl6QUH+kV0jX2MQmsGpvPkG4E4+0+TlAq/4vD4PjnzcgEe3+y+HPRPizwMmCsv570uo81WnSWpo1MoZRLuOb0LH8uOvCZHpyHWhC3MHhPO+LSQnXdg3toRwmXbm6/uS7N2zpDDazNsqtifZ0o6K1vHa41ujHwEdKktvLLRYnIQqjcK/8V4tto+yNch6yFdmiiHEPcvm3wNkFC45bV90xnJbcHUO0hhKbf3Q1Ovm0WanXqPCs6CeYvaLQllbIqbcqsJ25sLrTKWQG/Yz3Xw+uP7rZUC+YtSBojsXXTzYufOAcMgSwtGP8qZ83SyQbriImcxt5cLBr//fXsqrotq5kdmdgHWjOECnMk7IzwdfRpqGDVosnt64VHdyneXR8y3ONEspZ1vYKq2g6g5xCU5QARpyD2dE+hCHHECk1UqbKYTvQJyLN3wI2eOTto2YaY3UUCeDeT4HzYwzclENkiTuwqD+LgjUbNmvjAE1U1CT6otFOqk60tQM7A3pnbMQ6NQCwh5hjwsdYvDfZ3lSZE55ooVK7mK7tIBquLPB7YN2xFhHkqVR5r/P6pRJNCiWlNsiXo5wlNGOkFB+SoAwKV0AV5Wez3Qd9D1SRwn8/FE7rNFhckzf kyPAu3No NVrbWSEuzhL/fJ4xFayRjjQxtfZ5e2+nKN3SjCnY967IXTRkSx89OHzDCQxGKA2bPEuaTo3rEqUUoytr++QfLUz74tYjnUf/QBUoJS1FeQH9Wg/GI2pFNr8IuTUvTGwlMjUWm9ZvvlXRVD8zdGCwuRW7jeJJNzDoijLUKKDlfTk0lZEhv7p7eftnHzn7+ilzWp9oNBxvqw0PVSyZhSrE7tmFhs7S0KxwmDhf6tvgrq8+kEytOnssQGWK0Bd8GqzjiQEqmZNesMAy1ZmH1ljHarDWwqEoHb/6BleaDWXIHoATy0ltsqWvvNH/wjxOWSwVA4K+S+LOO6K4/UvfkI01x2TTkWAJ4etlk1au4u/7EWJVUVGA/xooEx6WTN7PxcPUyRsHE/qke6DV6WA2ZAmLq9O9xMeCFR3vZK1NyK1isncy7JP5iTX7gZa3o1JmIo1j3cNtVZTNH1HBeql7ASEUlLJ/6kCxq7+ejipX7mKVcucEgXz8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The density ratio is set to 2, i.e. two users per one node. For example if there are 6 cores in a system the "nr_nodes" is 3. The "node_size" also depends on number of physical cores. A high-threshold limit is hard-coded and set to SZ_4M. For 32-bit, single/dual core systems an access to a global vmap heap is not balanced. Such small systems do not suffer from lock contentions due to limitation of CPU-cores. Test on AMD Ryzen Threadripper 3970X 32-Core Processor: sudo ./test_vmalloc.sh run_test_mask=127 nr_threads=64 94.17% 0.90% [kernel] [k] _raw_spin_lock 93.27% 93.05% [kernel] [k] native_queued_spin_lock_slowpath 74.69% 0.25% [kernel] [k] __vmalloc_node_range 72.64% 0.01% [kernel] [k] __get_vm_area_node 72.04% 0.89% [kernel] [k] alloc_vmap_area 42.17% 0.00% [kernel] [k] vmalloc 32.53% 0.00% [kernel] [k] __vmalloc_node 24.91% 0.25% [kernel] [k] vfree 24.32% 0.01% [kernel] [k] remove_vm_area 22.63% 0.21% [kernel] [k] find_unlink_vmap_area 15.51% 0.00% [unknown] [k] 0xffffffffc09a74ac 14.35% 0.00% [kernel] [k] ret_from_fork_asm 14.35% 0.00% [kernel] [k] ret_from_fork 14.35% 0.00% [kernel] [k] kthread vs 74.32% 2.42% [kernel] [k] __vmalloc_node_range 69.58% 0.01% [kernel] [k] vmalloc 54.21% 1.17% [kernel] [k] __alloc_pages_bulk 48.13% 47.91% [kernel] [k] clear_page_orig 43.60% 0.01% [unknown] [k] 0xffffffffc082f16f 32.06% 0.00% [kernel] [k] ret_from_fork_asm 32.06% 0.00% [kernel] [k] ret_from_fork 32.06% 0.00% [kernel] [k] kthread 31.30% 0.00% [unknown] [k] 0xffffffffc082f889 22.98% 4.16% [kernel] [k] vfree 14.36% 0.28% [kernel] [k] __get_vm_area_node 13.43% 3.35% [kernel] [k] alloc_vmap_area 10.86% 0.04% [kernel] [k] remove_vm_area 8.89% 2.75% [kernel] [k] _raw_spin_lock 7.19% 0.00% [unknown] [k] 0xffffffffc082fba3 6.65% 1.37% [kernel] [k] free_unref_page 6.13% 6.11% [kernel] [k] native_queued_spin_lock_slowpath confirms that a native_queued_spin_lock_slowpath bottle-neck can be considered as negligible for the patch-series version. The throughput is ~15x higher: urezki@pc638:~$ time sudo ./test_vmalloc.sh run_test_mask=127 nr_threads=64 Run the test with following parameters: run_test_mask=127 nr_threads=64 Done. Check the kernel ring buffer to see the summary. real 24m3.305s user 0m0.361s sys 0m0.013s urezki@pc638:~$ urezki@pc638:~$ time sudo ./test_vmalloc.sh run_test_mask=127 nr_threads=64 Run the test with following parameters: run_test_mask=127 nr_threads=64 Done. Check the kernel ring buffer to see the summary. real 1m28.382s user 0m0.014s sys 0m0.026s urezki@pc638:~$ Signed-off-by: Uladzislau Rezki (Sony) Reviewed-by: Baoquan He --- mm/vmalloc.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 9cce012aecdb..08990f630c21 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -796,6 +796,9 @@ struct vmap_node { atomic_t fill_in_progress; }; +#define MAX_NODES U8_MAX +#define MAX_NODE_SIZE SZ_4M + static struct vmap_node *nodes, snode; static __read_mostly unsigned int nr_nodes = 1; static __read_mostly unsigned int node_size = 1; @@ -4803,11 +4806,24 @@ static void vmap_init_free_space(void) } } +static unsigned int calculate_nr_nodes(void) +{ + unsigned int nr_cpus; + + nr_cpus = num_present_cpus(); + if (nr_cpus <= 1) + nr_cpus = num_possible_cpus(); + + /* Density factor. Two users per a node. */ + return clamp_t(unsigned int, nr_cpus >> 1, 1, MAX_NODES); +} + static void vmap_init_nodes(void) { struct vmap_node *vn; int i; + nr_nodes = calculate_nr_nodes(); nodes = &snode; if (nr_nodes > 1) { @@ -4830,6 +4846,16 @@ static void vmap_init_nodes(void) INIT_LIST_HEAD(&vn->free.head); spin_lock_init(&vn->free.lock); } + + /* + * Scale a node size to number of CPUs. Each power of two + * value doubles a node size. A high-threshold limit is set + * to 4M. + */ +#if BITS_PER_LONG == 64 + if (nr_nodes > 1) + node_size = min(SZ_64K << fls(num_possible_cpus()), SZ_4M); +#endif } void __init vmalloc_init(void)