diff mbox series

selftests/mm: gup_longterm: fix a resource leak

Message ID 20230831093144.7520-1-dingxiang@cmss.chinamobile.com (mailing list archive)
State New
Headers show
Series selftests/mm: gup_longterm: fix a resource leak | expand

Commit Message

Ding Xiang Aug. 31, 2023, 9:31 a.m. UTC 
The opened file should be closed in run_with_tmpfile(),
otherwise resource leak will occur

Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
---
 tools/testing/selftests/mm/gup_longterm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/tools/testing/selftests/mm/gup_longterm.c b/tools/testing/selftests/mm/gup_longterm.c
index d33d3e68ffab..ad168d35b23b 100644
--- a/tools/testing/selftests/mm/gup_longterm.c
+++ b/tools/testing/selftests/mm/gup_longterm.c
@@ -265,10 +265,11 @@  static void run_with_tmpfile(test_fn fn, const char *desc)
 	fd = fileno(file);
 	if (fd < 0) {
 		ksft_test_result_fail("fileno() failed\n");
-		return;
+		goto close;
 	}
 
 	fn(fd, pagesize);
+close:
 	fclose(file);
 }