From patchwork Fri Sep 1 15:51:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 13372170 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BE1DCA0FE6 for ; Fri, 1 Sep 2023 07:52:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 720F88D0024; Fri, 1 Sep 2023 03:52:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D1088D0023; Fri, 1 Sep 2023 03:52:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 571678D0024; Fri, 1 Sep 2023 03:52:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 46AE18D0023 for ; Fri, 1 Sep 2023 03:52:19 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1003D140177 for ; Fri, 1 Sep 2023 07:52:19 +0000 (UTC) X-FDA: 81187260798.12.4C63073 Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by imf12.hostedemail.com (Postfix) with ESMTP id CAACF40009 for ; Fri, 1 Sep 2023 07:52:16 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=none; spf=none (imf12.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693554737; a=rsa-sha256; cv=none; b=nw9rBo3Uo4KNQXNnYVBmqDQrucg93jCt70V9vRng7YrMNBVvuyQVvcFGHpkj2Ur5G2GLPW HzL8UfHXVzVAepdPbpAkcheAcB7JxonTqxNMzuNeHB9uPX+3pMHjFSPY7GOeNpbiXW8wcC RjU+rsud+1uKFWHMS6Mee1tG9Sp7aUk= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=none; spf=none (imf12.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693554737; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rR7yXoJyBzsfuZzRhYJlCeGChp8MH3Mlq3MJWURQvYY=; b=Q66yPJR8+C23/nzDdI39D6huA759LX8T8k8KMoDH3+r84pOxhQWPLroxS9ZHlIlUIAY239 5BL7MsAGwK6CdQDVTddvShZ4nG2H+5t/Anf1yNY9hGRl2PhBQa/FdSRkYleEZoSglndGxF IxbmLo6/sC2jibUBx7qGLASegrFMvzA= Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RcVc13Gnwz4f3kKN for ; Fri, 1 Sep 2023 15:52:01 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgDnw6YfmPFk1Z5cCA--.13825S6; Fri, 01 Sep 2023 15:52:01 +0800 (CST) From: Kemeng Shi To: akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, david@redhat.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 4/6] mm/compaction: remove repeat compact_blockskip_flush check in reset_isolation_suitable Date: Fri, 1 Sep 2023 23:51:39 +0800 Message-Id: <20230901155141.249860-5-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230901155141.249860-1-shikemeng@huaweicloud.com> References: <20230901155141.249860-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: gCh0CgDnw6YfmPFk1Z5cCA--.13825S6 X-Coremail-Antispam: 1UD129KBjvdXoWruFyxur4ruw48JFyxCr15urg_yoWkXwc_Jr 1rtrs0krW5ArykWrZrAFsIvrs8KFWkZF1UWw1Dtan0yasI9an5Ja1DZF17ZF15XFWDur93 u3Z3ZF1YkF1fWjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbS8YFVCjjxCrM7AC8VAFwI0_Wr0E3s1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JFv_Gryl82 xGYIkIc2x26280x7IE14v26r126s0DM28IrcIa0xkI8VCY1x0267AKxVW5JVCq3wA2ocxC 64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM2 8EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq 3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8w Aqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE 14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x 0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E 7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcV C0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF 04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7 CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07jstxDUUUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: CAACF40009 X-Stat-Signature: edmzz6ezbd315x1ngeabwxnyinkjya1c X-Rspam-User: X-HE-Tag: 1693554736-940087 X-HE-Meta: U2FsdGVkX1/zhlnLpsW1foqBAB3Pi3tiQu7hsknItQ5Plxd/kjGrJg6xHrzJ0ogYem5JuXlfCNqnyPo6TAyzlaVjX5ihYRE10ACTDm3zuQDpMW/QZzqF85nKZwLEoFEbGazRfUc8SRlhcg5n8VCz3ph/Hryef3xmd36NIort2BFF1YbdTpmd/zCJUID7sRwKXsAy5HM4KagIuvT0yhGc66W/A1YG8C/Cv4iSagGbwty03mNov2RRjWhO1ofy1P38i0aEiq1uCCF8F7IJdG/ywA/FyGk2OYve53LLGyFrK0Nlpi1iKKpH74UUBVe/VuzW7vzHrY14UD6iAC077+vJpb4dJeje5rPXgDLDtdsg9sl5WVuXfHCREtb1vBdba2KWKuefErLTOitsAvCrWhKpvz00e7EEvEtnr5U4cO2MVG3ej4j17BquJoFiThPctWYx2FE45yX0v5aNoEic424bGqWenLAW98cUmke0Jd9ZaZWXEB/3ukjWBzVoPlJSOj5tUBA4aDfhl1FxjnduwEeIiLtSEUF6XzFhgFeqhjFm27nPSa52xUO4yQOsJgDTfmOOxHqPFj2lZIGCR6ap4pJzv5EOIn2ZwrIV7XAexH7NTZicts1TkVmnO30w7rfVYLaYsxX864KR8xEHuyX9Hq4ekgkef7j0tG4K7SapIi0NNhJkWyjXS+q7ljuSXALI796TKVSpLOczsnYkMdeindXO0wSTyc7WX6gpkfvjXCzgN/Msiy6z1fcsDqPLSHxRWsqNmk5QkGqHiccnakBHi+owHpptBtXsjdANAUyAdmOthh8x9W8s71goTuB36qgM3+yzKrrDdTlP47P7Nb+ZKYMjbe/awVjoBuSUVBMADyG3IQX8yc7ZjVmeNiNgldSWvx7MQndLdwFmSs8vq6N+jW6NBbVuAica4AvAAj28x4xMjmOrh5iItJPQ+4150VxVnoNv1Cokkdp3M7GLcx36vfi bZXLF+f7 RsBZLybipt6orJrNyHUb8SmkIjlxY55sE5umCV5xSHDYYZz+WPJ7spPnOM0ufv8VdjBgYudoq/mzaVAL80XD841XR8DZyB5OVWa+SIb1le9uvi0L2cnV1t9+aQ3sZlNJyYGXh/wylC3Uv90rYcuMvoZEURJdJ1Eh6/sIv8hqPImKIBgdafkMEFNljPL9bXGVNgUrY+JDzPCdhnG277q1+kpGGlxd1sPHF3KkgfMGyhRpZVjHjXdEIHId9rDN2GmqE/bPHPK/CMuwm2ZJtNi+tpk0Qf2H5rU1Ey6Cn+hYuLXeaDd2puut+EfvnwuMXpBQcC3cpVcV9DOfdpZ7Unf1GYN2NXg/jhVoXUMuGO1V2kw7BITDHtbIEJEK5xWBVqMEfLY4fMXQXcxAVq/E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: We have compact_blockskip_flush check in __reset_isolation_suitable, just remove repeat check before __reset_isolation_suitable in compact_blockskip_flush. Signed-off-by: Kemeng Shi Reviewed-by: Baolin Wang Acked-by: Mel Gorman --- mm/compaction.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index 9ecbfbc695e5..c377d78e0f15 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -382,6 +382,7 @@ static void __reset_isolation_suitable(struct zone *zone) bool source_set = false; bool free_set = false; + /* Only flush if a full compaction finished recently */ if (!zone->compact_blockskip_flush) return; @@ -434,9 +435,7 @@ void reset_isolation_suitable(pg_data_t *pgdat) if (!populated_zone(zone)) continue; - /* Only flush if a full compaction finished recently */ - if (zone->compact_blockskip_flush) - __reset_isolation_suitable(zone); + __reset_isolation_suitable(zone); } }