From patchwork Mon Sep 11 11:21:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adrian Hunter X-Patchwork-Id: 13379224 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3AF6EE7FF4 for ; Mon, 11 Sep 2023 11:21:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86F846B027B; Mon, 11 Sep 2023 07:21:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81F116B027C; Mon, 11 Sep 2023 07:21:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BF516B027D; Mon, 11 Sep 2023 07:21:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5986D6B027B for ; Mon, 11 Sep 2023 07:21:48 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 26FB21209CF for ; Mon, 11 Sep 2023 11:21:48 +0000 (UTC) X-FDA: 81224076696.18.6F5D70C Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by imf03.hostedemail.com (Postfix) with ESMTP id E7E102001A for ; Mon, 11 Sep 2023 11:21:45 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=HfhBDx3+; spf=pass (imf03.hostedemail.com: domain of adrian.hunter@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=adrian.hunter@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694431306; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/qOVYw8/AQCA41GDNfFddh0waGvAXp3uQuqAeh5dWu0=; b=bfU2KhgwBcH115ZNwGatXBB70XRXfFQxR9QH/TuYvC7XudHS7Ga8H/JC7uB3/kpytoXLE6 U1sXmHuQ+e6zk6V+MA1VN5pLPp/08erzUYTDvPMclRDl2qGUmMvtzRM0f1c6DKzbwwJ6qN M7R1C2evtdzOSEVZ9pEzVkaUXxtEntg= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=HfhBDx3+; spf=pass (imf03.hostedemail.com: domain of adrian.hunter@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=adrian.hunter@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694431306; a=rsa-sha256; cv=none; b=oNkvXtMzxmuCJCatYrtp42EAbpPccrVlUNBBwSEQ/MI341UN8h59e51bwLrr2GKUKSlEI0 9olnLUxy1npJin/QXcwZhWBVkWeEdlYBptlN8qRgZG6jo2uJC9tHAebFBMzG9WKnEqcsTW ZTBZeDQRV6VlAQ9i6swVkzRhEG4EVDA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694431306; x=1725967306; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=M9e2eeN/kfGtE3gA5n3bGk//DgEyKzp702J0NcFnLyE=; b=HfhBDx3+m4pum/zCwIw5Md/ApGACf8KYWakqZYmDQ4qdtsBFECF/2wQi 1VBx7Rqd0dbsGgE9iGF/UtH9XYev67XXuA5H0LcdsVjoyke1kKLPeXCKQ 5O5B9KbV6Yf2LKC3Blhp5sSyrOZH9MBFyKcEyyvsq924V5IvGOcVEdHSA loq3pMQAMXViH5wBFogwt6u9NTETc+/paz3qaBw3OqxGCic8u0yz3wxG4 JUCCYFaz4Mu8tx30HS1FedAijK/59R2btmGPTGhL6pOvvEWoMSirJgz1O UbyPHt9vXtXINbooRbdEyStbYM+zSJgwp4SKtp7JUCY1jPLwrXfTdEh3m g==; X-IronPort-AV: E=McAfee;i="6600,9927,10829"; a="358358429" X-IronPort-AV: E=Sophos;i="6.02,243,1688454000"; d="scan'208";a="358358429" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2023 04:21:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10829"; a="778356406" X-IronPort-AV: E=Sophos;i="6.02,243,1688454000"; d="scan'208";a="778356406" Received: from ahunter6-mobl1.ger.corp.intel.com (HELO ahunter-VirtualBox.home\044ger.corp.intel.com) ([10.251.216.218]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2023 04:21:35 -0700 From: Adrian Hunter To: "Kirill A. Shutemov" , Borislav Petkov , Andrew Morton , Ard Biesheuvel Cc: Dave Hansen , Vlastimil Babka , Mike Rapoport , Lorenzo Stoakes , Tom Lendacky , Baoquan He , Vivek Goyal , Dave Young , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, kexec@lists.infradead.org Subject: [PATCH V2 2/2] proc/kcore: Do not try to access unaccepted memory Date: Mon, 11 Sep 2023 14:21:14 +0300 Message-Id: <20230911112114.91323-3-adrian.hunter@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230911112114.91323-1-adrian.hunter@intel.com> References: <20230911112114.91323-1-adrian.hunter@intel.com> MIME-Version: 1.0 Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki X-Rspamd-Queue-Id: E7E102001A X-Rspam-User: X-Stat-Signature: 3qiuke9xg6fim6zs3pfq6jj3icwccsdt X-Rspamd-Server: rspam01 X-HE-Tag: 1694431305-612078 X-HE-Meta: U2FsdGVkX18jkd5TTxKJpEbHeNk5+SrEcnDtn/WPjaPBD7VAt/SOxP+J9CNmfI7d+53al3wpz1DlyBnJUXHOQQPIndken6AbKLE/C+EMf6y/S0QoAvrK7C2FPIpU2lp/Re5wkrKLwl63FREH9aDtyrlpSYM+oyGTprEUYRmkSsF7SKdXEoJDVvt+vKf3ky5GzzM49sbvaj5kvmEhcFc7WmPYlaPYxQmtNVK/3GeRGCFvL9j65NBCzR1VmFutbIC+Yl4QPZacZKCw9Rl3QuF4ZFr6M4BmiuCMmmc9Gi+BC2YTJHtM59Q/VJG8FG8/7Je/M4k+gHPXCWp+Yc3DgZVwUC/pZNVnUn/CqTQGWFCMFAHeeWSZNyFEEHSgpvnIragp5ZqxVqNtKUVtFzTdgwWNzlUzDDt6/dePSvo2hgHnAPHEjxpxo3FFBZWAwFnY0VKNpMO1zm2IPm7OtVXAvylHyqdWctPxh/Byp0BfqRqoL2sfgYA56j8WeBAJESDjYmXp4dFuhiABjhMvm4wfQmdSCfVr1Wd5NnesMac5WBvel1Ty4KYxwjpPMd+zKDGjNohLnwWVD8QpO9HCfWPOtTkdgZH0OQDYH/cfagtqjNpFWDqzuk3okK7BvBs3CMb3LSJKoyCXNkJL9NVLdnGPUYdZuefrsI/JliahUTquMXZzE1Q+KJgZs4jx5ujupp0szzQrv1qNDTeIeXS/nDcrFPq9ZrR2ZLRqBHmFjaDxHcfy5UimJaSBkX4PMMIivV4PpeRb4rQgWEqlQq/akSZNpvbkD5go8Py5ERfVWi3EUarvT8R66Pgos5taCQIqSj5mpzC8QFX7g1wnoKFLII76Zmckp9hHCKmi0uRS5AlLD9LP0efVTDF+ZvWykrn0SQwZqzxSIQNUaVggEMzz8yMcDgn2deLBHjdAcBH0mTKw3MPPZr3INhQGwIEmwbz51XtVye8BPTSocOmsbb8U98R7yxq t2gycCAp v0UHrVwWMvLO053H1qm4X+jMXf3/ptWoFFNNAqXncNPF++5BjEXSBWyf0YjQqLdetPEDRG7RmiZQwbFJF/EyZbsZEhgDR+Fm/961W3UigiRqaz8pWs8sJI0xm8m0rrcyg/AkZ/XFESTYtrtAmcFf+zHg/ptRTPOh/+kBxEb+MVBF3ockGFuuS/rcGLN6vgUZQwENX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Support for unaccepted memory was added recently, refer commit dcdfdd40fa82 ("mm: Add support for unaccepted memory"), whereby a virtual machine may need to accept memory before it can be used. Do not try to access unaccepted memory because it can cause the guest to fail. For /proc/kcore, which is read-only and does not support mmap, this means a read of unaccepted memory will return zeros. Signed-off-by: Adrian Hunter Reviewed-by: David Hildenbrand --- fs/proc/kcore.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Changes in V2: Change patch subject and commit message Do not open code pfn_is_unaccepted_memory() diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c index 23fc24d16b31..6422e569b080 100644 --- a/fs/proc/kcore.c +++ b/fs/proc/kcore.c @@ -546,7 +546,8 @@ static ssize_t read_kcore_iter(struct kiocb *iocb, struct iov_iter *iter) * and explicitly excluded physical ranges. */ if (!page || PageOffline(page) || - is_page_hwpoison(page) || !pfn_is_ram(pfn)) { + is_page_hwpoison(page) || !pfn_is_ram(pfn) || + pfn_is_unaccepted_memory(pfn)) { if (iov_iter_zero(tsz, iter) != tsz) { ret = -EFAULT; goto out;