From patchwork Tue Sep 12 08:59:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: liujinlong X-Patchwork-Id: 13381109 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 624EACA0ED5 for ; Tue, 12 Sep 2023 09:00:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 92D656B00CD; Tue, 12 Sep 2023 05:00:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DCCB6B00D0; Tue, 12 Sep 2023 05:00:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CC8D6B00D1; Tue, 12 Sep 2023 05:00:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6A3F16B00CD for ; Tue, 12 Sep 2023 05:00:10 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2EABAA0D70 for ; Tue, 12 Sep 2023 09:00:10 +0000 (UTC) X-FDA: 81227348580.21.27175F7 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by imf30.hostedemail.com (Postfix) with ESMTP id 3490080012 for ; Tue, 12 Sep 2023 09:00:06 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf30.hostedemail.com: domain of liujinlong@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liujinlong@kylinos.cn ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694509208; a=rsa-sha256; cv=none; b=A0+0g1BShPFb4hbuOi46WB5xBIDgRXTFhLqgu7wAKDH//13AvwqyHuuU+Wv7E7HdgcYsYr LYQ0uH4FSF12+lraBmb1fLGhc/rjDYBud9onIXs810gJxdGg7DnzT3CBDoJH/M7jYyqPE0 WVQPUIWpTg69j91BXGwsHKmX6kFvr+o= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf30.hostedemail.com: domain of liujinlong@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liujinlong@kylinos.cn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694509208; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=sDir4op6SG6kBSX8kOngiV/GxfdwqFF8EFgqihES70w=; b=y1oiXXOu+bAuQBdVxryeQpm0tHOkqbhm4HqQpEIsbr9aeDpj2oIzfrksU1ThCvV0Jv7eYE 0SnW499gBgRLwxbwjAcgmbsld0eqg+9+gxwEcYlCmJVFqTsPu/xYR33fQGHMIbB+Ez6zhx R7yMKH3XPqbhduNFnaw5bpZ1D9wYM3w= X-UUID: 1b208d654f514db6ab615f053c02d5c0-20230912 X-CID-O-RULE: Release_Ham X-CID-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.31,REQID:0df1d1f6-bd20-45d5-95d9-0e2e93b66f7c,IP:20, URL:0,TC:0,Content:-5,EDM:0,RT:0,SF:-5,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:10 X-CID-INFO: VERSION:1.1.31,REQID:0df1d1f6-bd20-45d5-95d9-0e2e93b66f7c,IP:20,UR L:0,TC:0,Content:-5,EDM:0,RT:0,SF:-5,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:10 X-CID-META: VersionHash:0ad78a4,CLOUDID:66bdbdbe-14cc-44ca-b657-2d2783296e72,B ulkID:230912165507KG6SZBFD,BulkQuantity:1,Recheck:0,SF:38|24|17|19|44|102, TC:nil,Content:0,EDM:-3,IP:-2,URL:0,File:nil,Bulk:40,QS:nil,BEC:nil,COL:0, OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_FSD,TF_CID_SPAM_FSI,TF_CID_SPAM_SNR,TF_CID_SPAM_FAS X-UUID: 1b208d654f514db6ab615f053c02d5c0-20230912 X-User: liujinlong@kylinos.cn Received: from kylin-thinkpad-pc.. [(116.128.244.171)] by mailgw (envelope-from ) (Generic MTA) with ESMTP id 727084725; Tue, 12 Sep 2023 16:59:26 +0800 From: liujinlong To: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: liujinlong Subject: [PATCH] mm: vmscan: modify an easily misunderstood function name Date: Tue, 12 Sep 2023 16:59:23 +0800 Message-Id: <20230912085923.27238-1-liujinlong@kylinos.cn> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 3490080012 X-Stat-Signature: zwshm5g73ageuz4rzzxm8ftu9sn81bw3 X-Rspam-User: X-HE-Tag: 1694509206-895579 X-HE-Meta: U2FsdGVkX19BZSjjqVoIY4Yuk+I21UL6OpRztCCgRREf4kRg9xNK5jOe2rSdyyk916Q9MEy+qd2C7lVNwGOfu0sjk8rhaJoToH6Wke3vo2WDE7Af/vAorINUT+0n5/r6L0mPj1vJSZWlrUVTTB1nBtleQahNT5svKUgCfri1cgnt5aAVt9AuHGoaYG+i97ANvcBmVItXE2LMxogE2JVLknfoCumraOVqC23c9zIvj9KBYO6sr2VZGQT9purGGZi9VxTwcAve4BCztVT8UI7juPgdjN341yZlUkVXA50RH99RhnZ6FoPdYvO8oS4QFxtkt+lprN7UjTUI8nAI9+g4v2zoW4QAj0R6MQhkAXuE9Jf4Dot7yzYH92KJW5C5mGl0IOld91WVKllYWJa4I2OkuOuHriGQxaFemfz18JlAt75qSy2wFmyd/dUCd+dWBqCM7xf8KB6+Zqb7N6Fhikj5jl/eli1sI/CHZM8y8bgT6rv8GYDZEMtdMLufIljlmxyZYd7wo4GFYz/u/axCbE94WU45TiUDu2bi6YuQ7a7ZMsKggmyj5blPfFDM7aOIQrI6t1xw2WXlX2b2GmBZC4zO8a35Ntn9n1iREX2bWMMzOOBHeRpRv6AmkfArSyZQChtv/zxdY8YA6XuWeJSyaIObcPDey4pScvwYznhp2f7cm6NK3lPy1XSnm6hWR92SXQOLXPdgRsLyKL/ROG5xI2r4vkGGp4gaq9TM4HAoMA+kF/pp2Lc0yNw5JGbv71blOsug8Y6DsAniwGDSf0csh5Gxlhf68SWDhtyRgsr6UYZEqMTbyLOI2MABmcQHufQaj0O4Il/Qr2o2aoLQ4BEE2/eNrdQK6UvslHmHpBgZf2wcFqNyMqzo/DsOlYs2aVfKeb8iIdIfvLtL5s1eZ9/z13GBlTSIloLyiry1Nv8STBxnmQYLNwlks2wEUJK9LgrXEau3qj4zGCH+334MS+hathg W7+5osET y2zPpnUUgoHEqAEZj4N7NtqpwLDRU2J59798m X-Bogosity: Ham, tests=bogofilter, spamicity=0.000072, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When looking at the code in the memory part, I found that the purpose of the function prepare_scan_countis very different from the function name. It is easy to misunderstand when reading.The function prepare_scan_count mainly completes the assignment of the scan_control structure.Therefore, I suggest that the function name can be changed to prepare_scan_control, which is easier to understand. Signed-off-by: liujinlong --- mm/vmscan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 6f13394b112ea..4e1d2b8ced91a 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2909,7 +2909,7 @@ enum scan_balance { SCAN_FILE, }; -static void prepare_scan_count(pg_data_t *pgdat, struct scan_control *sc) +static void prepare_scan_control(pg_data_t *pgdat, struct scan_control *sc) { unsigned long file; struct lruvec *target_lruvec; @@ -6535,7 +6535,7 @@ static void shrink_node(pg_data_t *pgdat, struct scan_control *sc) nr_reclaimed = sc->nr_reclaimed; nr_scanned = sc->nr_scanned; - prepare_scan_count(pgdat, sc); + prepare_scan_control(pgdat, sc); shrink_node_memcgs(pgdat, sc);