From patchwork Wed Sep 13 10:53:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Usama Arif X-Patchwork-Id: 13382761 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A507CA553A for ; Wed, 13 Sep 2023 10:54:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9F616B0179; Wed, 13 Sep 2023 06:54:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 94AF46B017D; Wed, 13 Sep 2023 06:54:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 68C1E6B017A; Wed, 13 Sep 2023 06:54:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 383396B017B for ; Wed, 13 Sep 2023 06:54:11 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0229780D5F for ; Wed, 13 Sep 2023 10:54:10 +0000 (UTC) X-FDA: 81231264702.13.3EEC7ED Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by imf26.hostedemail.com (Postfix) with ESMTP id AACE414000A for ; Wed, 13 Sep 2023 10:54:08 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=R4YLke9u; spf=pass (imf26.hostedemail.com: domain of usama.arif@bytedance.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=usama.arif@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694602449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=av0vrlLKsg9xBQaLOcb8CPCy93VQFu46a3TbtxpfU4U=; b=tLmw1eQdaSOaV2lKauZL5i1Nzs5vjERs/4BYYe3cZYn3guq1ppF3U2hBnlYUNdqQB8/50I e+7AZII0pS5WU8koivrEYaT5vdoZGbkl2sMgr08O2sLpr8y5tPp/sRcJ4dB155qIBvksbR FEjBxDSp0vaN2h99Y1ms3sJvL78mmks= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694602449; a=rsa-sha256; cv=none; b=zNbNXBR4SLjH0oQvKEQc7N6G+XFA5Z9jPbBNbyAn9OR/5cq2tDGbmWmKNrpayPP/H/6zV3 S6cWHN1DhETlyvLSt/SbJQbfbmg1SwtLic6408hsSfqOGdwoIwp2vR6mqfUaB4DuRCERP3 r3zUCB7ajm+frLyGpGAXWxNQm3esHqY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=R4YLke9u; spf=pass (imf26.hostedemail.com: domain of usama.arif@bytedance.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=usama.arif@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2bf66a32f25so87873241fa.2 for ; Wed, 13 Sep 2023 03:54:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1694602446; x=1695207246; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=av0vrlLKsg9xBQaLOcb8CPCy93VQFu46a3TbtxpfU4U=; b=R4YLke9uKg7N248/G2Th2cRmaN+bzvwnbZa8yhjzAgotxkRghtV4qxOGYf38Ucv4x0 CBUlHwOMV3gENssbYFE1L6EkTtP+zOIY0SV8drrVslh5RbEk16+Ehk8zQ/wSeF2T48qg DRtp1Yk4rSpPB1eiiWZ7G4+zsj/v/QcExN1f/zhadQNpscZHBS8n1veiTYiqmxK2BkEI RIgh9SFOJwUHaeb0N4vCisNupE5sYrMVtIB1mUpaWCFUkUahUgcX3S85SIsZ04DeqiiO k3zSLD+OGuTzMbwZX95K9opbCoE2cytTjCdBxgUMPWjgZdHTq7xOPzy/+jLDeSlXY1cn NZVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694602446; x=1695207246; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=av0vrlLKsg9xBQaLOcb8CPCy93VQFu46a3TbtxpfU4U=; b=aUJZ2w2fTTaCYSBcu2gq5244SeKt8hjyOcqVfOrCJJxcQKjdMY2XnB86hIWHK+ZvJm sK5rX9k8QQww09XLXK0L9e9oPPaAIC34LhxPqkzeP81zfjJMA3HsHFKwcs3y9MNugMRJ UF5Z6nY8pl+hpINC8EN2yEPdNQVuBwYu8TIv1z2egqHVegHTUXytkKXlhJi1+LwZSfCm zHBqD7Km6t5zUvApAUCIAv9YMTxWwDsoEdugPvjvf7r1fUOJwUvjttMiWzM9PMi23PdN jswMatrF2uEEUcf8R9plzPPD0eYFN+WZQi0lPkpGFgVlh03+OZ6H6F4+QkDNvtMyOuDh 4nvA== X-Gm-Message-State: AOJu0YwpgCoxH75FNUTv4bYWqoOuXga8/mZIFdzRTEDyofZUhUOrqsiw WLvA8FlbLT05Ua8tri48jL6HBDmiAmULXd4q4wo= X-Google-Smtp-Source: AGHT+IHgwCAQBLvB0z1DFSfacZLlZe7iyFgzrmCJNMai57WocOmkFwr5tPYGi6nJ7z357utYkGkfeA== X-Received: by 2002:a05:651c:8f:b0:2bf:9576:afd4 with SMTP id 15-20020a05651c008f00b002bf9576afd4mr1875974ljq.16.1694602446317; Wed, 13 Sep 2023 03:54:06 -0700 (PDT) Received: from localhost.localdomain ([2a02:6b6a:b5c7:0:59d5:28b9:7f13:cd1b]) by smtp.gmail.com with ESMTPSA id p36-20020a05600c1da400b003ff013a4fd9sm1757055wms.7.2023.09.13.03.54.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 03:54:05 -0700 (PDT) From: Usama Arif To: linux-mm@kvack.org, muchun.song@linux.dev, mike.kravetz@oracle.com, rppt@kernel.org Cc: linux-kernel@vger.kernel.org, songmuchun@bytedance.com, fam.zheng@bytedance.com, liangma@liangbit.com, punit.agrawal@bytedance.com, Usama Arif Subject: [v5 1/4] mm: hugetlb_vmemmap: Use nid of the head page to reallocate it Date: Wed, 13 Sep 2023 11:53:58 +0100 Message-Id: <20230913105401.519709-2-usama.arif@bytedance.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230913105401.519709-1-usama.arif@bytedance.com> References: <20230913105401.519709-1-usama.arif@bytedance.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: AACE414000A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 56m596x3fk67r47k7nbf3a7tm4wj3xxf X-HE-Tag: 1694602448-719733 X-HE-Meta: U2FsdGVkX19jXGlSPVRFZ0O0iV+Xy3aVotzmTJmHvhqsBkeSJnMqMyZUa5Gg1NBMRrfHSg4sYYt6ielYiXdZvT+6QJ01X3Te+dgA5sFjqoC3jY3UQ9SSvk5dviRvkvGIqhvngSzZriFpemP/4OLaOqV3YO/FcnPiCTcq2PdmL32/tihbNRbMsVAHCnSMvVRo36rHK2+vyv/s6xOhlex+HP9R9Jt55QjQlxuCBTl9c5Y7b3Y9E2/sdlnKZS7YY2FQlHFkOgwHZHlPfbuXEf1KRDtYupwn4s10bsno6T8BChLXZBXoVKYyJTtnLeLNGD4SXkNrFzwKIr4hSLopT26g3MJ3WfLJvLeI9Bqfrto19y5p6QwYGY5HWv+yXT3IR8XylKMXgyFlpkDsmojG18LQW4cxKy6aQapLmhRYHxnCweli+5COCJZFautUn1i/uzWvjkJAsE1hTuTqLnxHNzGTuCsgs7DD+2FUuZ0c6/1sGgwJYW2QWx2fW4IWKMdtnCL8wDrEfchAXKMYtlUS9rfmn2+MB71dDraimfb/HTHK38b81qkFJwfDv+muvmyrHFtkuIZVHRkGwUB3UwQfIZD4xGKQ6W/iiwbyrmVUND1OVeZsru3co0+3Jdp8cKjEDSI+kS/QkG3MDS2uy0JhOS8f8RoJ+PpwiUzjBSLJbGBTHk+e0bWgr3Ro1YEhNK75grLhJ15F7yEnkU+UYd8QapAHG86cyjhRB1b6BLNCg4LQFTi3UKuxT0QAmOuFYj90URCe6tLtHWkTjQTcYuHLU0U/uWv1fS/4g53bQNLVq8TS2bEE+4RdeDnS4zpfBM/Ob0/Yx5ECD6PzEQxyOqd61mfwXVpnqWiA9Cj7Tpo9006DW0L+bSDrqsHTTiFnD1vrs527jSv0Zsq+SR8agO0VnD+MY2L/Er4EVeqcSZV8b7AFxqyAyDPUBXnZWya65ooAXFOi6APlOZcjLPmWA8pU6vL 1CtqoxPR RemUTGZHcQh0py7Gnv0bqQVCBNaZi05DfQ27vkGLLpwn2SIiQjwi2S832D89iwe2TvsClhov5Bn947wWbKgHvuajhYni/kWQy8UuA0y0MzDaT8ugxhKn5NFrx61rqbfAqTrrMjHdyfSlIfEnYOCyerdnycU4AVpbQcqMq8TUgSrbdkwKwgTBHeTWyrQWvNL3MWMs0RI7uFDZVhqEtl0TlfZpd40uSo9Lkwx38CbvLKS5VeaLiXCwylQxfpMU2W716+DN4tZsSOe5mXMkUA6+DqjHyLG3b3xsi8qI2vKq3zD6+wUDbKMvAT3DmttW+ZdQS2sN6pvay+fOKBBsO5TxwLiqI0sZlWviqIjZQ+c8rtvuXcXK16ZT7PKoofal0I1hO68wy/YMl6e6d9pmkYFmhnCBHzNeOMjuewK4yceDJDweCJqF7yaGZ2dVa5pBvfMrHyabQu4nnLgZ2sILMpjIuVdh9gC0yzyaCJd2EcaGUpNcg39M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: If tail page prep and initialization is skipped, then the "start" page will not contain the correct nid. Use the nid from first vmemap page. Signed-off-by: Usama Arif Reviewed-by: Muchun Song Reviewed-by: Mike Kravetz --- mm/hugetlb_vmemmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c index aeb7dd889eee..3cdb38d87a95 100644 --- a/mm/hugetlb_vmemmap.c +++ b/mm/hugetlb_vmemmap.c @@ -319,7 +319,7 @@ static int vmemmap_remap_free(unsigned long start, unsigned long end, .reuse_addr = reuse, .vmemmap_pages = &vmemmap_pages, }; - int nid = page_to_nid((struct page *)start); + int nid = page_to_nid((struct page *)reuse); gfp_t gfp_mask = GFP_KERNEL | __GFP_THISNODE | __GFP_NORETRY | __GFP_NOWARN;