From patchwork Mon Sep 18 05:10:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 13388819 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC626CD13D2 for ; Mon, 18 Sep 2023 05:12:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C4486B0208; Mon, 18 Sep 2023 01:12:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 54D216B0209; Mon, 18 Sep 2023 01:12:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C5F26B020A; Mon, 18 Sep 2023 01:12:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 26C326B0208 for ; Mon, 18 Sep 2023 01:12:00 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EDB57C0B68 for ; Mon, 18 Sep 2023 05:11:59 +0000 (UTC) X-FDA: 81248546358.17.340FB65 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf24.hostedemail.com (Postfix) with ESMTP id 6AE9B18000D for ; Mon, 18 Sep 2023 05:11:55 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf24.hostedemail.com: domain of ruanjinjie@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=ruanjinjie@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695013917; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9ZaTUvZE/pjQ4z9Ivg9EXH3zCdyFK6qIfvk9hks0kD0=; b=TFsOq+7UGqdKCk1cv0pYq3wPcemmO7EO97qBM5ESbk1YmX3/LO82aqfv9oqHcazbhQ9LTA zFUp5lRPjbtDznJ/FRB2+GEnf3ldPaMnHMhcfuvR7XL1sReeIY1eLoyxDzNjFgKTBCHods VbAEB22f0wqWOIBONPGmAgydCzSMoZg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf24.hostedemail.com: domain of ruanjinjie@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=ruanjinjie@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695013917; a=rsa-sha256; cv=none; b=ZrCTWcocJTc9pBdkeAx8pF+WUsvflAETch2AoVi9UDMtYX6tqcE3KmeqrvylUN3cem7KWa 8ZdN3+x46MXzOmOq9cCmaFOL+76ahyiqk1P7eCU2rq5Gd4xt6756z0Yg5yQgnKGH4gziVQ sNY29LnU9tHurnHdcESOkc9uKE4kAPE= Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4RptC05lLcz15NQX; Mon, 18 Sep 2023 13:09:48 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Mon, 18 Sep 2023 13:11:51 +0800 From: Jinjie Ruan To: , , , , , , , , CC: Subject: [PATCH RESEND 2/2] mm/damon/core-test: Fix memory leak in damon_new_ctx() Date: Mon, 18 Sep 2023 13:10:44 +0800 Message-ID: <20230918051044.3814018-3-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230918051044.3814018-1-ruanjinjie@huawei.com> References: <20230918051044.3814018-1-ruanjinjie@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 6AE9B18000D X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: f5zq9cn4cybiedz1joono8u8r435makk X-HE-Tag: 1695013915-346059 X-HE-Meta: U2FsdGVkX19YqDqBvPFDhgK6zj12rayFyGzi8P3vnhfKM5yZfnRieVYa9vQtcib/N8K+HzJM+cl9sC9oG9NzDfWYz/VCriY21tkymnYjJxfMJIEcMdBaJqNdr7NudXgU6dOOmlYdaFC1CqFj/xSuC9X6J1umXqwI+a0Ih+YWSWyH7N9Mew22R471L6oHOlxmgRFINuOwldAOs/u38S+IIqYbL+1Li4kT2jCuZ2zxQSTdWkuo+DT4vSkAHcmWdcSmko4cf8aPWOR6OUkTCAz+2OkJFbNfWjnjqKe4/xdNLWscyBSkjMQ1UB/gZdoAkyMKjfOuygqcFRFruMDxVujpR3CcqJxKiSYpWZ0z1osxGf8fPYwyvE/NV7jbMWbHh4YsMA6p+zldFAFQKF2RHNWB19ridykfQ2GH74WeY1V0/DNjwra1CSBiI1c+DenN0/oGKDFWF41PxcymYaxVxlcIIm8/SClSzly5LY7payghalpP8nrvUvLmEJJwTjwonqkaYdwpwwCmZM8x905ykQFu2jnase0OUyMZv7zeJGZyahfndau0xorf1KPbGSB1/OR07jEOOCpWsbsFeYR8O8tGud8P3I31Bb8GNr65yi+dMw290LR+NPBwjLSppvW01fHzDeHtfbLkvcMy9N5bkIJMrL3vudvcrrPOzbGiuBd8GgKTHfbIonCNXYCsFdn46tL8DUPQ4TfcFNsBPvUzwuenPe4o8lIQVikG9LyK3s4DR5zxjYEPfQqi06v2cXQ4LALF8SOA4dUqnjZs9xwOXTQtd3+Cf5IKQwDR0fPN+MlE/+wqd5uiE4dHd0eFuDGm6gLAQ/sMGJWrzLKE8QZkfFmCJc2Pz/h+ogPUpunwA1R/wHn30XH8kTNRZRoWGDhVz9Rl0Jm9yVgcC501VNGIVXKdlpZGqpdJ4//EXoQKyzNLqviHVczEaix4BdhocW1N0uewHVlotujaSQS84WbFr8d LX8Nn8cu 36eJpRuZrFwVfA4ttnBJs8wtheaEa4oFtnXnqdKt229ewdALGCJJ9zgKmaumLP24l9tatFiiTS77rG2HzcyAzaTAm00po3128LI0BcNh2xdd+ApwCTSowmUT6tfjnfaiIS7ClnuDcbzFRl0A5unfHx9mZGb6Owxtyn+6/DJrP6TW0YUePdPJVxTq37oclUUrIGtSQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The damon_ctx which is allocated by kzalloc() in damon_new_ctx() in damon_test_ops_registration() and damon_test_set_attrs() are not freed and it causes below memory leak. So use damon_destroy_ctx() to free it. unreferenced object 0xffff2b49c6968800 (size 512): comm "kunit_try_catch", pid 350, jiffies 4294895294 (age 557.028s) hex dump (first 32 bytes): 88 13 00 00 00 00 00 00 a0 86 01 00 00 00 00 00 ................ 00 87 93 03 00 00 00 00 0a 00 00 00 00 00 00 00 ................ backtrace: [<0000000088e71769>] slab_post_alloc_hook+0xb8/0x368 [<0000000073acab3b>] __kmem_cache_alloc_node+0x174/0x290 [<00000000b5f89cef>] kmalloc_trace+0x40/0x164 [<00000000eb19e83f>] damon_new_ctx+0x28/0xb4 [<00000000daf6227b>] damon_test_ops_registration+0x34/0x328 [<00000000559c4801>] kunit_try_run_case+0x50/0xac [<000000003932ed49>] kunit_generic_run_threadfn_adapter+0x20/0x2c [<000000003c3e9211>] kthread+0x124/0x130 [<0000000028f85bdd>] ret_from_fork+0x10/0x20 unreferenced object 0xffff2b49c1a9cc00 (size 512): comm "kunit_try_catch", pid 356, jiffies 4294895306 (age 557.000s) hex dump (first 32 bytes): 88 13 00 00 00 00 00 00 a0 86 01 00 00 00 00 00 ................ 00 00 00 00 00 00 00 00 0a 00 00 00 00 00 00 00 ................ backtrace: [<0000000088e71769>] slab_post_alloc_hook+0xb8/0x368 [<0000000073acab3b>] __kmem_cache_alloc_node+0x174/0x290 [<00000000b5f89cef>] kmalloc_trace+0x40/0x164 [<00000000eb19e83f>] damon_new_ctx+0x28/0xb4 [<00000000058495c4>] damon_test_set_attrs+0x30/0x1a8 [<00000000559c4801>] kunit_try_run_case+0x50/0xac [<000000003932ed49>] kunit_generic_run_threadfn_adapter+0x20/0x2c [<000000003c3e9211>] kthread+0x124/0x130 [<0000000028f85bdd>] ret_from_fork+0x10/0x20 Fixes: d1836a3b2a9a ("mm/damon/core-test: initialise context before test in damon_test_set_attrs()") Fixes: 4f540f5ab4f2 ("mm/damon/core-test: add a kunit test case for ops registration") Signed-off-by: Jinjie Ruan Reviewed-by: Feng Tang --- mm/damon/core-test.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/mm/damon/core-test.h b/mm/damon/core-test.h index 255f8c925c00..ce86ed30fb47 100644 --- a/mm/damon/core-test.h +++ b/mm/damon/core-test.h @@ -266,6 +266,8 @@ static void damon_test_ops_registration(struct kunit *test) /* Check double-registration failure again */ KUNIT_EXPECT_EQ(test, damon_register_ops(&ops), -EINVAL); + + damon_destroy_ctx(c); } static void damon_test_set_regions(struct kunit *test) @@ -342,6 +344,8 @@ static void damon_test_set_attrs(struct kunit *test) invalid_attrs = valid_attrs; invalid_attrs.aggr_interval = 4999; KUNIT_EXPECT_EQ(test, damon_set_attrs(c, &invalid_attrs), -EINVAL); + + damon_destroy_ctx(c); } static void damos_test_new_filter(struct kunit *test)