From patchwork Fri Sep 22 07:09:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yajun Deng X-Patchwork-Id: 13395075 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5360EE7D0D6 for ; Fri, 22 Sep 2023 07:10:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C23206B028A; Fri, 22 Sep 2023 03:10:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD1FF6B028B; Fri, 22 Sep 2023 03:10:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9A9F6B028C; Fri, 22 Sep 2023 03:10:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9A1886B028A for ; Fri, 22 Sep 2023 03:10:03 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 73B891CAD08 for ; Fri, 22 Sep 2023 07:10:03 +0000 (UTC) X-FDA: 81263359086.14.FC9FFDB Received: from out-226.mta0.migadu.com (out-226.mta0.migadu.com [91.218.175.226]) by imf09.hostedemail.com (Postfix) with ESMTP id 9ECC014000F for ; Fri, 22 Sep 2023 07:10:01 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=jxWX0Bgf; spf=pass (imf09.hostedemail.com: domain of yajun.deng@linux.dev designates 91.218.175.226 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695366601; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k0mCgISWNiznjjM6SFzdDoz9gB321AuL+FXt04gr7LU=; b=6cLx3tqoMhkaJVvAAwNprs7mC1mDMWW3s4cAi2gk70IezW9r0Smux4rracElUdyEtx5uur MTnzZubGTT223e1rcaekP2S75v7f7pLEIjJ6IfRWEnfX7YTAnnG8zxnk//iN8Bjx/NEK0T WqtuAYhztJ7mS50gRXHfGgLo2iUDNNw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695366601; a=rsa-sha256; cv=none; b=U5uxir6vHtyFqEkBgpGRYFxJ/dCJACuKs1fRXuPmE4JjJ9acukTBuuFumsrhZ8nboIy8jA R2yEYMqRTlrUlCoLpQl6pRBI/5cdH03DN4sDAtPaQdIdvl7zeDOy4WyVAVgqZn27tEtkPP /RMV3d+Aex7HVxY4Ed0/ao+eIVwuz34= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=jxWX0Bgf; spf=pass (imf09.hostedemail.com: domain of yajun.deng@linux.dev designates 91.218.175.226 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1695366600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k0mCgISWNiznjjM6SFzdDoz9gB321AuL+FXt04gr7LU=; b=jxWX0BgfnsPK+/UXL3X/EVvjG8BWDljXrq53ger1dOsqtFyF7Qy0lOSvvZlzrSxRGiowBX aZ+aCA1UetBKaJ3y1q6OBuvEv3GThzFUov3jfT6/IHSVlPKdHtoHot+HJ51tvuCMu1WOgT 36r5JuQY/7UoGeeVslveatFA3PqI7mk= From: Yajun Deng To: akpm@linux-foundation.org, mike.kravetz@oracle.com, muchun.song@linux.dev, glider@google.com, elver@google.com, dvyukov@google.com, rppt@kernel.org, david@redhat.com, osalvador@suse.de Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Yajun Deng Subject: [PATCH 1/4] mm: pass set_count and set_reserved to __init_single_page Date: Fri, 22 Sep 2023 15:09:20 +0800 Message-Id: <20230922070923.355656-2-yajun.deng@linux.dev> In-Reply-To: <20230922070923.355656-1-yajun.deng@linux.dev> References: <20230922070923.355656-1-yajun.deng@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 9ECC014000F X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: cmjed3fphwqc7qmakq8rgf8j5b16j5h5 X-HE-Tag: 1695366601-577634 X-HE-Meta: U2FsdGVkX18QCdFtUZTZGM7oFHP3EzwuWHzWax4y2nwCTLOgoim0pdF11X2wirhguu4I0j8OX/qTv6KLUCpRAYqtacU91+PN5u5NKMGd9mou8FbPHp/ml6HS/jU/329BVjQJHh4UK+4vw7yFHuJVfoxKPyGCPa6GVgMuMmDwrq12lm9gFCarSebU07PW33uqhYN478AybheWDGrnm69L0yK2mIqLbRcHu76+Zn2FZ3pu/ioSD7H34zg3PYrJmPuoDl09PotAXUm2ZZRFCheVvH+V2XarmeStPC3/k+2gEzB7XYrx52xc/IIbXB1dRSVgHihNTwb7OnFD/CDJlTvutN6QJDZI6KnvsQeF974YWC1Hw44QoEQh5yHgtN+h4gd7v9DVwSDaFIfjSKnmVKMv0VYaqx279gJrbLdNiXtpI0VbUoCGSfKREqagKDgGbSCoSSHkeOE/8AdmFi9UsqrIzzte8HLz813kIP785d5uzxejkOyEiuQrJOFjiSsChzcIBV1+R6W6hLgAdxG1KM+hEFoNW9dNzz40mj4FLLu/JKwBvCzOg5WSR07mHc5jOYhnrknp7xFEti0BmCiTrShkUpBvXlT67z7GUAU06eXfAzWc7yXwOx0+qZSZmr4MLJXsaRn+yi+2hPePI6MbPEyHbFrs7Lepu3mXdcmHW5lRIvsr2qfIXRigiH1yY3OsEX8iJDb08MCxnSKxHCenDVu/ZAQXfjaQjp2WAZp0+CqMQsHvwLEjeUa58x76MytXEUtNHIaceSi3jcFWXhDl9URTLdVD6mApS9HI+hHAgTJa6FnVpdtz/dR9XSIfzR2zCnC/5NNT6qG60jQqcQptK4LiBXQ9cJj/FxvMQifGFyrFej/quDxa5CfcrVIG+ormpjcj9sBGG6zhpJwJZ+YqaOdsEJu+iGV5RKwlX/sPHv/qrMnttJsNrgaadW5xsqZCMxR7K2Y5lu8B5sBooVYbT+Y pePgeela O8qpA1zoWhpXi/SZVZspXQnMVe6FANEPpTGlvexgg7RBoXmIc2xe6hMpAok2/9BN7C6YMRZ7lhDMGP8+rmaPx+R20RJsc5L9vm4bodR2iU5hwskQvMj9npo5pAg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When we init a single page, we need to mark this page reserved if it does. And somes page may not need to set page count, such as compound pages. Pass set_count and set_reserved to __init_single_page, let the caller decide if it needs to set page count or mark page reserved. Signed-off-by: Yajun Deng --- mm/hugetlb.c | 2 +- mm/internal.h | 3 ++- mm/mm_init.c | 30 ++++++++++++++++-------------- 3 files changed, 19 insertions(+), 16 deletions(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index e2123d1bb4a2..4f91e47430ce 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -3196,7 +3196,7 @@ static void __init hugetlb_folio_init_tail_vmemmap(struct folio *folio, for (pfn = head_pfn + start_page_number; pfn < end_pfn; pfn++) { struct page *page = pfn_to_page(pfn); - __init_single_page(page, pfn, zone, nid); + __init_single_page(page, pfn, zone, nid, true, false); prep_compound_tail((struct page *)folio, pfn - head_pfn); ret = page_ref_freeze(page, 1); VM_BUG_ON(!ret); diff --git a/mm/internal.h b/mm/internal.h index 7a961d12b088..8bded7f98493 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -1210,7 +1210,8 @@ struct vma_prepare { }; void __meminit __init_single_page(struct page *page, unsigned long pfn, - unsigned long zone, int nid); + unsigned long zone, int nid, bool set_count, + bool set_reserved); /* shrinker related functions */ unsigned long shrink_slab(gfp_t gfp_mask, int nid, struct mem_cgroup *memcg, diff --git a/mm/mm_init.c b/mm/mm_init.c index 06a72c223bce..c40042098a82 100644 --- a/mm/mm_init.c +++ b/mm/mm_init.c @@ -557,11 +557,13 @@ static void __init find_zone_movable_pfns_for_nodes(void) } void __meminit __init_single_page(struct page *page, unsigned long pfn, - unsigned long zone, int nid) + unsigned long zone, int nid, bool set_count, + bool set_reserved) { mm_zero_struct_page(page); set_page_links(page, zone, nid, pfn); - init_page_count(page); + if (set_count) + init_page_count(page); page_mapcount_reset(page); page_cpupid_reset_last(page); page_kasan_tag_reset(page); @@ -572,6 +574,8 @@ void __meminit __init_single_page(struct page *page, unsigned long pfn, if (!is_highmem_idx(zone)) set_page_address(page, __va(pfn << PAGE_SHIFT)); #endif + if (set_reserved) + __SetPageReserved(page); } #ifdef CONFIG_NUMA @@ -714,7 +718,7 @@ static void __meminit init_reserved_page(unsigned long pfn, int nid) if (zone_spans_pfn(zone, pfn)) break; } - __init_single_page(pfn_to_page(pfn), pfn, zid, nid); + __init_single_page(pfn_to_page(pfn), pfn, zid, nid, true, false); } #else static inline void pgdat_set_deferred_range(pg_data_t *pgdat) {} @@ -821,8 +825,8 @@ static void __init init_unavailable_range(unsigned long spfn, pfn = pageblock_end_pfn(pfn) - 1; continue; } - __init_single_page(pfn_to_page(pfn), pfn, zone, node); - __SetPageReserved(pfn_to_page(pfn)); + __init_single_page(pfn_to_page(pfn), pfn, zone, node, + true, true); pgcnt++; } @@ -884,7 +888,7 @@ void __meminit memmap_init_range(unsigned long size, int nid, unsigned long zone } page = pfn_to_page(pfn); - __init_single_page(page, pfn, zone, nid); + __init_single_page(page, pfn, zone, nid, true, false); if (context == MEMINIT_HOTPLUG) __SetPageReserved(page); @@ -965,11 +969,9 @@ static void __init memmap_init(void) #ifdef CONFIG_ZONE_DEVICE static void __ref __init_zone_device_page(struct page *page, unsigned long pfn, unsigned long zone_idx, int nid, - struct dev_pagemap *pgmap) + struct dev_pagemap *pgmap, + bool set_count) { - - __init_single_page(page, pfn, zone_idx, nid); - /* * Mark page reserved as it will need to wait for onlining * phase for it to be fully associated with a zone. @@ -977,7 +979,7 @@ static void __ref __init_zone_device_page(struct page *page, unsigned long pfn, * We can use the non-atomic __set_bit operation for setting * the flag as we are still initializing the pages. */ - __SetPageReserved(page); + __init_single_page(page, pfn, zone_idx, nid, set_count, true); /* * ZONE_DEVICE pages union ->lru with a ->pgmap back pointer @@ -1041,7 +1043,7 @@ static void __ref memmap_init_compound(struct page *head, for (pfn = head_pfn + 1; pfn < end_pfn; pfn++) { struct page *page = pfn_to_page(pfn); - __init_zone_device_page(page, pfn, zone_idx, nid, pgmap); + __init_zone_device_page(page, pfn, zone_idx, nid, pgmap, false); prep_compound_tail(head, pfn - head_pfn); set_page_count(page, 0); @@ -1084,7 +1086,7 @@ void __ref memmap_init_zone_device(struct zone *zone, for (pfn = start_pfn; pfn < end_pfn; pfn += pfns_per_compound) { struct page *page = pfn_to_page(pfn); - __init_zone_device_page(page, pfn, zone_idx, nid, pgmap); + __init_zone_device_page(page, pfn, zone_idx, nid, pgmap, true); if (pfns_per_compound == 1) continue; @@ -2058,7 +2060,7 @@ static unsigned long __init deferred_init_pages(struct zone *zone, } else { page++; } - __init_single_page(page, pfn, zid, nid); + __init_single_page(page, pfn, zid, nid, true, false); nr_pages++; } return (nr_pages);