Message ID | 20231012194711.3288031-10-jim.cromie@gmail.com (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91A34CDB482 for <linux-mm@archiver.kernel.org>; Thu, 12 Oct 2023 19:47:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 024B68D0146; Thu, 12 Oct 2023 15:47:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F14D28D0002; Thu, 12 Oct 2023 15:47:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D68068D0146; Thu, 12 Oct 2023 15:47:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C25D08D0002 for <linux-mm@kvack.org>; Thu, 12 Oct 2023 15:47:35 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 98463C0844 for <linux-mm@kvack.org>; Thu, 12 Oct 2023 19:47:35 +0000 (UTC) X-FDA: 81337844070.30.C823D5D Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) by imf16.hostedemail.com (Postfix) with ESMTP id 514E5180015 for <linux-mm@kvack.org>; Thu, 12 Oct 2023 19:47:31 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jzOtF9jR; spf=pass (imf16.hostedemail.com: domain of jim.cromie@gmail.com designates 209.85.166.49 as permitted sender) smtp.mailfrom=jim.cromie@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697140051; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Jr8tQe/cDXue74QN3U0cEdutzIhNedVe/s3FJQcenu4=; b=ePm4iGiUs0nVTO9r9qDlzIpPPzK4/I1FEIVAcaMhhWh6/6aT0++NTeiDuLjvXmmiE0sVzj dBFLfudR2t/vbUSSTvMHGMaBOL5MZhWH+t5X0ZOegjgDCMKU22cypH1G/Obqhj4UTUC/jB 1xJix2X7WVlUE7ktFE3BUazwWH/L1TU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697140051; a=rsa-sha256; cv=none; b=mTiUpgJFeGbzhLG8KPR5kuX6mtZ3fJFER61N5f52W2vwVGgwWUPhcNpg/PUnocP1skxLnB m7CmBUs1gBepP7NoaaDj4HMywo24JjAroE+iIenPxO8FXiAiBxLd3jDBHdJjQS14GU91B2 e1cdR3zBwi82JD/dFmz2R3zpVQ9rhmE= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jzOtF9jR; spf=pass (imf16.hostedemail.com: domain of jim.cromie@gmail.com designates 209.85.166.49 as permitted sender) smtp.mailfrom=jim.cromie@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-io1-f49.google.com with SMTP id ca18e2360f4ac-79f8e4108c3so56666639f.3 for <linux-mm@kvack.org>; Thu, 12 Oct 2023 12:47:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697140050; x=1697744850; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Jr8tQe/cDXue74QN3U0cEdutzIhNedVe/s3FJQcenu4=; b=jzOtF9jRW13VrHfCtctrGR6TwdVI20M9UurtP8amFJqm1JdNreBqbemFMQn76zrF59 /EjM6LPWdLI4pc/Z24oBJr5PzR7PaahRJWjGXsbVGqYN0YivEPKqNlu5JxJWwLqPdNY4 yOZWZWmjTiY8gFFHtDL6IIfPUBIKBkzAFAwwSaHExwCACfIAcUfq5b97q7d2fLxriQ4x ySh6fpS5HFYeJrOUnD69JNeirxBYD38O4PDgXN6WMxgWz26zmHMYBNu77LKTImIEV2eX okQ+T4tMx+7KlDoUar5IS7QGIe0/BdpL5LpkbWp0WfRwfKW+1w/91xk5abenq7HARFk5 bXXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697140050; x=1697744850; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jr8tQe/cDXue74QN3U0cEdutzIhNedVe/s3FJQcenu4=; b=KqfM46mGkpDI/qo4mDaGo++7XE1l9b0/bGdJi59KrfZwjy3SY+4kOXXHK3VxsTYTUW BBfF2j2a1Ng394bGDT9QhZIYdnPWgCZe5ETZ+2A5fu7G75zYpipwvFSPzN6aPzm9kDSo 8IAvBPLzDSWrTwsU/khnNJdAs868Z2z25ZyRzR8nZLs16HQML8i8CSgQyz0NNCLSdjiw RodAmcaFaRGdWvdVfJo4hqKwSFFUaVYAsQbJ7GGIRdFesgIIGMhX/eiZ8xi5nWxJzNsd v8gsu6ajkzMMi0vsxwr0a0AtI41XRQ3L3F/irSdo0H0KWYzh3j9SRWSmFoOcGFNiZfJk 05Kw== X-Gm-Message-State: AOJu0YwwBtZ6KR0erTVKvxFHyaTAyUsZwiyfglpoH1q2HMSEL7qah9oG orSwzMR/dgVLdoRDZ5PfU/M= X-Google-Smtp-Source: AGHT+IHU6/UwAxmm5iYu+krC4jYwWl30+9Laj14aUjTrmQt6Cnwhp5cwnYiXxGdgbdS9u1QcuHlA7A== X-Received: by 2002:a6b:da06:0:b0:783:4e11:76d7 with SMTP id x6-20020a6bda06000000b007834e1176d7mr24140049iob.21.1697140050527; Thu, 12 Oct 2023 12:47:30 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id z7-20020a5ec907000000b0079fbb834232sm4351002iol.19.2023.10.12.12.47.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Oct 2023 12:47:29 -0700 (PDT) From: Jim Cromie <jim.cromie@gmail.com> To: linux-kernel@vger.kernel.org Cc: david@redhat.com, Liam.Howlett@Oracle.com, linux-mm@kvack.org, Jim Cromie <jim.cromie@gmail.com> Subject: [RFC PATCH 09/10] dyndbg: add dd_clear_range to prune mtrees Date: Thu, 12 Oct 2023 13:47:10 -0600 Message-ID: <20231012194711.3288031-10-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231012194711.3288031-1-jim.cromie@gmail.com> References: <20231012194711.3288031-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 514E5180015 X-Rspam-User: X-Stat-Signature: bcmx5bsks8geur8x9zq3mot6q7ssp45h X-Rspamd-Server: rspam03 X-HE-Tag: 1697140051-159608 X-HE-Meta: U2FsdGVkX19G7WCWs4v3WlUd6eG01Yd6AzF6X5ivl29Ozui48CdeJ6n90oDTBn3b+q9oRDyXQ1Xj7RGyKkXopu6EkYypqgFmvnmo66B8ir4FRl32BZ3QJR5gTGT/23syZA3pQYDDZAo2bC2zJoIi8Jmjxaxgn8xybn6IyugJV2nIMxp1OF/RAL79BwLFVSOruJr9Yavn1Re1yMErf86kDidzvZg2xtAQ2T+LU4NC+WMwJ/auiKL1SANo/CPe2522rK8dRYZP4GeRvFNaVx5j22TVG+G0ku8KoKdBQmUb7F++PKliFF+STv6m8ZJkzS6glcJy5Ds/49IlWt3mbrpe2LnZ/uFd82Gf2YWEexYzIFiJQ99Tt9LRm4vBj0sB4UssjbFm7pLx8nIlrbeaOntUVHQ8NGucy2njXYuPnIw0ydZDS7qs4gaB2WxeOnQv3/1Jw7dFQGcXAeouAY8g5bCngcpZcJBEpmgxikrH3QTMy2XsSlMTFOBhVYTWAIDYQWLI4x7vraUGZHAsL6YuF6MQk7xuV8MNOM7n/adgxumHA5P9War7KssIYglgsYVcv4vOpEmD/xYtVFH5akl+io7HETavZK13NoT3ni5VqwKGcYV37p9g3ivadeqnDeiAIqUJzr/P4ta0iwhRInTObkMPcQq/TdejxpiKxgMFmcQioqfbnnfB4tqUq5/eOIi9tJmp0Krnyeo0aLIWY+skbypTOl9vWHb3wByHlcLSYPwZV8pyua8VsebUywh7jnz0oKKBI1nacAUkvkOsgf51KOezVw6yVrpAlPV3ULZ3HwEXWSLTnOAnHLUyVQ5LvMuLOxfT5kCz8zY8qz769cKgMqz/KOMJgT2tBVosIuwbmYGCIZ+gjLNbb0cciOTWaoZN7v+nL3GensgxltquB4+DJCU8J6qntmNsDNtvul2EwUpaGVyixZ36CoGuQ1I5sSYXSkAgnNZv+3wJeznFB0ZbUwb hKkxJh4I qanud+hGa0jLw+3HENJmLv+w/g5dgXl4/z0gS+9naYC5igO8Ve1umiT4ckLUR5lIuG+eOPLC12LWyzbPFYmHGIYNFfQFum6dpFi9KRQ7iy+UX/osP5E0pajKpgseutJEy0vJL4eR64YdhXHLzBVsUPy3T/FPRGmGTJMoCeP/5Fu7cIIhd3ZhgF2EjnVLTjnriWG3AFY+y+SWJ7SzYAMVu6C1mxzCF6WNBmpyyeU0qMuWUsDUqpGVG3xXzler1t4VHuvAoxlMBKAEK07cg9d3+1rajs9leBpFesrWEgBBjDBy+WUBp0D8B72ujwJA21YrtMPJ7KGjR7Bvee6z3XzOP0U4mGl0+N4mijDebeZPfyiP7/KXII/RHdkz09w1lKDr9BexiUAJE1FTNWPSUX1ZMQ/GmjJVp8N8jfQdhAa7TlY9yWLeYWULrSLZQeXcVO7+wGe2ARmxLHbMxUYDVy87Q5pi0wju2kLcxBExmeTeYUHCvqUnKHpg0gdNjtOex8qs5c+f4gS0L0RQ7noxoZByLyqiKdPnWDJvpE1MW50B6HgsXWdYVxiEwu2xAoCQmW/euBotXW88WFttF+3lvY6vG6z+qNJnAoFZyvbCOctpA4g4P32oddvUMAS1d2rG4vmvFa/aEvXAeZQN3udG9ySxyTbqbeGTzLn+w5RUuccj5zAbv5N4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> |
Series |
how to reclaim unneeded vmlinux memory ?
|
expand
|
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index fb72a7b05b01..92ffd70a07de 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -1426,6 +1426,14 @@ static void dd_store_range(struct maple_tree *mt, const struct _ddebug *start, v4pr_info(" ok %s at %lx\n", val, first); } +static void dd_clear_range(const struct _ddebug *start) +{ + v3pr_info("clearing %px\n", start); + mtree_erase(&mt_funcs, (unsigned long)start); + mtree_erase(&mt_files, (unsigned long)start); + mtree_erase(&mt_mods, (unsigned long)start); +} + #define site_function(s) (s)->_function #define site_filename(s) (s)->_filename #define site_modname(s) (s)->_modname @@ -1578,6 +1586,8 @@ static int ddebug_remove_module(const char *mod_name) mutex_lock(&ddebug_lock); list_for_each_entry_safe(dt, nextdt, &ddebug_tables, link) { if (dt->mod_name == mod_name) { + /* free mtree entries on descs */ + dd_clear_range(dt->ddebugs); ddebug_table_free(dt); ret = 0; break;
Call new dd_clear_range() from ddebug_remove_module(). It calls mtree_erase() on the trees storing the function, filename, modname intervals, and passing the 1st descriptor of the interval (ie the index used on the insert). dd_clear_range() should properly undo the 3 mtree_insert_ranges done by dd_store_range. RFC: it doesnt work as I expected. What am I missing ? The following log shows that 'rmmod amdgpu' only removes 1 entry from each maple-tree, not the whole interval. My index is the 1st descriptor in each interval. ISTM (naive reader) this contradicts the documented behavior. void *mtree_erase(struct maple_tree *mt, unsigned long index) Find an index and erase the entire range. what is my "entire range" ? bash-5.2# modprobe amdgpu .... [ 74.256006] dyndbg: attach-client-module: module:amdgpu nd:4652 nc:0 nu:1 [ 74.256968] dyndbg: 4652 debug prints in module amdgpu bash-5.2# echo 2 > /sys/module/dynamic_debug/parameters/do_scan [ 81.370509] dyndbg: cache: funcs has 3741 entries [ 81.371233] dyndbg: cache: files has 911 entries [ 81.371819] dyndbg: cache: mods has 323 entries bash-5.2# rmmod amdgpu [ 102.325851] dyndbg: removed module "amdgpu" bash-5.2# echo 2 > /sys/module/dynamic_debug/parameters/do_scan [ 105.277439] dyndbg: cache: funcs has 3740 entries [ 105.278163] dyndbg: cache: files has 910 entries [ 105.278756] dyndbg: cache: mods has 322 entries cc: Liam R. Howlett <Liam.Howlett@Oracle.com> cc: linux-mm@kvack.org Signed-off-by: Jim Cromie <jim.cromie@gmail.com> --- lib/dynamic_debug.c | 10 ++++++++++ 1 file changed, 10 insertions(+)