From patchwork Fri Oct 13 11:30:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "zhaoyang.huang" X-Patchwork-Id: 13420729 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F606CDB47E for ; Fri, 13 Oct 2023 11:31:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5AC3D8D0162; Fri, 13 Oct 2023 07:31:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 55B628D0015; Fri, 13 Oct 2023 07:31:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44A2C8D0162; Fri, 13 Oct 2023 07:31:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 353218D0015 for ; Fri, 13 Oct 2023 07:31:36 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F3AD1A0226 for ; Fri, 13 Oct 2023 11:31:35 +0000 (UTC) X-FDA: 81340222950.27.531E675 Received: from SHSQR01.spreadtrum.com (unknown [222.66.158.135]) by imf11.hostedemail.com (Postfix) with ESMTP id 2597D40011 for ; Fri, 13 Oct 2023 11:31:32 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf11.hostedemail.com: domain of zhaoyang.huang@unisoc.com designates 222.66.158.135 as permitted sender) smtp.mailfrom=zhaoyang.huang@unisoc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697196694; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=46g4yk1ucuwHds3pdyDAsghbkyMAc7JI8Rq622Pn70A=; b=5VV7LD1K+STQOJLpRIJeSYvbvW2Z04L8jdQj9Xvw6xq8IyYz4NTzmkcG9CZ/xABzzRkqSo vnhMSJtSsj7YlGO7NBWrFwYu0+VoGiUgPFzvr6NUMtH4NNMw2kmu7OHR2ibDHWe2JSRDGY nXs2/Fff911A1I+tJKvusvtYTG18hk8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf11.hostedemail.com: domain of zhaoyang.huang@unisoc.com designates 222.66.158.135 as permitted sender) smtp.mailfrom=zhaoyang.huang@unisoc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697196694; a=rsa-sha256; cv=none; b=UrlA1KrwZ8dArl7m7plTZ3LWw2YE22uyqmIvnaoMTxk7Zf4QQpK4pYNsqnBf6VMEMRwVui hvq8t7IwKfHbj2AFMuOLmrDtDQmDn4osSK9xF8nvnkuBOsdhYjYuXxCt9irmv/x20TZ54L TjzCYgYr+ymvqNEvFBJTSLUP6bVQmfI= Received: from dlp.unisoc.com ([10.29.3.86]) by SHSQR01.spreadtrum.com with ESMTP id 39DBUXrv083164; Fri, 13 Oct 2023 19:30:33 +0800 (+08) (envelope-from zhaoyang.huang@unisoc.com) Received: from SHDLP.spreadtrum.com (bjmbx01.spreadtrum.com [10.0.64.7]) by dlp.unisoc.com (SkyGuard) with ESMTPS id 4S6PN53R5wz2KWZZn; Fri, 13 Oct 2023 19:26:29 +0800 (CST) Received: from bj03382pcu01.spreadtrum.com (10.0.73.40) by BJMBX01.spreadtrum.com (10.0.64.7) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Fri, 13 Oct 2023 19:30:31 +0800 From: "zhaoyang.huang" To: Andrew Morton , Matthew Wilcox , Johannes Weiner , Suren Baghdasaryan , Michal Hocko , Yu Zhao , , , Zhaoyang Huang , Subject: [RFC PATCH 1/1] mm: only use old generation and stable tier for madv_pageout Date: Fri, 13 Oct 2023 19:30:28 +0800 Message-ID: <20231013113028.2720996-1-zhaoyang.huang@unisoc.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.0.73.40] X-ClientProxiedBy: SHCAS01.spreadtrum.com (10.0.1.201) To BJMBX01.spreadtrum.com (10.0.64.7) X-MAIL: SHSQR01.spreadtrum.com 39DBUXrv083164 X-Rspam-User: X-Stat-Signature: 3ohn8633ncbtrisijd1qbcx5uhfmups3 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 2597D40011 X-HE-Tag: 1697196692-104117 X-HE-Meta: U2FsdGVkX199oDiygbGZhZJLXwYTkqYkQ/RcOI2tGuF2xHFx9AB9jV0c6N7RqcXoRjtME8gEtFYvwFes1WnhiG7CHWBUOvT4LfvMvw/4q1Zggc0ny3b2BA57HkssYneqM75qMywFlOp9kz2pwXcfqjRF5Em8poERJhObM9fcvw5VfByF0Ws4w1ghSfrZ9G1JTCrj1SAi4Ud2FNLwiBdDJjakzmuW74YgJ1Bw5j6O+gCyWNeb0PQYcsIo21jrx3UpRdua5IexKGwsp2K91ITts5o5Z4aO0Ml68hn7YedL+p5tLvn0iDzNhvRHRxo+C0OJK0/9VO+vLyewQ1BxJ/Y9l3xhz7DqMQU2VZ/ND2d/OeRuElc7vA32ajM35m8LCdR75L4xdQftpnqy2CiSsTD9r+jGU+QUdRTJ3CMvgw/dCsuagJVGUOIYja8yJgUXvoQrreI+jQdU0ckSNahGRZuE4/+TfeTeB+iqeztRxkKvaitm8pEgU06uWd/2Qt87QBPyQ3ySR8zFIYraVFrTYHz4EyDzzvcGxFfeC9250pt+VteB20aT6J1rJUIpDz94Lpf6VA140PFYuqu2nB6TKJdW6OV+knoHQd9VrN7e2GQMPq1RQ3tXSIodB2IVoGwRCRtwn4bnD9ftLBIsTrS+E6eny03XinuNJz+32lVOPq/zNWEk6XVvBI7J52Um8w8XbhpVJfIc+vM8um2P71F22OHUl26OrUn64a0ghXqxqdiGgWUjbmMU2Aw5wIFSK17EQS1vNjE02t7QmEuS9boEAIlmHbPiykuyBLkotQYGAqsOWCg25jYcgGYd+MkZD8zWKKkNHWlMmbQJMWQF+kzro4DeeIU6HjBTC95TLkL5gYffcXF0LGzN/QYBnklZ0ribWqUJPHgutPZM6R/xtAPTjOjq/3/0RA8tb9hzaodY4El7IY3En4IkBusmFbEAGmoH2kjNQdelaEXqbfG3winOjtb LFIZP5N4 ObsepFOAsAfBJlBQy13Z8wfLjFDSQgzX++y5pSWKuP/vdV6CZsU+Lotsykhs8kjYuBhojxRGeYvyU6kjhyYrGcccX5eviKyOFzVLiUj/wAVa0PxBw4BsxXHfZDrXESNgac5Yk+WKvM7w3ZMGj+L5FsJqfafpKEl9xRYaS73eU62NBkqHRqrUOocv98jqIYLtqEpawHg9Mg1cgJt8i5ccaPt/39jyXzKlvNm4q1RH2Rk71CYQyGGQrONAzQg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Zhaoyang Huang Dropping pages of young generation or unstable tier via madvise could make the system experience heavy page thrashing and IO pressure. Furthermore, it could lead to failure of tier's PID controller which affect normal reclaiming. I would like suggest skipping this pages in madv_pageout. Signed-off-by: Zhaoyang Huang --- include/linux/swap.h | 1 + mm/madvise.c | 12 ++++++++++++ mm/vmscan.c | 3 ++- 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/include/linux/swap.h b/include/linux/swap.h index 493487ed7c38..d09c859ccc45 100644 --- a/include/linux/swap.h +++ b/include/linux/swap.h @@ -496,6 +496,7 @@ extern int init_swap_address_space(unsigned int type, unsigned long nr_pages); extern void exit_swap_address_space(unsigned int type); extern struct swap_info_struct *get_swap_device(swp_entry_t entry); sector_t swap_page_sector(struct page *page); +extern int get_tier_idx(struct lruvec *lruvec, int type); static inline void put_swap_device(struct swap_info_struct *si) { diff --git a/mm/madvise.c b/mm/madvise.c index 4dded5d27e7e..324d76096ca5 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -452,6 +452,18 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd, if (!folio || folio_is_zone_device(folio)) continue; + if (lru_gen_enabled() && pageout) { + int gen = folio_lru_gen(folio); + struct lruvec *lruvec = folio_lruvec(folio); + int type = folio_is_file_lru(folio); + int refs = folio_lru_refs(folio); + int tier = lru_tier_from_refs(refs); + int tier_st = get_tier_idx(lruvec, type); + + if (gen > lru_gen_from_seq(lruvec->lrugen.min_seq[type]) + 1 + || tier > tier_st) + continue; + } /* * Creating a THP page is expensive so split it only if we * are sure it's worth. Split it if we are only owner. diff --git a/mm/vmscan.c b/mm/vmscan.c index 6f13394b112e..16900a8c13e0 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -5072,7 +5072,7 @@ static int scan_folios(struct lruvec *lruvec, struct scan_control *sc, return isolated || !remaining ? scanned : 0; } -static int get_tier_idx(struct lruvec *lruvec, int type) +int get_tier_idx(struct lruvec *lruvec, int type) { int tier; struct ctrl_pos sp, pv; @@ -5091,6 +5091,7 @@ static int get_tier_idx(struct lruvec *lruvec, int type) return tier - 1; } +EXPORT_SYMBOL_GPL(get_tier_idx); static int get_type_to_scan(struct lruvec *lruvec, int swappiness, int *tier_idx) {