From patchwork Fri Oct 13 16:03:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 13421168 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7CBDCDB47E for ; Fri, 13 Oct 2023 16:06:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 036708D0167; Fri, 13 Oct 2023 12:06:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F2A4C8D0015; Fri, 13 Oct 2023 12:06:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA57E8D0167; Fri, 13 Oct 2023 12:06:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C3E718D0015 for ; Fri, 13 Oct 2023 12:06:13 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 91686120317 for ; Fri, 13 Oct 2023 16:06:13 +0000 (UTC) X-FDA: 81340915026.24.2BA9F65 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id C4ACA100018 for ; Fri, 13 Oct 2023 16:06:11 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=h8aPTxFr; spf=pass (imf05.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697213171; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YCXtE3Gqov3oA1rKgjLh+er5qsDXpT3dWhNn5qjdKp8=; b=DTyqKojvG82jjXzei/C5xN4yA04uAVuo152zUBhSOhUZf0ZXGh3ruXsf6WbJ5yeRnEQi87 Oxad8qXdQdGCVUPkwSvA7rrn1d2lxziX5VHg3RK8pWJ3ikQy69vjWmW0Hg4jvCryYdIxbM kE38nl5UlktWkXcnJPUXMA9l0vWL7+A= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=h8aPTxFr; spf=pass (imf05.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697213171; a=rsa-sha256; cv=none; b=EovM2+SYq49jI0j/z5PasH4erXgN4VDyyeNIvw+1eFLlPOsdEhbXZbXXnQmufXB0k5kROc 8oukHuVcX2LHfYqd8cdZCTkPC/r3/MioBKVEyQ1qxVb2yBcCOB4/vBHv3MvEYOmmqRmv/f xigxuoEAOoaevCBUEsmvvrswEzeEQcM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697213171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YCXtE3Gqov3oA1rKgjLh+er5qsDXpT3dWhNn5qjdKp8=; b=h8aPTxFr1nac6uJ4eI7mACmCxyGn2S3Fq3y5/8wBcEMxgWHoHCRFzQWstS2op+FNQmGeRG GAX7ewZOFDEd6KW6xmJMN1Cw8ffIyzN62E4k4k/4WPRlYprfjuojGxQholYVNVZLcVVspM lvsRQSX1Jv/wl8nqeVNIFux55tOvBZQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-173-TJDkM4R1O72X3owEh91uEg-1; Fri, 13 Oct 2023 12:05:59 -0400 X-MC-Unique: TJDkM4R1O72X3owEh91uEg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 93274801E62; Fri, 13 Oct 2023 16:05:58 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id 11660C15BBC; Fri, 13 Oct 2023 16:05:55 +0000 (UTC) From: David Howells To: Jeff Layton , Steve French Cc: David Howells , Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Dominique Martinet , Ilya Dryomov , Christian Brauner , linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cachefs@redhat.com Subject: [RFC PATCH 26/53] netfs: Allocate multipage folios in the writepath Date: Fri, 13 Oct 2023 17:03:55 +0100 Message-ID: <20231013160423.2218093-27-dhowells@redhat.com> In-Reply-To: <20231013160423.2218093-1-dhowells@redhat.com> References: <20231013160423.2218093-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Rspamd-Queue-Id: C4ACA100018 X-Rspam-User: X-Stat-Signature: 8yybpmnmepe16j5woafhh9xaiuhsdety X-Rspamd-Server: rspam01 X-HE-Tag: 1697213171-359762 X-HE-Meta: U2FsdGVkX19FPKFm3gSKVmlJefdG+ng7Ha+INmblvxrdSiH87YS5M3pvuwsYycROfExuipcWDofXtYJgrxg+69+r55vWkOJBMzYnVLj8Khjjso4e0oDQS0PiRDkAcYazLUmWx6Ey6fFe3OKvRfb8hV3b6Q7H6by7GdRxT67klOuSt+gKI/5HAwyuXRm+6AtuWJ13CHHECAuMP7V8Apv6WSnpffg6JwU3SqTlGJ5IFmBhz1ByY0QvRhCtg3DCNU+1FSFNVOj3fNCof0uIt6339ODpZuK0NfPxd9gw1sduhu/PA0ynf4PjAthCygAqZP0S/EHiTtPsVFdOrKmnu8Xxx9HHfya//QG7Pul0XqwhgZ2EshPRrC23TCOVFzMnxlAX2Y17+SzSPYShb4F2CJL/6Oe6KFO40rGW9Zcu5BtMC2Yq1tZdJ5/yzjsfcoYWl+VMA/CXHsOslcx0DYOTd1u7jRVzI+0e5sm4lI3Qj4BR8WrU5bOHPEcxSyNgvFp7eyFDj3NzrgY+lNX6HSJNHT3WUxM6UX3sCLNvGB//kdRBA7cB9V/UriBSrRfowyTqQq6TMNzJO9QyVi3mhTtZ5kjOcVFBg0txSwZq70oB2izqgf+tyROslgprL5AdLWq/yY5iDwiuBvmRSRBpjvwouALvRHok6RZup1QTWBfCIFEZYsQaw15ymoasnAlykSXSGwujINXeCJ/9jqI6B2uU5GP86tWpjG3Mr+dPIvz3espGmUCFX09K5hg2s7BYJ8iyURUXTKZQ87E8o0EJhvoFgC6EF//PYPiTBDmolR+e+eDRxLCpnd9+I/oY4kwShm2GTONjmQfjO1Su5T77PO0rwhRx8D9nO2GqhMDQ7Rt/ev4y/Y6r5IRKpFnEkxlUEKUTLcvq7e9MHD84tfyAkDKbnp/D0fi6SmARaXMRVHhjt+U9XqiPpeF3mJ34jhLPklnUnVh5qUxgGcdlawpG72zosnT Ki1unL5E H8pr4BXuj8CB1p3hVPga63zv9qFbyIEcaHXkr0CLDHYNGTW1uVLDZh58OPuTr7+dpWvogF/mvjyAJl9K0OKjJUgouifriWASe4upCleLcOiEGwPNqr2ToOX+pVyPS89hkw3Vl3qOBYnMIdq1AJ9MWU2so3d34pcTTB93v/6GoQFtyAGcmkGMyM0iSdxrSFK7SWAgEDNjYgiA9kNBGd1uXs+rAHh7XAUp2POE1f6Xv8F0ytT7/hAYkkHKFts5qaHjBkoSyk7qYq+E+U4j1a6+myjUPdE09sagDjQcY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Allocate a multipage folio when copying data into the pagecache if possible if there's sufficient data to warrant it. Signed-off-by: David Howells cc: Jeff Layton cc: linux-cachefs@redhat.com cc: linux-fsdevel@vger.kernel.org cc: linux-mm@kvack.org --- fs/netfs/buffered_write.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/fs/netfs/buffered_write.c b/fs/netfs/buffered_write.c index 406c3f3666fa..4de6a12149e4 100644 --- a/fs/netfs/buffered_write.c +++ b/fs/netfs/buffered_write.c @@ -84,14 +84,19 @@ static enum netfs_how_to_modify netfs_how_to_modify(struct netfs_inode *ctx, } /* - * Grab a folio for writing and lock it. + * Grab a folio for writing and lock it. Attempt to allocate as large a folio + * as possible to hold as much of the remaining length as possible in one go. */ static struct folio *netfs_grab_folio_for_write(struct address_space *mapping, loff_t pos, size_t part) { pgoff_t index = pos / PAGE_SIZE; + fgf_t fgp_flags = FGP_WRITEBEGIN; - return __filemap_get_folio(mapping, index, FGP_WRITEBEGIN, + if (mapping_large_folio_support(mapping)) + fgp_flags |= fgf_set_order(pos % PAGE_SIZE + part); + + return __filemap_get_folio(mapping, index, fgp_flags, mapping_gfp_mask(mapping)); }