From patchwork Fri Oct 13 19:03:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Audra Mitchell X-Patchwork-Id: 13421589 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C97BCDB47E for ; Fri, 13 Oct 2023 19:05:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8564380065; Fri, 13 Oct 2023 15:05:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 803978D0015; Fri, 13 Oct 2023 15:05:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62F6D80065; Fri, 13 Oct 2023 15:05:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 510008D0015 for ; Fri, 13 Oct 2023 15:05:23 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 20E28B516C for ; Fri, 13 Oct 2023 19:05:23 +0000 (UTC) X-FDA: 81341366526.13.A5A544E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 7996680180 for ; Fri, 13 Oct 2023 19:04:24 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GsgjDMLz; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of audra@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=audra@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697223864; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IjtK2o/m5KP3/dyNmmPPz1m7WWyth7vyB+quu5YHBuU=; b=3aXsGljR//VlrSefrtCtnVAIGMrf4JIRL1Ls5G3bMCzNdORpKxT6WurYH0eOTyYuHuBEQy y6Iwuqb8s9TXf5194PQwh4R7c+AERsYmwEavxPwBPv8zkXgmuxN8X7Odfr2DDKjR30LLkm Q6/Z3y9XbQAp8mMYWQFHmA0c45bgJdg= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GsgjDMLz; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of audra@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=audra@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697223864; a=rsa-sha256; cv=none; b=XP0rFpCLbimKbP5GsRC2YCTHuqPuNxf/D8ReThRT+EDcsi3DKIxU2iybyFHBBxxX8c3NHS lHO7bB5JwMLQ9oOrK9KAiss45nEX7XsTAJUoNJafp3vFferwSMUNOETG0zjy1tfJdCvXzU hRATZ4QPTu3g3AD3BZl5BorCKsz32bo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697223863; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IjtK2o/m5KP3/dyNmmPPz1m7WWyth7vyB+quu5YHBuU=; b=GsgjDMLzHMEvp//qbY1zeLV+JpL9o7cJybvXQcs7RDK8dasBJyPTr2FWbPW2bs5RksB9e0 ucWdK0QhzaR3chGlwmNeaoZ6+jnzTukgp823KrRRCJZWU5hp3p0neeJ2UtEFU2eAIbeAsE 9vE9BYwu690Q8a4J98W6TCGEeAn8alI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-68-1r44kpejO3C42J4SMTd1YA-1; Fri, 13 Oct 2023 15:04:06 -0400 X-MC-Unique: 1r44kpejO3C42J4SMTd1YA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E803382A68B; Fri, 13 Oct 2023 19:04:05 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.33.110]) by smtp.corp.redhat.com (Postfix) with ESMTP id AD86B2157F5A; Fri, 13 Oct 2023 19:04:05 +0000 (UTC) From: Audra Mitchell To: linux-mm@kvack.org Cc: raquini@redhat.com, akpm@linux-foundation.org, djakov@kernel.org, vbabka@suse.cz, linux-kernel@vger.kernel.org Subject: [PATCH 1/5] mm/page_owner: Remove free_ts from page_owner output Date: Fri, 13 Oct 2023 15:03:45 -0400 Message-ID: <20231013190350.579407-2-audra@redhat.com> In-Reply-To: <20231013190350.579407-1-audra@redhat.com> References: <20231013190350.579407-1-audra@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Rspam-User: X-Stat-Signature: 3e4onpuduys7mwun679bmie4mqebzxjz X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7996680180 X-HE-Tag: 1697223864-440351 X-HE-Meta: U2FsdGVkX199jFTOLYudyG0vd4TTbsQGqe6ght38khHPYLsWbMrj03AnXAG1n6NnDth9StdWWahTixHVDHy1y5Ru39M1IATrOxhyz6FHv2eZpV8R2KuiMElL1vnqUz6V4fouUt3UNUmJZQ4fBjz+WM+NEe/SI23XanOAkA/3UzvHVP/nb8gcWVR2qYHc6jZmDuWS45G8oVAfnPK54u5TEYUK6t2DW+H1NiBmxKTa9Q0KObISNwcgiVgaXW167asG80DQuZPFihQ+yM9Afhz/3f7MxCUpNFkhJiBeXp4PSGJK4RQc0fuIko2ZOw3hhCm4o4q6AN3yeWnHzi4PJjYW35LY2CuluBdRoH+O+FyeyqD0PaCdddXw2V+2FDGUi7Hvp9mKkNkcSbIWeBNOg3Lyz/NQsSN/9OY1yyetOk6YfSPfj5mbxzR4lrq+fFYdQeQ87sYSUEwSjqXJYdgLBYL5hGi3hkEmOgAsgWMYO344ycuhgOqmPrvsutl2SS6e54ZiLj+edon6ynBW2Du6uSMS6SSeIkvKHSh4NFNkxUjLktSpWG7h44MoX6CJYmNBV7XeG06ROsiFv42lno8qrkxgWpzFGGXcMQABqP9yQJ7onmAcC4amTJGnpQ1P0Shx8JEe452PW0MoNpgdddrJRBggrLaO5UXZPO7uNWf8/W6ipzQPWtIrZmI1kC+x4ywSI7n3Wk6zP9uv2UvlzvDQFEWpbpee3UHtG3JYuhYtQHbsrXRBlKDMudv4ZupG6wYIAVLLXdnq7il3HTgjB+6fkBFs6jEfWMFJs1uUa2CwBIbWi6kn8z+0r6H0Qo6UZ27ooi+cGFKiSrOPsRmNRZqduoHeSygCcurZ6nrjAU0JK2QGG+GpB0pzRWgE/qNy3im/MA/GUKXfXJtQuqFfp7XwWQZBxkCnEwlnduDwc1gZiClAFARE7galfLbLkjcZSdnL7omN/VcZT7bX+i0GjJOSKxT +TVq5key lfZ1Cpg96SNi3wHcY4mW6TC8MgxM0SSeLddoPhl/DddVyyt3UckExqw9Ncnq9OcJyB3nsT9hH19BWGSMySrVN6V/FAgc4cWRYPWO3xEnr2mid7P+53P6EOUG09kCtIUctEE04gyGSs28YrPB3wDtLTeDw2g3WZYNpAfcdfWprvWYgZR251un2dSXOAwU192+xcvSEbBEHwz1K/MlgIgIcsDcwMg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When printing page_owner data via the sysfs interface, no free pages will ever be dumped due to the series of checks in read_page_owner(): /* * Although we do have the info about past allocation of free * pages, it's not relevant for current memory usage. */ if (!test_bit(PAGE_EXT_OWNER_ALLOCATED, &page_ext->flags)) The free_ts values are still used when dump_page_owner() is called, so keeping the field for other use cases but removing them for the typical page_owner case. Fixes: 866b48526217 ("mm/page_owner: record the timestamp of all pages during free") Signed-off-by: Audra Mitchell Reviewed-by: Vlastimil Babka --- mm/page_owner.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/page_owner.c b/mm/page_owner.c index 4e2723e1b300..4f13ce7d2452 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -408,11 +408,11 @@ print_page_owner(char __user *buf, size_t count, unsigned long pfn, return -ENOMEM; ret = scnprintf(kbuf, count, - "Page allocated via order %u, mask %#x(%pGg), pid %d, tgid %d (%s), ts %llu ns, free_ts %llu ns\n", + "Page allocated via order %u, mask %#x(%pGg), pid %d, tgid %d (%s), ts %llu ns\n", page_owner->order, page_owner->gfp_mask, &page_owner->gfp_mask, page_owner->pid, page_owner->tgid, page_owner->comm, - page_owner->ts_nsec, page_owner->free_ts_nsec); + page_owner->ts_nsec); /* Print information relevant to grouping pages by mobility */ pageblock_mt = get_pageblock_migratetype(page);