From patchwork Mon Oct 16 17:36:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Charlie Jenkins X-Patchwork-Id: 13423884 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64EEBCDB482 for ; Mon, 16 Oct 2023 17:36:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F3EE08D0001; Mon, 16 Oct 2023 13:36:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EEF198E000D; Mon, 16 Oct 2023 13:36:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D42CA8D00B9; Mon, 16 Oct 2023 13:36:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C233C8D0001 for ; Mon, 16 Oct 2023 13:36:21 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8AF3980A96 for ; Mon, 16 Oct 2023 17:36:21 +0000 (UTC) X-FDA: 81352028562.08.B4E4014 Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) by imf03.hostedemail.com (Postfix) with ESMTP id 8CB5A20012 for ; Mon, 16 Oct 2023 17:36:19 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=dGvvPYIn; spf=pass (imf03.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.160.45 as permitted sender) smtp.mailfrom=charlie@rivosinc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697477779; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s+UQB+1TQkrpOkRFVThwqlc0oUBJvetOcp6tU9R+gzE=; b=2n7/f2PI+FMWTGOKV50EHnpWkypVFkP6yJ141/dF9D56F/xkvzDtmpDfd3kLsN1fZHIfnD N7i99rSIAD7Yxa1uJnEatPbyjre4qZTLgeQBJqlkrlcu6WoHSUQdawLCwaKZrqRb5JkTNa fbkBDBU5DGqRVnFmnwEp582xzwM3lpk= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=dGvvPYIn; spf=pass (imf03.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.160.45 as permitted sender) smtp.mailfrom=charlie@rivosinc.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697477779; a=rsa-sha256; cv=none; b=chhVe0mLcL0hJDESRFFkdixSEFFQaf1cbBac//oVHIDO5XWp1sycTViGdgmjN1zBXkN/uR 7My7NIjffPO3JpVCLgu3/lZnxPapb608DtMDr7Wfv881nMlmmphsif5MBu0fbibS9ricnh rCwTT8eXgfgyBPs18kfX8oUf1+G+t8k= Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-1e9ac336589so3082579fac.1 for ; Mon, 16 Oct 2023 10:36:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1697477778; x=1698082578; darn=kvack.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=s+UQB+1TQkrpOkRFVThwqlc0oUBJvetOcp6tU9R+gzE=; b=dGvvPYInCGjklj3ucjfRQUDcab9JMXxLZGjzXDCDU/c2I3d47IG84xOTHJFdVk0MJl AOaJDN2Br/HEV47bZkzpkv1oUrRZ6stS6x7d4vhlkDWfU/rk4hfawJL7C+cLK6V3owMF nTG2eXm7eqc2RbYVZ+9org/AAj6x9YBK2eEmH7YTr/+v88lLoJXTwpuasNUtVVK8Yuu0 0obeT1AlD5nWL3EqfMgtuoCdDLY7wroocRfJ3fSC21FcMh98xjnIIsNaN5M8vh25Zgvp KaOf7lPtuPZBEL9CzyotvED1mm8uQb4ZO3vS1fD1pv+lz2v+bas4CMVMRAlbKa2DP+cQ PjGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697477778; x=1698082578; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s+UQB+1TQkrpOkRFVThwqlc0oUBJvetOcp6tU9R+gzE=; b=nUlzVZKJy27VYSlaWj9CpNiBltnHYS4H3Cglu8ATtNSqPVv8vQf/0v0kUOdDt7Q3tB /ChVpZvSjHjvbZngOHnjxqRK3KRECkJNtZm0VufJuo8FOEATNCz7kUlNfWm/EVGuSMXW VtQBcYAuNyhE+CU9gxJCEtqlylTMxSQXnhm1PCTy+FG14gXR+t7Tu1PWKWn1JCo4mTdk YwnIPBFt/QrT1aQa0EJiGvWr4+T/2YoDaJzFxeYWZurLemtfnfGJft2T0kOWcNHQroB4 bm+PrQ/n4C7kFTWLDQ+JCUbX9RcZI0uw5b614E8RKhjI0nJ9W1lBjT9PJGQgvCHo/GFm RceQ== X-Gm-Message-State: AOJu0YztO3zcTqjsR40WSO0boudNOHa7ko7Ak0DZ4j2r73fLA+hQ/4IR P6izcD24udQf43OhDxxnW6GZpg== X-Google-Smtp-Source: AGHT+IFHAB7cxzw0fcHb+ztvf9iVS3XeBivIGBaR4VYJX4/8HGYTW5h45Q9xt8gzKfUAA9A2mguwpA== X-Received: by 2002:a05:6870:10cf:b0:1e9:b496:ce2d with SMTP id 15-20020a05687010cf00b001e9b496ce2dmr15021007oar.12.1697477778745; Mon, 16 Oct 2023 10:36:18 -0700 (PDT) Received: from charlie.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id lv15-20020a056871318f00b001e0fd4c9b9asm2092936oac.6.2023.10.16.10.36.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 10:36:18 -0700 (PDT) From: Charlie Jenkins Date: Mon, 16 Oct 2023 10:36:09 -0700 Subject: [PATCH v3 1/2] riscv: Add remaining module relocations MIME-Version: 1.0 Message-Id: <20231016-module_relocations-v3-1-a667fd6071e9@rivosinc.com> References: <20231016-module_relocations-v3-0-a667fd6071e9@rivosinc.com> In-Reply-To: <20231016-module_relocations-v3-0-a667fd6071e9@rivosinc.com> To: linux-riscv@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Eric Biederman , Kees Cook , Paul Walmsley , Palmer Dabbelt , Albert Ou , Charlie Jenkins X-Mailer: b4 0.12.3 X-Rspamd-Queue-Id: 8CB5A20012 X-Rspam-User: X-Stat-Signature: zaasg8fc8wo6ypn147tgpx8i6e7mt466 X-Rspamd-Server: rspam01 X-HE-Tag: 1697477779-573243 X-HE-Meta: U2FsdGVkX18r5I1AU2xKf08w0SkrLCf0m2aKfNHS3W1TR4/aGZM3Lk//HCBJj88ArPmTqDYwx0MkSY7tmZW7RZXnS4W+w+5B5d5/+eU/zQ2/EOFvaFMzgm4lWVuORZnBSPvgUbNWoR7d/s8aGemq52e0Utdtitqv6ipH+yYPDFrxJQ87x1bKa+DS2AuwcdqIwbq4vhfRQMFuhX6yPvpLc7pbFBGkpA5lrwe0T+f/FuIUg5C56BMqBG+yMGctl7oExFyxF8fAzCv4lHR3eZKn+9Y9Qq2+yFhCspsQ6jOc2ma9S+v8mQZ8d7BrT8llxVFkdgaiyIZU+mk2mHIvr8PR2vcGE6np/ee1caHFRk58suBjUi/gFsELKdhf+HIWHr4pTQ/xnr3uqTnErz+7zAaVc9hAxtcPZjgotrfnRo0mpsm4Goh5kGXJtgtTFzWhX/VYWzu3b4bnlJIfrkHvMsBHnEPJfVARWLUyqvNaBnmU24MPGHWA24RgsGHk37D9UKmccOUYJW/0pb0bacmW6SM0Utx3hSp6+1NEhT40JF9iajDJt7Cx6ej4wYBsh8dowWyRJQFNSZ+TCwMO1Li3zliBkwJqxr7igvTQk5EWzpZP/TJx0WkrnXooIFJHVKqfi38j0Rt3sOo/Zg/C9TQGzCrGBilmOfLC1dP2K7MbcAA5A3jWF+8QVtfu0Wq8Wrp8kxTyQEqvNfb2J1RbBHiZ8DUbp8xTeLa9wkTutoguC5AYpADM2iNCPVxvFknYm3bMcJgw0OC2Lp2SVRZ8D19H2MdUUAhizVKQEbd0e/ho8B8O06gR5IgyB6gc/kCw4SOIXIJQXvvaZ7JQXrYOqjhKOf2oQ9OeHtzDVH/+O04mSQfayVzTdU+a1WNfPos3vEJE8V1hDnbHdJbUqKaiNRh0WWF2XSCBJ7acMZvclme4aFlomwGVNI1fW5CUg3jXAwtMVVUd3fWAAursqvp7uX1PHwI lGSIS9Ju I3U5Ex8Ft1fQdl52QWRz0oRs/vYs3o40Zjo4EngtR9qdX8gkRzmEJKlCM4DWXe2Rj5kzoW5oclKGea1sVnmYr3e8Xr7Bmw1EQbu4FeuUsRIneR09pyE0RBzwPbikwtsJ/uLq9fv3ZTwl/El1JGEGAmvT2uZ1zpIzhx+vI0t5pyE8JVPA0yW0SVaY/pH4bk6UXIUL5gSvEMuRo2z7kD7yMY23vPUl5k3v8jhIrMWire8TtB7DPix4K26Kz3Zx2Qy81FTm7+rMh2aOhabSinN83yqyw+BSxja+VETO2pYdWDoNXeLpuHGd9MTKOp7GzFqaQfn6/1acww0TRTrIi/rTTh3v1NlaBsUfPOllh2iV8s/PbRo4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000046, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Add all final module relocations and add error logs explaining the ones that are not supported. Signed-off-by: Charlie Jenkins --- arch/riscv/include/uapi/asm/elf.h | 6 +- arch/riscv/kernel/module.c | 207 +++++++++++++++++++++++++++++++++----- 2 files changed, 187 insertions(+), 26 deletions(-) diff --git a/arch/riscv/include/uapi/asm/elf.h b/arch/riscv/include/uapi/asm/elf.h index d696d6610231..a9307a1c9ceb 100644 --- a/arch/riscv/include/uapi/asm/elf.h +++ b/arch/riscv/include/uapi/asm/elf.h @@ -49,6 +49,7 @@ typedef union __riscv_fp_state elf_fpregset_t; #define R_RISCV_TLS_DTPREL64 9 #define R_RISCV_TLS_TPREL32 10 #define R_RISCV_TLS_TPREL64 11 +#define R_RISCV_IRELATIVE 58 /* Relocation types not used by the dynamic linker */ #define R_RISCV_BRANCH 16 @@ -81,7 +82,7 @@ typedef union __riscv_fp_state elf_fpregset_t; #define R_RISCV_ALIGN 43 #define R_RISCV_RVC_BRANCH 44 #define R_RISCV_RVC_JUMP 45 -#define R_RISCV_LUI 46 +#define R_RISCV_RVC_LUI 46 #define R_RISCV_GPREL_I 47 #define R_RISCV_GPREL_S 48 #define R_RISCV_TPREL_I 49 @@ -93,6 +94,9 @@ typedef union __riscv_fp_state elf_fpregset_t; #define R_RISCV_SET16 55 #define R_RISCV_SET32 56 #define R_RISCV_32_PCREL 57 +#define R_RISCV_PLT32 59 +#define R_RISCV_SET_ULEB128 60 +#define R_RISCV_SUB_ULEB128 61 #endif /* _UAPI_ASM_RISCV_ELF_H */ diff --git a/arch/riscv/kernel/module.c b/arch/riscv/kernel/module.c index 7c651d55fcbd..73f47de538d2 100644 --- a/arch/riscv/kernel/module.c +++ b/arch/riscv/kernel/module.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -268,6 +269,12 @@ static int apply_r_riscv_align_rela(struct module *me, u32 *location, return -EINVAL; } +static int apply_r_riscv_add8_rela(struct module *me, u32 *location, Elf_Addr v) +{ + *(u8 *)location += (u8)v; + return 0; +} + static int apply_r_riscv_add16_rela(struct module *me, u32 *location, Elf_Addr v) { @@ -289,6 +296,12 @@ static int apply_r_riscv_add64_rela(struct module *me, u32 *location, return 0; } +static int apply_r_riscv_sub8_rela(struct module *me, u32 *location, Elf_Addr v) +{ + *(u8 *)location -= (u8)v; + return 0; +} + static int apply_r_riscv_sub16_rela(struct module *me, u32 *location, Elf_Addr v) { @@ -310,31 +323,149 @@ static int apply_r_riscv_sub64_rela(struct module *me, u32 *location, return 0; } -static int (*reloc_handlers_rela[]) (struct module *me, u32 *location, - Elf_Addr v) = { - [R_RISCV_32] = apply_r_riscv_32_rela, - [R_RISCV_64] = apply_r_riscv_64_rela, - [R_RISCV_BRANCH] = apply_r_riscv_branch_rela, - [R_RISCV_JAL] = apply_r_riscv_jal_rela, - [R_RISCV_RVC_BRANCH] = apply_r_riscv_rvc_branch_rela, - [R_RISCV_RVC_JUMP] = apply_r_riscv_rvc_jump_rela, - [R_RISCV_PCREL_HI20] = apply_r_riscv_pcrel_hi20_rela, - [R_RISCV_PCREL_LO12_I] = apply_r_riscv_pcrel_lo12_i_rela, - [R_RISCV_PCREL_LO12_S] = apply_r_riscv_pcrel_lo12_s_rela, - [R_RISCV_HI20] = apply_r_riscv_hi20_rela, - [R_RISCV_LO12_I] = apply_r_riscv_lo12_i_rela, - [R_RISCV_LO12_S] = apply_r_riscv_lo12_s_rela, - [R_RISCV_GOT_HI20] = apply_r_riscv_got_hi20_rela, - [R_RISCV_CALL_PLT] = apply_r_riscv_call_plt_rela, - [R_RISCV_CALL] = apply_r_riscv_call_rela, - [R_RISCV_RELAX] = apply_r_riscv_relax_rela, - [R_RISCV_ALIGN] = apply_r_riscv_align_rela, - [R_RISCV_ADD16] = apply_r_riscv_add16_rela, - [R_RISCV_ADD32] = apply_r_riscv_add32_rela, - [R_RISCV_ADD64] = apply_r_riscv_add64_rela, - [R_RISCV_SUB16] = apply_r_riscv_sub16_rela, - [R_RISCV_SUB32] = apply_r_riscv_sub32_rela, - [R_RISCV_SUB64] = apply_r_riscv_sub64_rela, +static int dynamic_linking_not_supported(struct module *me, u32 *location, + Elf_Addr v) +{ + pr_err("%s: Dynamic linking not supported in kernel modules PC = %p\n", + me->name, location); + return -EINVAL; +} + +static int tls_not_supported(struct module *me, u32 *location, Elf_Addr v) +{ + pr_err("%s: Thread local storage not supported in kernel modules PC = %p\n", + me->name, location); + return -EINVAL; +} + +static int apply_r_riscv_sub6_rela(struct module *me, u32 *location, Elf_Addr v) +{ + *(u8 *)location -= (u8)v & 0x3F; + return 0; +} + +static int apply_r_riscv_set6_rela(struct module *me, u32 *location, Elf_Addr v) +{ + *(u8 *)location = (*(u8 *)location & 0xc0) | ((u8)v & 0x3F); + return 0; +} + +static int apply_r_riscv_set8_rela(struct module *me, u32 *location, Elf_Addr v) +{ + *(u8 *)location = (u8)v; + return 0; +} + +static int apply_r_riscv_set16_rela(struct module *me, u32 *location, + Elf_Addr v) +{ + *(u16 *)location = (u16)v; + return 0; +} + +static int apply_r_riscv_set32_rela(struct module *me, u32 *location, + Elf_Addr v) +{ + *(u32 *)location = (u32)v; + return 0; +} + +static int apply_r_riscv_32_pcrel_rela(struct module *me, u32 *location, + Elf_Addr v) +{ + *(u32 *)location = (u32)v; + return 0; +} + +static int apply_r_riscv_plt32_rela(struct module *me, u32 *location, + Elf_Addr v) +{ + *(u32 *)location = (u32)v; + return 0; +} + +static int apply_r_riscv_set_uleb128(struct module *me, u32 *location, Elf_Addr v) +{ + /* + * Relocation is only performed if R_RISCV_SET_ULEB128 is followed by + * R_RISCV_SUB_ULEB128 so do computation there + */ + return 0; +} + +static int apply_r_riscv_sub_uleb128(struct module *me, u32 *location, Elf_Addr v) +{ + if (v >= 128) { + pr_err("%s: uleb128 must be in [0, 127] (not %ld) at PC = %p\n", + me->name, (unsigned long)v, location); + return -EINVAL; + } + + *location = v; + return 0; +} + +/* + * Relocations defined in the riscv-elf-psabi-doc. + * This handles static linking only. + */ +static int (*reloc_handlers_rela[])(struct module *me, u32 *location, + Elf_Addr v) = { + [R_RISCV_32] = apply_r_riscv_32_rela, + [R_RISCV_64] = apply_r_riscv_64_rela, + [R_RISCV_RELATIVE] = dynamic_linking_not_supported, + [R_RISCV_COPY] = dynamic_linking_not_supported, + [R_RISCV_JUMP_SLOT] = dynamic_linking_not_supported, + [R_RISCV_TLS_DTPMOD32] = dynamic_linking_not_supported, + [R_RISCV_TLS_DTPMOD64] = dynamic_linking_not_supported, + [R_RISCV_TLS_DTPREL32] = dynamic_linking_not_supported, + [R_RISCV_TLS_DTPREL64] = dynamic_linking_not_supported, + [R_RISCV_TLS_TPREL32] = dynamic_linking_not_supported, + [R_RISCV_TLS_TPREL64] = dynamic_linking_not_supported, + /* 12-15 undefined */ + [R_RISCV_BRANCH] = apply_r_riscv_branch_rela, + [R_RISCV_JAL] = apply_r_riscv_jal_rela, + [R_RISCV_CALL] = apply_r_riscv_call_rela, + [R_RISCV_CALL_PLT] = apply_r_riscv_call_plt_rela, + [R_RISCV_GOT_HI20] = apply_r_riscv_got_hi20_rela, + [R_RISCV_TLS_GOT_HI20] = tls_not_supported, + [R_RISCV_TLS_GD_HI20] = tls_not_supported, + [R_RISCV_PCREL_HI20] = apply_r_riscv_pcrel_hi20_rela, + [R_RISCV_PCREL_LO12_I] = apply_r_riscv_pcrel_lo12_i_rela, + [R_RISCV_PCREL_LO12_S] = apply_r_riscv_pcrel_lo12_s_rela, + [R_RISCV_HI20] = apply_r_riscv_hi20_rela, + [R_RISCV_LO12_I] = apply_r_riscv_lo12_i_rela, + [R_RISCV_LO12_S] = apply_r_riscv_lo12_s_rela, + [R_RISCV_TPREL_HI20] = tls_not_supported, + [R_RISCV_TPREL_LO12_I] = tls_not_supported, + [R_RISCV_TPREL_LO12_S] = tls_not_supported, + [R_RISCV_TPREL_ADD] = tls_not_supported, + [R_RISCV_ADD8] = apply_r_riscv_add8_rela, + [R_RISCV_ADD16] = apply_r_riscv_add16_rela, + [R_RISCV_ADD32] = apply_r_riscv_add32_rela, + [R_RISCV_ADD64] = apply_r_riscv_add64_rela, + [R_RISCV_SUB8] = apply_r_riscv_sub8_rela, + [R_RISCV_SUB16] = apply_r_riscv_sub16_rela, + [R_RISCV_SUB32] = apply_r_riscv_sub32_rela, + [R_RISCV_SUB64] = apply_r_riscv_sub64_rela, + /* 41-42 reserved for future standard use */ + [R_RISCV_ALIGN] = apply_r_riscv_align_rela, + [R_RISCV_RVC_BRANCH] = apply_r_riscv_rvc_branch_rela, + [R_RISCV_RVC_JUMP] = apply_r_riscv_rvc_jump_rela, + /* 46-50 reserved for future standard use */ + [R_RISCV_RELAX] = apply_r_riscv_relax_rela, + [R_RISCV_SUB6] = apply_r_riscv_sub6_rela, + [R_RISCV_SET6] = apply_r_riscv_set6_rela, + [R_RISCV_SET8] = apply_r_riscv_set8_rela, + [R_RISCV_SET16] = apply_r_riscv_set16_rela, + [R_RISCV_SET32] = apply_r_riscv_set32_rela, + [R_RISCV_32_PCREL] = apply_r_riscv_32_pcrel_rela, + [R_RISCV_IRELATIVE] = dynamic_linking_not_supported, + [R_RISCV_PLT32] = apply_r_riscv_plt32_rela, + [R_RISCV_SET_ULEB128] = apply_r_riscv_set_uleb128, + [R_RISCV_SUB_ULEB128] = apply_r_riscv_sub_uleb128, + /* 62-191 reserved for future standard use */ + /* 192-255 nonstandard ABI extensions */ }; int apply_relocate_add(Elf_Shdr *sechdrs, const char *strtab, @@ -348,6 +479,10 @@ int apply_relocate_add(Elf_Shdr *sechdrs, const char *strtab, unsigned int i, type; Elf_Addr v; int res; + bool uleb128_set_exists = false; + u32 *uleb128_set_loc; + unsigned long uleb128_set_sym_val; + pr_debug("Applying relocate section %u to %u\n", relsec, sechdrs[relsec].sh_info); @@ -425,6 +560,28 @@ int apply_relocate_add(Elf_Shdr *sechdrs, const char *strtab, me->name); return -EINVAL; } + } else if (type == R_RISCV_SET_ULEB128) { + if (uleb128_set_exists) { + pr_err("%s: riscv psABI requires the next ULEB128 relocation to come after a R_RISCV_SET_ULEB128 is an R_RISCV_SUB_ULEB128, not another R_RISCV_SET_ULEB128.\n", + me->name); + return -EINVAL; + } + uleb128_set_exists = true; + uleb128_set_loc = location; + uleb128_set_sym_val = + ((Elf_Sym *)sechdrs[symindex].sh_addr + + ELF_RISCV_R_SYM(rel[i].r_info)) + ->st_value + + rel[i].r_addend; + } else if (type == R_RISCV_SUB_ULEB128) { + if (uleb128_set_exists && uleb128_set_loc == location) { + /* Calculate set and subtraction */ + v = uleb128_set_sym_val - v; + } else { + pr_err("%s: R_RISCV_SUB_ULEB128 must always be paired with the first R_RISCV_SET_ULEB128 that comes before it. PC = %p\n", + me->name, location); + return -EINVAL; + } } res = handler(me, location, v);