From patchwork Tue Oct 17 23:01:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Rasmussen X-Patchwork-Id: 13426169 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2072CDB484 for ; Tue, 17 Oct 2023 23:01:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F1298D0115; Tue, 17 Oct 2023 19:01:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2707F8D0002; Tue, 17 Oct 2023 19:01:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04D958D0115; Tue, 17 Oct 2023 19:01:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D6EE88D0002 for ; Tue, 17 Oct 2023 19:01:22 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AF70780F83 for ; Tue, 17 Oct 2023 23:01:22 +0000 (UTC) X-FDA: 81356476404.02.2ED9287 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by imf20.hostedemail.com (Postfix) with ESMTP id 038B41C000F for ; Tue, 17 Oct 2023 23:01:20 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="wI1v/9eT"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of 3QBIvZQ0KCFEtGx4AtB5DBBx6z77z4x.v75416DG-553Etv3.7Az@flex--axelrasmussen.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3QBIvZQ0KCFEtGx4AtB5DBBx6z77z4x.v75416DG-553Etv3.7Az@flex--axelrasmussen.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697583681; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zhGJS9TSuAOI7ph8IS5R88r99qDdTpF/uHgtYeaRs+U=; b=YJyD2yqQk1Tbq5db8XQ6qqVL/sqPmt12PUIKDrj63itFiXL1PnWL3Ph984GZ9ga5rvkFAy lwfM2+BCYUOYHmA61K26V7O52agH/Vd2N9ONblfMIVZoVujwzhXtUGOxhT2QyQBI5lU3Gc iD4GUqhFhhmGFs+0YHY6dt1YG21blvQ= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="wI1v/9eT"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of 3QBIvZQ0KCFEtGx4AtB5DBBx6z77z4x.v75416DG-553Etv3.7Az@flex--axelrasmussen.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3QBIvZQ0KCFEtGx4AtB5DBBx6z77z4x.v75416DG-553Etv3.7Az@flex--axelrasmussen.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697583681; a=rsa-sha256; cv=none; b=rmag/onolugssx5+XYmf0UKSZdNsoZszNh7xFTQE35tWT6MHy1Pwt6kb7eM+FjnY30l0yX 4K+R7qy0X3QZS9Jp8Tww8n8+vvvA0EXJCak4RwkL/OW7ZghHePKltxp0od16qW3HsdxBy7 SVBUPwBhpT5eKZJfiq1HS88XsbmfBpw= Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-5a7a6fd18abso95610657b3.1 for ; Tue, 17 Oct 2023 16:01:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697583680; x=1698188480; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=zhGJS9TSuAOI7ph8IS5R88r99qDdTpF/uHgtYeaRs+U=; b=wI1v/9eTFE8lbAKex6OyMPEoDbKFybyoXVtOCZcZWwa2n1lVLc+GFyMA4T+GOZUgu+ 50fX1oMi1IWyJs0jT2vyYga28g/txDLNMZnpd4u1c9iEB/YhjJ64hQ/OmwQNwiFZX2nj CzCmxjbC+XGKfwlv13tz6J5RUWz/ql3tNoXGiDML1xoWujlO6VyEzYQknovtTRHUROVg OiQYXMjfST/lqaw7ptfGj0t33KT8JRIsuM77zgTYxL6iTy2VTSdbgX7xcE/yU6k9qoXE 3KhcJvr7R6oa05U+cMr+IKXH1FD7Zf+p6BYHV1auKdZ5lwE8QEyvt3jSIINqHajz1PpI S/oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697583680; x=1698188480; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zhGJS9TSuAOI7ph8IS5R88r99qDdTpF/uHgtYeaRs+U=; b=nwrOWic7VcXZ5VgC5LcEysyrfYs56oqS3uBKUE/PTe4sy0fBIU6qo9/twOK6HIuBzL oHtIwvyiZGQz1cYJtoA1cDAEyB/CNIQRtLjROgNAF/WnMJ2hwtaySBh+oVEV1ZMBkhCH zXqoNdM/Q12NPsD/am73hnUi7oRBMlpx5M3OJe/4Te+veNZyJm25uphJVYICVtIOQt8C rkA8H4Vq7G1Q4/g/UbGfOwv7xDPKQZu/sWEvcEF2yy1g/0cnNUMECdKIjUekavNTrS4p bBqSR2z2KIHOkUIBtHJOCOxCa3iTx0QsUycqrp7u9XCEQfQWOev/NLkjYKrS4S9ExUri HqMw== X-Gm-Message-State: AOJu0YzrWnWSHRBs5QDrANUCN4pXuylVgSBDADNKrMy1CCKxUqGkfwjj mT2iqG7vqEJPXsBgixiJ53jXuSC0uI9wZUIoucsV X-Google-Smtp-Source: AGHT+IGUIIMYcfHcAX/EFWTsWCSWt3CWSp3wyfZIjOY21JWpjm5WYGNByO8zTW1z94HmtGuIWpM6167CUq/2ldotqPAL X-Received: from axel.svl.corp.google.com ([2620:15c:2a3:200:cd04:35d6:a586:5c86]) (user=axelrasmussen job=sendgmr) by 2002:a25:8c86:0:b0:d81:7617:a397 with SMTP id m6-20020a258c86000000b00d817617a397mr80370ybl.9.1697583680159; Tue, 17 Oct 2023 16:01:20 -0700 (PDT) Date: Tue, 17 Oct 2023 16:01:09 -0700 In-Reply-To: <20231017230110.3170850-1-axelrasmussen@google.com> Mime-Version: 1.0 References: <20231017230110.3170850-1-axelrasmussen@google.com> X-Mailer: git-send-email 2.42.0.655.g421f12c284-goog Message-ID: <20231017230110.3170850-3-axelrasmussen@google.com> Subject: [PATCH v3 2/3] ioctl_userfaultfd.2: fix / update UFFDIO_REGISTER error code list From: Axel Rasmussen To: Alejandro Colomar , Mike Rapoport , Peter Xu Cc: linux-man@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Axel Rasmussen X-Rspamd-Queue-Id: 038B41C000F X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: z1mx9ob7b66ozdsgrjccuxqxa5i366q7 X-HE-Tag: 1697583680-940874 X-HE-Meta: U2FsdGVkX184LmxfThxByPl88Oeb990i0BGYhaL/r5On8zxssYfNVVNymXNNT6WX0gFog+Ht3wGp5xQrR5TXwJ5/KRO0NSD4F/LtUwzxPUUwLkh8AmdHwcZHZTbPvlnvPzntmlgwaI0eQ/zyp+BDT+O9NqoMWt8TdxtdsgwqPepXQOpXVxidLsdHbc+DLXv1CwvzygxFqSPDp7FENpII485nVd3FXTtP0P00+nhxnCOuxf1naLqzXJK3YNzZ3TbINYQQyA26syPokj0j/SyvNJCIO53zkaxn48NNQ5L41kuO1OMq65acI/ZbhxyOngrM7O6qHOdgSYLyRXPTF57fSwMuwwfDACW5CLDFZYVYanhc/ZRudJYGn/LCyDI8NHUN+XGgrTAIbTOOWsN91RctIOTKEvG0wQeiPAyTvVEHTP6obBZ/Kvc3yYd+LxOirBZJZ4WfBf6/bzztz19SdpN+Wx0psoB7oUJdoNFfj/NyV4FkbIpF5PEv9Zh2ifYABWPXYISsI0UsY31xiIw4CoKoXjJBXGgvotB5BFWADxu8Bz+8EEI6Hy7zqktKj8HONitCYwUTNqDsdpHQ+OWyx57BjOOKs4JbtbkR+DqdZEX435iz7Gq6qeE1jQI9DAlDuMn8zhyqGp60XNqFd8vLAJC8CuiJxruu+nBmWAj0OdlXc8vVqkUuK/OQ5dvZHDGaLEwAbw+Q6pPi+JMMC6rypUUUUQZmBhMTLYNyDSHL+gdoQb/cgw8kxSqPQOAAyfgZRC99pcf5TMOgq6YyGOWREF8lVePRqRwnoCaDb1eF/mk6LglhlAL6AV5wmiwZD5M2wQc+6bqZBsAAxZJ+g2wcF0CaSbr2VApKyXqbFpRdUFXxp2d9yn1c4E7ZJ/xJ4o/Ck/hmbgbjYUfiwWVXFMNhuBL1PmPWm4NtrPM/Tj/m056zI9FXbcrSpUu6boTj2a+rglvLOxYV5gbJGwyE8I7zJb7 O09G3n+G 86NMTfLpC95VPazNJaF99YmOlETWRMquV6SEyaWqWWfEzFU0f1o2kTXG6IjPPdlm+CDWsLMHNLjG7ztvdcdjEcAls2NTkipbcuUusk3jEBvwzxYwu+yux7b8TuCJN/Jaib5aQmjPCT79CIIUc+YYJG4OuSmRqqiIBdu5Di7G92Wnl/nsLz7AP4HLNaaGhvsXm6FfqkuWOvba4leB8c0zNtug/xrs0p6nHGzkQy8s6skcjLXOwqxYscdasbnL3QEQQGXlYyiAkSSZ7UqV7dakrLf1s/bByxwZ1F8smRBeBiVFiC0VemLPujhOz7pDZ3lQUeqeLCYx4/FXDfynX3fF4X7sKG1dsdz6PcCNO2eFPiEdfJDkfLUHOMXEtPZ4frZeibTNO5d2iDZxyeCuCbY7BVVmGAPOrjG0A0lldePbdBpt+XFEoCccGvY6yw9GefUEjZ/UqPJp1xibLw711FeHpiEfo0m7460DBf9b55R794Ml92UkjTcOq6jU+x5rzz1C+5Rh2lJxKmoKtLBtyVHAnDeBPmLA+MyjpA20SPzGbS/anxEIjivfBw8pJIPfP/dlNw+LEQ05OVFFf6ksfmx0ezOk/PlrZfZLVcEXhKAB2uJvv6qtll0JPrd9NJ7f9L6/NWyU3XE6f1BZcMXR/EfTEJ0tM1kNVFw03Mn86lj4m7s6//TbfGd/s/xXZJxzVQmiEkEV+euxAvaC4LlA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.112480, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The list of error codes in the man page was out of date with respect to the current state of the kernel. Some errors were partially / incorrectly described. Update the error code listing, so it matches the current state of the kernel, and correctly describes all the errors. Signed-off-by: Axel Rasmussen --- man2/ioctl_userfaultfd.2 | 33 +++++++++++++++++++-------------- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/man2/ioctl_userfaultfd.2 b/man2/ioctl_userfaultfd.2 index 82aee667c..40528001e 100644 --- a/man2/ioctl_userfaultfd.2 +++ b/man2/ioctl_userfaultfd.2 @@ -413,8 +413,6 @@ On error, \-1 is returned and .I errno is set to indicate the error. Possible errors include: -.\" FIXME Is the following error list correct? -.\" .TP .B EBUSY A mapping in the specified range is registered with another @@ -433,21 +431,28 @@ field; or the field was zero. .TP .B EINVAL -There is no mapping in the specified address range. -.TP -.B EINVAL -.I range.start +The specified address range was invalid. +More specifically, +no mapping exists in the given range, +or the mapping that exists there is invalid +(e.g. unsupported type of memory), +or the range values +.RI ( range.start +or +.IR range.len ) +are not multiples of the relevant page size, or .I range.len -is not a multiple of the system page size; or, -.I range.len -is zero; or these fields are otherwise invalid. +is zero. .TP -.B EINVAL -There as an incompatible mapping in the specified address range. -.\" Mike Rapoport: -.\" ENOMEM if the process is exiting and the -.\" mm_struct has gone by the time userfault grabs it. +.B ENOMEM +The process is exiting, +and its address space has already been torn down +when userfaultfd attempts to reference it. +.TP +.B EPERM +The userfaultfd would allow writing to a file backing the mapping, +but the calling process lacks such write permissions. .SS UFFDIO_UNREGISTER (Since Linux 4.3.) Unregister a memory address range from userfaultfd.