From patchwork Sat Oct 21 14:43:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengming Zhou X-Patchwork-Id: 13431524 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20EBFC07545 for ; Sat, 21 Oct 2023 14:44:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 975678D0023; Sat, 21 Oct 2023 10:43:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9257F8D0008; Sat, 21 Oct 2023 10:43:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C76B8D0023; Sat, 21 Oct 2023 10:43:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 671008D0008 for ; Sat, 21 Oct 2023 10:43:59 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 29D5A140304 for ; Sat, 21 Oct 2023 14:43:59 +0000 (UTC) X-FDA: 81369738198.08.F8E9287 Received: from out-210.mta1.migadu.com (out-210.mta1.migadu.com [95.215.58.210]) by imf12.hostedemail.com (Postfix) with ESMTP id 65A8C40017 for ; Sat, 21 Oct 2023 14:43:57 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=U7c03tZf; spf=pass (imf12.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.210 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697899437; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=McUlAOC6AXMF3DQxwjxFsXChYXBELSqYw7TfeM0+yv0=; b=2IdiA9wEfaFdPSXEv4FJbHUNSph2UOaSi4igrt9ORDjz+DPyWDiBQ5F2Iayjkz31PXN82F FwatTJRhR/Z0OmWNd3T0Fsi27jfEiNNGRM6YUL9v6tNItiD/rFjhSQQI7m648pgE+7w6vT 7KN+SNERVYnqzoz6USI9DI4r8uvMlow= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697899437; a=rsa-sha256; cv=none; b=pupIcJpyfSz4mIzuiTcNBQqoWEjYSJq3rZY2kqMnRAN644/PuXigtVbxye+v3Jnjxw8IpX OCKjlfR94k5qKRAqKldFsR3w8NrzYZquVQy++f9JUPwuXtEpUYiswLl21kY8S4uO/ePk23 nCNAxbC6JB+2ZO8se4dHAkjyUDy/glU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=U7c03tZf; spf=pass (imf12.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.210 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1697899435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=McUlAOC6AXMF3DQxwjxFsXChYXBELSqYw7TfeM0+yv0=; b=U7c03tZf2fCoW5T3wE2WN887d5Ut/z0dqbsdzuHPFwfuTnJjKkXIqgu1qkz/ZM1D7dvN/0 +t0ZPZQ04YUwljOgsVlPl0zjwouHH5C+41xLj3a5pQygz/jzSeLcr3C5ImZ/LyIGOBMkuM Zx55Qopachdrboij0Lf1+nGLH57UfVI= From: chengming.zhou@linux.dev To: cl@linux.com, penberg@kernel.org Cc: rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, willy@infradead.org, pcc@google.com, tytso@mit.edu, maz@kernel.org, ruansy.fnst@fujitsu.com, vishal.moola@gmail.com, lrh2000@pku.edu.cn, hughd@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, chengming.zhou@linux.dev, Chengming Zhou Subject: [RFC PATCH v2 1/6] slub: Keep track of whether slub is on the per-node partial list Date: Sat, 21 Oct 2023 14:43:12 +0000 Message-Id: <20231021144317.3400916-2-chengming.zhou@linux.dev> In-Reply-To: <20231021144317.3400916-1-chengming.zhou@linux.dev> References: <20231021144317.3400916-1-chengming.zhou@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 65A8C40017 X-Rspam-User: X-Stat-Signature: 8dsq8swbebtenntjhrwnxpkzd9yw4ucq X-Rspamd-Server: rspam03 X-HE-Tag: 1697899437-345791 X-HE-Meta: U2FsdGVkX18f/LU4pZrb8IoTxqnVPgSe5NTLLSKO1KQRD9vivHWa3Qp890B59gB0HDrp4VSYnBvo0ZYcDFhJy3gcItaW0ZSlUhDgmtD4avrpsiEubOTfUUjjq3gpqAXGk2Vy03cjCgxzjtbECcOZpwwNk/SNiHJ1I45+PY55RMbNbmg2UlKePVRjMTLrLom0eRxPuLm92FOOEwVP/laU+Zx9KGnbMPHuVTL7b/ftKzxHGgyuFMc+Oy5NTy6xComOS+qMbGMHOy2dRVM34H0+JGTCqpF+Gj7To9OwO68nXfNtdUPYLorBLoX5mQXWAhIMprv0e6gPDq2tlRgFKfnXigXwBoW0/enA7tgzEUujtdq3wN6kLKB6PUYtRGlUC7Gs6IC6QzFr+vuCi9pin8ViFpEZNO0tSXP3bLYrHV00EPZj0rUVGOsq5SIoasOCd/XzhOYO3V7VYMgdq8e2SZf5ZPEu/B3321hfUrNuKxyF+BnN1RlpceJRv0/73eVY4cU4vbhFM6FOLnSU10sWqQhLw3WjHza3eIRlT9MfKW+j9qzChEb9KLwB5xi3Wjdk3WZ90TAg3DudfPqQJ+d91dXjh14b4kV+Glm8mGkUgrkkl/dEd0nO2WnuyR5nDxU1tFvz2TwLokGU7/VeJOq0/rPTuWA7c07dvSC0CcAXa8Dj0mkJ6mAHC7d4IOuKngu30+MX0Fp0S0hqV/zRVdFOlz1Z6nvI8KTcx8lXeqhfc40z+go2p5EO6MMueppe/pZTVrYEJY39gZJJbh4lyn4J1SpQLauENx9kc5jwiuACNlVQ9VymMDSuu5xLBquPDs1M4TXD0+UMoIVtJG2JpGB+0qARwunzrL6c4bXsB6RD8l1yvOOzk+0DPF+4IgbmPRk6696wRCRxNHc8RSAwnb+ElOU54gR6AG8fEmfin8wbx2p9k/ioI7Uh26COzhuSBKt0uLsf67eFOUq51GqZ614Bu36 QrLksRPN s3ksOxakiuec0PrHXPo3KyP6a6QRVlQaGSdJs+/JMXmkR3mk0FQIr6L+UEksdUT+AiCGq1NdItA8U6SXN7/NMGWRHwqGScckn7qVosgO/1YbQTstDbY6943pFsT50D+2bVqMJQHawBNL/4+R/rNpVVGRxxiLYxFC+xCW/Bc+D+Vmg5GWrh9Ju9WRaTkFxGEbgbI1Ya0UJMsP2p9g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Chengming Zhou Now we rely on the "frozen" bit to see if we should manipulate the slab->slab_list, which will be changed in the following patch. Instead we introduce another way to keep track of whether slub is on the per-node partial list, here we reuse the PG_workingset bit. Signed-off-by: Chengming Zhou --- include/linux/page-flags.h | 2 ++ mm/slab.h | 19 +++++++++++++++++++ mm/slub.c | 3 +++ 3 files changed, 24 insertions(+) diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h index a88e64acebfe..e8b1be71d722 100644 --- a/include/linux/page-flags.h +++ b/include/linux/page-flags.h @@ -478,6 +478,8 @@ PAGEFLAG(Active, active, PF_HEAD) __CLEARPAGEFLAG(Active, active, PF_HEAD) TESTCLEARFLAG(Active, active, PF_HEAD) PAGEFLAG(Workingset, workingset, PF_HEAD) TESTCLEARFLAG(Workingset, workingset, PF_HEAD) + __SETPAGEFLAG(Workingset, workingset, PF_HEAD) + __CLEARPAGEFLAG(Workingset, workingset, PF_HEAD) __PAGEFLAG(Slab, slab, PF_NO_TAIL) PAGEFLAG(Checked, checked, PF_NO_COMPOUND) /* Used by some filesystems */ diff --git a/mm/slab.h b/mm/slab.h index 8cd3294fedf5..9cff64cae8de 100644 --- a/mm/slab.h +++ b/mm/slab.h @@ -193,6 +193,25 @@ static inline void __slab_clear_pfmemalloc(struct slab *slab) __folio_clear_active(slab_folio(slab)); } +/* + * Slub reuse PG_workingset bit to keep track of whether it's on + * the per-node partial list. + */ +static inline bool slab_test_node_partial(const struct slab *slab) +{ + return folio_test_workingset((struct folio *)slab_folio(slab)); +} + +static inline void slab_set_node_partial(struct slab *slab) +{ + __folio_set_workingset(slab_folio(slab)); +} + +static inline void slab_clear_node_partial(struct slab *slab) +{ + __folio_clear_workingset(slab_folio(slab)); +} + static inline void *slab_address(const struct slab *slab) { return folio_address(slab_folio(slab)); diff --git a/mm/slub.c b/mm/slub.c index 63d281dfacdb..3fad4edca34b 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2127,6 +2127,7 @@ __add_partial(struct kmem_cache_node *n, struct slab *slab, int tail) list_add_tail(&slab->slab_list, &n->partial); else list_add(&slab->slab_list, &n->partial); + slab_set_node_partial(slab); } static inline void add_partial(struct kmem_cache_node *n, @@ -2141,6 +2142,7 @@ static inline void remove_partial(struct kmem_cache_node *n, { lockdep_assert_held(&n->list_lock); list_del(&slab->slab_list); + slab_clear_node_partial(slab); n->nr_partial--; } @@ -4831,6 +4833,7 @@ static int __kmem_cache_do_shrink(struct kmem_cache *s) if (free == slab->objects) { list_move(&slab->slab_list, &discard); + slab_clear_node_partial(slab); n->nr_partial--; dec_slabs_node(s, node, slab->objects); } else if (free <= SHRINK_PROMOTE_MAX)