From patchwork Mon Nov 20 07:09:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Zhang X-Patchwork-Id: 13460872 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A25E0C197A0 for ; Mon, 20 Nov 2023 07:09:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 293506B0337; Mon, 20 Nov 2023 02:09:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 244016B033C; Mon, 20 Nov 2023 02:09:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E3FF6B038E; Mon, 20 Nov 2023 02:09:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 012106B0337 for ; Mon, 20 Nov 2023 02:09:57 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C84BDA01B9 for ; Mon, 20 Nov 2023 07:09:57 +0000 (UTC) X-FDA: 81477458034.08.105541B Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf10.hostedemail.com (Postfix) with ESMTP id 01E4EC000C for ; Mon, 20 Nov 2023 07:09:55 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="CQg/Ps9g"; spf=pass (imf10.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700464196; a=rsa-sha256; cv=none; b=hSUiKvG0+3bZTZBYFNfVLIxLaq2CH89+Wl1N3zptp+3a4Xj1m+PLZmbCyxmg1AP4qwRYF9 QgaKiqe3hb8v2bmSlXy+gPLgGKgKFuc7/K0GCjw1jaV+Qf9RT9Cc3bXQBhGeAGF7MPO4ss J4rJ4T8Ta/uNEQa0amf734ah2Y5FVto= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="CQg/Ps9g"; spf=pass (imf10.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700464196; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nUE9ZvwZFQu7umd/mVKa2M3eheT6QrVVeWcfJsSgwak=; b=HIn+jGdeSY0VVWW2q8J0tqmtDERD7BfD1E5TWQwEPJpWQvkhW0cb7D87+HTaZV7vlByv/M dyMitjeHHra0J6OX+3gnfiJcJqOxiH1HeKOpcNHVCJtg935yruFYrylOPJUBXGbGPX1Qlo ONWLMvD6oV2/Gh2fpIst1radGJxDCek= Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1cc3542e328so29180965ad.1 for ; Sun, 19 Nov 2023 23:09:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1700464195; x=1701068995; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nUE9ZvwZFQu7umd/mVKa2M3eheT6QrVVeWcfJsSgwak=; b=CQg/Ps9gTkB6kiuxCp5XgwIqLXXJLAfjAp8DQESO8yARkAsHGSehsg6cjQG25CF6Rc WxSMhUgLZUV11Pe2wIOZS4VTMMQPqQyp2Y4+euxxTxjqQ5kRkCIq0UUmlis9mb7iyxj2 ehEGiSq8Cc4JVrL4zoVJ2mVoeQofo82ZRQS/ntMJTD4fkH0eJ4LcfNi+q1Kf4iFRBpJ8 jkSQmgJVlmGtqkOb45pI2JDJhM1whTobY5LSryI0QAe3ylyhfeUJ03tmsFr5I1+FErcl i19Fx9qy8ifZYrKYef18p6+Y8ybRcYEn38KtW8D/fZ152w+G0YUKWGff4HX8ouKqbNVB Ptow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700464195; x=1701068995; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nUE9ZvwZFQu7umd/mVKa2M3eheT6QrVVeWcfJsSgwak=; b=vcAC+cFUnXK52xQoF5HrgngcZxi/51M7ezhTLE1DAftkQlUDktyrL/cmmmJbL8zysI sUtt82ZmEsAu8aWZtZH48g5dihWV6aCwG7CQE1/h8qnqPOhku2W/xk1c9CE2IZ0j6LYf ZMOaK8t7XvdjFDiyLu7yvLgfqhYWWvx+5I91stUDs5/3gCCkeGsTUwp6VIow4GL+Z800 FYq0nSmY180rT1Zb4bblu51yXsa8h5W3BPxg1yDkxOiagqy0YrzTT8RWQaDefWMp9OnC YefxmrwP2Oa0rqsm4aRwBqvxuodF6OH0mpj2SeNLkxV7WSbqYANpCYPhuRmaoxz6Z+MA 65Wg== X-Gm-Message-State: AOJu0YyoOn+apdMdnZdcC3yQnVjG9sT3VjAB6iY8ztK3FUNt6danbcKG yup6tShl1mNzIrakyyB3LZWo+w== X-Google-Smtp-Source: AGHT+IHoQx5VP90DjW6z7hmikj/ILZ20irNIme8mby57GLohgMrwLjCqPd9SOayxbZcQ2cOPovcmJg== X-Received: by 2002:a17:902:d904:b0:1ce:5c04:fb60 with SMTP id c4-20020a170902d90400b001ce5c04fb60mr4374550plz.8.1700464194899; Sun, 19 Nov 2023 23:09:54 -0800 (PST) Received: from GL4FX4PXWL.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id d4-20020a170902cec400b001ce67fab3a2sm3698143plg.261.2023.11.19.23.09.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 19 Nov 2023 23:09:54 -0800 (PST) From: Peng Zhang To: Liam.Howlett@oracle.com, dan.carpenter@linaro.org, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, maple-tree@lists.infradead.org, Peng Zhang Subject: [PATCH v2 1/5] maple_tree: Move the check forward to avoid static check warning Date: Mon, 20 Nov 2023 15:09:33 +0800 Message-Id: <20231120070937.35481-2-zhangpeng.00@bytedance.com> X-Mailer: git-send-email 2.39.3 (Apple Git-145) In-Reply-To: <20231120070937.35481-1-zhangpeng.00@bytedance.com> References: <20231120070937.35481-1-zhangpeng.00@bytedance.com> MIME-Version: 1.0 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 01E4EC000C X-Stat-Signature: ex79of5utck1ehwadu5qzks18sbcrbde X-Rspam-User: X-HE-Tag: 1700464195-909972 X-HE-Meta: U2FsdGVkX18eNKOdC5WGxsZgZNddC+0r4/PJEsCQzIPzxU9/GxAxBmliPcxdtTHfnSxFISJi4Vk7u2UIb/lV13mZvsA0iFUoBCJR3GSgffwV6Vpe9uRjRm9zcVwmrRTkpE8Rv3IluxCJ1o8E0JFFWFQEesROvjyALGaOVshf2KdAeDD4rjNBA09ryICXQtPtilakyGdJLMa1M6Ibmrw88AajCCkbqnX9vAroy3a3FnuP/mZFtzmuLURlMgkzRaUQKR9lZE7iUrZNEX2BLkiUWqlOVGDxILnn+vkAYmsIUNto/v7aOA/Bf+xWeHLc3pk4L1n1yZIT0Q+t1eBxTrHFu+yK0D+PJJdl5PXFGhh/JcmFzIcnRxGvItXkBYkhvG6CjoFgYnPbAdYGyCQrU37ij46g1wZnCKYDeUAMM0MSYe78Gkgnw6QTSop1pIyMDSefjV3az8JfzqUweBTF2G22rFAknYlYSYS1BF34F24QJDKT5G2pd07KMoFNaDaU+GH2JQp7nIP8diopPIvo7CV3N3e8MlL6K1F/hfpKswLdjQanCG6JS5fcJRZNBvU9dH3a4hFwY/DAGmwRZLDYGlB/yLselBecpOk8gkNMZdyK6Kq6KsWZ+q0OQfeFIwR83DjZCMIHq4RBGEqxN6TeRWFRKOmJCkLY+/oZ1RCpCw77WvGfflHozccTOTHTjVQP1qaszU9ydG0kIw8nVDJKEd3iLhDmOQxQuBgwhDl0eq7TTcQqkjrz7N0buwxevF6Yoywn603LQY4w5+COIJQL0M7RsfCermtP6zJy2szyICwgAn0mYe6HrtILjTG6phn2dViH+UWUwzFdff41a8x1niVQVA9JXnKwOFs4sMSxcbVMn/ArGb5ww0SkqzYnzQ8dMXt1oWS/ycrFPDcaV9LTOdey8yoet/ExDUeg3U3XjKxGN0XQGiGwndh5ci4Zjt4sH7fKOttkp+uHmbsXHvuayTv jIQAw1rL uWqtwNcHeUcJyhe0X2cm5e+Kl3kV8dz4Sn83UrSKwFgC49ho/ienii1FozPQl2go0nYEjr2xmk80EmmefInGruz+j+hU7U23WUpfBCDMiS5vkWnuENrM0UQUXokS7iZw1k/4R6efJYPosLoqU65ygA9A/jQ1ZE8hOrdSsVFyxMUATdZq6SqO3pXdIBZ/N1z/Nc9LGBz46FbJnksPq4fr/s3Zjm6SYMNyFyYfzUDAUZ67X8GAu4HaOc/8YJc2wfhrbVW8EJBzWt/K5xaLHdz0jI6PT1z57kPkJ3ZYy27Nz1/xMdxOfgXCrSnuRoMt429q8XE9C78AIwoN4hXjvHsoewh9j4X5l4tTRUGZFpMv4sepjbNlTKCtJKydMGoxqQPuXFYUdTV5dM9sVPc6o6iSs7+3O0UWKC/8tPwWmbSaoJaj33vhlgYIeoYnKsoBSd+JuExFxxdaM9R/HqbL9lMjkSFDnKSrvpelAiL0udnv6SI28Mpq9REhJCLDotbQOusb99oRVWmtStH/BJ5AfQVQZBvhuMn945D8unntFw0ffESZRVEo4uElrsP3K1rd1hGx4deE5pwBADD80AC9f1/qQlDLJP1aB8zELHckF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000027, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Put the check for gap before its reference to avoid Smatch static check warnings. This is not a bug, it's just a validation program. Even with this change, Smatch may still generate warnings because MT_BUG_ON() doesn't necessarily stop the program. It may require fixing Smatch itself to avoid these warnings. Reported-by: Dan Carpenter Closes: http://lists.infradead.org/pipermail/maple-tree/2023-November/003046.html Signed-off-by: Peng Zhang --- lib/maple_tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/maple_tree.c b/lib/maple_tree.c index aaba453b0d30..067b186202d7 100644 --- a/lib/maple_tree.c +++ b/lib/maple_tree.c @@ -7249,6 +7249,7 @@ static void mas_validate_gaps(struct ma_state *mas) counted: if (mt == maple_arange_64) { + MT_BUG_ON(mas->tree, !gaps); offset = ma_meta_gap(node, mt); if (offset > i) { pr_err("gap offset %p[%u] is invalid\n", node, offset); @@ -7261,7 +7262,6 @@ static void mas_validate_gaps(struct ma_state *mas) MT_BUG_ON(mas->tree, 1); } - MT_BUG_ON(mas->tree, !gaps); for (i++ ; i < mt_slot_count(mte); i++) { if (gaps[i] != 0) { pr_err("gap %p[%u] beyond node limit != 0\n",