From patchwork Tue Nov 21 10:18:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shiju Jose X-Patchwork-Id: 13462761 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E924C61D88 for ; Tue, 21 Nov 2023 10:19:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 536616B03DA; Tue, 21 Nov 2023 05:19:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 499516B03DC; Tue, 21 Nov 2023 05:19:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 311E26B03FE; Tue, 21 Nov 2023 05:19:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 189B76B03DA for ; Tue, 21 Nov 2023 05:19:08 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D1587A0A5E for ; Tue, 21 Nov 2023 10:19:07 +0000 (UTC) X-FDA: 81481563534.09.6FB83C6 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf08.hostedemail.com (Postfix) with ESMTP id D2E60160003 for ; Tue, 21 Nov 2023 10:19:05 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700561946; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mFq0betXAZgTTeBy8rpZ+XK2oHjPQjaBYTMsTAAeMMs=; b=aOPsdbMiDHYIMgTksswnJ6anSx9sxoLMjH+04xUhXbnsdtfdhxA1N296+EGSe1b5WqDzLf /TUiCQSohnIrcOjPvLqUaoYpPUb458QZvZOh1BGhRLM/fo90EejP1PoSTm2KrHeoSfVxGV 8XKy2ckhNny9Bd7lzgf1VRxHA+6+rlw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700561946; a=rsa-sha256; cv=none; b=xl9V6XGSZv0E330NwCyBjI3ZKH9pGMRmRpSbJedcHVmeMddYKk614f8edn39AGGmybP/Ox sg4ZLKnniRJOw18zMdE46TPQ4SBnTZffukiP+BUPRLIlEnB9FRUDvkJBK0ton3F4smGmk7 uUwIgguGHWFKAPKC4y9pt/tLY+vRn94= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from lhrpeml500006.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4SZKwY56B8z67nhP; Tue, 21 Nov 2023 18:14:05 +0800 (CST) Received: from SecurePC30232.china.huawei.com (10.122.247.234) by lhrpeml500006.china.huawei.com (7.191.161.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 21 Nov 2023 10:19:01 +0000 From: To: , , , , , , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH v2 03/10] cxl/mbox: Add SET_FEATURE mailbox command Date: Tue, 21 Nov 2023 18:18:36 +0800 Message-ID: <20231121101844.1161-4-shiju.jose@huawei.com> X-Mailer: git-send-email 2.35.1.windows.2 In-Reply-To: <20231121101844.1161-1-shiju.jose@huawei.com> References: <20231121101844.1161-1-shiju.jose@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.122.247.234] X-ClientProxiedBy: lhrpeml100005.china.huawei.com (7.191.160.25) To lhrpeml500006.china.huawei.com (7.191.161.198) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: D2E60160003 X-Rspam-User: X-Stat-Signature: 6tgjt6wwzis7thydnfjch4xe64xctgt1 X-Rspamd-Server: rspam03 X-HE-Tag: 1700561945-555234 X-HE-Meta: U2FsdGVkX1+ISSkwilwWX+xRywOoV7/YUNjURS+WdCQHGwm9piVVOUOUmCjQoa0x9wliqJr3sgMBaguo+Zvijfi5+fJUoAsdoSU7oaQK8cc8dDeJhDoPvqmItA1tWSjcPW1sMjDKLUXHdOqkru0xLDXleS/D+65xujf2VQLA9hHG80TG/ec5mDXPiNtwbMxnhsT+kqzY4kjb2SfdyNe3537zmu4gVW7fYykcKwpBP4yWFPs5wVRP5jcoFhNAGfwJ0joKo9Oy9UFXcoDAuSHH11qfuZ+dAdn0Y2PvmHkFhx3lySjl8A3pNRjNYrjGbqzlwMxB2FIUYe1H+PZ0Pt+0NQvse84WnKAVstkmO4JmPyM/V/p8RR4BmcaoDzmG0KmaeTYqlp/TpuxK+9gVmgkETw7zIuxwkt0tgp7TFMY549C/TJ/BuLn4jRTSf5tVKFM9EdmDU9IKWZiQ8EL32au1nSi9A8L7UFe/58mSSljjen0eTL7PdmUSChgUDZK1wvNRnJFq+T0kfYarlwmGB+V9IxCL9nW8/X9IjIrWwYxBbupIjIdPnwx3tzq8piqxs9g+j2oXqQI0RZiSqmLlYMiVY8pNeWeyWxqyV8sbJOm5SAlkQTnN6wuPOeqQ44clkAkjjnkOTV+y+xfxvz+utAJapd8lSHJ1SMTtyFkcTgDjoMNZB29CKnJkTqSQOsKWw8kIusRG1m5tsAfMorOmwlfMGhQuGiUTuh3vT1cuARDcca+zAGW9XqcmGi7qvD5yNsG0aKmVLHdE3Z7X0y6B8OHBJHl8OV8ZxZabxauW8WAstzflP1uKfUJFN19pRsG9e9uyBPkUODQzpDgzDjfj4ekQLzpSlHOgdz9YGG4+qjw773nKUjSFqrabKfCMOeJXIqhpxZwotVX2mI5abL7yEMHI/yJhB5XmYwjwh53KhqGaDzMXlv4cjavhE1ERN4h3Q7zITfGzCkh1ysEbkZTAeLx cdXe3die S82mMl7ycNRYhw/D/47+22s/UHJbRoMoh/o3+jq2/AmVSUhUoJv47MocJCSkJuxhPHuLGYZ/ISF6wkm+LTKjknE6TAIP1rlzZq5v6xrj8aGqxXGcSptCbUtnUvVJOh2gWVHPXCt3XUI4Geh9nauHtuC/V/p6n5wp1+owD2NC/x1o7oIEHnF3TEfMo/AmQAm5ZYjidceMCvsu6hWg2Xn5MIm5AwwEnxObUZyCwHJRiQlTosfA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Shiju Jose Add support for SET_FEATURE mailbox command. CXL spec 3.0 section 8.2.9.6 describes optional device specific features. CXL devices supports features with changeable attributes. The settings of a feature can be optionally modified using Set Feature command. Signed-off-by: Shiju Jose --- drivers/cxl/core/mbox.c | 15 +++++++++++++++ drivers/cxl/cxlmem.h | 27 +++++++++++++++++++++++++++ include/uapi/linux/cxl_mem.h | 1 + 3 files changed, 43 insertions(+) diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c index 2675c616caec..d892b07446ca 100644 --- a/drivers/cxl/core/mbox.c +++ b/drivers/cxl/core/mbox.c @@ -65,6 +65,7 @@ static struct cxl_mem_command cxl_mem_commands[CXL_MEM_COMMAND_ID_MAX] = { CXL_CMD(GET_SCAN_MEDIA_CAPS, 0x10, 0x4, 0), CXL_CMD(GET_SUPPORTED_FEATURES, 0x8, CXL_VARIABLE_PAYLOAD, 0), CXL_CMD(GET_FEATURE, 0x15, CXL_VARIABLE_PAYLOAD, 0), + CXL_CMD(SET_FEATURE, CXL_VARIABLE_PAYLOAD, 0, 0), }; /* @@ -1350,6 +1351,20 @@ int cxl_get_feature(struct cxl_memdev_state *mds, } EXPORT_SYMBOL_NS_GPL(cxl_get_feature, CXL); +int cxl_set_feature(struct cxl_memdev_state *mds, void *feat_in, size_t size) +{ + struct cxl_mbox_cmd mbox_cmd; + + mbox_cmd = (struct cxl_mbox_cmd) { + .opcode = CXL_MBOX_OP_SET_FEATURE, + .size_in = size, + .payload_in = feat_in, + }; + + return cxl_internal_send_cmd(mds, &mbox_cmd); +} +EXPORT_SYMBOL_NS_GPL(cxl_set_feature, CXL); + int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, struct cxl_region *cxlr) { diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h index 92c1f2a44713..46131dcd0900 100644 --- a/drivers/cxl/cxlmem.h +++ b/drivers/cxl/cxlmem.h @@ -508,6 +508,7 @@ enum cxl_opcode { CXL_MBOX_OP_GET_LOG = 0x0401, CXL_MBOX_OP_GET_SUPPORTED_FEATURES = 0x0500, CXL_MBOX_OP_GET_FEATURE = 0x0501, + CXL_MBOX_OP_SET_FEATURE = 0x0502, CXL_MBOX_OP_IDENTIFY = 0x4000, CXL_MBOX_OP_GET_PARTITION_INFO = 0x4100, CXL_MBOX_OP_SET_PARTITION_INFO = 0x4101, @@ -817,6 +818,31 @@ struct cxl_mbox_get_feat_in { u8 selection; } __packed; +/* Set Feature CXL 3.0 Spec 8.2.9.6.3 */ +/* + * Set Feature input payload + * CXL rev 3.0 section 8.2.9.6.3; Table 8-81 + */ +/* Set Feature : Payload in flags */ +#define CXL_SET_FEAT_FLAG_DATA_TRANSFER_MASK GENMASK(2, 0) +enum cxl_set_feat_flag_data_transfer { + CXL_SET_FEAT_FLAG_FULL_DATA_TRANSFER = 0x0, + CXL_SET_FEAT_FLAG_INITIATE_DATA_TRANSFER = 0x1, + CXL_SET_FEAT_FLAG_CONTINUE_DATA_TRANSFER = 0x2, + CXL_SET_FEAT_FLAG_FINISH_DATA_TRANSFER = 0x3, + CXL_SET_FEAT_FLAG_ABORT_DATA_TRANSFER = 0x4, + CXL_SET_FEAT_FLAG_DATA_TRANSFER_MAX +}; +#define CXL_SET_FEAT_FLAG_MOD_VALUE_SAVED_ACROSS_RESET BIT(3) + +struct cxl_mbox_set_feat_in { + uuid_t uuid; + __le32 flags; + __le16 offset; + u8 version; + u8 rsvd[9]; +} __packed; + /* Get Poison List CXL 3.0 Spec 8.2.9.8.4.1 */ struct cxl_mbox_poison_in { __le64 offset; @@ -949,6 +975,7 @@ int cxl_get_supported_features(struct cxl_memdev_state *mds, void *feats_out); int cxl_get_feature(struct cxl_memdev_state *mds, struct cxl_mbox_get_feat_in *pi, void *feat_out); +int cxl_set_feature(struct cxl_memdev_state *mds, void *feat_in, size_t size); int cxl_poison_state_init(struct cxl_memdev_state *mds); int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, struct cxl_region *cxlr); diff --git a/include/uapi/linux/cxl_mem.h b/include/uapi/linux/cxl_mem.h index b20de60bfc71..8c89d323cc41 100644 --- a/include/uapi/linux/cxl_mem.h +++ b/include/uapi/linux/cxl_mem.h @@ -48,6 +48,7 @@ ___DEPRECATED(GET_SCAN_MEDIA, "Get Scan Media Results"), \ ___C(GET_SUPPORTED_FEATURES, "Get Supported Features"), \ ___C(GET_FEATURE, "Get Feature"), \ + ___C(SET_FEATURE, "Set Feature"), \ ___C(MAX, "invalid / last command") #define ___C(a, b) CXL_MEM_COMMAND_ID_##a