Message ID | 20231122211200.31620-11-gregory.price@memverge.com (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFD83C61D9C for <linux-mm@archiver.kernel.org>; Wed, 22 Nov 2023 21:12:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 653EB6B063B; Wed, 22 Nov 2023 16:12:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D9DE6B063C; Wed, 22 Nov 2023 16:12:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 405EA6B063D; Wed, 22 Nov 2023 16:12:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 27B346B063B for <linux-mm@kvack.org>; Wed, 22 Nov 2023 16:12:39 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F2EF981648 for <linux-mm@kvack.org>; Wed, 22 Nov 2023 21:12:38 +0000 (UTC) X-FDA: 81486839196.09.3B5E6A4 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by imf18.hostedemail.com (Postfix) with ESMTP id 1E0AE1C0017 for <linux-mm@kvack.org>; Wed, 22 Nov 2023 21:12:35 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=S6vwlMjo; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of gourry.memverge@gmail.com designates 209.85.210.194 as permitted sender) smtp.mailfrom=gourry.memverge@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700687556; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HOrPhfU2mXxyBlZrT3heEZSZHpuQWnnIT7HedEB0hRs=; b=EgLs4o/qlrBCkSZU1o6IBpuSvdf/9QNw5kSsVqqCA/OLoYQURXDMFIpQD4VtruOjiQb0dz bl57IyeGY3Pnuwg6UCIP9LGgJKEeeHd6TvM0MzQUhGA2Rno55uCpIRBj70jHlwEbWAe5tO W91WSQxy+Vk0nvk5EGft5sk8MszK2DU= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=S6vwlMjo; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of gourry.memverge@gmail.com designates 209.85.210.194 as permitted sender) smtp.mailfrom=gourry.memverge@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700687556; a=rsa-sha256; cv=none; b=YsIFPksN4sdy7ZX0mGNAbWVbC10BCuIljOh0zNhoJwzFE3sw7c0vgnOypb1hB3qQGN5Awj hGGMpKGll9xHRTTvnYMgl8+zkZe/+Wui+7HGYxhmuw+fmSBDRoMtCOWiFd4xQpvtarARUd FwC5o5xyUByX0jppgdmmJc5LB/l2sl8= Received: by mail-pf1-f194.google.com with SMTP id d2e1a72fcca58-6c431b91b2aso233529b3a.1 for <linux-mm@kvack.org>; Wed, 22 Nov 2023 13:12:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700687555; x=1701292355; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HOrPhfU2mXxyBlZrT3heEZSZHpuQWnnIT7HedEB0hRs=; b=S6vwlMjoK2NhbtpOKUdZAtLmY/A0u1KcaxoSyCBHGI1bQVlEeTncR6PFUnBODDAkVY +yJ1Tw2t78skpMLNQT2Zct1eFO6e5ePWNhiCxj4M02lqEVSx0vyhxx7dbqiDQjUEWwft wWsVx08lMyJ1c3f/INLykai5tZpxnlYEQ1Rcdna3riwg41K9VcdECcpk5uLKttOpeExq +bXhS9iQrpNwnSOQVS4X5b8JPUJSdedO3hrt1Y2zflWFO+G/r2Jc8409/xIkrYlOb8bf avAbG9HKuDMncAqtyd9MwB9H2lKSGmpA+9iHVILqu7LQ2Ro1ySEk8s4vz4FCNrxJaE8c b5UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700687555; x=1701292355; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HOrPhfU2mXxyBlZrT3heEZSZHpuQWnnIT7HedEB0hRs=; b=rOwYEpQ+GV6BrBOg9FjdgJ6Igb2MEgq1Wh8wSBI6gBYDNPx7+vgAoDkm3sWu3X3dqi KWrr1T5uQNlj8YUzzp9ItEWc7Ry1S1JdZC4U5Q6xS2DHraW7itctT4OzZpcw52O3Mlf2 CAtOYQcJB1CYAImmLJO1tndmL/vhaC7RX6oTgi19knfXbzLRRcoCNl8eLhnrjUNVCddA 95g9s9sJRF2GU8NVBU3oN01VjtLA0xOSa4UsPLQMTS31mw0AnbE340Qd4TA8uIhjLeOl QDfyFMKVB24d790+Lp+5D4w+FluTsuZ7L2CPru2QCAWqFWA2J3cz6qqZQdNvF2BgXzFK 0rqw== X-Gm-Message-State: AOJu0Yxx6c+AdzYLYjWNZcPQBNypD3lOXijisweAx4bi/nPMxzM1iu64 6qNOiG0e/GMgFkBzcC0M/XYpcr3+bzVf X-Google-Smtp-Source: AGHT+IEMVmGwOk2fW31bSZrZqUdP6V2qhUklPoSlj+1Lun+mapADWEqdgcI4ZGVd2ENv41y7cSvJXA== X-Received: by 2002:a05:6a21:9982:b0:189:11e8:6237 with SMTP id ve2-20020a056a21998200b0018911e86237mr4066108pzb.51.1700687554935; Wed, 22 Nov 2023 13:12:34 -0800 (PST) Received: from fedora.mshome.net ([75.167.214.230]) by smtp.gmail.com with ESMTPSA id j18-20020a635512000000b005bdbce6818esm132136pgb.30.2023.11.22.13.12.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 13:12:34 -0800 (PST) From: Gregory Price <gourry.memverge@gmail.com> X-Google-Original-From: Gregory Price <gregory.price@memverge.com> To: linux-mm@kvack.org Cc: linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, arnd@arndb.de, tglx@linutronix.de, luto@kernel.org, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, mhocko@kernel.org, tj@kernel.org, ying.huang@intel.com, Gregory Price <gregory.price@memverge.com> Subject: [RFC PATCH 10/11] mm/mempolicy: mpol_parse_str should ignore trailing characters in nodelist Date: Wed, 22 Nov 2023 16:11:59 -0500 Message-Id: <20231122211200.31620-11-gregory.price@memverge.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20231122211200.31620-1-gregory.price@memverge.com> References: <20231122211200.31620-1-gregory.price@memverge.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 1E0AE1C0017 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: qm69iaoi4swijq46ru68a9fugiq5fdoe X-HE-Tag: 1700687555-372204 X-HE-Meta: U2FsdGVkX1+etQ7Jc+349iNRxwHRFsfqsY1ZC17wxd//4NGvuaBmzLUIulLx9wx+ZJB6V6IDnjLViudzTaxSsKtIdeSn6NPdAAB0tPHXpxZqMt85EYHN3eIMvi2xM78m0Q40cr15+Dmi8HNqpQTh3I3TGDfTOJmLqMeWKN5COuxPnJ7iVDozaa86a8z5dwLuuQ04+D3HAvJ2IoJXwCxCC7s2514BpwAD7JzHcNDGyOb7BOgBfSOeoaC57c+mmc7gWVtspP1TIYDyl0/fYkFJqXj4A0r9ykJNrjgtr+RqjxlIwT9lI4mA3L1PeidRV2j/D/TUr8jJyMa7M3PncmTe6oEEp3n3+yj3ftJF18GI80EWomDajFNrBS86FvBHhXkTa/HIif4Yx1Fdi/yIcTeRzUvL4M7iDD2vkrDr5Bzs+4naUuJRE9ALOryainbhLoEIkQ+a8FzDMp1kt5WWg/2u6JYmCmMWnsv8Y74R9H+/1FLytza4lEEuQ873zjo1HwLq3tBLccQNPDWKQbyzSbjtzo14y8qGWeQOvMMe6DB0daPc3oZUCIb6fMLgi8E/WDwVX9MzKqtVtbJP86GPB19HoX8ubEhnwccluoGGMQ+r53yrW3NvqnBU9Yddg6EHwANYVIRnhJKEfTkA+Bfh6pme+PG3p8MV8LxK4uwCCAkPD8t15x1c4nfTsqqd8r5d2CBuafS1tnjsFWhai29Jaw1CBZcg3KlL9VyjCHDeNHejbNUJawXRhPE7baPvQ+NUiv435UAYS0xjgiTAFlucHu5N2f0rF7LqaVR2rQjxD1LZEiB2akETQ/DS95O6ql+5R5/k1NbxTjDDBFTDnC8HWyptceI2VCSbza+LOvtkZ6uQRWAUcOhJo+KpzoUbxb3cWcV0OQpetZnsw8WAqIGL6gLSpZskntd0FgaWZSzNJXBAPRHq6Or9qvLtG4ElDVpnUkwJmb2vUOFiXFTLLUDJiiP 4ZkRXq4D WcdktL15tsWgDQ1I60cUINX4x8fo2eG5JQteG+tAeybynqwftHflxE7pGVwSctgORaa6awxeWJP+3sNKneMhU6v20hP7X8MoNMLNTtgXLICQbrbekf8t4+f8FanKFIzZavdrrKWF7yI3roVixZWKqVHGg8T3gNDFC1IUwCxwcbUZyQw9P80arugAtynaKpMRCsXcptRgTtooVlqF8sVvCHN8JzM5MWhnMqSFKUW/YLG+0X1Fs3q/1SVCMKCIuwCS1xOf2uzwS6qXZtwsf2G2znGdXS4nkrmP41L3ByNDnIcNQsGMaFJLQck5aCq9bjjC/BmUCy+qr6IqW/MrwZFw5aNgx2Gwbxvq2l7pEPRPIVp1Ja6OyeNxMIeZRWaz/dtSEcDWRZ6HF4HBC5f8OmSYiLN/jT3Aev20SuawVBYltrpNredyisj6fmgraC6IoBXhXfmf7+k57lmF68SrAYlWpDvQlONz09+i8iSWYazIljg//B531TA24qjzxq1y2lkOAfX0lpzxwzV3Rxk8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> List-Subscribe: <mailto:majordomo@kvack.org> List-Unsubscribe: <mailto:majordomo@kvack.org> |
Series |
mm/mempolicy: Make task->mempolicy externally modifiable via syscall and procfs
|
expand
|
diff --git a/mm/mempolicy.c b/mm/mempolicy.c index a418af0a1359..eac71f2adfdc 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -3159,12 +3159,7 @@ int mpol_parse_str(char *str, struct mempolicy **mpol) * nodelist (or nodes) cannot be empty. */ if (nodelist) { - char *rest = nodelist; - while (isdigit(*rest)) - rest++; - if (*rest) - goto out; - if (nodes_empty(nodes)) + if (nodes_weight(nodes) != 1) goto out; } break;
When validating MPOL_PREFERRED, the nodelist has already been parsed and error checked by nodelist_parse. So rather than looping through the string again, we should just check that the weight of the nodemask is 1, which is the actual condition we care to check. This also handles the case where newline characters are present. Signed-off-by: Gregory Price <gregory.price@memverge.com> --- mm/mempolicy.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)