From patchwork Thu Nov 23 06:44:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kasireddy, Vivek" X-Patchwork-Id: 13465859 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29FFDC61D97 for ; Thu, 23 Nov 2023 07:08:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB0FF6B0645; Thu, 23 Nov 2023 02:08:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B5BEA6B0647; Thu, 23 Nov 2023 02:08:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93B446B0649; Thu, 23 Nov 2023 02:08:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 783166B0645 for ; Thu, 23 Nov 2023 02:08:37 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 50B7580834 for ; Thu, 23 Nov 2023 07:08:37 +0000 (UTC) X-FDA: 81488341074.25.6E105CA Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by imf09.hostedemail.com (Postfix) with ESMTP id 2B64014002C for ; Thu, 23 Nov 2023 07:08:34 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=QDWqRNbd; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf09.hostedemail.com: domain of vivek.kasireddy@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=vivek.kasireddy@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700723315; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OFWxI1i+p4efvmikRdB46knSq10ZwkVaViiQ0SsvQMA=; b=Bk1tKqMZbjCtIJiJE6D7fxqDbcnv8p6TGJDeIPokPsq12Jh3OEzLKAmdzrbOJ+juhma9GJ pEjjHCouAYqUFD0X8qQ5KNdGXuzU7WdLyu7aiX2H3Oko1YG3YGuds+kAuULuwntk8vPTuH JGCK3v7WNBrskgEJyX4Hx5DpbriBsx0= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=QDWqRNbd; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf09.hostedemail.com: domain of vivek.kasireddy@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=vivek.kasireddy@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700723315; a=rsa-sha256; cv=none; b=j6Zvreog2YcsEHdLtliCnLSuzyd6+H/aShYsp9LI8Mbq6uJy3Ht/k23ybkh0S70EwihLgg c9T0HyVuenhGVHlUdOTIchm6Z0v7kYijJYBmVtz/gTQUS1OHoO5F5str8obDUqCuLA2JPL QTv1kN77WHa1eQOsDanl8LxtVv344g8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700723315; x=1732259315; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=U5Op4CjhDDAHfKtiDzpe6+9a1b7R8CllBxVTE/TesJE=; b=QDWqRNbdWXACEU9ruzqBiv2e6l1eunZ4Mai41qgX5qprJAD0ZYxaF83K F0mVnYT46CMMaTQ9QzJJO230+Mpf/OGT+APmikwXNd/o8PUmHKWisoZty xh4eo8d1fhvzt3btPNt6UkWdRHR5Yq3pldVWxI1qUPFB1Hfa/9uSlab1y ZcyvpEMqvM4UcE5s4ggYVwj6Kyp51fu55/MrVm9DOlx421v5orcWsuwmM Eai1Gz0qgJDVNbs65/jMd39ua861VvcUElvJoQAwQ6QzP1hxfPYF9Jvt1 HsDYnvMw7ClI1qYZDB6glr0smb9VM9w/xrlWhv5v/NP8h9OcSYCogaTYR A==; X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="382612317" X-IronPort-AV: E=Sophos;i="6.04,220,1695711600"; d="scan'208";a="382612317" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 23:08:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,220,1695711600"; d="scan'208";a="8757714" Received: from vkasired-desk2.fm.intel.com ([10.105.128.132]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 23:08:23 -0800 From: Vivek Kasireddy To: dri-devel@lists.freedesktop.org, linux-mm@kvack.org Cc: Vivek Kasireddy , David Hildenbrand , Daniel Vetter , Mike Kravetz , Hugh Dickins , Peter Xu , Jason Gunthorpe , Gerd Hoffmann , Dongwon Kim , Junxiao Chang Subject: [PATCH v5 1/5] udmabuf: Use vmf_insert_pfn and VM_PFNMAP for handling mmap Date: Wed, 22 Nov 2023 22:44:39 -0800 Message-Id: <20231123064443.1035709-2-vivek.kasireddy@intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231123064443.1035709-1-vivek.kasireddy@intel.com> References: <20231123064443.1035709-1-vivek.kasireddy@intel.com> MIME-Version: 1.0 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 2B64014002C X-Stat-Signature: cmzdtodcmexyi6mghhg8ohd3ebrnu9zd X-Rspam-User: X-HE-Tag: 1700723314-841956 X-HE-Meta: U2FsdGVkX19VWhgvHsxS0da4YADcTX67LbINaNyffd9GJiqtw3Aw8WGNyrXg57fYumU8TtB/m5Y4ZChwCeEO9ujDV42l0XeJjo+O5Y6cDOgaGgWQYzG1VUa7mm/+9fJQcQ5DPxcMQotg0IkN6ahzhwcmj1E2qlQ7yDOq/45WolNuCbAjpeF4QKxQEsNC7LL0OHeQHz1onGBdkyU7WbxGCLI8Qh+znySi9M6STtefZaEmz1i+S59U3/ErHL68aRRJzGLCB2nUfiUgLt/x7HOt4V6qONrXhwhR4BD/DyWleMVnRK6ihbyOc2eyKcc++8PYHe2hKo4Zz2r3f2jOf2A5zXM5KnAjii9XS9zOdXOrc4hrYHqd4HfSfcNBDqvFrwmYIHATYEgrJMoET4Kn6tQsdR1aCfFQ4XVTKRavvIViYrMtZufBDMi+DXh1d5US6xk38G9xvLQnJG7oWRnjrmC7V9uJEJtx0tyMhIj9dlqq1U6qqc86e3GKao3pdBfcfrsc+XWz+4HsB+kes/Pbzlp6RNf6phKrxQGXXs2LFvCW7bbKarbKuAi/Y22wjbUcZXJffmg8IJjSmuox2oUyKlUzdJR/DkDZio+/Ct/ZQwHPFiU8HVlwdIwg0M5D7XjpWnGvHzTuIojXLOzIYb1hpicdGgYZSkLfQTRjOPgXGUs+kuPL5YuJyCCuyb59D3eprm9se/a2jbIxuP6VaxqAn1XdM6vfACl2XAhQ5Fqyr/JKXqM0vtHVbWTNn+TbPHp97b6Vil9x1tcZ/OB3C3Am2IfxFDdnO0QTld75RUNwHDZuEn4tCB7DPFH3f1V0Zj3HhRYMaG/B/mTvhU+JzlL0xmDm3M0jP2b7DSd4AOFB1b7OE4opYCgYrsXiGZBdqQHsIuF+1OhHZfH3Y0cYfMRsz4OoIH09alA7zxWaw4vNPBpqeI/9rqxE8MLFNsLEv+V0XOyNKpqP7eoboTqMuNKG6j5 ajE68Upn qZ/4iXU/H8TynNvYfatA8QktX+BXkW2Ffe1TrfaVnYjdtbgsIRozJ7i6aZ5r46DUjStRUNkwwMMAQ1GsaJe907gzyR2boeYRPSPVZ8kZdJ21m3pZJM0FP4QWdU8ZNsGVlenxZxzLNp03umZ7AQgQ9zyyeEV8urjhxu5I3x2IBreraBu3sXQ73pgJu4OjWIBC6Q8FnCKRKXk0pptiJOh301OqZ8uJRaVYm1aMqBGOyWoZ86FvfBfoXcw4aRIqze7RFbIju3OYxIZWokIN1C5i1GTE0Ox4CWhTUpw8Kh2gT5kkOXdo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Add VM_PFNMAP to vm_flags in the mmap handler to ensure that the mappings would be managed without using struct page. And, in the vm_fault handler, use vmf_insert_pfn to share the page's pfn to userspace instead of directly sharing the page (via struct page *). Cc: David Hildenbrand Cc: Daniel Vetter Cc: Mike Kravetz Cc: Hugh Dickins Cc: Peter Xu Cc: Jason Gunthorpe Cc: Gerd Hoffmann Cc: Dongwon Kim Cc: Junxiao Chang Suggested-by: David Hildenbrand Acked-by: David Hildenbrand Signed-off-by: Vivek Kasireddy --- drivers/dma-buf/udmabuf.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c index c40645999648..820c993c8659 100644 --- a/drivers/dma-buf/udmabuf.c +++ b/drivers/dma-buf/udmabuf.c @@ -35,12 +35,13 @@ static vm_fault_t udmabuf_vm_fault(struct vm_fault *vmf) struct vm_area_struct *vma = vmf->vma; struct udmabuf *ubuf = vma->vm_private_data; pgoff_t pgoff = vmf->pgoff; + unsigned long pfn; if (pgoff >= ubuf->pagecount) return VM_FAULT_SIGBUS; - vmf->page = ubuf->pages[pgoff]; - get_page(vmf->page); - return 0; + + pfn = page_to_pfn(ubuf->pages[pgoff]); + return vmf_insert_pfn(vma, vmf->address, pfn); } static const struct vm_operations_struct udmabuf_vm_ops = { @@ -56,6 +57,7 @@ static int mmap_udmabuf(struct dma_buf *buf, struct vm_area_struct *vma) vma->vm_ops = &udmabuf_vm_ops; vma->vm_private_data = ubuf; + vm_flags_set(vma, VM_PFNMAP | VM_DONTEXPAND | VM_DONTDUMP); return 0; }