From patchwork Thu Nov 23 17:43:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shiju Jose X-Patchwork-Id: 13466472 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F805C624B4 for ; Thu, 23 Nov 2023 17:44:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2711E6B067D; Thu, 23 Nov 2023 12:44:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 220B26B067E; Thu, 23 Nov 2023 12:44:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E8C96B067F; Thu, 23 Nov 2023 12:44:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0158A6B067D for ; Thu, 23 Nov 2023 12:44:10 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CADFFB6FEA for ; Thu, 23 Nov 2023 17:44:10 +0000 (UTC) X-FDA: 81489942660.06.918D2E6 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf29.hostedemail.com (Postfix) with ESMTP id 3E90F12001D for ; Thu, 23 Nov 2023 17:44:07 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf29.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700761449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=76Vjr9A8OIcwKDK2GRWiqjut9jFAArBooGzrFSiDZFM=; b=qJqvCP26PeQNI2ILIRNKykOzheot4bSOO9v21ei3EiYJPBnVsnXn20UkKI7dXd1rkB5TuO REhSLbVyWYKsYJ7idYWJYOAhqsFQPBCYn8kD0BkRsOKjjmjTqkVu60jBCzygbFJCqD1Nqn PLdZVE59Ov08hH6bphKMKcVXFuUDjvs= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf29.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700761449; a=rsa-sha256; cv=none; b=x9pE7l9VtXslnWp3VycVHgnw7hNSVFeYFapgvWtnTshyu5pckYy4NNhRCgmZJmrceRkSli k0FQUaPUd1bIsjANwPNNmIVsHmyJMQ/lwsG5avVF9bcahKh9G7CghufrN3XLmX51pU/Xxk 2ZVMJO6QHJpooAJzaGjUkdqsIURJLfU= Received: from lhrpeml500006.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4SblnB2Vspz6K8sn; Fri, 24 Nov 2023 01:42:38 +0800 (CST) Received: from SecurePC30232.china.huawei.com (10.122.247.234) by lhrpeml500006.china.huawei.com (7.191.161.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 23 Nov 2023 17:44:03 +0000 From: To: , , , , , , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH v3 01/11] cxl/mbox: Add GET_SUPPORTED_FEATURES mailbox command Date: Fri, 24 Nov 2023 01:43:44 +0800 Message-ID: <20231123174355.1176-2-shiju.jose@huawei.com> X-Mailer: git-send-email 2.35.1.windows.2 In-Reply-To: <20231123174355.1176-1-shiju.jose@huawei.com> References: <20231123174355.1176-1-shiju.jose@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.122.247.234] X-ClientProxiedBy: lhrpeml100003.china.huawei.com (7.191.160.210) To lhrpeml500006.china.huawei.com (7.191.161.198) X-CFilter-Loop: Reflected X-Rspam-User: X-Stat-Signature: t8d54gkgqr8mmnjexuzdr7mikbxfiq6e X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3E90F12001D X-HE-Tag: 1700761447-852566 X-HE-Meta: U2FsdGVkX1/U44cPYKL3GlBi/Mkqn4/hwXuwqBz/v7Nmc1T93Vb7f6Ggd26JFv6LLbmoK/9nKNCma5/cPTWa4xF0CBB3YzdLRKS6oMlbouPeZjqTh/71gI6PFP4/KAQ5E3iOvGS9KChUYDwfbJhM6yA/U/7fITRdJBWbBP58ErqMM5UQJYj4ctqsEUqQ6J0j3QyKclGqqYl4kthW3TRkKY2s7JSha7r3dTZ3qXGUPRnA3HSdKTEl1ITmWDHfTLQIg3fbtIxj92MWIrwWygoWhxOIaL72BGfsfwbfZrPsiA5dqFhB8KKFC6g2wZTkZ9XZPE8zDrSD4D2PucymDznYuIyllfjvnyeoE7dFrusVl7dMf0/VX+puXQdnvLfnrHYstQVHFthEjBKm/5uyHLtpXYZ9RVkF2nTAWV3BCGBuP1w5ZHf6WpU66KAf+cgpwjBaWtLJRKXufXXndmAJKKACt7vTJOk/Z08CrJmqXpNT+zwvaSSLQ4vAfcPtf4nS8k2PusyXE2U3J+hsi7/+npuhmQSfx8iV7QMc77/Jwto4F45r3rDF22AgqwQbEy217yrKzRIRiia5K5htPenS9XEhoyKI4Rnk0xpk6kALVOem1BsNg8/0L/H/ukuGjfZDbyOoxOuYEPp4tVanv/wPuPjLadXkylcJUCGDwiC6kboMpbJ5+r8xxL9GCeCXJ8oVevhjmhgazidZe9Y1c5zx/+u4MFK11iLPLj1xXGd5lcN38NN7dI95DQj0EV3RmxoBnNt3lcbvWZR2ONIt+5iRygMeuIp6efq/vPmC+wyNv4+atKEuk5rpWVfnZoNADxTSBAly1JSbHrZGNW7j4zP/87VKwrb3nNnvvqO3TT4xRa6OmBE1tb4jWRIn/rv2Y+XQjf25vRLaSwjiwhRtND6+62mLxmtC1ZUvrsVSWu2m6VCljKn8nqAKMhKFlcaC2kZ3FbfGRxYpGcLi5eBK43W5nTp JnW2UIMf Kz87AT6lBpMl3UhLJXwozQ3yaZVIIjX+cQz5QgVrAZ/R64IDVzoXHN0mlhD7dok+kej4a4Q8NdfjOLnvjE+7LHR6Qk4LFTYeyLV9iaJGI42WSZUJ9Quslq2PXYu1Mph43M7efphRP+mKdNpaDsBIDygwEbhkjTw3q+J0vohiTUPVJwRdrGvvNT6gHyuG3GAv0CykJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Shiju Jose Add support for GET_SUPPORTED_FEATURES mailbox command. CXL spec 3.0 section 8.2.9.6 describes optional device specific features. CXL devices supports features with changeable attributes. Get Supported Features retrieves the list of supported device specific features. The settings of a feature can be retrieved using Get Feature and optionally modified using Set Feature. Signed-off-by: Shiju Jose --- drivers/cxl/core/mbox.c | 23 ++++++++++++++++ drivers/cxl/cxlmem.h | 59 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 82 insertions(+) diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c index 36270dcfb42e..eb2741446b5f 100644 --- a/drivers/cxl/core/mbox.c +++ b/drivers/cxl/core/mbox.c @@ -1303,6 +1303,29 @@ int cxl_set_timestamp(struct cxl_memdev_state *mds) } EXPORT_SYMBOL_NS_GPL(cxl_set_timestamp, CXL); +int cxl_get_supported_features(struct cxl_memdev_state *mds, + struct cxl_mbox_get_supp_feats_in *pi, + void *feats_out) +{ + struct cxl_mbox_cmd mbox_cmd; + int rc; + + mbox_cmd = (struct cxl_mbox_cmd) { + .opcode = CXL_MBOX_OP_GET_SUPPORTED_FEATURES, + .size_in = sizeof(*pi), + .payload_in = pi, + .size_out = (size_t)pi->count, + .payload_out = feats_out, + .min_out = sizeof(struct cxl_mbox_get_supp_feats_out), + }; + rc = cxl_internal_send_cmd(mds, &mbox_cmd); + if (rc < 0) + return rc; + + return 0; +} +EXPORT_SYMBOL_NS_GPL(cxl_get_supported_features, CXL); + int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, struct cxl_region *cxlr) { diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h index a2fcbca253f3..d831dad748f5 100644 --- a/drivers/cxl/cxlmem.h +++ b/drivers/cxl/cxlmem.h @@ -506,6 +506,7 @@ enum cxl_opcode { CXL_MBOX_OP_SET_TIMESTAMP = 0x0301, CXL_MBOX_OP_GET_SUPPORTED_LOGS = 0x0400, CXL_MBOX_OP_GET_LOG = 0x0401, + CXL_MBOX_OP_GET_SUPPORTED_FEATURES = 0x0500, CXL_MBOX_OP_IDENTIFY = 0x4000, CXL_MBOX_OP_GET_PARTITION_INFO = 0x4100, CXL_MBOX_OP_SET_PARTITION_INFO = 0x4101, @@ -740,6 +741,61 @@ struct cxl_mbox_set_timestamp_in { } __packed; +/* Get Supported Features CXL 3.0 Spec 8.2.9.6.1 */ +/* + * Get Supported Features input payload + * CXL rev 3.0 section 8.2.9.6.1; Table 8-75 + */ +struct cxl_mbox_get_supp_feats_in { + __le32 count; + __le16 start_index; + u16 reserved; +} __packed; + +/* + * Get Supported Features Supported Feature Entry + * CXL rev 3.0 section 8.2.9.6.1; Table 8-77 + */ +/* Supported Feature Entry : Payload out attribute flags */ +#define CXL_FEAT_ENTRY_FLAG_CHANGABLE BIT(0) +#define CXL_FEAT_ENTRY_FLAG_DEEPEST_RESET_PERSISTENCE_MASK GENMASK(3, 1) + +enum cxl_feat_attrib_value_persistence { + CXL_FEAT_ATTRIB_VALUE_PERSISTENCE_NONE = 0x0, + CXL_FEAT_ATTRIB_VALUE_PERSISTENCE_CXL_RESET = 0x1, + CXL_FEAT_ATTRIB_VALUE_PERSISTENCE_HOT_RESET = 0x2, + CXL_FEAT_ATTRIB_VALUE_PERSISTENCE_WARM_RESET = 0x3, + CXL_FEAT_ATTRIB_VALUE_PERSISTENCE_COLD_RESET = 0x4, + CXL_FEAT_ATTRIB_VALUE_PERSISTENCE_MAX +}; + +#define CXL_FEAT_ENTRY_FLAG_PERSISTENCE_ACROSS_FW_UPDATE_MASK BIT(4) +#define CXL_FEAT_ENTRY_FLAG_PERSISTENCE_DEFAULT_SEL_SUPPORT_MASK BIT(5) +#define CXL_FEAT_ENTRY_FLAG_PERSISTENCE_SAVED_SEL_SUPPORT_MASK BIT(6) + +struct cxl_mbox_supp_feat_entry { + uuid_t uuid; + __le16 feat_index; + __le16 get_feat_size; + __le16 set_feat_size; + __le32 attrb_flags; + u8 get_feat_version; + u8 set_feat_version; + __le16 set_feat_effects; + u8 rsvd[18]; +} __packed; + +/* + * Get Supported Features output payload + * CXL rev 3.0 section 8.2.9.6.1; Table 8-76 + */ +struct cxl_mbox_get_supp_feats_out { + __le16 entries; + __le16 nsuppfeats_dev; + u32 reserved; + struct cxl_mbox_supp_feat_entry feat_entries[]; +} __packed; + /* Get Poison List CXL 3.0 Spec 8.2.9.8.4.1 */ struct cxl_mbox_poison_in { __le64 offset; @@ -867,6 +923,9 @@ void clear_exclusive_cxl_commands(struct cxl_memdev_state *mds, unsigned long *cmds); void cxl_mem_get_event_records(struct cxl_memdev_state *mds, u32 status); int cxl_set_timestamp(struct cxl_memdev_state *mds); +int cxl_get_supported_features(struct cxl_memdev_state *mds, + struct cxl_mbox_get_supp_feats_in *pi, + void *feats_out); int cxl_poison_state_init(struct cxl_memdev_state *mds); int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, struct cxl_region *cxlr);