| Message ID | 20231123174355.1176-3-shiju.jose@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | cxl: Add support for CXL feature commands, CXL device patrol scrub control and DDR5 ECS control features | expand |
Hi, kernel test robot noticed the following build warnings: [auto build test WARNING on krzk-mem-ctrl/for-next] [also build test WARNING on linus/master v6.7-rc2 next-20231124] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/shiju-jose-huawei-com/cxl-mbox-Add-GET_SUPPORTED_FEATURES-mailbox-command/20231124-014622 base: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux-mem-ctrl.git for-next patch link: https://lore.kernel.org/r/20231123174355.1176-3-shiju.jose%40huawei.com patch subject: [PATCH v3 02/11] cxl/mbox: Add GET_FEATURE mailbox command config: i386-randconfig-061-20231124 (https://download.01.org/0day-ci/archive/20231124/202311241607.cZbPFKOR-lkp@intel.com/config) compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231124/202311241607.cZbPFKOR-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202311241607.cZbPFKOR-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) drivers/cxl/core/mbox.c:1317:30: sparse: sparse: cast from restricted __le32 >> drivers/cxl/core/mbox.c:1339:30: sparse: sparse: cast from restricted __le16 drivers/cxl/core/mbox.c:1341:29: sparse: sparse: cast from restricted __le16 vim +1339 drivers/cxl/core/mbox.c 1328 1329 int cxl_get_feature(struct cxl_memdev_state *mds, 1330 struct cxl_mbox_get_feat_in *pi, void *feat_out) 1331 { 1332 struct cxl_mbox_cmd mbox_cmd; 1333 int rc; 1334 1335 mbox_cmd = (struct cxl_mbox_cmd) { 1336 .opcode = CXL_MBOX_OP_GET_FEATURE, 1337 .size_in = sizeof(*pi), 1338 .payload_in = pi, > 1339 .size_out = (size_t)pi->count, 1340 .payload_out = feat_out, 1341 .min_out = (size_t)pi->count, 1342 }; 1343 rc = cxl_internal_send_cmd(mds, &mbox_cmd); 1344 if (rc < 0) 1345 return rc; 1346 1347 return 0; 1348 } 1349 EXPORT_SYMBOL_NS_GPL(cxl_get_feature, CXL); 1350
diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c index eb2741446b5f..759b7e7e6a09 100644 --- a/drivers/cxl/core/mbox.c +++ b/drivers/cxl/core/mbox.c @@ -1326,6 +1326,28 @@ int cxl_get_supported_features(struct cxl_memdev_state *mds, } EXPORT_SYMBOL_NS_GPL(cxl_get_supported_features, CXL); +int cxl_get_feature(struct cxl_memdev_state *mds, + struct cxl_mbox_get_feat_in *pi, void *feat_out) +{ + struct cxl_mbox_cmd mbox_cmd; + int rc; + + mbox_cmd = (struct cxl_mbox_cmd) { + .opcode = CXL_MBOX_OP_GET_FEATURE, + .size_in = sizeof(*pi), + .payload_in = pi, + .size_out = (size_t)pi->count, + .payload_out = feat_out, + .min_out = (size_t)pi->count, + }; + rc = cxl_internal_send_cmd(mds, &mbox_cmd); + if (rc < 0) + return rc; + + return 0; +} +EXPORT_SYMBOL_NS_GPL(cxl_get_feature, CXL); + int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, struct cxl_region *cxlr) { diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h index d831dad748f5..92c1f2a44713 100644 --- a/drivers/cxl/cxlmem.h +++ b/drivers/cxl/cxlmem.h @@ -507,6 +507,7 @@ enum cxl_opcode { CXL_MBOX_OP_GET_SUPPORTED_LOGS = 0x0400, CXL_MBOX_OP_GET_LOG = 0x0401, CXL_MBOX_OP_GET_SUPPORTED_FEATURES = 0x0500, + CXL_MBOX_OP_GET_FEATURE = 0x0501, CXL_MBOX_OP_IDENTIFY = 0x4000, CXL_MBOX_OP_GET_PARTITION_INFO = 0x4100, CXL_MBOX_OP_SET_PARTITION_INFO = 0x4101, @@ -796,6 +797,26 @@ struct cxl_mbox_get_supp_feats_out { struct cxl_mbox_supp_feat_entry feat_entries[]; } __packed; +/* Get Feature CXL 3.0 Spec 8.2.9.6.2 */ +/* + * Get Feature input payload + * CXL rev 3.0 section 8.2.9.6.2; Table 8-79 + */ +/* Get Feature : Payload in selection */ +enum cxl_get_feat_selection { + CXL_GET_FEAT_SEL_CURRENT_VALUE = 0x0, + CXL_GET_FEAT_SEL_DEFAULT_VALUE = 0x1, + CXL_GET_FEAT_SEL_SAVED_VALUE = 0x2, + CXL_GET_FEAT_SEL_MAX +}; + +struct cxl_mbox_get_feat_in { + uuid_t uuid; + __le16 offset; + __le16 count; + u8 selection; +} __packed; + /* Get Poison List CXL 3.0 Spec 8.2.9.8.4.1 */ struct cxl_mbox_poison_in { __le64 offset; @@ -926,6 +947,8 @@ int cxl_set_timestamp(struct cxl_memdev_state *mds); int cxl_get_supported_features(struct cxl_memdev_state *mds, struct cxl_mbox_get_supp_feats_in *pi, void *feats_out); +int cxl_get_feature(struct cxl_memdev_state *mds, + struct cxl_mbox_get_feat_in *pi, void *feat_out); int cxl_poison_state_init(struct cxl_memdev_state *mds); int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, struct cxl_region *cxlr);