From patchwork Sat Dec 2 00:08:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13476685 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65CDAC4167B for ; Sat, 2 Dec 2023 00:08:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 898E98D0001; Fri, 1 Dec 2023 19:08:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8222A8D007C; Fri, 1 Dec 2023 19:08:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E9468D0001; Fri, 1 Dec 2023 19:08:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5F3158D007C for ; Fri, 1 Dec 2023 19:08:14 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 373691A033C for ; Sat, 2 Dec 2023 00:08:14 +0000 (UTC) X-FDA: 81519940908.24.B99A748 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 7D0F41C0019 for ; Sat, 2 Dec 2023 00:08:12 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="St1SM/T6"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701475692; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=geJbZJJvBae4jqe1AheshTuaF1oJvqnxOcUWPSWBKx8=; b=U/lV1qHlmtl3c8CIGatpty0PCaQx6JsTFkllt6OnRq8FWTIPmT87HoIGuuPHSurirdNh/E JkPzr0TqKpZMhZFufkKfjDm3SbJFLj4UudI8HbraM0LCo4/e4qUExPnL49pYvOfwqAb9NP 2sunsTxAHuUSp7wc+1UfR85P763CxPg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="St1SM/T6"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701475692; a=rsa-sha256; cv=none; b=LLICRqeznjdbwoCd5RUZVqAQsT/SoaxX7NgcILDNu4LdNwsSycyLJYVpn7PnywUidsmWds PeODmr1pqmY+6Gks0U5/ojlbMHES2XKBtPgUOdHMtuMlOmrPDOcGo4U/OAeeyj2TIb/ioT cp0JlA57S2ofB1VayhrT3WvhFPXzLYc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 89C7F622B7; Sat, 2 Dec 2023 00:08:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF60BC433D9; Sat, 2 Dec 2023 00:08:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701475691; bh=AwGT0TApqer7c6nSE0CIfNlDk2EEXmB7q5dDIYgH5bg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=St1SM/T6xISZDuqc/o8B1ANd9sw6LFQh8VK/f7EoOzTNUR4g7rzXiS1hZynIoPxES +nMkWRfV8caIcUBS38lTfH0DLfRc7n2PovLMBPtG7LJEzDmix7RmY0KUJsbX5bIPO5 GzEClqUyvi0tYdRq7Ekmt0QY2g0MGASEcBPdlUvVT+7/WsPmTtzUCKmVpib1y3Yu/1 B6nAGYY4WjDdUDk5tmZZ8jD2cVq1koMg0oxvSz7odEdd1TWGrzXxSeMrU1tjBQP9fR ZH7SVUwKuWrzURd6+3x387eEKnNktbMqJoeAtaux/7rvndIhARQB0ynXH+g1r8fay5 xYkJVtP412jrQ== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , Shuah Khan , damon@lists.linux.dev, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH 2/5] selftests/damon/_damon: implement sysfs-based kdamonds start function Date: Sat, 2 Dec 2023 00:08:03 +0000 Message-Id: <20231202000806.46210-3-sj@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231202000806.46210-1-sj@kernel.org> References: <20231202000806.46210-1-sj@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7D0F41C0019 X-Stat-Signature: 48jn4ocxkkdgcgqg7k58d9cznr55x6ke X-HE-Tag: 1701475692-464792 X-HE-Meta: U2FsdGVkX1+WLN5kjSf/mJlDa7ve1IyVrwVKm+qwaylFTeIUavyMnY3/WIxNuGuyDiHVM9eMErpmsEHstWaFhP5GvGP2yMJ2E+Q/MnB0sC87D4CgFpzKgM7ksQslZ9olifXHLtnDxzvbfhqyQ5PA46s5kyZkDzEnHRWzJWi0W1XWtWxNb5Uv7LZUce8QRbEIq2dcUJkCQf2SoQIkEPCSR0e6EyEfJTrtnoEFXN0lUVhvI9sG2/izv4JTVqPNYH3rM3UDbzBOJ7caCOB6CV/PrYz5lIJOorFtpp6/Icw60pDtn8wVisS6L92mFWVnp2E3Tc2rgEyrXW+gMIdg7iVhktddDDAjSHFfBrkRolt3Nnk+u71+oW/gvFsJeKBqpRQdkMi72Hgu0Oyg83nMKDL40zR4WODTZPehUlbQmLfNrStE2HVGMiiKfvVcXV3UMmfFSW0UbJCzXWBn67P4WNPR8sswCW6e4//7MdHb9MiHbP4QeLmlMze3MvT1d3Crjj4YbJ+nUe9CjvdjffWwe932qLmeJDYMG+K/98i7mKfTvLV6oo3CPVDptYXkoKcbqK1/swVprDTZbkAFPohKqM14jH/OA8tTonMuQacIbQiYKJVfwktl6ITj0F/84HXR95neGmVGi/UssVBAHZqIqKLKDcPovyWNALUOoDSg83cgMbw9IWtI6hgcIpmsSu+Oy4wbNNT3e7XCXolKXPmRH0W8mXRj2wXAUni7MLGT0oEi7LQUkcib4x2tvKJ1v++rQKn9O9UNNivpINRBmFI9JatDIYnSOoUI5OL8LHUA7YSa3DftNV5832Calb1IFO6lXIOBnr0Pupht5dJktqemJVOv3b9m7bMUxyNvdDoKl6yg/932vDqELLRg82QusJ1XIJ1NiXYGhoLUN0FXdwnV69ckdmfqjXdmABdix1wHnG6U+5FZOu4CCdY7ETAU8ZFIhLi8QVHiRzlY18RzXiEruoR DMwnn1Mp RXjV+TGNRPbWkA2erMKhoJhd7oa3LbinlQW1+wt/bqC/8wfsFVs7eNsTX4gchucS+NOAgxF5+yHDS4GSZ8N0RopmD9hhbSheXlG36bJmRrKTLwlEsdVxLfzY2mbJMA9QtHuN30Pc6Ot0S4oY2Z/2oSnJkS980yrncD8BTrrdVBtyTruMcSU5xVARUTFo7ug7jFZZSvj43NeRgctJdJgFm5LKO7TUJrvLA2aGfiQVwpyNMMJOTi5PPv6y1lAurTfQ/AjeYeq3r1rYnHQWZsDM5EI5SAD0uF1dJ6pfR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Extend the test-writing-purpose DAMON sysfs wrapper Python module to support turning DAMON on with basic parameter inputs. Signed-off-by: SeongJae Park --- tools/testing/selftests/damon/_damon.py | 206 ++++++++++++++++++++++++ 1 file changed, 206 insertions(+) diff --git a/tools/testing/selftests/damon/_damon.py b/tools/testing/selftests/damon/_damon.py index 78101846ab66..6b99f87a5f1e 100644 --- a/tools/testing/selftests/damon/_damon.py +++ b/tools/testing/selftests/damon/_damon.py @@ -1,5 +1,28 @@ # SPDX-License-Identifier: GPL-2.0 +import os + +sysfs_root = '/sys/kernel/mm/damon/admin' + +def write_file(path, string): + "Returns error string if failed, or None otherwise" + string = '%s' % string + try: + with open(path, 'w') as f: + f.write(string) + except Exception as e: + return '%s' % e + return None + +def read_file(path): + '''Returns the read content and error string. The read content is None if + the reading failed''' + try: + with open(path, 'r') as f: + return f.read(), None + except Exception as e: + return None, '%s' % e + class DamosAccessPattern: size = None nr_accesses = None @@ -18,6 +41,35 @@ class DamosAccessPattern: if self.age == None: self.age = [0, 2**64 - 1] + def sysfs_dir(self): + return os.path.join(self.scheme.sysfs_dir(), 'access_pattern') + + def stage(self): + err = write_file( + os.path.join(self.sysfs_dir(), 'sz', 'min'), self.size[0]) + if err != None: + return err + err = write_file( + os.path.join(self.sysfs_dir(), 'sz', 'max'), self.size[1]) + if err != None: + return err + err = write_file(os.path.join(self.sysfs_dir(), 'nr_accesses', 'min'), + self.nr_accesses[0]) + if err != None: + return err + err = write_file(os.path.join(self.sysfs_dir(), 'nr_accesses', 'max'), + self.nr_accesses[1]) + if err != None: + return err + err = write_file( + os.path.join(self.sysfs_dir(), 'age', 'min'), self.age[0]) + if err != None: + return err + err = write_file( + os.path.join(self.sysfs_dir(), 'age', 'max'), self.age[1]) + if err != None: + return err + class Damos: action = None access_pattern = None @@ -30,6 +82,39 @@ class Damos: self.access_pattern = access_pattern self.access_pattern.scheme = self + def sysfs_dir(self): + return os.path.join( + self.context.sysfs_dir(), 'schemes', '%d' % self.idx) + + def stage(self): + err = write_file(os.path.join(self.sysfs_dir(), 'action'), self.action) + if err != None: + return err + err = self.access_pattern.stage() + if err != None: + return err + + # disable quotas + err = write_file(os.path.join(self.sysfs_dir(), 'quotas', 'ms'), '0') + if err != None: + return err + err = write_file( + os.path.join(self.sysfs_dir(), 'quotas', 'bytes'), '0') + if err != None: + return err + + # disable watermarks + err = write_file( + os.path.join(self.sysfs_dir(), 'watermarks', 'metric'), 'none') + if err != None: + return err + + # disable filters + err = write_file( + os.path.join(self.sysfs_dir(), 'filters', 'nr_filters'), '0') + if err != None: + return err + class DamonTarget: pid = None # todo: Support target regions if test is made @@ -39,6 +124,18 @@ class DamonTarget: def __init__(self, pid): self.pid = pid + def sysfs_dir(self): + return os.path.join( + self.context.sysfs_dir(), 'targets', '%d' % self.idx) + + def stage(self): + err = write_file( + os.path.join(self.sysfs_dir(), 'regions', 'nr_regions'), '0') + if err != None: + return err + return write_file( + os.path.join(self.sysfs_dir(), 'pid_target'), self.pid) + class DamonAttrs: sample_us = None aggr_us = None @@ -55,6 +152,40 @@ class DamonAttrs: self.min_nr_regions = min_nr_regions self.max_nr_regions = max_nr_regions + def interval_sysfs_dir(self): + return os.path.join(self.context.sysfs_dir(), 'monitoring_attrs', + 'intervals') + + def nr_regions_range_sysfs_dir(self): + return os.path.join(self.context.sysfs_dir(), 'monitoring_attrs', + 'nr_regions') + + def stage(self): + err = write_file(os.path.join(self.interval_sysfs_dir(), 'sample_us'), + self.sample_us) + if err != None: + return err + err = write_file(os.path.join(self.interval_sysfs_dir(), 'aggr_us'), + self.aggr_us) + if err != None: + return err + err = write_file(os.path.join(self.interval_sysfs_dir(), 'update_us'), + self.update_us) + if err != None: + return err + + err = write_file( + os.path.join(self.nr_regions_range_sysfs_dir(), 'min'), + self.min_nr_regions) + if err != None: + return err + + err = write_file( + os.path.join(self.nr_regions_range_sysfs_dir(), 'max'), + self.max_nr_regions) + if err != None: + return err + class DamonCtx: ops = None monitoring_attrs = None @@ -79,6 +210,46 @@ class DamonCtx: scheme.idx = idx scheme.context = self + def sysfs_dir(self): + return os.path.join(self.kdamond.sysfs_dir(), 'contexts', + '%d' % self.idx) + + def stage(self): + err = write_file( + os.path.join(self.sysfs_dir(), 'operations'), self.ops) + if err != None: + return err + err = self.monitoring_attrs.stage() + if err != None: + return err + + nr_targets_file = os.path.join( + self.sysfs_dir(), 'targets', 'nr_targets') + content, err = read_file(nr_targets_file) + if err != None: + return err + if int(content) != len(self.targets): + err = write_file(nr_targets_file, '%d' % len(self.targets)) + if err != None: + return err + for target in self.targets: + err = target.stage() + if err != None: + return err + + nr_schemes_file = os.path.join( + self.sysfs_dir(), 'schemes', 'nr_schemes') + content, err = read_file(nr_schemes_file) + if int(content) != len(self.schemes): + err = write_file(nr_schemes_file, '%d' % len(self.schemes)) + if err != None: + return err + for scheme in self.schemes: + err = scheme.stage() + if err != None: + return err + return None + class Kdamond: state = None pid = None @@ -92,6 +263,27 @@ class Kdamond: context.idx = idx context.kdamond = self + def sysfs_dir(self): + return os.path.join(self.kdamonds.sysfs_dir(), '%d' % self.idx) + + def start(self): + nr_contexts_file = os.path.join(self.sysfs_dir(), + 'contexts', 'nr_contexts') + content, err = read_file(nr_contexts_file) + if err != None: + return err + if int(content) != len(self.contexts): + err = write_file(nr_contexts_file, '%d' % len(self.contexts)) + if err != None: + return err + + for context in self.contexts: + err = context.stage() + if err != None: + return err + err = write_file(os.path.join(self.sysfs_dir(), 'state'), 'on') + return err + class Kdamonds: kdamonds = [] @@ -100,3 +292,17 @@ class Kdamonds: for idx, kdamond in enumerate(self.kdamonds): kdamond.idx = idx kdamond.kdamonds = self + + def sysfs_dir(self): + return os.path.join(sysfs_root, 'kdamonds') + + def start(self): + err = write_file(os.path.join(self.sysfs_dir(), 'nr_kdamonds'), + '%s' % len(self.kdamonds)) + if err != None: + return err + for kdamond in self.kdamonds: + err = kdamond.start() + if err != None: + return err + return None