From patchwork Thu Dec 7 21:21:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 13484052 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96620C4167B for ; Thu, 7 Dec 2023 21:24:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD7026B0082; Thu, 7 Dec 2023 16:24:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C5F456B0085; Thu, 7 Dec 2023 16:24:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD9DE6B00C0; Thu, 7 Dec 2023 16:24:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9B8A86B0082 for ; Thu, 7 Dec 2023 16:24:07 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6D100A109B for ; Thu, 7 Dec 2023 21:24:07 +0000 (UTC) X-FDA: 81541300134.27.2863E17 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id A1CDD120019 for ; Thu, 7 Dec 2023 21:24:05 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=irqQw5a+; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701984245; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YcUt6Wlq9qFzNGrM+VViKKkJSoOctikTKew3FuWO+5w=; b=ggeBJI2P3NYwXOCkJukUMeoKoRC553+fgK0tAO/h7evznoppasIhGfrl9xNU0qI8jOazbI r+NP8yCDrq0g3oPzipK+zIMYEDsL5u78pEz+hursAGU1L/iM1VbGVlReHTFlVyqrjcmEgI wonnZciuD7aKD+eJ0dAYdUDSBezxKi0= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=irqQw5a+; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701984245; a=rsa-sha256; cv=none; b=LyvZpFVMJCYq0wVWe8hju7m0kaTMzALl8VVfnUORU87+9DqzQyFtMAr/3T+VV2qV0OFNq5 KPXfkMGCEvRwLZ1SiRvYdD33vOhgppZT+wJptX1s2EWob7QS9CGkgsVEYwtLQCv9FojxDh HGJeBh/AGRZ0+3zgaiMUwZcIANdB9YI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701984244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YcUt6Wlq9qFzNGrM+VViKKkJSoOctikTKew3FuWO+5w=; b=irqQw5a+KqCMd3GZF8HCGwR6xvamTenmAPr+/KBDDucDIr2LaUi61C2zXcrCBcJ3F3akeH oWYQkU0B+Lto95x6Duo6PFXSCf1AQLD6xfzqMixnJLzLhiOF0DUN+NYePmQPlhOs483Bgg 8AugROOvyjbmgsq76ml8DCcl/PpEIt0= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-50-YYix5oYnM_O-H5lo0OEt7w-1; Thu, 07 Dec 2023 16:23:59 -0500 X-MC-Unique: YYix5oYnM_O-H5lo0OEt7w-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BE76F1C5407F; Thu, 7 Dec 2023 21:23:58 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.42.28.161]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2968C492BE6; Thu, 7 Dec 2023 21:23:56 +0000 (UTC) From: David Howells To: Jeff Layton , Steve French Cc: David Howells , Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Dominique Martinet , Eric Van Hensbergen , Ilya Dryomov , Christian Brauner , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 31/59] netfs: Allow buffered shared-writeable mmap through netfs_page_mkwrite() Date: Thu, 7 Dec 2023 21:21:38 +0000 Message-ID: <20231207212206.1379128-32-dhowells@redhat.com> In-Reply-To: <20231207212206.1379128-1-dhowells@redhat.com> References: <20231207212206.1379128-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Rspamd-Queue-Id: A1CDD120019 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 93u8kadjophiz83rhiggqo59kc15mqur X-HE-Tag: 1701984245-487101 X-HE-Meta: U2FsdGVkX19vox7EYe1IEUTAy5wMD+rWJ8o65hCOUPS0W1+n7tuLPu2yiSYILsw2RiQrcOE/B544dmzStplgPJNQ7ZJF1AUoIBWTwhcGUUffszP+/L1/dTcdwm20V5N/2L58qH+PdhKWo5NsjMZ1C8TWFSBAmrUigg3GSTbd74qhisNdD47hvBE59bBOYiMNapxanmgDV1IYDmV5U590d0IEiAiNuCXwlHE92WVj2G+3UVUtxelj1fYrzk5kv6Eyhs0K3ptzdbQsjWE8RpakG/XOtO7cDhp2s5sgYMXulCbmUsAxV1agAGSFVLVE342VGUzQd3Yp99cukZIETMLadQieDYrpu4l62n3lz37usGW+4IcX1YPHuUcSf0pcYDw/MhApdy5g0ffT5H2bpwNIRhrjBmPpRHTBn52+/Ph3jBgnWnlz0c8Py1rr0xQb9ZLy9ocpPSESMy8YalNarT36zO28i9iVQCHtwOkad2oLTjRLKQckGplya+uzJCIAu8cBgPERMtIZsv2P0ImKLaGFW2peGki3C7JTekXqAnwYQ/RIK8vlF+teFFdw0BvVB9N2X/uk8IQMWdXSJqB/m8xLiRJY+ledlYA1vE939LUFm2sOSJNKWgVG409gfD47AxUc0aiNnZOmrlTQ51s6G4yg/ztG9lXPV/3Z8myr9z2WmvsKLfKvs+fNn7Pc2ePxNelu0FeZFSEb4rw/rzSThnnjKwDwgDvHzQ1twobCYYfRomPNEQa+mjN/FUO1tna7rXkyPZslDzowTrxmBdPVzmvmvwL/F08AX++SZD9AaRyUA74usDFLj80amdRSn+0l3zL1rPAIv2uvibJSYSqWsjyMuKWa0EENgcS60iFtqK4WuS5pJVOm53xr1d3ETg9fcnC6F3Rw0zFupYKu0qy4AsWz0+m5NST+HPG0QTQMw+z64mOLERavET5kwyMhk4isVDgq2NPk/R3zy03tYZ64yxU XUr77OdW KcalE8+2nXcCmlkZJ2qJDl0UFxgIHO7nlzjOmyBgbubiWGALurkVakU7DVQOvXZPq9tjKycREeWhtB3FsxOdbF+EwCs25bGAnhFp+zq1JOh9o6lsRncyAN7gzkTOsU5m0EvypL9/UNBy7e2xVcKsOiqLzb1Cj3OEhI2Ja/Ogg/mdAMgIKXRw64neOtiWNDxiSjbfDw3xKNXO0tV+m5Enfeihlj/esrpvIE3bpDrp229mXELur8GTy0WvFPAwbJegfQOnqQwTkEiidJMlmp6KpLJnvx8Y1ZKTQwUboBxpuBNDDciSt5ZBH261S58stzM3svj+fNM9NrQYsKpo3XF65If3eXw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Provide an entry point to delegate a filesystem's ->page_mkwrite() to. This checks for conflicting writes, then attached any netfs-specific group marking (e.g. ceph snap) to the page to be considered dirty. Signed-off-by: David Howells cc: Jeff Layton cc: linux-cachefs@redhat.com cc: linux-fsdevel@vger.kernel.org cc: linux-mm@kvack.org --- fs/netfs/buffered_write.c | 59 +++++++++++++++++++++++++++++++++++++++ include/linux/netfs.h | 4 +++ 2 files changed, 63 insertions(+) diff --git a/fs/netfs/buffered_write.c b/fs/netfs/buffered_write.c index f244123ab568..70cb8e98d068 100644 --- a/fs/netfs/buffered_write.c +++ b/fs/netfs/buffered_write.c @@ -416,3 +416,62 @@ ssize_t netfs_file_write_iter(struct kiocb *iocb, struct iov_iter *from) return ret; } EXPORT_SYMBOL(netfs_file_write_iter); + +/* + * Notification that a previously read-only page is about to become writable. + * Note that the caller indicates a single page of a multipage folio. + */ +vm_fault_t netfs_page_mkwrite(struct vm_fault *vmf, struct netfs_group *netfs_group) +{ + struct folio *folio = page_folio(vmf->page); + struct file *file = vmf->vma->vm_file; + struct inode *inode = file_inode(file); + vm_fault_t ret = VM_FAULT_RETRY; + int err; + + _enter("%lx", folio->index); + + sb_start_pagefault(inode->i_sb); + + if (folio_wait_writeback_killable(folio)) + goto out; + + if (folio_lock_killable(folio) < 0) + goto out; + + /* Can we see a streaming write here? */ + if (WARN_ON(!folio_test_uptodate(folio))) { + ret = VM_FAULT_SIGBUS | VM_FAULT_LOCKED; + goto out; + } + + if (netfs_folio_group(folio) != netfs_group) { + folio_unlock(folio); + err = filemap_fdatawait_range(inode->i_mapping, + folio_pos(folio), + folio_pos(folio) + folio_size(folio)); + switch (err) { + case 0: + ret = VM_FAULT_RETRY; + goto out; + case -ENOMEM: + ret = VM_FAULT_OOM; + goto out; + default: + ret = VM_FAULT_SIGBUS; + goto out; + } + } + + if (folio_test_dirty(folio)) + trace_netfs_folio(folio, netfs_folio_trace_mkwrite_plus); + else + trace_netfs_folio(folio, netfs_folio_trace_mkwrite); + netfs_set_group(folio, netfs_group); + file_update_time(file); + ret = VM_FAULT_LOCKED; +out: + sb_end_pagefault(inode->i_sb); + return ret; +} +EXPORT_SYMBOL(netfs_page_mkwrite); diff --git a/include/linux/netfs.h b/include/linux/netfs.h index 702b864a4993..46c0a6b45bb8 100644 --- a/include/linux/netfs.h +++ b/include/linux/netfs.h @@ -403,6 +403,10 @@ void netfs_clear_inode_writeback(struct inode *inode, const void *aux); void netfs_invalidate_folio(struct folio *folio, size_t offset, size_t length); bool netfs_release_folio(struct folio *folio, gfp_t gfp); +/* VMA operations API. */ +vm_fault_t netfs_page_mkwrite(struct vm_fault *vmf, struct netfs_group *netfs_group); + +/* (Sub)request management API. */ void netfs_subreq_terminated(struct netfs_io_subrequest *, ssize_t, bool); void netfs_get_subrequest(struct netfs_io_subrequest *subreq, enum netfs_sreq_ref_trace what);