| Message ID | 20231216032957.3553313-5-kent.overstreet@linux.dev (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | big header dependency cleanup targeting sched.h | expand |
On 12/15/23 19:29, Kent Overstreet wrote: > list_head is defined in types.h, not list.h - this kills a sched.h > dependency. > > Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> > --- > include/linux/rslib.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/linux/rslib.h b/include/linux/rslib.h > index 238bb85243d3..a04dacbdc8ae 100644 > --- a/include/linux/rslib.h > +++ b/include/linux/rslib.h > @@ -10,7 +10,6 @@ > #ifndef _RSLIB_H_ > #define _RSLIB_H_ > > -#include <linux/list.h> > #include <linux/types.h> /* for gfp_t */ > #include <linux/gfp.h> /* for GFP_KERNEL */ > What about line 47? 47 struct list_head list;
On Sat, Dec 16, 2023 at 11:05:08AM -0800, Randy Dunlap wrote: > > > On 12/15/23 19:29, Kent Overstreet wrote: > > list_head is defined in types.h, not list.h - this kills a sched.h > > dependency. > > > > Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> > > --- > > include/linux/rslib.h | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/include/linux/rslib.h b/include/linux/rslib.h > > index 238bb85243d3..a04dacbdc8ae 100644 > > --- a/include/linux/rslib.h > > +++ b/include/linux/rslib.h > > @@ -10,7 +10,6 @@ > > #ifndef _RSLIB_H_ > > #define _RSLIB_H_ > > > > -#include <linux/list.h> > > #include <linux/types.h> /* for gfp_t */ > > #include <linux/gfp.h> /* for GFP_KERNEL */ > > > > What about line 47? > > 47 struct list_head list; It's in types.h.
On 12/16/23 11:05, Randy Dunlap wrote: > > > On 12/15/23 19:29, Kent Overstreet wrote: >> list_head is defined in types.h, not list.h - this kills a sched.h >> dependency. >> >> Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> >> --- >> include/linux/rslib.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/include/linux/rslib.h b/include/linux/rslib.h >> index 238bb85243d3..a04dacbdc8ae 100644 >> --- a/include/linux/rslib.h >> +++ b/include/linux/rslib.h >> @@ -10,7 +10,6 @@ >> #ifndef _RSLIB_H_ >> #define _RSLIB_H_ >> >> -#include <linux/list.h> >> #include <linux/types.h> /* for gfp_t */ >> #include <linux/gfp.h> /* for GFP_KERNEL */ >> > > What about line 47? > > 47 struct list_head list; > I see. :) it's in types.h, not list.h, as you explained!
diff --git a/include/linux/rslib.h b/include/linux/rslib.h index 238bb85243d3..a04dacbdc8ae 100644 --- a/include/linux/rslib.h +++ b/include/linux/rslib.h @@ -10,7 +10,6 @@ #ifndef _RSLIB_H_ #define _RSLIB_H_ -#include <linux/list.h> #include <linux/types.h> /* for gfp_t */ #include <linux/gfp.h> /* for GFP_KERNEL */
list_head is defined in types.h, not list.h - this kills a sched.h dependency. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> --- include/linux/rslib.h | 1 - 1 file changed, 1 deletion(-)