From patchwork Wed Dec 20 22:44:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Hildenbrand X-Patchwork-Id: 13500648 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DCC7C3DA6E for ; Wed, 20 Dec 2023 22:46:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97BF58D0025; Wed, 20 Dec 2023 17:46:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DD588D0022; Wed, 20 Dec 2023 17:46:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 735238D0025; Wed, 20 Dec 2023 17:46:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 545E48D0022 for ; Wed, 20 Dec 2023 17:46:46 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2690F1203E6 for ; Wed, 20 Dec 2023 22:46:46 +0000 (UTC) X-FDA: 81588682812.18.165CB62 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 5C306C0012 for ; Wed, 20 Dec 2023 22:46:43 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PJLWuO22; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703112403; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qNA8pWEc7GnGKj0IRh6+wWeJkGUBzLslpaDMoEDhhnE=; b=fTxea/FXBOle+igBP90iPB+FkVFTO5dCHMudf7xaFHoE6m83mzwrToXvqwwsa3931sRF0r RJN++jlChohZ3H/KXAODb1HF+pEMCg79SthiLDT2v4b3QfGLFMnzqtvRJtxRD36GAePu5b /000VmyOEo+4GoLAjiaHNe2OnR3hAqc= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PJLWuO22; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703112403; a=rsa-sha256; cv=none; b=TvNV/0sImEsrNf/H0spk5+fFwvQo6wRQRe3SpODHxHJuiwZ0FyKnb5m+HhvCJUGrIY1701 8QqY5Pl2DjJR2cOShYyJ+5gpYf7JRiKXQapE89wd3Z6TmBP93qsGQ7fIztgiR84qWpjXHZ iqFPtpPrKDKWBEO4N9+PENI1Nc1U010= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703112402; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qNA8pWEc7GnGKj0IRh6+wWeJkGUBzLslpaDMoEDhhnE=; b=PJLWuO22VvPtfULpCk7t1XzGZml0/TAtWbveSKTwfnhX36wFQt3w5zwuE3yYOiHOXqlAoq GkgBE6OGe4y3hZxmZmWbKOIm9AGteZFK2/UT/vp2uHt+qnz0Y7UAekjKnZpfbYjCbEV2FS jqgbsNJkH/788zigWzJLbzw9VAKQgLc= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-464-FgP96C90Ok2CEIy_NFv94Q-1; Wed, 20 Dec 2023 17:46:37 -0500 X-MC-Unique: FgP96C90Ok2CEIy_NFv94Q-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A735D38425B2; Wed, 20 Dec 2023 22:46:36 +0000 (UTC) Received: from t14s.fritz.box (unknown [10.39.192.101]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1F9F740C6EB9; Wed, 20 Dec 2023 22:46:34 +0000 (UTC) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, David Hildenbrand , Andrew Morton , "Matthew Wilcox (Oracle)" , Hugh Dickins , Ryan Roberts , Yin Fengwei , Mike Kravetz , Muchun Song , Peter Xu Subject: [PATCH v2 34/40] mm/rmap: introduce folio_try_dup_anon_rmap_[pte|ptes|pmd]() Date: Wed, 20 Dec 2023 23:44:58 +0100 Message-ID: <20231220224504.646757-35-david@redhat.com> In-Reply-To: <20231220224504.646757-1-david@redhat.com> References: <20231220224504.646757-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Rspamd-Queue-Id: 5C306C0012 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: xf8qw5fnxwrc8amtc3wi83eain11k98r X-HE-Tag: 1703112403-30294 X-HE-Meta: U2FsdGVkX1+Ene5x+/JIANChPtW5HLxhnViw+660UKJn+goPiaGpV1uv9zdMj6ieUj361N/SrZwJ80LimmICFUQc5jFukO4SP+Z1NA3jp7UAaS5IaDppGkv7OjFIKjbNXLhhKSiZMY0g3HeT9Iu3ayTQDZGAk0XXXTa9hz4q57q0iYIa97mlSXiEDTpkyyrB1po71SbCL4kQTKf8vvABSKXAF6UBikJnnS4xTyF2yc8AvXz2nCElIUpULqyPqFRP20tTnu5UeWS/hJI94Fe1CgTjl1RLFFAzxCcIINGRmsHw88GxRXm2I3QJQUx2IJjWN6hd0huSt+O+kE86Wf8A0bUlLzZlRUndaU3VEG3N21RZKwT0KP4YnI3KACJlEr8yFGCYBEQfRBElp84thIhYtpGYywZNarCVkiRlGt19AByeb5iXBgLmuZ3b0AMt87ft7PptSAkS4/uYSrS5DBsA90RQZ+v+prQbgoGhGh2vby0JSZGTfNLcjS+qX0KSTquODUAKxwDQGq/JqCXXcVkLMGDwhincw1+xUAjJ/Mx5kV9nWrdaQf3lA4AZJLNCokf16Muc+St9bKkINxK9lKYAjPLi7Y/06GkprownmZ5cjZQ7Ls/3b6hOFfa9BBHsR0UQ6nF8JB6YzKe3387DiQEwaj/XrlQY2fyTvTVXf83Nbj8iCX2ShxELW0k5zgDrcDClOLmCfmizGDKiYTuAkLQkC7WVSSoj5EWSgJiS1CHID/moR30868tVwHUWgGP7cYPhjFp6Yrr3by6DWlqNp/n4VJm2N2Wd+RkTGqJZFpKTFzOs1lYm68PfSag6qcceRCl7+282TonIGwbz4RX9JuuT7zTmxSkkhKZB2CmlbNb6L0xHu4VYX6iYL/0sZziLRbyaraI91qZibr+sbfr7aMPFe6W3Hh/51SL4QKaxzPR+EKscxKoz3ycwA5iUEqNmWJ39uUqRQ+lRXwRsx0YQQeR wc16hXwp w767jDf7sD+ta/G6+JVZnNKGm4+x2YmyErU4jfulIcAYrmVgtK+Dpjh/yThzMF9jmorQ2RGFv0q1YIBdjHmD35fElCsI1JEZPemwpg+fo8ykZiMQBl1WA37JOszQvZtQzE6+gtaU/QYMcxojCp4YQN43jjBKiilowCCYRZ0FmQWyZPvHylzbn38prZCZajijSE/jZx2ixdwCyXFEcFMZ+5kmNJN/FL2UCV/kC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The last user of page_needs_cow_for_dma() and __page_dup_rmap() are gone, remove them. Add folio_try_dup_anon_rmap_ptes() right away, we want to perform rmap baching during fork() soon. Signed-off-by: David Hildenbrand --- include/linux/mm.h | 6 -- include/linux/rmap.h | 150 ++++++++++++++++++++++++++++++------------- 2 files changed, 106 insertions(+), 50 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index ae547b62f3252..30edf3f7d1f38 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -1975,12 +1975,6 @@ static inline bool folio_needs_cow_for_dma(struct vm_area_struct *vma, return folio_maybe_dma_pinned(folio); } -static inline bool page_needs_cow_for_dma(struct vm_area_struct *vma, - struct page *page) -{ - return folio_needs_cow_for_dma(vma, page_folio(page)); -} - /** * is_zero_page - Query if a page is a zero page * @page: The page to query diff --git a/include/linux/rmap.h b/include/linux/rmap.h index 7607f862e795d..850aa74b6724c 100644 --- a/include/linux/rmap.h +++ b/include/linux/rmap.h @@ -362,68 +362,130 @@ static inline void folio_dup_file_rmap_pmd(struct folio *folio, #endif } -static inline void __page_dup_rmap(struct page *page, bool compound) +static __always_inline int __folio_try_dup_anon_rmap(struct folio *folio, + struct page *page, int nr_pages, struct vm_area_struct *src_vma, + enum rmap_level level) { - VM_WARN_ON(folio_test_hugetlb(page_folio(page))); + bool maybe_pinned; + int i; + + VM_WARN_ON_FOLIO(!folio_test_anon(folio), folio); + __folio_rmap_sanity_checks(folio, page, nr_pages, level); - if (compound) { - struct folio *folio = (struct folio *)page; + /* + * If this folio may have been pinned by the parent process, + * don't allow to duplicate the mappings but instead require to e.g., + * copy the subpage immediately for the child so that we'll always + * guarantee the pinned folio won't be randomly replaced in the + * future on write faults. + */ + maybe_pinned = likely(!folio_is_device_private(folio)) && + unlikely(folio_needs_cow_for_dma(src_vma, folio)); - VM_BUG_ON_PAGE(compound && !PageHead(page), page); + /* + * No need to check+clear for already shared PTEs/PMDs of the + * folio. But if any page is PageAnonExclusive, we must fallback to + * copying if the folio maybe pinned. + */ + switch (level) { + case RMAP_LEVEL_PTE: + if (unlikely(maybe_pinned)) { + for (i = 0; i < nr_pages; i++) + if (PageAnonExclusive(page + i)) + return -EBUSY; + } + do { + if (PageAnonExclusive(page)) + ClearPageAnonExclusive(page); + atomic_inc(&page->_mapcount); + } while (page++, --nr_pages > 0); + break; + case RMAP_LEVEL_PMD: + if (PageAnonExclusive(page)) { + if (unlikely(maybe_pinned)) + return -EBUSY; + ClearPageAnonExclusive(page); + } atomic_inc(&folio->_entire_mapcount); - } else { - atomic_inc(&page->_mapcount); + break; } + return 0; } /** - * page_try_dup_anon_rmap - try duplicating a mapping of an already mapped - * anonymous page - * @page: the page to duplicate the mapping for - * @compound: the page is mapped as compound or as a small page - * @vma: the source vma + * folio_try_dup_anon_rmap_ptes - try duplicating PTE mappings of a page range + * of a folio + * @folio: The folio to duplicate the mappings of + * @page: The first page to duplicate the mappings of + * @nr_pages: The number of pages of which the mapping will be duplicated + * @src_vma: The vm area from which the mappings are duplicated * - * The caller needs to hold the PT lock and the vma->vma_mm->write_protect_seq. + * The page range of the folio is defined by [page, page + nr_pages) * - * Duplicating the mapping can only fail if the page may be pinned; device - * private pages cannot get pinned and consequently this function cannot fail. + * The caller needs to hold the page table lock and the + * vma->vma_mm->write_protect_seq. + * + * Duplicating the mappings can only fail if the folio may be pinned; device + * private folios cannot get pinned and consequently this function cannot fail + * for them. + * + * If duplicating the mappings succeeded, the duplicated PTEs have to be R/O in + * the parent and the child. They must *not* be writable after this call + * succeeded. + * + * Returns 0 if duplicating the mappings succeeded. Returns -EBUSY otherwise. + */ +static inline int folio_try_dup_anon_rmap_ptes(struct folio *folio, + struct page *page, int nr_pages, struct vm_area_struct *src_vma) +{ + return __folio_try_dup_anon_rmap(folio, page, nr_pages, src_vma, + RMAP_LEVEL_PTE); +} +#define folio_try_dup_anon_rmap_pte(folio, page, vma) \ + folio_try_dup_anon_rmap_ptes(folio, page, 1, vma) + +/** + * folio_try_dup_anon_rmap_pmd - try duplicating a PMD mapping of a page range + * of a folio + * @folio: The folio to duplicate the mapping of + * @page: The first page to duplicate the mapping of + * @src_vma: The vm area from which the mapping is duplicated + * + * The page range of the folio is defined by [page, page + HPAGE_PMD_NR) * - * If duplicating the mapping succeeds, the page has to be mapped R/O into - * the parent and the child. It must *not* get mapped writable after this call. + * The caller needs to hold the page table lock and the + * vma->vma_mm->write_protect_seq. + * + * Duplicating the mapping can only fail if the folio may be pinned; device + * private folios cannot get pinned and consequently this function cannot fail + * for them. + * + * If duplicating the mapping succeeds, the duplicated PMD has to be R/O in + * the parent and the child. They must *not* be writable after this call + * succeeded. * * Returns 0 if duplicating the mapping succeeded. Returns -EBUSY otherwise. */ +static inline int folio_try_dup_anon_rmap_pmd(struct folio *folio, + struct page *page, struct vm_area_struct *src_vma) +{ +#ifdef CONFIG_TRANSPARENT_HUGEPAGE + return __folio_try_dup_anon_rmap(folio, page, HPAGE_PMD_NR, src_vma, + RMAP_LEVEL_PMD); +#else + WARN_ON_ONCE(true); + return -EBUSY; +#endif +} + static inline int page_try_dup_anon_rmap(struct page *page, bool compound, struct vm_area_struct *vma) { - VM_BUG_ON_PAGE(!PageAnon(page), page); - - /* - * No need to check+clear for already shared pages, including KSM - * pages. - */ - if (!PageAnonExclusive(page)) - goto dup; - - /* - * If this page may have been pinned by the parent process, - * don't allow to duplicate the mapping but instead require to e.g., - * copy the page immediately for the child so that we'll always - * guarantee the pinned page won't be randomly replaced in the - * future on write faults. - */ - if (likely(!is_device_private_page(page)) && - unlikely(page_needs_cow_for_dma(vma, page))) - return -EBUSY; + struct folio *folio = page_folio(page); - ClearPageAnonExclusive(page); - /* - * It's okay to share the anon page between both processes, mapping - * the page R/O into both processes. - */ -dup: - __page_dup_rmap(page, compound); - return 0; + if (likely(!compound)) + return folio_try_dup_anon_rmap_pte(folio, page, vma); + return folio_try_dup_anon_rmap_pmd(folio, page, vma); } /**