From patchwork Wed Dec 20 22:45:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Hildenbrand X-Patchwork-Id: 13500653 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38B96C3DA6E for ; Wed, 20 Dec 2023 22:47:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E365E8D002A; Wed, 20 Dec 2023 17:46:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DE6188D0022; Wed, 20 Dec 2023 17:46:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C11B98D002A; Wed, 20 Dec 2023 17:46:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id ABFF08D0022 for ; Wed, 20 Dec 2023 17:46:58 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8B77E1C0BEE for ; Wed, 20 Dec 2023 22:46:58 +0000 (UTC) X-FDA: 81588683316.17.FA400A9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id D9F8F8001B for ; Wed, 20 Dec 2023 22:46:56 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HkZltjKZ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703112417; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zwHHhlXrWPXO/4jePm24jC5xrVtR1eDI9aBc8Gwcrbg=; b=TAVPvTMe8G6T61EY/ElOjETRwpNa9GdSdKHZ51w0iDLozXxcN+btWZUW111nPORFxM2Tdc hGyZpOonu4ASRgScZMoWGd1oLP+1yk2KJUbxX6ndHaI6++iopdTGEhr1xFDHWBrXmG9io7 qQRBDScgs7Hgb+fqn6PaJgWkS5naGGA= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HkZltjKZ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703112417; a=rsa-sha256; cv=none; b=kmNtRpUj2X7aHRNDqfEc8unlDpqu86GCcnO/CKhlwmT0lSKQxvAcqCd6jPvollfrGTeHNc G3gRuzRlXRgMjdW5RDEi7hlcuHQtNSrZ9ML0vdBs6V9Hz2npUw0hfPhSpTiaaxp5HhsmuM JBR8XYtpmjmyxIQcxRGLNbM6EkIrjBg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703112416; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zwHHhlXrWPXO/4jePm24jC5xrVtR1eDI9aBc8Gwcrbg=; b=HkZltjKZC3ul53coi6baNmb8Xc+F8tG2XV18mKdXiKgeiYbbn9OPBeUWdh5ztAimjbnpFB 2GilE/3J5f0GR7BFekMsnA105T6Tj1V3o4vskWNbm00HErq2KJUn8n+qngWdk5GDZkKe0E o5RyMOJJs+PYvY0E2HPFUJ4lXC+XsoM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-176-ZzFw3tvFOO2FjpEXoDI-bg-1; Wed, 20 Dec 2023 17:46:53 -0500 X-MC-Unique: ZzFw3tvFOO2FjpEXoDI-bg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 405B3863B83; Wed, 20 Dec 2023 22:46:52 +0000 (UTC) Received: from t14s.fritz.box (unknown [10.39.192.101]) by smtp.corp.redhat.com (Postfix) with ESMTP id E2D0D40C6EB9; Wed, 20 Dec 2023 22:46:49 +0000 (UTC) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, David Hildenbrand , Andrew Morton , "Matthew Wilcox (Oracle)" , Hugh Dickins , Ryan Roberts , Yin Fengwei , Mike Kravetz , Muchun Song , Peter Xu Subject: [PATCH v2 40/40] mm: remove one last reference to page_add_*_rmap() Date: Wed, 20 Dec 2023 23:45:04 +0100 Message-ID: <20231220224504.646757-41-david@redhat.com> In-Reply-To: <20231220224504.646757-1-david@redhat.com> References: <20231220224504.646757-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D9F8F8001B X-Stat-Signature: twnxg811rqa9fg9f3a65xdc1rhtupa8i X-HE-Tag: 1703112416-672763 X-HE-Meta: U2FsdGVkX18MRJSQtl1ikyqak7WIU5huYQ8xMNo3xNw2RoRBJjdRPbiLl5xKrh+F1/Nbfx83xufKJOQYlmQmerhKr27NIGlLghwsRT3mWcZFEzSUXWL5rnLHr8cV+AWHlsix5SrcKwLhg7+BPlUbuNtTvuWQxwGKtsp6eMe0opp5txnhwHcNa4KqYFSf7vHpVTBnwq577wswXnsYLfCPHarsYwN3dOA8BU+I2opHrHpBV0nnf6kyZD4DoU7/E9eUtylUr3ry7AUaw3k9OqA9HMGTGj63aA8ydCTx71KPzesfK4nCMdu42Lh4b4mLLWg2z0QaoS40nQCGNdig4Q/1yfaqqyb0aMUUG1uKjcTN8bPTXulkzWDr2yXB/sUFtw8mDTRmctv8z3cS64XlxiPi9dxyq/tv/cg/4ZQXEB1qrFo5pEd/1crG0Nm9oDZufcCmFyhIiMwfelnLDjyOPyxxOr0mpLGq2uwJ1rx1/TUHojnd/2zWo3DcR9/N3T5NpqANmrDSlt0gPDWiuWtXlD2ogP5ONxXgTRY08uCRWXbKPs5jSyeSEakKaOrhoshHOvuPppeMwX0HjVUGFcGZSCEqvfap6IPN4iVj3is0k6tfJbM0FRodVwFOdAvPxwbCplR+XOgYEAXWGWxU8fRako4FWsbg3GeGKZ5mqbyzTCZ5TiiNHiwiQERNibA5Aj6HdjsHk2JU9trVXpe+l2SR5rFRwvNwBpYKjsEIyUv8t8i4ByAHObA6DAUkR03CE7JnADdNTjT5KQccU3VMVtEeQW5QE4z4+yMGhmjc+8GBQ/LVx9gLML+qAR/DBb70K4zw0XKFpY4BKRYNNy/7C/bPKkh7WxL51xhvSaFgsCCZ6k8CO3/EzGL38O8upjVcxppl2HEWDucKvPMoL+IVWOqWSUVZ9WrOrnIrpA0AirWlEoQyw0qhE6oqcSzKbw07QvlXiJ8o8vxyZAZgV0ZoXPHQVR9 16GCM0+l pInAz8ixrgE2dbbqXmyKXGa1lKe6AG7oirkjKh8yX8Tej4B+rKN13dFLBNXjW+jIP90dNiaARVtyUbsgygZ1rw6NRiUBJcp33/wOhuAW4NBASFQXIlSW+0Bo2GV14d3oHEYaPwCUf4O5P9Qf/j08q0LkGaDFJxaFWm8ORAu12KDK/rwpez4tRScFFgZC/qQd8W3KL7c2klO3XCqugjkGDscWTPQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Let's fixup one remaining comment. Note that the only trace remaining of the old rmap interface is in an example in Documentation/trace/ftrace.rst, that we'll just leave alone. Signed-off-by: David Hildenbrand --- mm/internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/internal.h b/mm/internal.h index 188807d2aebc5..ac40c3d003368 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -650,7 +650,7 @@ folio_within_vma(struct folio *folio, struct vm_area_struct *vma) * should be called with vma's mmap_lock held for read or write, * under page table lock for the pte/pmd being added or removed. * - * mlock is usually called at the end of page_add_*_rmap(), munlock at + * mlock is usually called at the end of folio_add_*_rmap_*(), munlock at * the end of folio_remove_rmap_*(); but new anon folios are managed by * folio_add_lru_vma() calling mlock_new_folio(). */