| Message ID | 20231221180042.104694-1-andrey.konovalov@linux.dev (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [mm] kasan: Mark unpoison_slab_object() as static | expand |
On Thu, 21 Dec 2023 at 19:00, <andrey.konovalov@linux.dev> wrote: > > From: Nathan Chancellor <nathan@kernel.org> > > With -Wmissing-prototypes enabled, there is a warning that > unpoison_slab_object() has no prototype, breaking the build with > CONFIG_WERROR=y: > > mm/kasan/common.c:271:6: error: no previous prototype for 'unpoison_slab_object' [-Werror=missing-prototypes] > 271 | void unpoison_slab_object(struct kmem_cache *cache, void *object, gfp_t flags, > | ^~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > > Mark the function as static, as it is not used outside of this > translation unit, clearing up the warning. > > Fixes: 3f38c3c5bc40 ("kasan: save alloc stack traces for mempool") > Signed-off-by: Nathan Chancellor <nathan@kernel.org> > Signed-off-by: Andrey Konovalov <andreyknvl@google.com> Reviewed-by: Marco Elver <elver@google.com> > --- > > Changes v1->v2: > - Mark as "static inline" instead of just "static". > --- > mm/kasan/common.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index ebb1b23d6480..f4255e807b74 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -277,8 +277,8 @@ void __kasan_kfree_large(void *ptr, unsigned long ip) > /* The object will be poisoned by kasan_poison_pages(). */ > } > > -void unpoison_slab_object(struct kmem_cache *cache, void *object, gfp_t flags, > - bool init) > +static inline void unpoison_slab_object(struct kmem_cache *cache, void *object, > + gfp_t flags, bool init) > { > /* > * Unpoison the whole object. For kmalloc() allocations, > -- > 2.25.1 >
diff --git a/mm/kasan/common.c b/mm/kasan/common.c index ebb1b23d6480..f4255e807b74 100644 --- a/mm/kasan/common.c +++ b/mm/kasan/common.c @@ -277,8 +277,8 @@ void __kasan_kfree_large(void *ptr, unsigned long ip) /* The object will be poisoned by kasan_poison_pages(). */ } -void unpoison_slab_object(struct kmem_cache *cache, void *object, gfp_t flags, - bool init) +static inline void unpoison_slab_object(struct kmem_cache *cache, void *object, + gfp_t flags, bool init) { /* * Unpoison the whole object. For kmalloc() allocations,