From patchwork Fri Dec 22 15:08:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13503425 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50A2FC46CD2 for ; Fri, 22 Dec 2023 15:09:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C511D8D000B; Fri, 22 Dec 2023 10:09:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B65DE8D0003; Fri, 22 Dec 2023 10:09:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91A6D8D000B; Fri, 22 Dec 2023 10:09:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 810278D0003 for ; Fri, 22 Dec 2023 10:09:12 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5845D160E88 for ; Fri, 22 Dec 2023 15:09:12 +0000 (UTC) X-FDA: 81594787344.24.A0AF759 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf09.hostedemail.com (Postfix) with ESMTP id B3689140022 for ; Fri, 22 Dec 2023 15:09:10 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=EwhMMlXL; dmarc=none; spf=none (imf09.hostedemail.com: domain of BATV+af923ccb694ecd533eae+7425+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+af923ccb694ecd533eae+7425+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703257750; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vSRtoBhWiymkrUriREDGEOquZtVYvqi7wp6gqOzPpq0=; b=lEwu2tjiJxWY9Um8eInYX+AYMntRVboHSVDGPORp+CY4vaKgRkLKh157KKJQmXrm7MR/XL cJ3a9Pg7UhxUmPUGsZPaDsqdYsDAM8dr6f64jyqckVcb8rYspYdj+zHe/v0/nxsTGyDon3 awPB2/VXKvl8v+kNhhkxJKIQhu+Dqhs= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=EwhMMlXL; dmarc=none; spf=none (imf09.hostedemail.com: domain of BATV+af923ccb694ecd533eae+7425+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+af923ccb694ecd533eae+7425+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703257750; a=rsa-sha256; cv=none; b=AodNSPgJcy874ExmwhHsu7YoOowYSLwmuZTfjblUd9p8yW6vxmo4DuN/4fDTbgKjHSXj43 F7iItc5+ySiB10Nqd0tSkY+5jFjp4Z/o/+oU7F6PNURsXE4cjzOdiBAMclCg6G9gbYnjGy PM/UmEy0fxW1JYj6gX3GKaRYSx8XndU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=vSRtoBhWiymkrUriREDGEOquZtVYvqi7wp6gqOzPpq0=; b=EwhMMlXLFZbb/tlh1Ap0vPdrcR QeXKb5dVMvla5R8BdZFAmfwJTIijr0Gqh4grvfBE2kVQ74iY2pchwGk1U6PBfvQLlseP3Joxij14M f6DDtw8jvufT1eQ0dD6EnwdEEfmngoOSFwXb3tcNOHge1rxqDek23e1IBIgaxlzAOjCOrrDyZ1Pm9 6bpZHxF0yNGAKL1BWEHRC7Ee16sHdUCn73JAe5XO5P7gvg/24bmDnR1HUJ/8m8hxdxp+ALaoGDdjh CrJ0gy89UfK4aZ28Lih1VvI2b3nUn8Yje//rK3yG35lU++vIYwhUFSmTiW8uFt5D70kn6sI9l1clv MGfNkVlA==; Received: from 2a02-8389-2341-5b80-39d3-4735-9a3c-88d8.cable.dynamic.v6.surfer.at ([2a02:8389:2341:5b80:39d3:4735:9a3c:88d8] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1rGh9B-006Bdj-10; Fri, 22 Dec 2023 15:09:09 +0000 From: Christoph Hellwig To: linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" , Jan Kara , David Howells , Brian Foster , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Dave Chinner , Jan Kara Subject: [PATCH 17/17] writeback: update the kerneldoc comment for tag_pages_for_writeback Date: Fri, 22 Dec 2023 16:08:27 +0100 Message-Id: <20231222150827.1329938-18-hch@lst.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231222150827.1329938-1-hch@lst.de> References: <20231222150827.1329938-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: B3689140022 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: bkg6usxo4u71py5jiritybn78qm33h8p X-HE-Tag: 1703257750-77579 X-HE-Meta: U2FsdGVkX1/Wu3y+vCp9lLiHZWD0BKvzRXqBGDNeP9Z8cWPXy2xvxQ/M4aotyMgOTWcfQh7w5sHfTwjmqz5lbP7Fc78ptRKWSxiRAgXQBtD+D7ur/tpAFr1x2excISU8eHA1MPNdxeylfxaxFfMxzHGtY1VMLwFW3C2S/AOt9u9Icu70GnJAJ+G/fbezrFqH1Y2bmne1LVJjbbnFyxsg9IlitZetZRlaVdfqqevRDaUO5ow2tUFHLOYBZX8VwuzxTmdT670N4PvUqytjyT564Fb+eCz6Vn6TvQx6E/zf/6De3lFo+eki/RBOJPL7ZjsQwmorDQhIPW7E3Z/AlTu2wFz6FESINl9juMHMogdhTOWvX41EYR4RiAM8r8r53sEeh3HQCWmbMuJjjvfBPHVdRSBcmNZ+vQg1bKRLrx9BtvDfnDEqTtHucz+dnwbnISW/PKrCJ2ICglVtTja7hvCPCUSB5DzNM3MH2VAOWkwqhRq69ClqNnUmXREn4RqW5O8Ovf1daFOFJi6XAfMAsmxjK93u00EAPJmOqGdlz7gRWMEhNPwZnBGpzNXFQxpmzyQ+9Gqov9X20rvx9+g/yFY/FLb+BE/ljFl1T1rRufW35JZjCku43KLZDshSEj5bFFyfBIfotDF09jmI/r6E6N77Ajc1MXRNjMQW29Km4DqnPoe6iqO/ss/bja98e5kGhV3rGiZyAT7pf5zPRQXx/1KRcQB4a2Diw1OYycLzByjIHz8JWql++a7XMAl5DKN1C+LlwC8R09x5F0PC8sagnSYHAvwnv7n+yJuHiiRfpo7kaSgBb/nnRAXejS1NFNDpyjQj3cLnUmCe6NSCruYjO49uSd7xX6suhczKh18MxcYQXUvibSBIigIpW2jN72jem/kDwBgN7UA8y6j0IIL395QtWdsXlt4xHS1GepDQ4yb3CIVJQU5E8UQGKUssMIC+tGGTeAwAcNM7GJJElOxttJa dctAeLlM azR3SK3EuxcaLSUeQocvCsMpSQAufKj63BdsC5LI7lLetHeF+SHY2HKjEqjWbJ8s0Dc0aDeDUJjOGD/nOE6EQTjtjHcL5NacWg7GQAe2AjDe0+1BKOHrXaYWPkerY/FHM+RRZl4Y2HyomtIMxlS9Q9X56mEu6uin5WoajAScDHRSyNpmItOkSaFnpXY2+yeUwWwv6HSkWpVROHVqpyWGmO3fHWA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Don't refer to write_cache_pages, which now is just a wrapper for the writeback iterator. Signed-off-by: Christoph Hellwig Acked-by: Dave Chinner Reviewed-by: Jan Kara --- mm/page-writeback.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/mm/page-writeback.c b/mm/page-writeback.c index 1ff444d5e4317a..0546741856d70d 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -2325,18 +2325,18 @@ void __init page_writeback_init(void) } /** - * tag_pages_for_writeback - tag pages to be written by write_cache_pages + * tag_pages_for_writeback - tag pages to be written by writeback * @mapping: address space structure to write * @start: starting page index * @end: ending page index (inclusive) * * This function scans the page range from @start to @end (inclusive) and tags - * all pages that have DIRTY tag set with a special TOWRITE tag. The idea is - * that write_cache_pages (or whoever calls this function) will then use - * TOWRITE tag to identify pages eligible for writeback. This mechanism is - * used to avoid livelocking of writeback by a process steadily creating new - * dirty pages in the file (thus it is important for this function to be quick - * so that it can tag pages faster than a dirtying process can create them). + * all pages that have DIRTY tag set with a special TOWRITE tag. The caller + * can then use the TOWRITE tag to identify pages eligible for writeback. + * This mechanism is used to avoid livelocking of writeback by a process + * steadily creating new dirty pages in the file (thus it is important for this + * function to be quick so that it can tag pages faster than a dirtying process + * can create them). */ void tag_pages_for_writeback(struct address_space *mapping, pgoff_t start, pgoff_t end)