From patchwork Wed Dec 27 07:38:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vivek Kasireddy X-Patchwork-Id: 13505180 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 662EEC4706F for ; Wed, 27 Dec 2023 08:02:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C26B36B0074; Wed, 27 Dec 2023 03:02:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BD61A6B0075; Wed, 27 Dec 2023 03:02:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A515B6B007B; Wed, 27 Dec 2023 03:02:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 924F46B0074 for ; Wed, 27 Dec 2023 03:02:41 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5B0621406DB for ; Wed, 27 Dec 2023 08:02:41 +0000 (UTC) X-FDA: 81611856522.30.48BCF7B Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by imf20.hostedemail.com (Postfix) with ESMTP id 554DA1C002D for ; Wed, 27 Dec 2023 08:02:38 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="MNSQ/3fR"; spf=pass (imf20.hostedemail.com: domain of vivek.kasireddy@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=vivek.kasireddy@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703664159; a=rsa-sha256; cv=none; b=1HbJ2DUxZtB0N2ZPRO+oYT9dllP791uCPfAEdkfcDmr/bHpG+QUeY/hHa62ftoQNU9mLZR E3TVF0J8bKqT8PjKDwe6Yv8ULghYRj2KoMAGIhEurv0/zZHXV/K/LZa+l6G6vFilbTkt/w Us+Z5lGdA/Vtq5NiMWbYFMeyC+OQ9Fs= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="MNSQ/3fR"; spf=pass (imf20.hostedemail.com: domain of vivek.kasireddy@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=vivek.kasireddy@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703664159; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OFWxI1i+p4efvmikRdB46knSq10ZwkVaViiQ0SsvQMA=; b=I6nDxDAyUn5ggfKDgL+h5Y65usOZY7/cSVKEXreYCRGIO9l/N/ukAUi9CmrX7yD9Zlo2In Q6AKl1WLASIaHD47gwJBmizDfrl6S2Mo8KwPNvIqj7gl8lst7yuYQzJv4bY5TA4SKnCOI0 PZT2P8sLb6PlRn0FzjqQYD1pK2SiCpk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703664158; x=1735200158; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=U5Op4CjhDDAHfKtiDzpe6+9a1b7R8CllBxVTE/TesJE=; b=MNSQ/3fRh98h5tbm5+oPaUyGyeyuWgl0WIV/B+i+IeweWDeIvhPLJ5Y7 IoM8E8YGUKeNqGeFuGKt5xgATI4gRQAsF6LoKKpSCWTFI2Ur9JD7Gw0yp 2KsuzzRG5Mf1+UdmFrxUNpZ/UYZef3KVAb+bUqOhNoFLYQWsmfQgTqGYm CCTED9B7yWDJWX4XQW3G9TEhtkmj0FEj27z7313bpKBPZdn2yhaGSq27Y m9aV2Lpdl6icE90sXMX5hfOPmEDaXlLtwnhMqzEr3oOZUoR8Fsyyvq/07 SRv6SG8E8/Qj0qHaozG3e+//8e5uqTyqePirGF7UW1GpsXYsgMyt/fjFT Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10935"; a="482604283" X-IronPort-AV: E=Sophos;i="6.04,308,1695711600"; d="scan'208";a="482604283" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Dec 2023 00:02:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10935"; a="781668181" X-IronPort-AV: E=Sophos;i="6.04,308,1695711600"; d="scan'208";a="781668181" Received: from vkasired-desk2.fm.intel.com ([10.105.128.132]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Dec 2023 00:02:36 -0800 From: Vivek Kasireddy To: dri-devel@lists.freedesktop.org, linux-mm@kvack.org Cc: Vivek Kasireddy , David Hildenbrand , Daniel Vetter , Mike Kravetz , Hugh Dickins , Peter Xu , Jason Gunthorpe , Gerd Hoffmann , Dongwon Kim , Junxiao Chang Subject: [PATCH v9 1/6] udmabuf: Use vmf_insert_pfn and VM_PFNMAP for handling mmap Date: Tue, 26 Dec 2023 23:38:17 -0800 Message-Id: <20231227073822.390518-2-vivek.kasireddy@intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231227073822.390518-1-vivek.kasireddy@intel.com> References: <20231227073822.390518-1-vivek.kasireddy@intel.com> MIME-Version: 1.0 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 554DA1C002D X-Stat-Signature: qnk6awnm3545rjeyw7kq5bwtadsdt5qf X-Rspam-User: X-HE-Tag: 1703664158-694915 X-HE-Meta: U2FsdGVkX1+LFyTCeQg8clNVoM80bYOAzlEz7VQN2h3bJ5GBn85pNeK2Qf2DRz8Xvk51v+i5brUXLQcy6fyD25egOSHJG8Bt7TdEe/dcXBLoZN48ykPxF2ACFCDZ8DuQnAk9nM0ZvFPO9MCUejYCxbe5vxYxd7rhVn4Pv7ZujwdW+r825xUdRgGqk7y86LJaI1VpQeYjBRn1mlkKEGTj3MQN1GYkXF8UkxciV+Wt7uYS2Ge4ufkbF8GfTQ0S1CCZD6gbj6Ck2X+X8Zu4TKfCRtdM5VhtE4B4jpjxYvSfvNTjJBjYUkEMpUy5qLrQwd4A3Pnwp9rbHTgR5rg311YfF+IAE0xipXttnybTPua8jcjpkR1RpKCIxJVWq13yrswqXtsPTvOB8RkhiDCjtMnhnqYhGFFErXf3Yc/q/5C1K+0zzaoXkz8YjFkjKcdBXeddCzYdXL1g9kPiZ6UHEDziZPz1d9k/xHuHk6XKWuoxb3a59Xb7YWQ67th+JVTeAjAoJEGTsM3nhcX268PpL8RN8ngDReRGtJ7TBdWHTlMci4FGNGFAkhvVl7s8YYXsqPFBT94Z4hUcZrJ4ZQM1PeC5BwzUIvPgwkQE6p9E0mH/TvRrGdQh4yggB0qWjeuPhzMvzDoueXbGOTieGexODL8oVkrASRex9Bh4sdQH5LEOTroCzRcFmYWe39fR6uMz87fc9TXMNp5m0GE+rZ5q7ph8gBBMpd30tptUDz36WN+7dhJbtrAjzE6PHJwbwKLxh00XsJ0S2TzDcvevbtBF1FWqA6ADsRoRorc36A1MiSfmXWBr/c7jRdodFnDrU+v1KLc8PFFD3Gp7NPX6wq6JoOAkKnDYP9zhIboxcWkKZ1jMJA59Oj9r3lqCGe9ZwvSx3Lu3FFTNmOlMLy9cEBoktshQywoJAQ7rYTF9P8txDJEVZU036y33ZL/pcOmylDr+thMFwG1GkM0MvmB3Vf81ygs LMn7xvLd unTcXGwzrRrCLL7e0D1lQxZA2tl21STDTaIyKN1WAO3AyNWM75JG75gIyAwQIQ9cuhEsHKoifBOBS3ei/VScJT45MNek4gIQOrrlCyNhoiGUisgiOPVo4TiqMgjVjXiackCvFy9c2ECystSxamHavP/sceh38aPJql1gsr1PkGJMtZGt4W/HxVVhSw7LYCKBDgFN1LRHmIkQwVsiGx4t33qhCYOzPvp7qkoX5pcaFs1naULEaab57+hD3EqQmqQaIiHacRRUsIi9oWiFplV9ZBwfWssB+he9HOGfUdiD6IlV4uKQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Add VM_PFNMAP to vm_flags in the mmap handler to ensure that the mappings would be managed without using struct page. And, in the vm_fault handler, use vmf_insert_pfn to share the page's pfn to userspace instead of directly sharing the page (via struct page *). Cc: David Hildenbrand Cc: Daniel Vetter Cc: Mike Kravetz Cc: Hugh Dickins Cc: Peter Xu Cc: Jason Gunthorpe Cc: Gerd Hoffmann Cc: Dongwon Kim Cc: Junxiao Chang Suggested-by: David Hildenbrand Acked-by: David Hildenbrand Signed-off-by: Vivek Kasireddy --- drivers/dma-buf/udmabuf.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c index c40645999648..820c993c8659 100644 --- a/drivers/dma-buf/udmabuf.c +++ b/drivers/dma-buf/udmabuf.c @@ -35,12 +35,13 @@ static vm_fault_t udmabuf_vm_fault(struct vm_fault *vmf) struct vm_area_struct *vma = vmf->vma; struct udmabuf *ubuf = vma->vm_private_data; pgoff_t pgoff = vmf->pgoff; + unsigned long pfn; if (pgoff >= ubuf->pagecount) return VM_FAULT_SIGBUS; - vmf->page = ubuf->pages[pgoff]; - get_page(vmf->page); - return 0; + + pfn = page_to_pfn(ubuf->pages[pgoff]); + return vmf_insert_pfn(vma, vmf->address, pfn); } static const struct vm_operations_struct udmabuf_vm_ops = { @@ -56,6 +57,7 @@ static int mmap_udmabuf(struct dma_buf *buf, struct vm_area_struct *vma) vma->vm_ops = &udmabuf_vm_ops; vma->vm_private_data = ubuf; + vm_flags_set(vma, VM_PFNMAP | VM_DONTEXPAND | VM_DONTDUMP); return 0; }