From patchwork Wed Dec 27 07:38:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kasireddy, Vivek" X-Patchwork-Id: 13505182 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA01BC46CD4 for ; Wed, 27 Dec 2023 08:02:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1EFC48D0006; Wed, 27 Dec 2023 03:02:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 178218D0001; Wed, 27 Dec 2023 03:02:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E987B8D0006; Wed, 27 Dec 2023 03:02:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D3C0D8D0001 for ; Wed, 27 Dec 2023 03:02:43 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A2F2D12066A for ; Wed, 27 Dec 2023 08:02:43 +0000 (UTC) X-FDA: 81611856606.08.EEE35CA Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by imf20.hostedemail.com (Postfix) with ESMTP id 904771C000F for ; Wed, 27 Dec 2023 08:02:41 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ODz6N1gx; spf=pass (imf20.hostedemail.com: domain of vivek.kasireddy@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=vivek.kasireddy@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703664161; a=rsa-sha256; cv=none; b=pp2AaptbURJpLFDKM095XlXCvAYmjd4Sn1gRWa2ibZrgF0lFN22J6ftoyjm/I/upaU8wTZ f7OHfbFEA9rRgJR2j9xdCBJGhKcxhR5Jg2SyaqDxZQuXKnbiSiRGPtuq0b5+/fd1WY438L 4CZs/IpWn4FDc0mdpQokTevUAqvHKsE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ODz6N1gx; spf=pass (imf20.hostedemail.com: domain of vivek.kasireddy@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=vivek.kasireddy@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703664161; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gnFFCZ/4N7bQ8jwcsO7jGvxgDXP7BPVbDrHLX60MqX8=; b=Fsz0rrAWryOguN+NxEHjAUDo6FiP2mk3m4Fj28yduQ4A2hN+um7cdXkuN3pzBgWKJAhQ4e xLs2XJAbX/hOP3YEdDGGwMZJJOmlEVF0QqA8lZ71stefiKMweFneUs6fKkQ89gze7rfhEe jjBcwvQ8wqnFLtLiT1Un2J9LkSRh1W8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703664161; x=1735200161; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=O1c3JIhGATN1dxcRTvUuRK9RhQSZEkJPgfU5c33zkAo=; b=ODz6N1gx6v5tqFdP/JtjKm1gxrq4u8WLF7oenjQ7roV+NmizBpCcFfC0 RJT1aNUTTPBYl5aK92UuQfXeU0hzd1NU/wlT3EXvzTvm/hoO/8obx4fVp UhMqKCdqIhDUNphwaERIVJN43yRR+GfNtzCZYQEzQrtNCMlJYNleEEFNn 4EQiR0F1xFd4ZSbTMPjWaaaIv4DDN/xGajPwgwqQynT8uZnwrFhFXs/Ek 4O48wvxy3rZDeKIbgesSud7orE6JHF2Gvvzz9GGW5U1ZLbtnNJ0r7tILF 2W9xQbDk3PG7VH9kmSvWX+SO+58SRqmy0THKpiRFtDGE14eNNrtQEE69S w==; X-IronPort-AV: E=McAfee;i="6600,9927,10935"; a="482604295" X-IronPort-AV: E=Sophos;i="6.04,308,1695711600"; d="scan'208";a="482604295" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Dec 2023 00:02:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10935"; a="781668184" X-IronPort-AV: E=Sophos;i="6.04,308,1695711600"; d="scan'208";a="781668184" Received: from vkasired-desk2.fm.intel.com ([10.105.128.132]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Dec 2023 00:02:36 -0800 From: Vivek Kasireddy To: dri-devel@lists.freedesktop.org, linux-mm@kvack.org Cc: Vivek Kasireddy , David Hildenbrand , Daniel Vetter , Mike Kravetz , Hugh Dickins , Peter Xu , Jason Gunthorpe , Gerd Hoffmann , Dongwon Kim , Junxiao Chang Subject: [PATCH v9 2/6] udmabuf: Add back support for mapping hugetlb pages (v6) Date: Tue, 26 Dec 2023 23:38:18 -0800 Message-Id: <20231227073822.390518-3-vivek.kasireddy@intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231227073822.390518-1-vivek.kasireddy@intel.com> References: <20231227073822.390518-1-vivek.kasireddy@intel.com> MIME-Version: 1.0 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 904771C000F X-Stat-Signature: p6fqgaz5ujfzc3sci9yw8yjcteew3qsm X-Rspam-User: X-HE-Tag: 1703664161-848059 X-HE-Meta: U2FsdGVkX18W8cjR7JRDnD7IXRYpBPqNpCBIQN2N+bv9j7vnNv8MY4mkiXC+aXmepI0mi0kGgrV1Ry7McSUY0F3thE7bZ3jh1f+xlw6beRvbkBog+d7lVCZQM+2mqDNYyMSvvh69mUci3WJoruYpxFIg7oKB12z3XsHdHbIIisaxDk+MRH44wxpMnlIfJYV/vDmuohDa7z0pqk4RkYw5GnKYJEi1mWU+mt4KWfYPX7glgwLyIDKWK1Kfk85iWVm1K16RQo3bmA2uM2oJzy5nhyK3m+2tDNDJffrRUvHtDVcJHchbBVz9+WwmYL5Srvdaq69+w3BJkzPwpUir7ZAD6+rd4fRUDMzGMq/laIkIGGni5p7LL5EzlUYn1ENOglAw/Rm6CoSuNMpXZpZvNuaAIBSzZJqJgjwS9V+82tcmeFWqdfD877x5EhZ264IUQ5SVFKlFVTPzRuXl+Z6MijNWp2mJsa5y3LbQF5UOIBsMs8m7/ZtpT8J7pjAzaAbmrXw0A9YYnlj3YcB3XwkerpehuJyeZLZ2O17iAHpq0aYtXyHlMMc7oUXv6/cYfmuIc1aLFWMAiNn3jj9vsWxLKT88AXdK3ESXGkeJS84s1Spk6i1FmbQWAxZ2iHwo7u75any65ORpMvwf/szo9a53cU0ZblcqUeLcbkx3QJMfF3VPHMkwbpt944gPHQTvwmpxiK77cypoRRBz2BOa7q06R0eTWbdaNu8MW9bYEy1F8p2vWvZ/rLMHjMOGF+tU217Y7B59xUbh95Bhv1DA5/3RXF1F44/iNa9o0ttmYASO86fGveb44qFXQjmcNrponBiFJBY1GKMWy7XOHNIWe/aC6PHNxXTzaXnaJmQW0ie6RaafGT8Nq2JPOEGCXVe3e/sguYa3ODdCoON4HN3oBABBenuZ7lsV/JfqSXlTgQvGhRpFseMX6coQERGDaB+cBtUDcig48S/hhgxK3Ii+4W0EYlA 8ZJs3kY5 J8oiBwtKt2SXW8iE9JClWlvNQ5Y2a8jZt3y9ud1Hdd3C2lt1Ci6t9QA04haKomWDT43mBs0TUkWXq/3N9ZUO07QPDC82OPSJs1ITFRg5sjuiXNercZpmxwaI1pMFw8L03xRI/+AZwbY3qMJR/znSuV6TCG5zP+n1p2s6MTVx8fq4H9TJh/lUOlblEMz5wmOsOnc2TnoReHD5T3VicYmmzK5nr2FvE/UvTndvO/fK9liL3JocCuiYhDQQCyQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: A user or admin can configure a VMM (Qemu) Guest's memory to be backed by hugetlb pages for various reasons. However, a Guest OS would still allocate (and pin) buffers that are backed by regular 4k sized pages. In order to map these buffers and create dma-bufs for them on the Host, we first need to find the hugetlb pages where the buffer allocations are located and then determine the offsets of individual chunks (within those pages) and use this information to eventually populate a scatterlist. Testcase: default_hugepagesz=2M hugepagesz=2M hugepages=2500 options were passed to the Host kernel and Qemu was launched with these relevant options: qemu-system-x86_64 -m 4096m.... -device virtio-gpu-pci,max_outputs=1,blob=true,xres=1920,yres=1080 -display gtk,gl=on -object memory-backend-memfd,hugetlb=on,id=mem1,size=4096M -machine memory-backend=mem1 Replacing -display gtk,gl=on with -display gtk,gl=off above would exercise the mmap handler. v2: Updated get_sg_table() to manually populate the scatterlist for both huge page and non-huge-page cases. v3: s/offsets/subpgoff/g s/hpoff/mapidx/g v4: Replaced find_get_page_flags() with __filemap_get_folio() to ensure that we only obtain head pages from the mapping v5: Fix the calculation of mapidx to ensure that it is a order-n page multiple v6: - Split the processing of hugetlb or shmem pages into helpers to simplify the code in udmabuf_create() (Christoph) - Move the creation of offsets array out of hugetlb context and into common code Cc: David Hildenbrand Cc: Daniel Vetter Cc: Mike Kravetz Cc: Hugh Dickins Cc: Peter Xu Cc: Jason Gunthorpe Cc: Gerd Hoffmann Cc: Dongwon Kim Cc: Junxiao Chang Acked-by: Mike Kravetz (v2) Signed-off-by: Vivek Kasireddy --- drivers/dma-buf/udmabuf.c | 122 +++++++++++++++++++++++++++++++------- 1 file changed, 101 insertions(+), 21 deletions(-) diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c index 820c993c8659..274defd3fa3e 100644 --- a/drivers/dma-buf/udmabuf.c +++ b/drivers/dma-buf/udmabuf.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include #include @@ -28,6 +29,7 @@ struct udmabuf { struct page **pages; struct sg_table *sg; struct miscdevice *device; + pgoff_t *offsets; }; static vm_fault_t udmabuf_vm_fault(struct vm_fault *vmf) @@ -41,6 +43,8 @@ static vm_fault_t udmabuf_vm_fault(struct vm_fault *vmf) return VM_FAULT_SIGBUS; pfn = page_to_pfn(ubuf->pages[pgoff]); + pfn += ubuf->offsets[pgoff] >> PAGE_SHIFT; + return vmf_insert_pfn(vma, vmf->address, pfn); } @@ -90,23 +94,29 @@ static struct sg_table *get_sg_table(struct device *dev, struct dma_buf *buf, { struct udmabuf *ubuf = buf->priv; struct sg_table *sg; + struct scatterlist *sgl; + unsigned int i = 0; int ret; sg = kzalloc(sizeof(*sg), GFP_KERNEL); if (!sg) return ERR_PTR(-ENOMEM); - ret = sg_alloc_table_from_pages(sg, ubuf->pages, ubuf->pagecount, - 0, ubuf->pagecount << PAGE_SHIFT, - GFP_KERNEL); + + ret = sg_alloc_table(sg, ubuf->pagecount, GFP_KERNEL); if (ret < 0) - goto err; + goto err_alloc; + + for_each_sg(sg->sgl, sgl, ubuf->pagecount, i) + sg_set_page(sgl, ubuf->pages[i], PAGE_SIZE, ubuf->offsets[i]); + ret = dma_map_sgtable(dev, sg, direction, 0); if (ret < 0) - goto err; + goto err_map; return sg; -err: +err_map: sg_free_table(sg); +err_alloc: kfree(sg); return ERR_PTR(ret); } @@ -143,6 +153,7 @@ static void release_udmabuf(struct dma_buf *buf) for (pg = 0; pg < ubuf->pagecount; pg++) put_page(ubuf->pages[pg]); + kfree(ubuf->offsets); kfree(ubuf->pages); kfree(ubuf); } @@ -196,17 +207,77 @@ static const struct dma_buf_ops udmabuf_ops = { #define SEALS_WANTED (F_SEAL_SHRINK) #define SEALS_DENIED (F_SEAL_WRITE) +static int handle_hugetlb_pages(struct udmabuf *ubuf, struct file *memfd, + pgoff_t offset, pgoff_t pgcnt, + pgoff_t *pgbuf) +{ + struct hstate *hpstate = hstate_file(memfd); + pgoff_t mapidx = offset >> huge_page_shift(hpstate); + pgoff_t subpgoff = (offset & ~huge_page_mask(hpstate)) >> PAGE_SHIFT; + pgoff_t maxsubpgs = huge_page_size(hpstate) >> PAGE_SHIFT; + struct page *hpage = NULL; + struct folio *folio; + pgoff_t pgidx; + + mapidx <<= huge_page_order(hpstate); + for (pgidx = 0; pgidx < pgcnt; pgidx++) { + if (!hpage) { + folio = __filemap_get_folio(memfd->f_mapping, + mapidx, + FGP_ACCESSED, 0); + if (IS_ERR(folio)) + return PTR_ERR(folio); + + hpage = &folio->page; + } + + get_page(hpage); + ubuf->pages[*pgbuf] = hpage; + ubuf->offsets[*pgbuf] = subpgoff << PAGE_SHIFT; + (*pgbuf)++; + if (++subpgoff == maxsubpgs) { + put_page(hpage); + hpage = NULL; + subpgoff = 0; + mapidx += pages_per_huge_page(hpstate); + } + } + + if (hpage) + put_page(hpage); + + return 0; +} + +static int handle_shmem_pages(struct udmabuf *ubuf, struct file *memfd, + pgoff_t offset, pgoff_t pgcnt, + pgoff_t *pgbuf) +{ + pgoff_t pgidx, pgoff = offset >> PAGE_SHIFT; + struct page *page; + + for (pgidx = 0; pgidx < pgcnt; pgidx++) { + page = shmem_read_mapping_page(memfd->f_mapping, + pgoff + pgidx); + if (IS_ERR(page)) + return PTR_ERR(page); + + ubuf->pages[*pgbuf] = page; + (*pgbuf)++; + } + + return 0; +} + static long udmabuf_create(struct miscdevice *device, struct udmabuf_create_list *head, struct udmabuf_create_item *list) { DEFINE_DMA_BUF_EXPORT_INFO(exp_info); struct file *memfd = NULL; - struct address_space *mapping = NULL; struct udmabuf *ubuf; struct dma_buf *buf; - pgoff_t pgoff, pgcnt, pgidx, pgbuf = 0, pglimit; - struct page *page; + pgoff_t pgcnt, pgbuf = 0, pglimit; int seals, ret = -EINVAL; u32 i, flags; @@ -234,6 +305,12 @@ static long udmabuf_create(struct miscdevice *device, ret = -ENOMEM; goto err; } + ubuf->offsets = kcalloc(ubuf->pagecount, sizeof(*ubuf->offsets), + GFP_KERNEL); + if (!ubuf->offsets) { + ret = -ENOMEM; + goto err; + } pgbuf = 0; for (i = 0; i < head->count; i++) { @@ -241,8 +318,7 @@ static long udmabuf_create(struct miscdevice *device, memfd = fget(list[i].memfd); if (!memfd) goto err; - mapping = memfd->f_mapping; - if (!shmem_mapping(mapping)) + if (!shmem_file(memfd) && !is_file_hugepages(memfd)) goto err; seals = memfd_fcntl(memfd, F_GET_SEALS, 0); if (seals == -EINVAL) @@ -251,16 +327,19 @@ static long udmabuf_create(struct miscdevice *device, if ((seals & SEALS_WANTED) != SEALS_WANTED || (seals & SEALS_DENIED) != 0) goto err; - pgoff = list[i].offset >> PAGE_SHIFT; - pgcnt = list[i].size >> PAGE_SHIFT; - for (pgidx = 0; pgidx < pgcnt; pgidx++) { - page = shmem_read_mapping_page(mapping, pgoff + pgidx); - if (IS_ERR(page)) { - ret = PTR_ERR(page); - goto err; - } - ubuf->pages[pgbuf++] = page; - } + + pgcnt = list[i].size >> PAGE_SHIFT; + if (is_file_hugepages(memfd)) + ret = handle_hugetlb_pages(ubuf, memfd, + list[i].offset, + pgcnt, &pgbuf); + else + ret = handle_shmem_pages(ubuf, memfd, + list[i].offset, + pgcnt, &pgbuf); + if (ret < 0) + goto err; + fput(memfd); memfd = NULL; } @@ -287,6 +366,7 @@ static long udmabuf_create(struct miscdevice *device, put_page(ubuf->pages[--pgbuf]); if (memfd) fput(memfd); + kfree(ubuf->offsets); kfree(ubuf->pages); kfree(ubuf); return ret;