From patchwork Mon Jan 15 22:59:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dave Chinner X-Patchwork-Id: 13520258 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91E2DC3DA79 for ; Mon, 15 Jan 2024 23:01:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F9B46B007B; Mon, 15 Jan 2024 18:01:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1847A6B0080; Mon, 15 Jan 2024 18:01:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E54DA6B007E; Mon, 15 Jan 2024 18:01:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D1B2D6B007D for ; Mon, 15 Jan 2024 18:01:24 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9FF4F1A05E7 for ; Mon, 15 Jan 2024 23:01:24 +0000 (UTC) X-FDA: 81683068488.29.1E236C0 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf04.hostedemail.com (Postfix) with ESMTP id A41A24000B for ; Mon, 15 Jan 2024 23:01:22 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=B0ts6bbZ; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf04.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705359682; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XTU7Fr08s4rUxky9Yys2MV8QifwgSoaYIdZvg8gWTFY=; b=zlqJzVTVcN4bF5VtmOLZRdYpl8pIs0qnjF38XjFwYBiB7ZlpvMG9K0I4alPejB2uRwQplx I38iKDPv4FJUdtI2e3sJ0oLScQ2SyOVXi6Yp2AzkSvmzxWr/cqnnYg3zLMNVBtl0EInM7O iLJJs1buJlXHsiyd2iSPyXF+9cxL704= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=B0ts6bbZ; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf04.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705359682; a=rsa-sha256; cv=none; b=E1koPwrkno0XeK2l40p7t9W0iRP8rXGKPSrggdHc9mxSrgUz+wn0itwAjKpH9+de+DyFvV 1NeH04JSyqxcGZ9IVPk2gIbP+KUxfcqwJEYL3mjZ77i743BHy+p2OD7fxEjwRGsNxNGthi czSyzlNJvLy6Ft8pMwMLBt8xrrp2G/g= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1d44200b976so49058275ad.2 for ; Mon, 15 Jan 2024 15:01:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1705359681; x=1705964481; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XTU7Fr08s4rUxky9Yys2MV8QifwgSoaYIdZvg8gWTFY=; b=B0ts6bbZoEVUkgaAZD5t2gUkpEWLfx046YwKBwfs3TDLSQqnxFzQWULkjcARpB0Y6M Rd0HAvZi3rFVhh6w5y/LC5HWiZIaZzUR5/uYqzhPoirj6q4xHlYtz2Gv6C01gFXm5hde Tm646q48S3FvzLOC5gELHLyDLljLpDyHYPZ2EuXFpHu91Tw2BliCOeR5/+G8t0yBLBxA /Q4E7U2otfnBfiQnhI/2/vehlmlOUkIGFQr+z6v17ID5r0im8hpogmw4IR5xr6kF4iXU WZLDoyw6lRGgaV0AvXcHjAltAF4OFIOAbcbo29arbYP5usStZYuQKC0QBkU/3uPI+RXz p7gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705359681; x=1705964481; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XTU7Fr08s4rUxky9Yys2MV8QifwgSoaYIdZvg8gWTFY=; b=WOlfMl7VaQ/VBAV0GLzw2C1arvpI93/NKbyaR1PZAx2s8YZjhqXPtYB794ebpUxxjG 2Rr5qJ9ZuEr6eOQSAMN8IP2cwt8ruuLUUKz7quKldzQAeelpWt4BQKcN6pCLFk4eOKuz ffVymLa4i1oXCRRMgG3DZgdqHLzkxpOw4p9x27Jt7cBW3Ov4BmKbf0i/hXaVKcqy/gHI 58VjWVgSpgiRJRoz8DjQ4KHTo0dNw+dZTWox+A2TWkNupquB9CCdOLMqVvqlEKAM9Yqm D2mzzlgy4tN3PurMDEIo7V3/yiICmw9JFR2WGoQE65IYWMBCSCUtDGk3rCj3hKRqvaVG ppPA== X-Gm-Message-State: AOJu0YxFRwrlQde8K4ndeQeP1qmr3P494pfcCwUkkrI7DvT1W+1eyKjM QeZ1CmbXxUyvXFrqKlA2nZhJsTdHVO/k7mFiBuWkJOEfVwQ= X-Google-Smtp-Source: AGHT+IGNiHk1RuGG1sc4v4L0zJg68Gv9p9I32eJCDEJ/+w/GY8Au5JZTtLDF5HjZXmrnuOPcXmWQew== X-Received: by 2002:a17:902:c78b:b0:1d4:1bcc:416a with SMTP id w11-20020a170902c78b00b001d41bcc416amr2727232pla.30.1705359681657; Mon, 15 Jan 2024 15:01:21 -0800 (PST) Received: from dread.disaster.area (pa49-180-249-6.pa.nsw.optusnet.com.au. [49.180.249.6]) by smtp.gmail.com with ESMTPSA id jj7-20020a170903048700b001d472670a30sm8176436plb.162.2024.01.15.15.01.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jan 2024 15:01:18 -0800 (PST) Received: from [192.168.253.23] (helo=devoid.disaster.area) by dread.disaster.area with esmtp (Exim 4.96) (envelope-from ) id 1rPVxE-00AtKR-0v; Tue, 16 Jan 2024 10:01:15 +1100 Received: from dave by devoid.disaster.area with local (Exim 4.97) (envelope-from ) id 1rPVxD-0000000H8g6-3Een; Tue, 16 Jan 2024 10:01:15 +1100 From: Dave Chinner To: linux-xfs@vger.kernel.org Cc: willy@infradead.org, linux-mm@kvack.org Subject: [PATCH 10/12] xfs: place the CIL under nofs allocation context Date: Tue, 16 Jan 2024 09:59:48 +1100 Message-ID: <20240115230113.4080105-11-david@fromorbit.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240115230113.4080105-1-david@fromorbit.com> References: <20240115230113.4080105-1-david@fromorbit.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A41A24000B X-Stat-Signature: fapxqzqef7c3jggnqkccnupmco5mm6fy X-HE-Tag: 1705359682-163513 X-HE-Meta: U2FsdGVkX19tpCVTFCj4BmRk42aKG/7rRjQ7JPvyEGR9gzwF5Fp6gbEOtV3ZPsyfh/N3IDcXiUzwvIuBKcYEqtLWWMeAw9CZ7KwIta0DpDrBL1QMIquBXUzv2feCGgS9HLSTBFtrCKqIrcwNh2f4veIGdZJsac7Ok1Ec8EkXTyhpClunFLgPILfTW/QgfcUS/4OWkQ8iXrOrLf+MuI+v9NgyDvgZqk9PcW2wWt8GSGtHX8Wb+Obnfy6+Lh0Zeikmq2/ujY1T1ADSogSFHTVd9BLox4+u5PX6KtStCeCsIXjlfjWC9OCJ/fRGpyTdsEqRD2uPgkGwUYEv15iV8cMKkQEEFdz+Miv8C4fxH+bzrgpsucH3EeTHPPW+HpTudQCgsCOC+XONABdjFA4bPUhelKJXq4XzMJbYFUbcgn5LDx/iKy2cyE/TusuC8eF+XxbRy7bIQXurktin0NE23kBcVlUUJpE86ocI2ab/vq3MApcAs+tt//jgcucUUhumD1N0fnlKlSKpi739h6Qnzg3cnJ2r4OqxRRHmY+7t/XxOS6GMhNGhfnao3sq6/tkf21s9fDWb4amtVl3EQoQ0S/GW25Kfvm7FSeBIoBwkEsvjHEwRdhyM+iIk36JevAx8GLNtk3PGrnEyJfKyTQiCENokR7+8NLXI64CfvxECEmDqoovPWGc+JTvrtJCRYIasUKhyST21L0G5Rrh6VhkakBAXCGHWfW4CdusIDL0jIGBbRQhiAuTMjx6nBJ+WiM1C1Xsp93+muHBUOSS0rj+yHpiVA/eS/7DxxKK+QFMw5QFHHbPdeWBh/xfRwnGbvFOxMsWky9TXJtv0brbydFMSZ5zoJ/zRzTffg+zUCe6BqQcWLB+3OLHAauGlXKMY3b2MdoTDiKocJX0uL6oz/LoZvLseDfwt7muxAz0dnGfsDqQRI0J2El2Jc0EvhZZ+b9gImvDwQvSLCYDI83gBoqBDdb6 XV13TaIG GsQtkZv65E/Y42YxDaWoQHxGHaRVPBM+c4OnfrwgB8bcvTc+lvAYe515XyQvMWat3Sou0VFYwmvIZQozxgao961zpqslG9fnVd+rONY/miSCvmmqXZb3kVgJqfux1D8IFBt98RToaO79tlrAAXjGTbBXm+61dO/hEOycsWJIoaTRNuBk97WzhNOZAcZSNyU6iPDCF7NYv5EIWS75Yx9e/Kr0qqVOMcSmU55Qq1UFf/Dp9KTkM4sbPjo+051G5hnDodF6WddcZFN7kr8a6oyPTNkXrELN1m6RxcFqST8zBis6hAePTW1aFs4PgeW7EAhPFoO8ZS8wfhRl56Qej6pe+bDs4jT1Bc64Jb1rjNKTnIYantuyDjV0ZNHGGCo38/fAfi2wl+ORbg3nS/JoFt/bAAC7RYOtkipEwWC8s/RQtzX7hWsDU88DM+ME5arBmEycX2uYzWlZhi4HxBDagMy7XMS9j1dXGaow2L5A4rmd0yt+Yl9k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Dave Chinner This is core code that needs to run in low memory conditions and can be triggered from memory reclaim. While it runs in a workqueue, it really shouldn't be recursing back into the filesystem during any memory allocation it needs to function. Signed-off-by: Dave Chinner Reviewed-by: Darrick J. Wong --- fs/xfs/xfs_log_cil.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/fs/xfs/xfs_log_cil.c b/fs/xfs/xfs_log_cil.c index 815a2181004c..8c3b09777006 100644 --- a/fs/xfs/xfs_log_cil.c +++ b/fs/xfs/xfs_log_cil.c @@ -100,7 +100,7 @@ xlog_cil_ctx_alloc(void) { struct xfs_cil_ctx *ctx; - ctx = kzalloc(sizeof(*ctx), GFP_NOFS | __GFP_NOFAIL); + ctx = kzalloc(sizeof(*ctx), GFP_KERNEL | __GFP_NOFAIL); INIT_LIST_HEAD(&ctx->committing); INIT_LIST_HEAD(&ctx->busy_extents.extent_list); INIT_LIST_HEAD(&ctx->log_items); @@ -1116,11 +1116,18 @@ xlog_cil_cleanup_whiteouts( * same sequence twice. If we get a race between multiple pushes for the same * sequence they will block on the first one and then abort, hence avoiding * needless pushes. + * + * This runs from a workqueue so it does not inherent any specific memory + * allocation context. However, we do not want to block on memory reclaim + * recursing back into the filesystem because this push may have been triggered + * by memory reclaim itself. Hence we really need to run under full GFP_NOFS + * contraints here. */ static void xlog_cil_push_work( struct work_struct *work) { + unsigned int nofs_flags = memalloc_nofs_save(); struct xfs_cil_ctx *ctx = container_of(work, struct xfs_cil_ctx, push_work); struct xfs_cil *cil = ctx->cil; @@ -1334,12 +1341,14 @@ xlog_cil_push_work( spin_unlock(&log->l_icloglock); xlog_cil_cleanup_whiteouts(&whiteouts); xfs_log_ticket_ungrant(log, ticket); + memalloc_nofs_restore(nofs_flags); return; out_skip: up_write(&cil->xc_ctx_lock); xfs_log_ticket_put(new_ctx->ticket); kfree(new_ctx); + memalloc_nofs_restore(nofs_flags); return; out_abort_free_ticket: @@ -1348,6 +1357,7 @@ xlog_cil_push_work( if (!ctx->commit_iclog) { xfs_log_ticket_ungrant(log, ctx->ticket); xlog_cil_committed(ctx); + memalloc_nofs_restore(nofs_flags); return; } spin_lock(&log->l_icloglock); @@ -1356,6 +1366,7 @@ xlog_cil_push_work( /* Not safe to reference ctx now! */ spin_unlock(&log->l_icloglock); xfs_log_ticket_ungrant(log, ticket); + memalloc_nofs_restore(nofs_flags); } /*